Skip to content

feat(sidebar): open the board folder menu on right-click - #18844

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
devansh1401:feat/board-folder-right-click
Oct 18, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
devansh1401:feat/board-folder-right-click

Conversation

@devansh1401

@devansh1401 devansh1401 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Right-clicking a folder in a board column opens the same menu as its ⋮ button.

Right now a right-click on a board folder just gives you the browser menu. The list view got this in #13545 but the board view was left out, so this is the other half of #18490.

Why it matters

The ⋮ button only shows on hover and it's tiny. Folders in the list view and session rows in both views already answer right-click, so board folders are the odd one out.

Not a goal

  • No new items in the board menu. "Hide folder" and "Hide when empty" stay list-view only.
  • Not touching the list-view menu, session menus, drag and drop or keyboard nav.

What changed (motivation → approach → change)

Right-clicking a board folder header opens the same actions as its ⋮ button. Both menus share the folder action renderer, so Rename and private-chat creation stay scoped to the clicked column. Session rows keep their own menus, and the rename input keeps the browser edit menu.

The implementation lives in chat-sidebar/boardLane.tsx and folderBlocks.tsx, preserving the extracted sidebar structure, offline guards and current private-chat actions. docs/feature-map/README.md and docs/system-specs/modules/history.md describe the behavior; website/scripts/restyle-baseline.json drops the board renderer's two removed findings.

Backwards compatibility

Compatible: the board ⋮ menu keeps its current actions and handlers. List-only hide and conductor actions remain list-only.

Removes nothing: board action test IDs align with the shared renderer (new-sub becomes new-subfolder; Rename and Delete receive IDs). Existing board and list regression tests verify the behavior.

Tests

website/src/test/ChatSidebar.boardFolderContextMenu.test.tsx has nine focused tests covering menu items, dropdown/context parity, column-scoped private-chat creation, the header/body boundary, offline rename refusal, scoped rename/save, native input context menus, and confirmed/cancelled deletion. The focused run passed all 20 tests across the new suite and existing board-rename/list-private-chat suites.

The selected frontend run passed 379 files / 11,630 tests. Electron tests passed 2,757 tests with four skips. Production build, TypeScript, full ESLint, Python lint/type checks, documentation lint, translation checks (including browser rendering), bundle checks, duplication scan (zero clones), restyle ratchet, diff-scoped Semgrep, and all 58 flake-pattern tests passed. A separate sidebar run passed 131 files / 1,471 tests with shuffled order (seed 18844, one worker).

Local backend validation is incomplete: the 951-file selection stalled during collection, and diagnostic collection runs crashed on Python 3.12.7 and 3.12.15. Full backend/platform validation and fresh GitHub reviews remain pending. The last upstream rebase leaves the sidebar implementation and its tests unchanged.

Manual verification

Verified the freshly built SPA with scripted Playwright and stubbed APIs: both menus contain the same seven actions, and Rename opens only in the selected column. In Chromium touch emulation, stationary long-press opens the menu with no reorder request. It briefly activates the drag preview; release clears the preview and leaves the menu open. Hold then drag produces one correct reorder, no menu, and clears the preview on release. No browser page errors. Physical touch hardware and WebKit have not been tested.

Screenshots / video

Right-click on "Release 0.9" in the ToDo column:

right-click menu on a board folder

Same items from the ⋮ button:

⋮ menu on the same folder

Rename picked from a right-click in the Review column. The ToDo copy of the folder is untouched:

rename input in the Review column only

Related Issues

Closes #18490

Pattern harvest

N/A — additive board-folder menu support using the existing folder-menu renderer.

Checklist

  • At most two commits, with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; independent focused review found no actionable defects
  • Documentation updated
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Apache-2.0, same as the project.

@devansh1401
devansh1401 requested review from a team and KiroCrewCaptain as code owners October 10, 2026 12:00
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Oct 10, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of ad4430c700dd04c3c5d836e7cd600be42a71e5f5 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that pressing and holding a board folder on a phone or tablet doesn't also start a drag. It was only tested in Chromium touch emulation; real touch hardware and WebKit weren't tested.

[DESIGN-REVIEWED] ad4430c

Description read

[DESCRIPTION-READ] d45ac2cdb4a73b83ef9d0f309d1edb9bb1f495032062b1af0fd026c2fc97bc58

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of ad4430c700dd04c3c5d836e7cd600be42a71e5f5 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Before merging, check long-press on a board folder header on a real touch device or in WebKit: it now opens a menu while the header is also a drag handle, and only Chromium emulation was tested.

What this change ships

Inventory (6 items) — 6 justified

Intent: let a person right-click a board-column folder and get the same actions as its ⋮ button. ADDITION. It finishes #18490, whose list-view half landed in #13545.

  1. Right-clicking a board folder header opens the folder actions menu at the pointer, scoped to the clicked column — justified
  2. The board ⋮ menu is now drawn by the shared renderFolderMenuItems instead of its own 22-line copy, with the same items in the same order — justified
  3. Board menu test IDs change (new-sub becomes new-subfolder; Rename and Delete get IDs). A grep for the old IDs finds no consumers outside the deleted lines — justified
  4. While a column's folder name is being edited, that header keeps the browser's native menu — justified
  5. The feature map and the history.md sidebar spec describe the board right-click and the list-only hide items — justified
  6. Committed screenshots under temp-screenshots/, and the boardLane.tsx restyle-baseline entry shrinks to nothing — justified

[FIRST-PRINCIPLES-REVIEWED] ad4430c

Description read

[DESCRIPTION-READ] 87cfae32bd0ff94ec9412027cfe52f9d2c02dc888cab80533125063d39ecdb0c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of ad4430c700dd04c3c5d836e7cd600be42a71e5f5 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has looked at the board folder right-click menu; the three attached screenshots show it, so this cap comes from the review lane, not a gap in the PR.

Watch

  • On touch devices, a long-press briefly shows the drag preview before the menu opens, per the PR's manual verification ("briefly activates the drag preview"). The user sees the folder start to lift and then gets a menu instead. Only touch users are affected, the menu still opens and nothing is reordered, so the severity is low. It hasn't been tested on WebKit or on real touch hardware, so a human should check it on an actual tablet before merging.

[UX-REVIEWED] ad4430c

Description read

[DESCRIPTION-READ] 566127936d14b7f99297b857f25714acf11ac93e9541dd394dae64ff066a4904

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed ad4430c700dd04c3c5d836e7cd600be42a71e5f5 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ad4430c

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed ad4430c700dd04c3c5d836e7cd600be42a71e5f5 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ad4430c

@devansh1401

Copy link
Copy Markdown
Contributor Author

@bolichen97 this is ready for a look when you get a chance.

ci has 3 red jobs but none of them come from this change, and i can't re-run from a fork:

coverage gate and readiness are red only because of those shards. could you re-run them?

on the touch question from the design and ux reviews: i tried it with chromium touch emulation (not a real phone). long-press opens the menu and does not reorder, hold then drag reorders and does not open the menu. same as the list view row.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 10, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Main moved the sidebar render code into website/src/pages/chat-sidebar/ in #20524, so this change no longer applies. The board folder menu now lives in boardLane.tsx. Please rebase and move the right-click handler there.

Right-clicking a folder in a board column fell through to the browser
menu, while the same folder already answers right-click in the list
view.

The board menu was its own inline copy of the folder items, so it now
goes through renderFolderMenuItems like the list view does, and the
header row gets a ContextMenu around it. Rename mode keeps the
browser's edit menu.

Closes kirodotdev#18490
@devansh1401
devansh1401 force-pushed the feat/board-folder-right-click branch from c0ab3ff to ad4430c Compare October 18, 2026 11:16
@devansh1401

Copy link
Copy Markdown
Contributor Author

rebased onto current main and moved the handler into boardLane.tsx, with the shared menu in folderBlocks.tsx. the conflicts are resolved, screenshots refreshed, and 1,471 sidebar tests passed. thanks for pointing out the move.

@devansh1401

Copy link
Copy Markdown
Contributor Author

fixed: checked the ported menu in chromium touch emulation. this is included in ad4430c. long-press opens the menu without reordering; the brief drag preview clears on release. hold then drag reorders once without opening the menu. no page errors. real hardware and webkit are still untested.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 18, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase. I re-reviewed the change at ad4430c and it looks good to ship.

What I checked:

  • The board ⋯ menu and the new right-click menu both render from renderFolderMenuItems. With a columnId, the item set and order match the board menu on main: Rename, New subfolder, the two private chats, Move folder to, Folder settings, Delete. Every item keeps its offlineMenuRow guard.
  • Rename and private-chat creation use the clicked column (setEditScope(columnId ?? 'list'), createChatInFolder(..., { columnId, ... })).
  • The conductor item and the two hide items are gated on columnId === undefined, so the board menu gains no new item. This matches "Not a goal".
  • Only the header row is the trigger. The trigger is disabled while that column's copy is renaming, so the input keeps the browser menu. This is the same shape as the list-view row.
  • The renamed test ids (new-sub to new-subfolder) have no other reference on main. The branch merges into current main with no conflict.
  • The new tests would go red if the trigger wrapped the body or lost its rename guard.

My earlier notes no longer apply after the rebase. The conductor item is gated, the offline notice only mounts inside an open menu, and private chats are flat rows.

Remaining before merge: the CI runs for this head were waiting for approval. I approved them, and the merge waits for PR Readiness on this head.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 18, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head ad4430c.

PR Readiness is green on this head and the readiness: passed label is present. Every required check passed. The Design, First Principles, Opus, GPT and Security Scope lanes passed. The UX lane reported watch items only, which my earlier review covered. The branch targets main and merges with no conflict.

My earlier review of this head still applies: both menus render from one item builder, the board menu gains no new item, and the new tests guard the trigger and the rename case.

@bolichen97
bolichen97 enabled auto-merge (squash) October 18, 2026 14:05
@bolichen97
bolichen97 merged commit a82fcba into kirodotdev:main Oct 18, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 18, 2026
@devansh1401
devansh1401 deleted the feat/board-folder-right-click branch October 18, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right-click on a sidebar folder should open its ⋮ menu

2 participants