Repository navigation
feat(sidebar): open the board folder menu on right-click - #18844
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that pressing and holding a board folder on a phone or tablet doesn't also start a drag. It was only tested in Chromium touch emulation; real touch hardware and WebKit weren't tested. [DESIGN-REVIEWED] ad4430c Description read[DESCRIPTION-READ] d45ac2cdb4a73b83ef9d0f309d1edb9bb1f495032062b1af0fd026c2fc97bc58 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Before merging, check long-press on a board folder header on a real touch device or in WebKit: it now opens a menu while the header is also a drag handle, and only Chromium emulation was tested. What this change shipsInventory (6 items) — 6 justifiedIntent: let a person right-click a board-column folder and get the same actions as its ⋮ button. ADDITION. It finishes #18490, whose list-view half landed in #13545.
[FIRST-PRINCIPLES-REVIEWED] ad4430c Description read[DESCRIPTION-READ] 87cfae32bd0ff94ec9412027cfe52f9d2c02dc888cab80533125063d39ecdb0c That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has looked at the board folder right-click menu; the three attached screenshots show it, so this cap comes from the review lane, not a gap in the PR. Watch
[UX-REVIEWED] ad4430c Description read[DESCRIPTION-READ] 566127936d14b7f99297b857f25714acf11ac93e9541dd394dae64ff066a4904 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
@bolichen97 this is ready for a look when you get a chance. ci has 3 red jobs but none of them come from this change, and i can't re-run from a fork:
coverage gate and readiness are red only because of those shards. could you re-run them? on the touch question from the design and ux reviews: i tried it with chromium touch emulation (not a real phone). long-press opens the menu and does not reorder, hold then drag reorders and does not open the menu. same as the list view row. |
|
Main moved the sidebar render code into website/src/pages/chat-sidebar/ in #20524, so this change no longer applies. The board folder menu now lives in boardLane.tsx. Please rebase and move the right-click handler there. |
Right-clicking a folder in a board column fell through to the browser menu, while the same folder already answers right-click in the list view. The board menu was its own inline copy of the folder items, so it now goes through renderFolderMenuItems like the list view does, and the header row gets a ContextMenu around it. Rename mode keeps the browser's edit menu. Closes kirodotdev#18490
c0ab3ff to
ad4430c
Compare
|
rebased onto current main and moved the handler into |
|
bolichen97
left a comment
There was a problem hiding this comment.
Thanks for the rebase. I re-reviewed the change at ad4430c and it looks good to ship.
What I checked:
- The board ⋯ menu and the new right-click menu both render from
renderFolderMenuItems. With acolumnId, the item set and order match the board menu on main: Rename, New subfolder, the two private chats, Move folder to, Folder settings, Delete. Every item keeps itsofflineMenuRowguard. - Rename and private-chat creation use the clicked column (
setEditScope(columnId ?? 'list'),createChatInFolder(..., { columnId, ... })). - The conductor item and the two hide items are gated on
columnId === undefined, so the board menu gains no new item. This matches "Not a goal". - Only the header row is the trigger. The trigger is disabled while that column's copy is renaming, so the input keeps the browser menu. This is the same shape as the list-view row.
- The renamed test ids (
new-subtonew-subfolder) have no other reference on main. The branch merges into current main with no conflict. - The new tests would go red if the trigger wrapped the body or lost its rename guard.
My earlier notes no longer apply after the rebase. The conductor item is gated, the offline notice only mounts inside an open menu, and private chats are flat rows.
Remaining before merge: the CI runs for this head were waiting for approval. I approved them, and the merge waits for PR Readiness on this head.
bolichen97
left a comment
There was a problem hiding this comment.
Approving head ad4430c.
PR Readiness is green on this head and the readiness: passed label is present. Every required check passed. The Design, First Principles, Opus, GPT and Security Scope lanes passed. The UX lane reported watch items only, which my earlier review covered. The branch targets main and merges with no conflict.
My earlier review of this head still applies: both menus render from one item builder, the board menu gains no new item, and the new tests guard the trigger and the rename case.
Problem / Motivation
Goal: Right-clicking a folder in a board column opens the same menu as its ⋮ button.
Right now a right-click on a board folder just gives you the browser menu. The list view got this in #13545 but the board view was left out, so this is the other half of #18490.
Why it matters
The ⋮ button only shows on hover and it's tiny. Folders in the list view and session rows in both views already answer right-click, so board folders are the odd one out.
Not a goal
What changed (motivation → approach → change)
Right-clicking a board folder header opens the same actions as its ⋮ button. Both menus share the folder action renderer, so Rename and private-chat creation stay scoped to the clicked column. Session rows keep their own menus, and the rename input keeps the browser edit menu.
The implementation lives in
chat-sidebar/boardLane.tsxandfolderBlocks.tsx, preserving the extracted sidebar structure, offline guards and current private-chat actions.docs/feature-map/README.mdanddocs/system-specs/modules/history.mddescribe the behavior;website/scripts/restyle-baseline.jsondrops the board renderer's two removed findings.Backwards compatibility
Compatible: the board ⋮ menu keeps its current actions and handlers. List-only hide and conductor actions remain list-only.
Removes nothing: board action test IDs align with the shared renderer (
new-subbecomesnew-subfolder; Rename and Delete receive IDs). Existing board and list regression tests verify the behavior.Tests
website/src/test/ChatSidebar.boardFolderContextMenu.test.tsxhas nine focused tests covering menu items, dropdown/context parity, column-scoped private-chat creation, the header/body boundary, offline rename refusal, scoped rename/save, native input context menus, and confirmed/cancelled deletion. The focused run passed all 20 tests across the new suite and existing board-rename/list-private-chat suites.The selected frontend run passed 379 files / 11,630 tests. Electron tests passed 2,757 tests with four skips. Production build, TypeScript, full ESLint, Python lint/type checks, documentation lint, translation checks (including browser rendering), bundle checks, duplication scan (zero clones), restyle ratchet, diff-scoped Semgrep, and all 58 flake-pattern tests passed. A separate sidebar run passed 131 files / 1,471 tests with shuffled order (seed 18844, one worker).
Local backend validation is incomplete: the 951-file selection stalled during collection, and diagnostic collection runs crashed on Python 3.12.7 and 3.12.15. Full backend/platform validation and fresh GitHub reviews remain pending. The last upstream rebase leaves the sidebar implementation and its tests unchanged.
Manual verification
Verified the freshly built SPA with scripted Playwright and stubbed APIs: both menus contain the same seven actions, and Rename opens only in the selected column. In Chromium touch emulation, stationary long-press opens the menu with no reorder request. It briefly activates the drag preview; release clears the preview and leaves the menu open. Hold then drag produces one correct reorder, no menu, and clears the preview on release. No browser page errors. Physical touch hardware and WebKit have not been tested.
Screenshots / video
Right-click on "Release 0.9" in the ToDo column:
Same items from the ⋮ button:
Rename picked from a right-click in the Review column. The ToDo copy of the folder is untouched:
Related Issues
Closes #18490
Pattern harvest
N/A — additive board-folder menu support using the existing folder-menu renderer.
Checklist
Contribution License Agreement
Apache-2.0, same as the project.