Skip to content

docs(decisions): a Conductor's board tab replaces its in-chat task board - #18900

Merged
bolichen97 merged 1 commit into
mainfrom
docs/decision-conductor-board-on-tab
Oct 12, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/decision-conductor-board-on-tab

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the maintainer's decision that a Conductor whose Dashboard tab shows the task board does not write a second board in the chat, superseding the 2026-10-02 Conductor entry.

The implementation #18608 is blocked by recorded-decisions-are-not-regressions: docs/decisions/2026-10-02-conductor-introduces-itself-in-every-chat.md says every Conductor chat reports with a live task board, and a change of mind needs a superseding entry in its own PR (docs/decisions/README.md rule 3).

Why it matters

The RFC #18620 is merged, so the direction is decided; without this entry the decision ledger still says the opposite, and #18608 cannot land.

Not a goal

What changed (motivation → approach → change)

  • docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md: new entry, Supersedes: 2026-10-02-conductor-introduces-itself-in-every-chat.md. It keeps the introduction and "Needs you" first everywhere; on a goal-board / work-kanban tab the tab is the board and no in-chat widget or task-dashboard artifact is written.
  • docs/decisions/README.md: one index row.

Decided by Joe Guo (@iamwhatever, maintainer in MAINTAINERS.md): merged RFC #18620 and commented on record. Per rule 4, @iamwhatever please restate the decision in a comment on this PR, and per rule 3 this PR needs a maintainer /ai-review override of the reviewer rule to land. cc @bolichen97, author of the 2026-10-02 entry.

Backwards compatibility

Compatible: documentation only.

Removes nothing: adds one entry and one index row; the 2026-10-02 entry stays byte-identical (check_decisions_history.py OK).

Tests

N/A — docs only; scripts/docs-lint.sh and DECISIONS_BASE_REF=origin/main scripts/check_decisions_history.py pass locally.

Manual verification

N/A — docs only.

Related Issues

RFC #18620; implementation #18608.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 10, 2026 18:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 3097b227d94eaff5b83abfe8e606642e060a27d0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 3097b227d94eaff5b83abfe8e606642e060a27d0 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3097b227d94eaff5b83abfe8e606642e060a27d0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merging, confirm that @iamwhatever has restated the decision on this PR and given the /ai-review override that rule 3 requires.

[DESIGN-REVIEWED] 3097b22

Description read

[DESCRIPTION-READ] 8754c4fa44299a67d40675061ff18dafc36b73dfcd8db0a7792996bd1fd548af

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 3097b227d94eaff5b83abfe8e606642e060a27d0 — this comment is updated in place on each push.

Human judgment by @iamwhatever overrides the Opus 5.5 finding for 3097b227d94eaff5b83abfe8e606642e060a27d0; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 3097b22

Verdict recorded from an authorized human decision for commit 3097b227d94eaff5b83abfe8e606642e060a27d0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3097b227d94eaff5b83abfe8e606642e060a27d0: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @iamwhatever overrides the GPT 6.1 finding for 3097b227d94eaff5b83abfe8e606642e060a27d0; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] 3097b22

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3097b227d94eaff5b83abfe8e606642e060a27d0: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Dispositions for head 3097b227d9, GPT 6.1 and Opus 5.5

  • Superseding a recorded decision requires a maintainer override (both lanes, docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md:5). Accepted as by design, not a defect. No code change. docs/decisions/README.md rule 3 says a superseding entry ships in its own PR, the recorded-decisions-are-not-regressions rule blocks it on purpose, and only a maintainer's override lets it land. Both lanes' own fixes say the same. Removing the Supersedes: line would make the entry contradict the 2026-10-02 one without saying so, which is worse.

What is still needed, and only a maintainer can do it:

  1. @iamwhatever: per rule 4, please restate the decision in a comment on this PR (the RFC comment #18620 (comment) says it was synced offline, which rule 4 does not count on its own).
  2. A maintainer posts the two overrides on head 3097b227d94eaff5b83abfe8e606642e060a27d0, for gpt and fable.

No new push: the entry is unchanged, so a push would only restart every lane. cc @bolichen97 (author of the 2026-10-02 entry).

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 3097b22: the recorded-decisions rule blocks every Supersedes: entry by design and asks for maintainer judgment; this entry is the author's own product decision (the Conductor's board moves from in-chat to the Dashboard tab), the superseded 2026-10-02 entry stays immutable per rule 2, and the README index row is present.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 3097b22: same judgment as the gpt override above: a deliberate, author-owned supersession recorded per the decisions rule, with the old entry left intact.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the gpt AI finding as false positive, not applicable, or explicitly accepted for 3097b227d94eaff5b83abfe8e606642e060a27d0.

the recorded-decisions rule blocks every Supersedes: entry by design and asks for maintainer judgment; this entry is the author's own product decision (the Conductor's board moves from in-chat to the Dashboard tab), the superseded 2026-10-02 entry stays immutable per rule 2, and the README index row is present.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the fable AI finding as false positive, not applicable, or explicitly accepted for 3097b227d94eaff5b83abfe8e606642e060a27d0.

same judgment as the gpt override above: a deliberate, author-owned supersession recorded per the decisions rule, with the old entry left intact.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: change matches its stated goal, tests cover the new behaviour, readiness passed at this head.

@bolichen97
bolichen97 merged commit 153c3c1 into main Oct 12, 2026
101 of 103 checks passed
@bolichen97
bolichen97 deleted the docs/decision-conductor-board-on-tab branch October 12, 2026 18:08
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants