Skip to content

fix(conductor): skip the in-chat task board when the Dashboard tab shows it - #18608

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/conductor-chat-board-dedupe
Oct 13, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/conductor-chat-board-dedupe

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Crew Mode conductor whose Dashboard tab already shows the task board stops drawing a second full copy of that board in the chat at every milestone.

User feedback (Crew Mode, dashboard chat): at every milestone the conductor draws a full "Task board" widget in the chat. The conductor's Dashboard tab, on the goal-board template, already shows the same board, folded live from the work ledger. Every task is shown twice, and the chat fills with tables the reader already has beside it.

Why it matters

Crew Mode is the plain-words entry to the conductor for everyday users. A chat where each milestone repeats a full table that sits one tab away buries the one thing they need to read: what waits on them.

Not a goal

  • Changing the introduction widget rule (first reply).
  • Changing any surface with no board tab (a chat whose Dashboard tab shows another template, a messaging channel, a scheduled run, the CLI): they keep the full in-chat "Task board" widget exactly as today.
  • Changing the goal-board / work-kanban templates or the [DASHBOARD] block.

What changed (motivation → approach → change)

Symptom (board twice) → cause: the "Talking to the person" milestone rule in _CONDUCTOR_SYSTEM_PROMPT (src/kiro_crew/agent.py) asks for the full widget unconditionally, though the conductor's turn already carries a [DASHBOARD] block naming the template its tab shows → the rule now branches on that block.

This is a generation-time rule in the conductor prompt: on a board tab the model is told not to write the widget or the artifact, so nothing is drawn and then hidden, and no client-side suppression is added. The motivation is the reader's duplication AND the output tokens of a full widget plus a task-dashboard artifact update at every milestone. Design record: #18620.

  • Tab shows goal-board or work-kanban (the two templates that draw every work item from the work fold): the reply carries only the "Needs you" lines first when anything waits on the person, then one short line on what changed and what happens next. No per-task table.
  • Anything else: the full "Task board" widget, unchanged. The branch keys on those two template ids rather than on "a [DASHBOARD] block exists", because a crewmate that never adopted a template gets the default project-report, which does not draw the task board.
  • task-dashboard artifact rule: written on the no-tab branch only. There it is still the only full board. On a board tab the prompt says not to write it: the tab is the full board, and a third copy costs output tokens.
  • The [OPTIONS: ...] / ask_question rule for answers now sits above both branches, since both still ask the person things.
  • Pinned conductor spec digests and the prompt fingerprint are refreshed.

Recorded decision: RFC #18620 (docs/request-for-change/rfc-conductor-chat-board-on-tab.md) is merged on main by maintainer @iamwhatever. The superseding decision entry docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md, which replaces 2026-10-02-conductor-introduces-itself-in-every-chat.md, is in its own PR #18900, as docs/decisions/README.md rule 3 asks.

@bolichen97 — this changes the Crew Mode milestone rule you added in #16088. Could you review whether this split matches your intent?

Backwards compatibility

Compatible: prompt text only; no API, config or data shape changes.

The diff takes one thing away on one surface: the in-chat per-task table when the Dashboard tab shows goal-board / work-kanban.

Reader: src/kiro_crew/agent.py:_CONDUCTOR_SYSTEM_PROMPT -- chat -- the conductor model reads it; the same board stays on its Dashboard tab (dashboard_templates/builtin/goal-board), and "Needs you" still leads the chat reply
Reader: src/kiro_crew/dashboard_agentic.py:turn_block -- crew page -- unchanged; it is the signal the new branch reads
Reader: test/test_agent_refactor_spec_bytes.py:GOLDEN -- release -- digests refreshed for the new prompt bytes (test_every_written_spec_matches_the_pre_split_bytes)

Tests

  • test/test_agent_refactor_spec_bytes.py: conductor and ledger-conductor spec digests refreshed for the new prompt bytes (all eight scenarios).
  • test/test_agent_refactor_contracts.py: _CONDUCTOR_SYSTEM_PROMPT fingerprint refreshed.
  • Locally (head 6bd42fd): both files 74 passed; test_agent_refactor_facade, test_conductor_agent, test_conductor_base_work_ledger, test_ledger_conductor_agent, test_conductor_allowed_tools_survive, test_conductor_wake_reset, test_agent_execution_catalog 368 passed. black / isort / flake8 clean on the touched files.

Manual verification

N/A — prompt-only change; no code path reads the text beyond the pinned digests.

Related Issues

Follows #16088. RFC #18620 (merged). Superseding decision #18900.

Pattern harvest

Not generalizable: one prompt rule written before the conductor's Dashboard tab carried the same board; nothing else draws a second copy of a tab's content.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — no doc quotes this rule
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 9, 2026 21:00
@iamwhatever
iamwhatever requested a review from bolichen97 October 9, 2026 21:00
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 4f31506abd942e79345e63dd82e83bae06e22c13 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 4f31506abd942e79345e63dd82e83bae06e22c13 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check before merge: the description says decision #18900 "replaces" 2026-10-02-conductor-introduces-itself-in-every-chat.md, but RFC §5 says "This change keeps it."

What this change ships

Inventory (5 items) — 5 justified

Intent: stop a conductor whose Dashboard tab already shows the task board from redrawing that board in chat at every milestone. FIX.

  1. On a goal-board / work-kanban tab, a milestone reply no longer draws the "Task board" widget. It carries only "Needs you" plus one status line — justified
  2. On those tabs, "Needs you" is left out when nothing waits, where it used to say "Nothing right now" — justified
  3. On a board tab, the prompt now says outright not to write a task-dashboard artifact. Every other surface keeps it unchanged — justified
  4. The [OPTIONS: ...] / ask_question rule for answers moved above both branches — justified
  5. Pinned conductor spec digests and the prompt fingerprint are refreshed — justified

[FIRST-PRINCIPLES-REVIEWED] 4f31506

Description read

[DESCRIPTION-READ] a5579f3ac867938c06ceaac5a45c5acce3d57bb7c22c654f6202cf41bcd4a8bd

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4f31506abd942e79345e63dd82e83bae06e22c13 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4f31506

Verdict parsed from the review's SHA-scoped output markers for commit 4f31506abd942e79345e63dd82e83bae06e22c13.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4f31506abd942e79345e63dd82e83bae06e22c13: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4f31506abd942e79345e63dd82e83bae06e22c13 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check one live goal-board conductor chat: milestone replies should carry only the "Needs you" lines and one status line, with no widget and no task-dashboard artifact.

[DESIGN-REVIEWED] 4f31506

Description read

[DESCRIPTION-READ] 9e0440859d37afba99007b9226f97d622556824a3121ac71881dcd8bb9438621

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4f31506abd942e79345e63dd82e83bae06e22c13 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4f31506

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4f31506abd942e79345e63dd82e83bae06e22c13: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Parked while we wait for @bolichen97's on-record decision. Details and the reason are on the RFC: #18620. The recorded-decisions and First Principles blocks clear only after his reply, so there will be no push here until then.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 9, 2026
@iamwhatever
iamwhatever force-pushed the fix/conductor-chat-board-dedupe branch from f566336 to 6bd42fd Compare October 10, 2026 19:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the fix/conductor-chat-board-dedupe branch from 6bd42fd to dfc0e9c Compare October 10, 2026 20:16
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the fix/conductor-chat-board-dedupe branch from dfc0e9c to ae8d6df Compare October 10, 2026 23:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 11, 2026
@iamwhatever
iamwhatever force-pushed the fix/conductor-chat-board-dedupe branch from 17b390b to 62d2f56 Compare October 12, 2026 23:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision labels Oct 12, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026
chenmingwei23
chenmingwei23 previously approved these changes Oct 13, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 13, 2026
…ows it

A crewmate conductor whose Dashboard tab shows `goal-board` or
`work-kanban` already has the full task board beside the chat, kept
current from the work ledger. Drawing the same board as a widget at every
milestone showed every task twice.

The "Talking to the person" milestone rule now branches on the
`[DASHBOARD]` block. With one of those two templates in force, the reply
carries only the "Needs you" lines (when anything waits on the person)
and one short line on what changed and what happens next. Every other
surface keeps the full "Task board" widget, and the `task-dashboard`
artifact rule stays with it, since those surfaces have no tab carrying
the full board. The intro widget rule is unchanged.

Pinned conductor spec digests and prompt fingerprint are refreshed.
@iamwhatever
iamwhatever force-pushed the fix/conductor-chat-board-dedupe branch from 62d2f56 to 4f31506 Compare October 13, 2026 06:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 13, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 13, 2026 08:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (3 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: conductor prompt stops drawing the in-chat task board when the Dashboard tab already shows a board page; spec hash fixtures updated to match.

@KiroCrewCaptain
KiroCrewCaptain merged commit 9b5f3d8 into main Oct 13, 2026
103 of 105 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/conductor-chat-board-dedupe branch October 13, 2026 08:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants