Repository navigation
docs(rfc): the dynamic dashboard is the Dashboard tab for every reader - #19609
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Before merge, check that a maintainer signs off on this record. Later PRs that remove the preview will cite this amendment as the maintainer's 2026-10-12 decision. [DESIGN-REVIEWED] 1af40b5 Description read[DESCRIPTION-READ] a3353401f9f94f791086a2efd00f7947719fc55f4516da4c2059a0098a6c7f59 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Disposition: needs-a-decision. Drafted by an agent working for this PR's author.
|
chenmingwei23
left a comment
There was a problem hiding this comment.
Approving. The four decisions match what we want: one Dashboard tab for every reader, the panel templates become built-in dashboard packages, panel_publish feeds a fold, and the preview toggle goes away.
Non-blocking follow-ups for the implementation PRs:
- Day-one default page: the built-in page should read the existing
panelfold, so crewmates that only call panel_publish keep working with no prompt change. - Store the redacted payload in the fold, not the raw publish body, so the page never sees what the publish path scrubs.
- Use one name for this surface in prompts and skills. Today
_MEMBER_DASHBOARD_ITEMsays "Dashboard tab" andagent.pystill says "You cannot write the page", which contradicts v3. - Please list the merge order for the in-flight PRs this touches: #18851, #19335, #18755, #19069, #18608, #18957.
Record a maintainer decision of 2026-10-12 as a second amendment of that day to the crewmate dynamic dashboard RFC, so the pull requests that remove the preview and carry the crew panel over can read it off the base branch. - The "Dynamic Dashboard" Feature Preview goes. The dynamic dashboard is the Dashboard tab for every reader, with no fallback to the panel_publish view. This closes Open question 3. - panel_publish keeps accepting. What it publishes is panel-fold data a page may read, resolved against its own crewmate's record. - While the catalog still serves pages, an operator's own page in the data home's panel-templates folder renders with source user, and a crewmate's default page may be the page named after it. Both end with the catalog. - Before the catalog retires, the layout lock and a root session's own page need a home on the package path, and a default page stays until a composed page renders end to end. Both earlier amendments stand. The front matter, the status line, the "where they disagree" bullet and the index's revision sentence move with it.
59f25bc to
1af40b5
Compare
|
Disposition: needs-a-decision. Drafted by an agent working for this PR's author.
|
|
@chenmingwei23 could you re-approve this head ( |
|
RFC merge |
Problem / Motivation
Goal: put on main the record that the dynamic dashboard is the Dashboard tab for every reader, with the "Dynamic Dashboard" Feature Preview removed, so the pull requests that build it trace to a decision instead of proposing one.
docs/request-for-change/rfc-crewmate-dynamic-dashboard.mdispartial, and its Open question 3 is still open: does the publishedpanel_publishpage keep the Dashboard tab when a crewmate has adopted nothing?On main the answer is a switch kept on each device. With the "Dynamic Dashboard" Feature Preview off, which is the default, a crewmate's tab shows its published panel. With it on, the tab shows the dynamic dashboard. The RFC's §Backward compatibility says nothing renders the published page any more, and main does not match it.
A maintainer decided on 2026-10-12: the dynamic dashboard is the tab for every reader, and the preview goes.
Why it matters
Removing the preview changes what every reader sees by default. The First Principles lane asks such a change to trace to an RFC decision on the base branch. Without this record, each pull request that removes the preview or carries the panel over needs a maintainer override on every head.
The decision also has to say where the panel's data goes. Otherwise a crewmate that publishes a board would lose its only reader the day the preview goes.
Not a goal
src/,website/ortest/moves. The preview is removed by its own pull request, which rebases onto this one.docs/request-for-change/README.mdkeeps its table row and status column as they are, and gains one revision sentence.What changed (motivation → approach → change)
Every reader gets the dynamic dashboard in the Dashboard tab, and the "Dynamic Dashboard" Feature Preview goes. This pull request puts that decision on main. It has to be on the base branch, because that is where the First Principles lane reads it. So it is docs only, the same shape as #19204 and #19287.
It adds one section to the RFC: "Amendment 2026-10-12 (second)". It records four decisions.
panel_publishkeeps accepting. What it publishes lands in thepanelfold, which a page may bind.panel-templatesfolder renders, with sourceuser.A last part says what the catalog's retirement under #18642 must carry. The layout lock and a root session's own page need a home first. The empty state waits until a composed page renders end to end.
The section keeps both earlier amendments. The first amendment of 2026-10-12 retired the catalog flow, and that stands. Decisions 3 and 4 hold only while the catalog still serves pages, and they end with it. "Kept" in decision 1 means the capability, so that amendment's moves still stand: preview and apply go into the save gate, and the undo becomes
artifact_revert.It supersedes only the parts of §Backward compatibility about the published page. That section's two other points stand. The section also names the drift main has today: with the preview off, a reader still sees the published view.
The header moves with it.
audited-atis10350b7294, the commit this was read against. The status line says the tab is still behind the preview on main. The "where they disagree" bullet names the new section. The index gets one revision sentence, in the shape #19287 used.Backwards compatibility
Removes nothing: the diff is two documentation files. No route, tool, field, default or public function changes. The superseded passages stay in the document, and the amendment names each one.
Tests
No test pins this file's text. The documentation gates were run on this diff with Python 3.12:
Manual verification
Each passage the amendment names was read again, to check it is still findable and the supersede is specific. Each code fact the amendment states was checked at
10350b7294:panelis a slot fold a page may bind, and it keeps one record per owner.panel-templatesfolder is write-fenced from agent file tools and sealed read-only for a sandboxed shell.useris already a template source.Related Issues
Part of #18642
Checklist