Skip to content

docs(rfc): the dynamic dashboard is the Dashboard tab for every reader - #19609

Merged
iamwhatever merged 1 commit into
mainfrom
docs/rfc-dashboard-tab-every-reader
Oct 13, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/rfc-dashboard-tab-every-reader

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: put on main the record that the dynamic dashboard is the Dashboard tab for every reader, with the "Dynamic Dashboard" Feature Preview removed, so the pull requests that build it trace to a decision instead of proposing one.

docs/request-for-change/rfc-crewmate-dynamic-dashboard.md is partial, and its Open question 3 is still open: does the published panel_publish page keep the Dashboard tab when a crewmate has adopted nothing?

On main the answer is a switch kept on each device. With the "Dynamic Dashboard" Feature Preview off, which is the default, a crewmate's tab shows its published panel. With it on, the tab shows the dynamic dashboard. The RFC's §Backward compatibility says nothing renders the published page any more, and main does not match it.

A maintainer decided on 2026-10-12: the dynamic dashboard is the tab for every reader, and the preview goes.

Why it matters

Removing the preview changes what every reader sees by default. The First Principles lane asks such a change to trace to an RFC decision on the base branch. Without this record, each pull request that removes the preview or carries the panel over needs a maintainer override on every head.

The decision also has to say where the panel's data goes. Otherwise a crewmate that publishes a board would lose its only reader the day the preview goes.

Not a goal

What changed (motivation → approach → change)

Every reader gets the dynamic dashboard in the Dashboard tab, and the "Dynamic Dashboard" Feature Preview goes. This pull request puts that decision on main. It has to be on the base branch, because that is where the First Principles lane reads it. So it is docs only, the same shape as #19204 and #19287.

It adds one section to the RFC: "Amendment 2026-10-12 (second)". It records four decisions.

# Decision What it settles
1 The dynamic dashboard takes the Dashboard tab for every reader. The "Dynamic Dashboard" Feature Preview goes. Closes Open question 3. The tab never falls back to the published panel.
2 panel_publish keeps accepting. What it publishes lands in the panel fold, which a page may bind. The panel's data keeps a reader.
3 An operator's own page in the data home's panel-templates folder renders, with source user. Narrows "the registry scans no writable directory". No agent can write that folder.
4 A crewmate's default page may be the page named after it. Carries over the panel's own naming rule.

A last part says what the catalog's retirement under #18642 must carry. The layout lock and a root session's own page need a home first. The empty state waits until a composed page renders end to end.

The section keeps both earlier amendments. The first amendment of 2026-10-12 retired the catalog flow, and that stands. Decisions 3 and 4 hold only while the catalog still serves pages, and they end with it. "Kept" in decision 1 means the capability, so that amendment's moves still stand: preview and apply go into the save gate, and the undo becomes artifact_revert.

It supersedes only the parts of §Backward compatibility about the published page. That section's two other points stand. The section also names the drift main has today: with the preview off, a reader still sees the published view.

The header moves with it. audited-at is 10350b7294, the commit this was read against. The status line says the tab is still behind the preview on main. The "where they disagree" bullet names the new section. The index gets one revision sentence, in the shape #19287 used.

Backwards compatibility

Removes nothing: the diff is two documentation files. No route, tool, field, default or public function changes. The superseded passages stay in the document, and the amendment names each one.

Tests

No test pins this file's text. The documentation gates were run on this diff with Python 3.12:

$ COMMENT_HISTORY_BASE_REF=origin/main python scripts/check_comment_history.py
comment-history gate passed: no history narration on the lines this change adds.   # exit 0
$ python scripts/check_comment_history.py --test
self-test passed: 22 flagged probes, 15 clean probes.                             # exit 0
$ python scripts/docs_lint.py --test
Self-test passed                                                                  # exit 0
$ python scripts/docs_lint.py
All documentation checks passed                     # exit 0, no finding names either file
$ BRAND_BASE_REF=origin/main python scripts/check_brand_name.py
brand gate: no misspellings of 'Kiro Crew' in the lines added since origin/main   # exit 0
$ FEATURE_MAP_BASE_REF=origin/main python scripts/check_feature_map.py
feature-map gate: docs/feature-map/README.md accounts for this change             # exit 0
$ python -m pytest test/test_pr_quality_gates.py     # the one related test file
76 passed                                                                         # exit 0

Manual verification

Each passage the amendment names was read again, to check it is still findable and the supersede is specific. Each code fact the amendment states was checked at 10350b7294:

  • The preview decides what a crewmate's Dashboard tab draws: with it off, the published panel. It also gates a root session's Dashboard view, the All Dashboards entry and the Profile card's lock switch.
  • panel is a slot fold a page may bind, and it keeps one record per owner.
  • The panel-templates folder is write-fenced from agent file tools and sealed read-only for a sandboxed shell.
  • The pipeline board's card is built from a published panel.
  • user is already a template source.
  • The automatic session cards switch defaults to off.

Related Issues

Part of #18642

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality (documentation gates run above; no code path changes)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 12, 2026 23:26
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 1af40b5de8ce6408ab9f031b30f3935634c93545 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1af40b5de8ce6408ab9f031b30f3935634c93545 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1af40b5de8ce6408ab9f031b30f3935634c93545 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merge, check that a maintainer signs off on this record. Later PRs that remove the preview will cite this amendment as the maintainer's 2026-10-12 decision.

[DESIGN-REVIEWED] 1af40b5

Description read

[DESCRIPTION-READ] a3353401f9f94f791086a2efd00f7947719fc55f4516da4c2059a0098a6c7f59

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1af40b5de8ce6408ab9f031b30f3935634c93545 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1af40b5

Verdict parsed from the review's SHA-scoped output markers for commit 1af40b5de8ce6408ab9f031b30f3935634c93545.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1af40b5de8ce6408ab9f031b30f3935634c93545: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1af40b5de8ce6408ab9f031b30f3935634c93545 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1af40b5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1af40b5de8ce6408ab9f031b30f3935634c93545: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Disposition: needs-a-decision. Drafted by an agent working for this PR's author.

The Design punchline asks a maintainer to confirm that the 2026-10-12 decision is theirs.
The maintainer who made it is this PR's author, and the PR was opened at their direction.
An agent drafted the amendment and this reply, so neither one is that confirmation.
Question for the maintainer: please confirm here, in your own comment, that the four decisions in "Amendment 2026-10-12 (second)" are yours.

chenmingwei23
chenmingwei23 previously approved these changes Oct 13, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The four decisions match what we want: one Dashboard tab for every reader, the panel templates become built-in dashboard packages, panel_publish feeds a fold, and the preview toggle goes away.

Non-blocking follow-ups for the implementation PRs:

  1. Day-one default page: the built-in page should read the existing panel fold, so crewmates that only call panel_publish keep working with no prompt change.
  2. Store the redacted payload in the fold, not the raw publish body, so the page never sees what the publish path scrubs.
  3. Use one name for this surface in prompts and skills. Today _MEMBER_DASHBOARD_ITEM says "Dashboard tab" and agent.py still says "You cannot write the page", which contradicts v3.
  4. Please list the merge order for the in-flight PRs this touches: #18851, #19335, #18755, #19069, #18608, #18957.

Record a maintainer decision of 2026-10-12 as a second amendment of that
day to the crewmate dynamic dashboard RFC, so the pull requests that remove
the preview and carry the crew panel over can read it off the base branch.

- The "Dynamic Dashboard" Feature Preview goes. The dynamic dashboard is the
  Dashboard tab for every reader, with no fallback to the panel_publish view.
  This closes Open question 3.
- panel_publish keeps accepting. What it publishes is panel-fold data a page
  may read, resolved against its own crewmate's record.
- While the catalog still serves pages, an operator's own page in the data
  home's panel-templates folder renders with source user, and a crewmate's
  default page may be the page named after it. Both end with the catalog.
- Before the catalog retires, the layout lock and a root session's own page
  need a home on the package path, and a default page stays until a composed
  page renders end to end.

Both earlier amendments stand. The front matter, the status line, the
"where they disagree" bullet and the index's revision sentence move with it.
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/README.md since this head went green (10350b7 -> 315affc); CI re-running.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Disposition: needs-a-decision. Drafted by an agent working for this PR's author.

The Design punchline asks for a maintainer's sign-off on this record before merge.
A maintainer approved the previous head 59f25bc and wrote that the four decisions match what is wanted.
The rebase onto main dismissed that approval. It changed only the RFC index sentence, and the RFC diff is byte-identical.
The sign-off is that maintainer's own approval on this head. An agent cannot give it, so it is asked for in a separate comment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@chenmingwei23 could you re-approve this head (1af40b5de8)? Rebasing onto main to clear a merge conflict dismissed your approval of 59f25bc248. The rebase only touched the RFC index sentence in docs/request-for-change/README.md. The RFC diff in docs/request-for-change/rfc-crewmate-dynamic-dashboard.md is byte-identical to the one you approved. Every check on this head is green.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

RFC merge

@iamwhatever
iamwhatever merged commit 7ca644d into main Oct 13, 2026
102 of 103 checks passed
@iamwhatever
iamwhatever deleted the docs/rfc-dashboard-tab-every-reader branch October 13, 2026 02:30
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants