Skip to content

feat(dashboard): the default page shows what a crewmate published - #19657

Merged
chenmingwei23 merged 1 commit into
mainfrom
feat/dashboard-default-page-panel
Oct 13, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
feat/dashboard-default-page-panel

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate that only calls panel_publish keeps showing what it published on its default dashboard page, once the preview flag is gone.

Today the published board shows only on the old panel view. The flag-removal PR deletes that view. Without this PR, a crewmate that publishes would show nothing of its board on day one.

Why it matters

Most crewmates adopted no page, so they get the default page, project-report. Their published boards must not vanish when the tab changes. The data must also stay safe: one slot can hold two crews, and a page must never show another crew's board or a secret.

Not a goal

  • Removing the preview flag (the next PR).
  • Operator pages, the conductor's own page, and any prompt or skill text.
  • Changing panel_publish, its route, its record or its crew-log entry.

What changed (motivation → approach → change)

This implements Decision 2 of the RFC amendment in #19609, and review items 1 and 2 there.

The page reads what the panel route reads. The panel fold keeps one record per crew, and its top level is just the newest publish, which may be another crew's. The panel read route picks a crew's own record by its ownership digest, and prefers the publish file over the fold, because the file holds every publish while the log can miss one. The page now uses that same rule through one shared helper, owned_panel_record in src/kiro_crew/dashboard/handlers/agent_panel.py, and the route and the page share one ownership check, _owned_by. read_fields in src/kiro_crew/dashboard/handlers/member_dashboard.py calls it and hands the record to the feed (page_panel in src/kiro_crew/dashboard_feed.py). A crewmate that never published, or a root session's page, gets an empty object. The other crews' records and the digest cannot be bound from a page.

The digest stays hidden. crew_key joins _MASKED_VALUE_KEYS, so no page carries it: the agentic and mistakes folds carry it inside their values too.

The stored copy is already clean. The publish route builds the crew-log entry from the scrubbed record, not the raw body. A test now pins that. The page read also redacts again.

The default page draws it. project-report (src/kiro_crew/dashboard_templates/builtin/project-report/manifest.json, now version 3) binds published to {"fold": "panel", "path": "data"}. A new block in src/kiro_crew/dashboard_templates/builtin/project-report/template.html draws any object as text, like the panel's default template: a short value is a tile, a long one a paragraph, a list of objects a table, a list of values a list, a nested object key/value rows. It wears the same crewmate wrote this tag as every other crewmate-written value on the page. It is hidden when nothing was published. The footer line says "a board published by the crewmate". A page with only a publish says so once, and hides the zero counters above it. A table that drops rows or columns says so. A publish re-reads the open page: panel_published now also refetches the dashboard (website/src/hooks/useWebSocket.ts). It uses textContent only, with no HTML sink.

The project-report sample fixtures gain a panel fold. A new sample_panel.json feeds the page tests, and sample_workstreams-published-only.json is the page for a crewmate that only publishes. The builtin README (src/kiro_crew/dashboard_templates/builtin/README.md), the feature map row and the evidence script name the new block.

Merge order: this lands after #19609 and before the flag-removal PR (feat/dashboard-remove-preview-flag), so a crewmate that only publishes keeps its data on day one. If #19335 or #18851 land first, this PR rebases onto them.

Backwards compatibility

Compatible: the publish wire contract is unchanged, and a page that never bound panel reads the same values. Adopted project-report copies read as stale until re-adopted, as any version bump does.

Removes nothing: a page could bind the slot's newest panel record before, and no shipped page did; the only binding is the new published field.

Tests

  • test/test_dashboard_panel_fold.py (real crew log, fold, file and feed): the page shows the file's publish when the log missed it, like the route; another crew's file on the slug never shows; another crew's publish on a shared slot never reaches this page; a crewmate that never published reads {} and is not stale; a root session reads no panel; owners and crew_key do not resolve from a page; a credential in a published line never reaches the page. Five of six fail on main.
  • test/test_agent_panel_routes.py: the fold holds the scrubbed publish, not the raw body.
  • test/test_dashboard_template_project-report.py: no HTML sink in the page; published binds panel.data.
  • website/src/test/projectReportPage.test.ts: the block draws each shape as text, wears the tag, draws markup as text, hides with no publish, leaves on a refresh that drops it, caps a long table, says when it drops columns, says once that only a publish is shown with no zero counters, and brings the counters back when work arrives. website/src/test/useWebSocket.frameTrace.test.ts: a publish refetches the dashboard (fails without the change). All six fail on the old template.
  • Determinism: the new Python cases pass three repeats and in reverse order; the flake-pattern ratchet passes.

Manual verification

Rendered the page from the fixtures with scripts/render_dashboard_builtin.py, wide and narrow, dark and light, and with no publish.

Screenshots / video

A crewmate with no tracked work that has published a board, the whole page:

page with only a publish, wide dark

page with only a publish, narrow dark

A busy page, whole: the published card sits under the tree, and the footer names it.

busy page, wide dark

Light themes

page with only a publish, wide light

busy page, narrow light

Related Issues

Part of #18642

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 13, 2026 02:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cdc3c914c5d9a42c9df27aa261fb19ac51cdc920 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Pages that explicitly adopted project-report v2 don't get published until someone re-adopts them. Check that this matches the "default page only" Goal.

What this change ships

Inventory (9 items) — 9 justified

Intent: let a crewmate that only calls panel_publish keep showing its board on the default dashboard page after the preview flag is removed. This is an ADDITION, and it carries out Decision 2 of rfc-crewmate-dynamic-dashboard.md, whose status on base is partial.

  1. The default project-report page shows a "crewmate wrote this" card with the crewmate's last publish, and hides it when there is none — justified
  2. The page reads only the reader's own crew's record, chosen by the read route's rule (file first, then fold); other crews' records and a root session's page read empty — justified
  3. crew_key is now masked on every dashboard page, including in the agentic and mistakes fold values — justified
  4. A publish now refetches the open dashboard page (useWebSocket.ts) — justified
  5. A page with only a publish says so once and hides the zero counters — justified
  6. The footer line now names "a board published by the crewmate" — justified
  7. A long or wide published table is capped and says what it dropped — justified
  8. The project-report manifest goes to version 3, so adopted copies read as stale until re-adopted — justified
  9. The route's ownership check moves into a shared _owned_by, with no change in behaviour — justified

[FIRST-PRINCIPLES-REVIEWED] cdc3c91

Description read

[DESCRIPTION-READ] 12249257b9b6a5cf0920023d42c3813fe5abd286d9b70b25c313ef0c156b2082

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cdc3c914c5d9a42c9df27aa261fb19ac51cdc920 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that handleDashboardMoved matches a panel_published frame to the open page by the same slug and member fields a dashboard-moved frame carries. If it doesn't, the open page won't refresh after a publish.

[DESIGN-REVIEWED] cdc3c91

Description read

[DESCRIPTION-READ] fb5232e8a54727370cdadb0a2508d70e8122e8e38a70c6be6a103f77e6ce57a4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of cdc3c914c5d9a42c9df27aa261fb19ac51cdc920 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The publish-only page shows no publish time, and its only freshness signal is an orange "No new entry" dot that reads as a warning.

Watch

  • No age on the publish. The new hint says "Below is what this crewmate last published.", but the card shows no time. Above it, the existing header shows an orange dot and "No new entry · Updated 17:12" (shot-01, shot-04). The blind reader said "the orange colour makes me wonder if something is wrong." Someone landing on this page can't tell whether the board is fresh or days old, or whether orange means trouble. Every crewmate that only publishes lands in this state on every visit. Smallest fix: put "published 3m ago" in the card header beside crewmate wrote this.
  • A blank band where the hidden header was. On the publish-only page there are about 90px of empty space above the hint card (shot-01, shot-04). hideHead sets display:none on the pills and the totals line, but the space they sat in stays. The content looks pushed down for no reason. Close the gap, or zero the margin on that container when the header is hidden.
  • The truncation notes aren't in any screenshot. "showing {n} of {m}" and "columns capped at {n}" are new user-visible strings. They only appear on large boards (over 100 rows or 20 columns), so most users rarely see them. Add one fixture shot with a capped table.

Suggestions

  • pub_title fallback "Published by the crewmate" sits next to the crewmate wrote this tag and says the same thing twice. When the publish has no title, use a fallback that names the content, e.g. "Latest board".

[UX-REVIEWED] cdc3c91

Description read

[DESCRIPTION-READ] bae1be7aaa660586389fb25272a934606db15704d9620b7a845a019cc6bb9181

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cdc3c914c5d9a42c9df27aa261fb19ac51cdc920 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cdc3c91

Verdict parsed from the review's SHA-scoped output markers for commit cdc3c914c5d9a42c9df27aa261fb19ac51cdc920.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cdc3c914c5d9a42c9df27aa261fb19ac51cdc920: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cdc3c914c5d9a42c9df27aa261fb19ac51cdc920 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cdc3c91

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cdc3c914c5d9a42c9df27aa261fb19ac51cdc920: <one-sentence reason>

@iamwhatever
iamwhatever force-pushed the feat/dashboard-default-page-panel branch 5 times, most recently from 38eeb59 to 1fe2724 Compare October 13, 2026 04:09
@iamwhatever
iamwhatever force-pushed the feat/dashboard-default-page-panel branch from 1fe2724 to cdc3c91 Compare October 13, 2026 04:21
@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted span=639ad9ed80c4

The publish-only page shows the same header every crewmate page shows today, including its "No new entry" freshness dot; this PR adds no freshness signal and changes none.
A publish time on the card is new scope beyond the goal, which is to keep showing what was published. Out of goal for this PR.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted span=39464d33f3d4

The band is the page grid's gap around its empty status hosts (stale, verdict, lanes), which the empty page on main already has; hiding the pills does not add it.
Changing the page's grid spacing would move every project-report layout, which is beyond this PR's goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted span=ed8a6eeaee6d

Both notes are pinned by website/src/test/projectReportPage.test.ts: 'caps a long table and says so' and 'says when it drops columns' assert their exact text.
They only appear past 100 rows or 20 columns, so a screenshot adds no evidence the tests do not already carry.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted span=c8bc63363d42

The fallback title shows only when a publish carries no title, and it then has to say whose words these are; the tag says they are the crewmate's, the title says what the block is.
Renaming it to a word like "board" was raised as unclear by this lane in an earlier round, so the fallback stays.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted (PASS punchline)

panel_published carries {slug}, and handleDashboardMoved invalidates ['member-dashboard', slug], the key the open crewmate tab reads.
website/src/test/useWebSocket.frameTrace.test.ts pins it: a panel_published frame for slug 'crew' invalidates ["member-dashboard","crew"].

@iamwhatever

Copy link
Copy Markdown
Contributor Author

rebutted (PASS punchline)

The goal is the DEFAULT page: a crewmate that adopted nothing renders the catalog's current project-report and gets the published field at once.
A crewmate that adopted v2 explicitly keeps its own copy, which reads as stale until re-adopted, as every template version bump does; the Backwards compatibility section says so.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026
@chenmingwei23
chenmingwei23 merged commit 234f6a2 into main Oct 13, 2026
102 checks passed
@chenmingwei23
chenmingwei23 deleted the feat/dashboard-default-page-panel branch October 13, 2026 05:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants