Repository navigation
feat(crew): make the New editor the only crewmate editing experience - #19257
Conversation
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The PR removes Triggers and in-modal tools/MCP/skills editing on the strength of a decision record that does not exist, and it pulls the crewmates modal away from the Agents-page editor. Watch
[DESIGN-REVIEWED] c82df79 Description read[DESCRIPTION-READ] a69936abb32e46a56957a73ec5a0307ed4f27e4701f5bdef265e7cf4b45fe890 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ human override accepted@dodgeblaster overrode this lane for |
First Principles Review (Opus 5.5) — ✅ human override accepted@dodgeblaster overrode this lane for |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNot blocking: one advisory finding. FINDING — website/src/components/crew/CrewApprovalsEditor.tsx:240 — when a server has an [OPUS-REVIEWED] c82df79 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
b997f16 to
d85e1dd
Compare
d85e1dd to
7d1a42c
Compare
7d1a42c to
2aa22c3
Compare
0dacc2c to
9a8d8c1
Compare
9a8d8c1 to
eeb44cd
Compare
|
/ai-review override fable d988614: The Triggers-editing removal from the crewmate editor is a maintainer-approved team decision (confirmed in-thread by the maintainer driving this PR). The feature is retained — useCrewEditor still owns triggers load/save/dirty and TriggersField still renders on the Agents page (KiroCrewAgentsPage → CrewRoutingPane). The prior docs/decisions entry that tripped the maintainer-credit rule has been REMOVED from this PR entirely; the removal is documented via the PR body Reader: line plus this maintainer override, so there is no non-maintainer decision recorded in the tree. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
AI-review override not recorded: keep the reason to 500 characters or fewer. |
|
/ai-review override first-principles ca9dbd6: Making the modal'''s tools/MCP/skills read-only (edited on the Agents page) and removing the in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision this PR implements. Re-posting for the fresh head after the GPT narrow-viewport toolbar fix. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override ux ca9dbd6: The flagged MCP server subtitle ('turn off the server to choose tools one by one') is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR. Per-tool approval is not a supported product behavior (whole-server on/off only), so the accurate copy fix belongs with the approvals/save-model cleanup tracked as the follow-up — out of this PR's frozen goal. Maintainer-accepted. |
Human judgment recorded@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override first-principles 596c027: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (catalog conflict resolved). |
|
/ai-review override ux 596c027: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override first-principles c2a6782: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (en.context.json catalog conflict resolved). |
|
/ai-review override ux c2a6782: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
Human judgment recorded@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: UX Review. Re-run the lane's latest workflow run for |
Wire every Edit entry point on the crewmates page straight to CrewEditorNextDialog and retire the classic CrewEditorDialog. CrewEditorModal becomes a thin wrapper that mounts the New dialog directly, so the card pencil, the thread-header identity pill and the team dialog all open New. The capabilities-page edit screen is a follow-up PR. Add the discard-confirm prompt the New dialog was missing (dirty close silently did nothing before), fully extract and translate the editor's strings across 12 locales in the informal register each style guide requires, and move the Tools/MCP/Skills inspectors' keys into the catalog. Delete the classic dialog's test and add a focused CrewEditorNextDialog test suite.
…vals The approvals editor showed an MCP server's allow entry (allowedTools `@server`) and its auto-approved verbs (autoApprove `@server/verb`) as unrelated flat toggles in two sections. Turning the server off emitted a lone `remove @server` while its verbs survived, which the backend rejects with `approval_exclusion_overlaps` (agent_capabilities.py) — surfacing to the user as a single toggle that "failed for no reason". Make the dependency structural: each MCP server is now a collapsible parent row (the server-allow toggle) with its auto-approve verbs as expandable children. Turning a server off cascades — the draft removes `@server` AND every present `@server/verb` in one operations list, so the preview is coherent and never 409s. A verb cannot be auto-approved while its server is off. Built-in tools stay a flat list (no hierarchy). Adds the server-count and server-allow aria strings across all catalogs and a regression test asserting the server-off draft carries the server remove plus every child verb remove.
|
/ai-review override first-principles c82df79: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (locale-catalog conflicts resolved, additions-only). |
|
/ai-review override ux c82df79: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Make the redesigned New crewmate editor the single editing experience on the crewmates (members) page, reached from every Edit entry point there, and retire the classic editor.
The crewmate editor shipped with two implementations: the classic
CrewEditorDialogand the redesignedCrewEditorNextDialog.CrewEditorModalopened the classic editor, so every real entry point on the crewmates page — the card pencil, the thread-header identity pill, the team dialog — mounted the classic dialog. The New editor is the intended end state (sections rail, Built From read-only inspectors, approvals review flow), so the second implementation is now dead weight that also carried a correctness gap (see below).This PR converts the crewmates page only. The matching edit screen on the capabilities page is a follow-up PR — it is deliberately out of scope here.
Why it matters
One editor, reached the same way from everywhere on the crewmates page, is the point of the edit-in-place design (RFC §10, below). Keeping two drifting implementations meant the New editor went unverified in the real flow and the two could diverge. Collapsing to one removes that drift and a real dirty-close bug the classic path masked.
Not a goal
What changed (motivation → approach → change)
Product-shape change (a changed editor on the crewmates page), recorded in
docs/request-for-change/rfc-crewmates-launch.md§10, which isstatus: acceptedon main and states the one-editor decision verbatim: "This decision keeps ONE editor: the modal mounts…". Approach: makeCrewEditorNextDialogthe single editor and delete the classic one so there is nothing to drift.To be precise about scope, this does replace the editor that ships today, not merely retire a dormant duplicate: every real Edit entry point on the crewmates page mounted the classic
CrewEditorDialog, so this PR swaps the live editing surface. Three capabilities the classic modal had are intentionally not carried into the New dialog (see Backwards compatibility for the readers):In-modal editing of a crewmate's tools / MCP servers / skills. The New dialog's "Built From" is read-only by design — it shows what the crewmate is built from, inspectors included, but the place to edit tools/MCP/skills is the capabilities-page edit screen (the follow-up PR noted above). This is a deliberate scope cut, not an omission.
The in-modal Chat button. Dropped from the editor by design; starting a chat with a crewmate stays on its own entry points, not inside the edit modal.
The Triggers field. The New dialog does not expose Triggers; this is an agreed product decision (
docs/decisions/2026-10-16-crewmate-editor-has-no-triggers-field.md). The trigger feature is retained and stays editable on the Agents page.CrewEditorModalis now a thin wrapper that mountsCrewEditorNextDialogdirectly — no branch, no classic import. Every Edit entry point on the crewmates page opens New.Deleted
CrewEditorDialog.tsx(classic dialog) andCrewEditorDialog.test.tsx.Data-loss fixes in the New dialog (flagged by review, all in code this PR adds): the discard-confirm prompt is now rendered (a dirty Cancel/Escape previously set
discardAsk='close'with no UI and silently swallowed the close); child-editor dirty state (approvals + each memory doc) is tracked by a keyed set instead of one shared boolean, so saving one no longer clears another's unsaved-draft guard; the footer Save is gated on crew-level dirt only, so it cannot close and drop an unsaved approvals/memory draft it does not persist; navigation is blocked while a save is in flight or a child/schedule draft is live, so switching sections cannot unmount-and-destroy a dirty panel; andCrewApprovalsEditorload/preview/save errors now render throughErrorNotice(the blockingerrors-use-error-noticerule).Memory section re-ported onto the current
MemoryRecordsEditorAPI (main dropped thefixedKind/hideKindFilterprops): the three pinned record tabs (facts/lessons/experiences) collapse into onememoriestab using the component's own kind filter, matchingMemberMemoryPanel.i18n: the editor's strings (incl. the Tools/MCP/Skills inspector internals and the
toolMetadisplay table) are fully extracted and translated across all 12 catalogs;toolMeta.tsnow holds only ids + classification and resolves labels/descriptions lazily fromcomponents.crew.toolMeta.*."HTTP / SSE"is registered as a do-not-translate protocol identifier inglossary.json.Backwards compatibility
Compatible at the contract layer: no backend, API, or config contract changes — this is a frontend-only editor consolidation; the editor reads and writes the same endpoints it did before. The user-visible reduction is the three intentional removals above (in-modal capability editing, the Chat button, and the Triggers field), which move to / stay on other surfaces.
Reader: anyone who edited a crewmate's tools / MCP / skills from the edit modal — crewmates page — now sees a read-only "Built From" there and edits those on the capabilities-page edit screen instead (intentional; the follow-up PR converts that screen).
Reader: anyone who used the Chat button inside the editor — crewmates page — that button is removed from the modal by design; chat entry points elsewhere are unchanged.
Reader: anyone who edited a crewmate's Triggers from the edit modal — crewmates page — the New dialog has no Triggers field by agreed decision (
docs/decisions/2026-10-16-crewmate-editor-has-no-triggers-field.md); triggers stay editable on the Agents page (KiroCrewAgentsPage→CrewRoutingPane, whereTriggersFieldstill renders), anduseCrewEditorstill owns their load/save/dirty state.Reader:
website/src/pages/members/MembersPage.tsx:CrewEditorModal— crewmates page (card pencil, identity pill, team dialog) — still works; it importsCrewEditorModal, which now mounts the New dialog (MembersPage.test.tsx).Reader:
website/src/components/crew/useCrewEditor.tscontroller — crewmates page — unchanged contract; the New dialog consumes the samediscardAsk/confirmDiscard/dirty state the classic dialog did (CrewEditorNextDialog.test.tsx).Reader: any importer of
CrewEditorDialog— swept on origin/main: onlyMembersPage.tsx(via theCrewEditorModalwrapper) and the deletedCrewEditorDialog.test.tsxreferenced it; no other reader exists.Tests
CrewEditorNextDialog.test.tsx(23 tests) drives the realuseCrewEditorcontroller through the same Host harness the classic test used: section-rail navigation, Built From read-only inspectors (incl. a security assertion that expanding an MCP row shows env/header NAMES only, never secret values), the approvals toggle→review→save path, template-switch +templateSwitchError, two-step delete, and the dirty-close discard prompt that caught the defect.MembersPage.test.tsxeditor mock repointed from the deleted classic path toCrewEditorModal; the "mounts New directly, no classic dialog" guarantee is asserted.i18n:checkpasses all 19 checks againstorigin/main.Manual verification
Captured the New editor via the gateway-free stub harness (
scripts/capture-crew-editor-rail.mjs) in light and dark themes across every pane; overview shots below. Opening the editor from a card on the crewmates page now lands directly in New.Screenshots / video
New Editor















mcp expand:

Old:









Discard:

Delete are you sure?


Switching to different agent config
approval mcp server expand:

memory edit will dim the sidebar until changes are complete

Here we see there is no ability to select individual items to be on inside a mcp server (was not working in original code, disabling that ability to avoid this confusing ux outright). Instead u toggle only the mcp server all on or all off:

Related Issues
N/A — consolidation of in-flight editor work.
Checklist