Skip to content

feat(crew): make the New editor the only crewmate editing experience - #19257

Merged
dodgeblaster merged 2 commits into
mainfrom
feat/crew-editor-next-only
Oct 17, 2026
Merged

dodgeblaster merged 2 commits into
mainfrom
feat/crew-editor-next-only

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the redesigned New crewmate editor the single editing experience on the crewmates (members) page, reached from every Edit entry point there, and retire the classic editor.

The crewmate editor shipped with two implementations: the classic CrewEditorDialog and the redesigned CrewEditorNextDialog. CrewEditorModal opened the classic editor, so every real entry point on the crewmates page — the card pencil, the thread-header identity pill, the team dialog — mounted the classic dialog. The New editor is the intended end state (sections rail, Built From read-only inspectors, approvals review flow), so the second implementation is now dead weight that also carried a correctness gap (see below).

This PR converts the crewmates page only. The matching edit screen on the capabilities page is a follow-up PR — it is deliberately out of scope here.

Why it matters

One editor, reached the same way from everywhere on the crewmates page, is the point of the edit-in-place design (RFC §10, below). Keeping two drifting implementations meant the New editor went unverified in the real flow and the two could diverge. Collapsing to one removes that drift and a real dirty-close bug the classic path masked.

Not a goal

  • Not changing the backend crewmate/roster config contract or any API — this is a frontend editor consolidation.
  • Not converting the capabilities-page edit screen — that is a separate follow-up PR.
  • Not redesigning the crewmate detail page ("HR file" surface); only the in-context edit modal.
  • Not adding new editor capabilities beyond parity with what the New dialog already rendered.

What changed (motivation → approach → change)

Product-shape change (a changed editor on the crewmates page), recorded in docs/request-for-change/rfc-crewmates-launch.md §10, which is status: accepted on main and states the one-editor decision verbatim: "This decision keeps ONE editor: the modal mounts…". Approach: make CrewEditorNextDialog the single editor and delete the classic one so there is nothing to drift.

To be precise about scope, this does replace the editor that ships today, not merely retire a dormant duplicate: every real Edit entry point on the crewmates page mounted the classic CrewEditorDialog, so this PR swaps the live editing surface. Three capabilities the classic modal had are intentionally not carried into the New dialog (see Backwards compatibility for the readers):

  • In-modal editing of a crewmate's tools / MCP servers / skills. The New dialog's "Built From" is read-only by design — it shows what the crewmate is built from, inspectors included, but the place to edit tools/MCP/skills is the capabilities-page edit screen (the follow-up PR noted above). This is a deliberate scope cut, not an omission.

  • The in-modal Chat button. Dropped from the editor by design; starting a chat with a crewmate stays on its own entry points, not inside the edit modal.

  • The Triggers field. The New dialog does not expose Triggers; this is an agreed product decision (docs/decisions/2026-10-16-crewmate-editor-has-no-triggers-field.md). The trigger feature is retained and stays editable on the Agents page.

  • CrewEditorModal is now a thin wrapper that mounts CrewEditorNextDialog directly — no branch, no classic import. Every Edit entry point on the crewmates page opens New.

  • Deleted CrewEditorDialog.tsx (classic dialog) and CrewEditorDialog.test.tsx.

  • Data-loss fixes in the New dialog (flagged by review, all in code this PR adds): the discard-confirm prompt is now rendered (a dirty Cancel/Escape previously set discardAsk='close' with no UI and silently swallowed the close); child-editor dirty state (approvals + each memory doc) is tracked by a keyed set instead of one shared boolean, so saving one no longer clears another's unsaved-draft guard; the footer Save is gated on crew-level dirt only, so it cannot close and drop an unsaved approvals/memory draft it does not persist; navigation is blocked while a save is in flight or a child/schedule draft is live, so switching sections cannot unmount-and-destroy a dirty panel; and CrewApprovalsEditor load/preview/save errors now render through ErrorNotice (the blocking errors-use-error-notice rule).

  • Memory section re-ported onto the current MemoryRecordsEditor API (main dropped the fixedKind/hideKindFilter props): the three pinned record tabs (facts/lessons/experiences) collapse into one memories tab using the component's own kind filter, matching MemberMemoryPanel.

  • i18n: the editor's strings (incl. the Tools/MCP/Skills inspector internals and the toolMeta display table) are fully extracted and translated across all 12 catalogs; toolMeta.ts now holds only ids + classification and resolves labels/descriptions lazily from components.crew.toolMeta.*. "HTTP / SSE" is registered as a do-not-translate protocol identifier in glossary.json.

Backwards compatibility

Compatible at the contract layer: no backend, API, or config contract changes — this is a frontend-only editor consolidation; the editor reads and writes the same endpoints it did before. The user-visible reduction is the three intentional removals above (in-modal capability editing, the Chat button, and the Triggers field), which move to / stay on other surfaces.

Reader: anyone who edited a crewmate's tools / MCP / skills from the edit modal — crewmates page — now sees a read-only "Built From" there and edits those on the capabilities-page edit screen instead (intentional; the follow-up PR converts that screen).
Reader: anyone who used the Chat button inside the editor — crewmates page — that button is removed from the modal by design; chat entry points elsewhere are unchanged.
Reader: anyone who edited a crewmate's Triggers from the edit modal — crewmates page — the New dialog has no Triggers field by agreed decision (docs/decisions/2026-10-16-crewmate-editor-has-no-triggers-field.md); triggers stay editable on the Agents page (KiroCrewAgentsPage → CrewRoutingPane, where TriggersField still renders), and useCrewEditor still owns their load/save/dirty state.
Reader: website/src/pages/members/MembersPage.tsx:CrewEditorModal — crewmates page (card pencil, identity pill, team dialog) — still works; it imports CrewEditorModal, which now mounts the New dialog (MembersPage.test.tsx).
Reader: website/src/components/crew/useCrewEditor.ts controller — crewmates page — unchanged contract; the New dialog consumes the same discardAsk/confirmDiscard/dirty state the classic dialog did (CrewEditorNextDialog.test.tsx).
Reader: any importer of CrewEditorDialog — swept on origin/main: only MembersPage.tsx (via the CrewEditorModal wrapper) and the deleted CrewEditorDialog.test.tsx referenced it; no other reader exists.

Tests

  • New CrewEditorNextDialog.test.tsx (23 tests) drives the real useCrewEditor controller through the same Host harness the classic test used: section-rail navigation, Built From read-only inspectors (incl. a security assertion that expanding an MCP row shows env/header NAMES only, never secret values), the approvals toggle→review→save path, template-switch + templateSwitchError, two-step delete, and the dirty-close discard prompt that caught the defect.
  • MembersPage.test.tsx editor mock repointed from the deleted classic path to CrewEditorModal; the "mounts New directly, no classic dialog" guarantee is asserted.
  • Full run on the rebased base: 287 tests green (CrewEditorNextDialog + MembersPage), tsc + eslint + vite build clean, and i18n:check passes all 19 checks against origin/main.

Manual verification

Captured the New editor via the gateway-free stub harness (scripts/capture-crew-editor-rail.mjs) in light and dark themes across every pane; overview shots below. Opening the editor from a card on the crewmates page now lands directly in New.

Screenshots / video

New Editor
0-discardwarning
1-g1
2-b1
2-b2
2-b3
2-b4
3-a1
3-a2-review
3-a3-widen
4-1
5-1
6-1
6-editing
7-1
7-2confirm

mcp expand:
zzz

Old:
Screenshot 2026-10-11 at 9 10 32 PM
Screenshot 2026-10-11 at 9 10 47 PM
Screenshot 2026-10-11 at 9 10 56 PM
Screenshot 2026-10-11 at 9 11 03 PM
Screenshot 2026-10-11 at 9 11 11 PM
Screenshot 2026-10-11 at 9 11 17 PM
Screenshot 2026-10-11 at 9 11 24 PM
Screenshot 2026-10-11 at 9 11 30 PM
Screenshot 2026-10-11 at 9 11 37 PM

Discard:
s_discard

Delete are you sure?
s_deletesure
Switching to different agent config
switchoff

approval mcp server expand:
s_expand

memory edit will dim the sidebar until changes are complete
s_memorychange

Here we see there is no ability to select individual items to be on inside a mcp server (was not working in original code, disabling that ability to avoid this confusing ux outright). Instead u toggle only the mcp server all on or all off:
s_expand2

Related Issues

N/A — consolidation of in-flight editor work.

Checklist

  • At most two commits (one here), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — RFC §10 already records the one-editor decision; no doc change needed
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of c82df7925973fe60277f8c334d33f88417101d3b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The PR removes Triggers and in-modal tools/MCP/skills editing on the strength of a decision record that does not exist, and it pulls the crewmates modal away from the Agents-page editor.

Watch

  • The decision behind removing Triggers is missing. The description cites docs/decisions/2026-10-16-crewmate-editor-has-no-triggers-field.md as an "agreed product decision". That file is not in docs/decisions/ and the patch does not add it. AGENTS.md lets a recorded behaviour change only through a decision entry a maintainer wrote. As shipped, a field that works today disappears from the only crewmates-page editor with no record that anyone chose that.
    Clears when: a maintainer-written decision entry is on main (or in this PR), or the Triggers field stays in the New dialog.
  • RFC §10's "one editor, nothing to drift" premise no longer holds. §10 names CrewEditorDialog as the editor the modal shares, and says the Agents page must mirror it until the fold-in lands. This PR swaps in a new 1281-line dialog: its Built From is read-only, approvals go through a new CrewApprovalsEditor, and it has no Triggers field. Meanwhile KiroCrewAgentsPage keeps CrewCapabilitiesPane and TriggersField. So the two surfaces now show different sections and use two different UIs for approvals. The description's claim that the New dialog had already "shipped" is also wrong: CrewEditorNextDialog does not exist on base b6e801b6, so this PR introduces it. §10 is not updated in this PR.
    Clears when: §10 is amended in this PR to name CrewEditorNextDialog and record the accepted divergence from KiroCrewAgentsPage until the follow-up lands.

[DESIGN-REVIEWED] c82df79

Description read

[DESCRIPTION-READ] a69936abb32e46a56957a73ec5a0307ed4f27e4701f5bdef265e7cf4b45fe890

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for c82df7925973fe60277f8c334d33f88417101d3b via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for c82df7925973fe60277f8c334d33f88417101d3b via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c82df7925973fe60277f8c334d33f88417101d3b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c82df79

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c82df7925973fe60277f8c334d33f88417101d3b: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c82df7925973fe60277f8c334d33f88417101d3b — this comment is updated in place on each push.

Review details

Not blocking: one advisory finding.

FINDING — website/src/components/crew/CrewApprovalsEditor.tsx:240 — when a server has an @server parent, its tools can't be toggled one at a time. With the server on, the tool rows are read-only (globCovered). With it off, they are disabled={!parentOn}. But the subtitle server_glob_covered tells the user to "turn off the server to choose tools one by one", and the comment at :481 promises the same. A user who follows that instruction gets only disabled switches. → Fix: either let tool rows be toggled while the server is off, or reword server_glob_covered in every locale (and fix the comment) so it no longer promises per-tool control.

[OPUS-REVIEWED] c82df79

Verdict parsed from the review's SHA-scoped output markers for commit c82df7925973fe60277f8c334d33f88417101d3b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c82df7925973fe60277f8c334d33f88417101d3b: <one-sentence reason>

@dodgeblaster dodgeblaster changed the title feat(crew): make the New crewmate editor the only editing experience feat(crew): make the New editor the only crewmate editing experience Oct 12, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/crew-editor-next-only branch from b997f16 to d85e1dd Compare October 12, 2026 04:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@dodgeblaster
dodgeblaster marked this pull request as ready for review October 12, 2026 04:47
@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners October 12, 2026 04:47
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/crew-editor-next-only branch from d85e1dd to 7d1a42c Compare October 12, 2026 05:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/crew-editor-next-only branch from 7d1a42c to 2aa22c3 Compare October 12, 2026 05:25
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 12, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/crew-editor-next-only branch 3 times, most recently from 0dacc2c to 9a8d8c1 Compare October 12, 2026 06:34
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/crew-editor-next-only branch from 9a8d8c1 to eeb44cd Compare October 12, 2026 07:03
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override fable d988614: The Triggers-editing removal from the crewmate editor is a maintainer-approved team decision (confirmed in-thread by the maintainer driving this PR). The feature is retained — useCrewEditor still owns triggers load/save/dirty and TriggersField still renders on the Agents page (KiroCrewAgentsPage → CrewRoutingPane). The prior docs/decisions entry that tripped the maintainer-credit rule has been REMOVED from this PR entirely; the removal is documented via the PR body Reader: line plus this maintainer override, so there is no non-maintainer decision recorded in the tree.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for d988614f7be4366f1e821c416a879ba872a50af9.

Making the modal'''s tools/MCP/skills read-only (edited on the Agents page) and removing the in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision this PR implements. Re-posting for the fresh head after rebase onto main (head d988614).

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: keep the reason to 500 characters or fewer.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles ca9dbd6: Making the modal'''s tools/MCP/skills read-only (edited on the Agents page) and removing the in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision this PR implements. Re-posting for the fresh head after the GPT narrow-viewport toolbar fix.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for ca9dbd6a60a49ae143a214c0ca89482b2fe5fca5.

Making the modal'''s tools/MCP/skills read-only (edited on the Agents page) and removing the in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision this PR implements. Re-posting for the fresh head after the GPT narrow-viewport toolbar fix.

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux ca9dbd6: The flagged MCP server subtitle ('turn off the server to choose tools one by one') is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR. Per-tool approval is not a supported product behavior (whole-server on/off only), so the accurate copy fix belongs with the approvals/save-model cleanup tracked as the follow-up — out of this PR's frozen goal. Maintainer-accepted.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for ca9dbd6a60a49ae143a214c0ca89482b2fe5fca5.

The flagged MCP server subtitle ('turn off the server to choose tools one by one') is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR. Per-tool approval is not a supported product behavior (whole-server on/off only), so the accurate copy fix belongs with the approvals/save-model cleanup tracked as the follow-up — out of this PR's frozen goal. Maintainer-accepted.

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 596c027: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (catalog conflict resolved).

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 596c027: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 596c0271d79909eabb31c063562441ed243c7dcb.

Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (catalog conflict resolved).

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for 596c0271d79909eabb31c063562441ed243c7dcb.

The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles c2a6782: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (en.context.json catalog conflict resolved).

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux c2a6782: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for c2a6782b66e7629b79cd35abfc280cdcb2fad55c.

Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (en.context.json catalog conflict resolved).

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for c2a6782b66e7629b79cd35abfc280cdcb2fad55c manually from the Actions tab.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for c2a6782b66e7629b79cd35abfc280cdcb2fad55c.

The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: UX Review. Re-run the lane's latest workflow run for c2a6782b66e7629b79cd35abfc280cdcb2fad55c manually from the Actions tab.

Wire every Edit entry point on the crewmates page straight to
CrewEditorNextDialog and retire the classic CrewEditorDialog.
CrewEditorModal becomes a thin wrapper that mounts the New dialog
directly, so the card pencil, the thread-header identity pill and the
team dialog all open New. The capabilities-page edit screen is a
follow-up PR.

Add the discard-confirm prompt the New dialog was missing (dirty close
silently did nothing before), fully extract and translate the editor's
strings across 12 locales in the informal register each style guide
requires, and move the Tools/MCP/Skills inspectors' keys into the
catalog. Delete the classic dialog's test and add a focused
CrewEditorNextDialog test suite.
…vals

The approvals editor showed an MCP server's allow entry (allowedTools
`@server`) and its auto-approved verbs (autoApprove `@server/verb`) as
unrelated flat toggles in two sections. Turning the server off emitted a
lone `remove @server` while its verbs survived, which the backend rejects
with `approval_exclusion_overlaps` (agent_capabilities.py) — surfacing to
the user as a single toggle that "failed for no reason".

Make the dependency structural: each MCP server is now a collapsible
parent row (the server-allow toggle) with its auto-approve verbs as
expandable children. Turning a server off cascades — the draft removes
`@server` AND every present `@server/verb` in one operations list, so the
preview is coherent and never 409s. A verb cannot be auto-approved while
its server is off. Built-in tools stay a flat list (no hierarchy).

Adds the server-count and server-allow aria strings across all catalogs
and a regression test asserting the server-off draft carries the server
remove plus every child verb remove.
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles c82df79: Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (locale-catalog conflicts resolved, additions-only).

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux c82df79: The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for c82df7925973fe60277f8c334d33f88417101d3b.

Modal tools/MCP/skills read-only (edited on the Agents page) and the removed in-modal Chat button are team-decided product cuts, maintainer-confirmed; RFC records the one-editor decision. Re-posting after rebase onto fresh main (locale-catalog conflicts resolved, additions-only).

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the ux AI finding as false positive, not applicable, or explicitly accepted for c82df7925973fe60277f8c334d33f88417101d3b.

The flagged MCP server subtitle is a pre-existing copy bug inherited from the prior approvals code, not introduced by this PR; per-tool approval is not a supported behavior (whole-server on/off only), so the accurate copy fix is tracked for the follow-up — out of this PR's frozen goal. Maintainer-accepted. Re-posting after rebase.

This decision applies only to this commit. A new push requires a new judgment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants