Repository navigation
feat(members): phone Crewmates shares the single top bar - #19503
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS One thing to check: while What this change shipsInventory (8 items) — 8 justifiedIntent: on a phone with a crewmate open, the Crewmates page shows one top bar instead of two stacked bars. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] bca20a7 Description read[DESCRIPTION-READ] d8d39463d4fc5b12581bcf304901b4139b99ff79cef48df97ebdc90af2ca34de That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The two mirrored square toggles in the new single bar are indistinguishable, and the bar still looks unlike the Sessions bar it claims to match. Watch
Suggestions
[UX-REVIEWED] bca20a7 Description read[DESCRIPTION-READ] 8918c70642f36f2dfe7bf6222116ce7e6b3ca0cfb65d0ea44603db7247b2fde7 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS If the Crewmates page never mounts, the phone bar is stuck at Watch
[DESIGN-REVIEWED] bca20a7 Description read[DESCRIPTION-READ] 9cb4cfbaea470a7b43d9560e6b797e7606a7260d273cf547efd63624c054d216 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsTwo advisory findings. Neither blocks the merge. FINDING — website/src/pages/members/MembersPage.tsx:391 — FINDING — website/src/App.tsx:1481 — [OPUS-REVIEWED] bca20a7 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
30e0fc7 to
ba24803
Compare
|
|
|
|
|
|
|
|
First Principles asked to check Backend Tests (Windows) (2) on 30e0fc7 failed in |
ba24803 to
5fe634d
Compare
|
|
|
|
|
UX on ba24803 blocked only because no admissible screenshot was found; the attachments are back in the body for 5fe634d. Backend Tests (Windows) (2) is red in |
5fe634d to
c2321b7
Compare
|
|
|
|
Answers to the two PASS punchlines on 5fe634d, both in c2321b7:
|
c2321b7 to
bca20a7
Compare
|
The 1.5 s fallback added in c2321b7 for a slow read on a bare What answers the Design PASS ask instead: while the page reports Tests: |
|
|
|
|
|
Opus's two advisory findings on bca20a7 are real and are deferred on the product owner's (buluoray) decision to land this PR and take the rest as a follow-up:
|
iamwhatever
left a comment
There was a problem hiding this comment.
This PR gives the phone Crewmates page (with a crewmate or team open) the Sessions page's single top bar: the page reports open/pending/roster through a new MobileRosterBarContext, the shell drops its logo row, and the thread header is portalled into #mobile-topbar-slot. That fixes the actual cause of the two stacked bars by reusing the existing mobileSingle mode, not by adding a second layout. I checked the state flow in App.tsx and MembersPage.tsx: the report runs from a layout effect so the shell switches before paint, unmount reports roster, leaving the route resets the state, the slot is looked up only once the page reports open (so a swapped slot is not held stale), a failed ?team= link gives the regular bar back, and the nav-drawer swipe stays on until open. Wide windows and the bare roster page are untouched. Gaps remain and are knowingly deferred by the product owner with dispositions on this head, tracked in #19589: while pending, or when the page throws before its first report, the bar has no visible nav control (the swipe still works); the old header stays over the create flow; and the update pill is missing from this bar. All three are narrow, recoverable UX gaps, not data or safety risks, so they do not block this change. Tests cover each state transition with mutations that turn them red, checks are green, and no change request is open. — crew-pr-reviewer (deep re-check)
Problem / Motivation
Goal: On a phone, the Crewmates page with a crewmate open shows one top bar, the same single bar the Sessions page shows, instead of two stacked bars.
Since #19086 the phone Crewmates page has the Sessions page's drawers: a swipe or the header's drawer toggle opens the rail and the roster. The shell still draws its own logo-and-bell row above the page's header, so a phone shows two bars at the top. The logo row's only job was opening the navigation, which the drawer toggle now does.
Why it matters
Two bars spend about 42px of a phone's height on a row that duplicates a control already on screen, and the page looks unlike the Sessions page it now mirrors.
Not a goal
/membersroster page (no crewmate or team open): it has no drawer, so it keeps the regular bar and its logo.What changed (motivation → approach → change)
The Sessions page already has a single-bar mode on a phone:
mobileSingleinApp.tsxdrops the shell's logo row and leaves#mobile-topbar-slot, which the page fills with its own header. This PR reuses that mode rather than building a second one.components/MobileNavRailContext.ts:MobileRosterBarContext, through which the page reportsopen(a crewmate or team on screen),pending(one still being read) orroster(the bare roster with no one to open, and on unmount, including through its error boundary).App.tsx:mobileSinglecovers a phone/membersvisit while the page reportsopenorpending, and before it has reported, because the page opens its crewmate from an effect and a bar keyed on the URL alone flashed the logo row for the frames before?member=landed.rostergives the regular bar back. The bar does not change under a slow read: until the page reportsopenthe shell's nav-drawer swipe stays on, so the navigation is one swipe away while the read is out. The report wins over the URL, so a?member=link the page cannot open keeps the logo. The shell's nav-drawer swipe stays on until the page reportsopen.MembersPage.tsx: when the slot exists, the thread header (drawer toggle, identity pill, panel toggle) is portalled into it, drops its fade, and the transcript stops padding for a floating header. In the 42px bar the pill drops its vertical padding (26px avatar), so it is as tall as the 32px controls beside it. A?team=link counts as open only while its team resolves or is still being read, so one the teams read failed on asks for the regular bar. The slot is only looked up once the page reportsopen, so after the regular bar has been back it finds the shell's new slot instead of keeping a detached one.website/docs/narrow-viewport.mddescribes the new case.Backwards compatibility
Compatible: only the phone layout of an open crewmate or team changes; URLs, data and the wide layout are untouched.
Removes nothing: the shell's logo row is not rendered on this one phone route, but every control it held is still reachable there (the bell sits in the same bar, the navigation opens from the drawer toggle or a swipe), and the roster page keeps the row.
Tests
MembersPage.test.tsx: the thread header moves into#mobile-topbar-slotwhen the shell renders one.App.mobileSingleTopbar.test.tsx: the single bar while the page reportsopenand before it reports; the single bar kept whilepending; the regular bar forroster, for a?member=link the page cannot open, and when the page is taken down by its error boundary.MembersPage.test.tsx: the thread header moves into#mobile-topbar-slot; the page reportsopenon a landing,rosterfor an empty roster, for a?team=link the teams read failed on, and on unmount; after the empty roster, and after a slot swap during a slow read, the header lands in the shell's new slot, not the old one.openon unmount; looking the slot up while the bare roster shows or whilepending; treatingpendingasroster; treating any?team=as open.tscandeslintclean.Manual verification
On a pod at iPhone 13 size,
/members?member=materenders one 42px bar (pill 31px tall at y 6-36, the toggles 32px at y 5-37, same as the Sessions page title row) holding the drawer toggle, the Mate pill, the panel toggle and the bell; the thread header's parent is#mobile-topbar-slot. The Sessions page in the same pod shows the same bar shape. Sampling every animation frame of a client-side switch from/chatto/members, every frame has the single bar (before this fix, frames 1-4 drew the logo row). Also running on the owner's live gateway.Screenshots / video
Phone (iPhone 13 size),
/members?member=mateon this revision, after:Phone, the Sessions page in the same build, for comparison:
Before this PR, the same page drew the shell's logo-and-bell row above the header row (see the screenshots in #19086).
Related Issues
Follows #19086.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.