Skip to content

feat(members): phone Crewmates shares the single top bar - #19503

Merged
iamwhatever merged 1 commit into
mainfrom
feat/crewmates-phone-single-bar
Oct 13, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/crewmates-phone-single-bar

Conversation

@buluoray

@buluoray buluoray commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a phone, the Crewmates page with a crewmate open shows one top bar, the same single bar the Sessions page shows, instead of two stacked bars.

Since #19086 the phone Crewmates page has the Sessions page's drawers: a swipe or the header's drawer toggle opens the rail and the roster. The shell still draws its own logo-and-bell row above the page's header, so a phone shows two bars at the top. The logo row's only job was opening the navigation, which the drawer toggle now does.

Why it matters

Two bars spend about 42px of a phone's height on a row that duplicates a control already on screen, and the page looks unlike the Sessions page it now mirrors.

Not a goal

  • A Sessions / Crewmates segmented switch in the drawer.
  • Any change on a wide window.
  • The bare /members roster page (no crewmate or team open): it has no drawer, so it keeps the regular bar and its logo.

What changed (motivation → approach → change)

The Sessions page already has a single-bar mode on a phone: mobileSingle in App.tsx drops the shell's logo row and leaves #mobile-topbar-slot, which the page fills with its own header. This PR reuses that mode rather than building a second one.

  • components/MobileNavRailContext.ts: MobileRosterBarContext, through which the page reports open (a crewmate or team on screen), pending (one still being read) or roster (the bare roster with no one to open, and on unmount, including through its error boundary).
  • App.tsx: mobileSingle covers a phone /members visit while the page reports open or pending, and before it has reported, because the page opens its crewmate from an effect and a bar keyed on the URL alone flashed the logo row for the frames before ?member= landed. roster gives the regular bar back. The bar does not change under a slow read: until the page reports open the shell's nav-drawer swipe stays on, so the navigation is one swipe away while the read is out. The report wins over the URL, so a ?member= link the page cannot open keeps the logo. The shell's nav-drawer swipe stays on until the page reports open.
  • MembersPage.tsx: when the slot exists, the thread header (drawer toggle, identity pill, panel toggle) is portalled into it, drops its fade, and the transcript stops padding for a floating header. In the 42px bar the pill drops its vertical padding (26px avatar), so it is as tall as the 32px controls beside it. A ?team= link counts as open only while its team resolves or is still being read, so one the teams read failed on asks for the regular bar. The slot is only looked up once the page reports open, so after the regular bar has been back it finds the shell's new slot instead of keeping a detached one.
  • website/docs/narrow-viewport.md describes the new case.

Backwards compatibility

Compatible: only the phone layout of an open crewmate or team changes; URLs, data and the wide layout are untouched.

Removes nothing: the shell's logo row is not rendered on this one phone route, but every control it held is still reachable there (the bell sits in the same bar, the navigation opens from the drawer toggle or a swipe), and the roster page keeps the row.

Tests

  • MembersPage.test.tsx: the thread header moves into #mobile-topbar-slot when the shell renders one.
  • App.mobileSingleTopbar.test.tsx: the single bar while the page reports open and before it reports; the single bar kept while pending; the regular bar for roster, for a ?member= link the page cannot open, and when the page is taken down by its error boundary.
  • MembersPage.test.tsx: the thread header moves into #mobile-topbar-slot; the page reports open on a landing, roster for an empty roster, for a ?team= link the teams read failed on, and on unmount; after the empty roster, and after a slot swap during a slow read, the header lands in the shell's new slot, not the old one.
  • Mutations, each turning a new test red: letting the URL beat the page report; reporting open on unmount; looking the slot up while the bare roster shows or while pending; treating pending as roster; treating any ?team= as open.
  • 30 frontend test files, 691 tests pass locally (members, shell nav, single-top-bar, chat page suites); tsc and eslint clean.

Manual verification

On a pod at iPhone 13 size, /members?member=mate renders one 42px bar (pill 31px tall at y 6-36, the toggles 32px at y 5-37, same as the Sessions page title row) holding the drawer toggle, the Mate pill, the panel toggle and the bell; the thread header's parent is #mobile-topbar-slot. The Sessions page in the same pod shows the same bar shape. Sampling every animation frame of a client-side switch from /chat to /members, every frame has the single bar (before this fix, frames 1-4 drew the logo row). Also running on the owner's live gateway.

Screenshots / video

Phone (iPhone 13 size), /members?member=mate on this revision, after:

Crewmates single top bar

Phone, the Sessions page in the same build, for comparison:

Sessions single top bar

Before this PR, the same page drew the shell's logo-and-bell row above the header row (see the screenshots in #19086).

Related Issues

Follows #19086.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 12, 2026 18:50
@buluoray
buluoray requested a review from bolichen97 October 12, 2026 18:50
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of bca20a7488945d4ddb61df3e7a1febcec94b8e24 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

One thing to check: while pending (a slow roster read), the single bar's slot is empty, so a swipe is the only way to reach navigation.

What this change ships

Inventory (8 items) — 8 justified

Intent: on a phone with a crewmate open, the Crewmates page shows one top bar instead of two stacked bars. This is an ADDITION.

  1. The shell's logo-and-bell row is no longer drawn on a phone /members page with a crewmate or team open. — justified
  2. The thread header (drawer toggle, identity pill, panel toggle) moves into the shell bar beside the bell. — justified
  3. The bar's fade is gone and the transcript no longer pads below a floating header. — justified
  4. In the bar, the pill has no vertical padding and a 26px avatar. — justified
  5. Every phone /members visit starts on the single bar and keeps it while the page reads, so the logo row no longer flickers in. — justified
  6. The bare roster, a failed ?team= link, a ?member= link the page cannot open, and a page taken down by its error boundary keep the regular bar. — justified
  7. While a crewmate is open, the shell's nav-drawer swipe is off on the phone Crewmates page. — justified
  8. A new page-to-shell report (MobileRosterBarContext: open, pending, roster) with one consumer, MembersPage. Each state is constructed and changes what the shell does. — justified

[FIRST-PRINCIPLES-REVIEWED] bca20a7

Description read

[DESCRIPTION-READ] d8d39463d4fc5b12581bcf304901b4139b99ff79cef48df97ebdc90af2ca34de

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of bca20a7488945d4ddb61df3e7a1febcec94b8e24 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The two mirrored square toggles in the new single bar are indistinguishable, and the bar still looks unlike the Sessions bar it claims to match.

Watch

  • The two toggles can't be told apart. The left toggle (drawer: navigation and roster) and the right toggle (side panel) are mirrored square icons in matching circles. The navigation now opens only from the left one, so a user has to guess which side holds it. The blind reader: "They look almost identical and mirrored, and I can't tell which panel each one opens." They also rated both readings "a guess". Severity: medium, because this is the only on-screen way to reach the navigation and users hit it on every phone visit.
  • The "same bar as Sessions" claim isn't visible in the pixels. shot-01 has round bordered buttons, a centred pill, and the bell squeezed against the panel toggle. shot-02 has borderless icons, a left-aligned title, and the bell followed by "…". The reader: "the top bars and text boxes are laid out differently. Nothing tells me they're the same chat." Severity: low to medium. Users switch between the two pages often, but nothing fails. Smallest fix: give the bell the same gap from the panel toggle that the Sessions bar uses, so the bell isn't crowded on the right.

Suggestions

  • On the drawer toggle in member-thread-header, use a menu or navigation glyph instead of the mirrored panel icon. That makes it distinct from the side-panel toggle, now that it replaces the logo row's job.

[UX-REVIEWED] bca20a7

Description read

[DESCRIPTION-READ] 8918c70642f36f2dfe7bf6222116ce7e6b3ca0cfb65d0ea44603db7247b2fde7

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of bca20a7488945d4ddb61df3e7a1febcec94b8e24 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

If the Crewmates page never mounts, the phone bar is stuck at pending with no logo, so the only way to the navigation is a swipe nobody can see.

Watch

  • The cause is that useState<MobileRosterBarState>('pending') combined with membersSingleBar = onMembersRoute && (… || membersBar === 'pending') treats "the page has not reported yet" as "single bar". The page only reports from layout effects after it mounts. If the lazy route chunk is still loading, fails to load, or the route's error boundary catches a throw during the first render, MembersPage never mounts. Its unmount cleanup, which reports roster, never runs either. The bar then stays topbar-single. Nothing is portalled into its slot, there is no logo button, and the swipe is the only way out. The error-boundary test only covers a crash after mount (members-stub-crash), not one before the first report. The same empty bar shows during a slow api.members read, which the description accepts. App.tsx itself still says "The hamburger stays the discoverable path."
    Clears when: the shell falls back to the regular bar when the route renders a Suspense fallback or error-boundary content without the page having reported. Alternatively, the pending single bar shows a visible nav control. Either way, a test covers a chunk-load or first-render failure.

[DESIGN-REVIEWED] bca20a7

Description read

[DESCRIPTION-READ] 9cb4cfbaea470a7b43d9560e6b797e7606a7260d273cf547efd63624c054d216

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed bca20a7488945d4ddb61df3e7a1febcec94b8e24 — this comment is updated in place on each push.

Review details

Two advisory findings. Neither blocks the merge.

FINDING — website/src/pages/members/MembersPage.tsx:391 — createPortal(threadHeader, topbarSlot) moves the header out of member-main-column, so that column's display: 'none' no longer hides it. To reproduce: on a phone with ?member=alpha open, pick New crewmate from the roster drawer's add menu. openGuided keeps activeName, so rosterBar stays 'open'. The old crewmate's back arrow, identity pill and panel toggle then stay in the shell bar over the guided or advanced create pane, and they act on a thread that is hidden. The bar also has no logo, and the shell swipe is off. → Fix: gate the portal and the 'open' report on the thread being shown (!guided.open && !createOpen), and report 'pending' or 'roster' while a create flow holds the page.

FINDING — website/src/App.tsx:1481 — mobileSingle = isMobile && (isChat || membersSingleBar) drops the tb-right group on the phone Crewmates page. That group holds <UpdatePill />, which the shell comments call "the download's only progress home" and say is "NOT gated on viewport", along with the theme aside. Only ChatPage puts the replacement UpdatePill variant="menu-item" into #mobile-topbar-trail-slot, so on /members with an update pending nothing on the page shows the update or its download progress. → Fix: have MembersPage portal an overflow menu with UpdatePill variant="menu-item" into mobile-topbar-trail-slot, or keep rendering the update pill in the single bar when the host is not the chat page.

[OPUS-REVIEWED] bca20a7

Verdict parsed from the review's SHA-scoped output markers for commit bca20a7488945d4ddb61df3e7a1febcec94b8e24.

False positive or not applicable? A repository writer can comment:
/ai-review override fable bca20a7488945d4ddb61df3e7a1febcec94b8e24: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of bca20a7488945d4ddb61df3e7a1febcec94b8e24 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] bca20a7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt bca20a7488945d4ddb61df3e7a1febcec94b8e24: <one-sentence reason>

@buluoray
buluoray force-pushed the feat/crewmates-phone-single-bar branch from 30e0fc7 to ba24803 Compare October 12, 2026 19:19
@buluoray

Copy link
Copy Markdown
Contributor Author
  • Clear the cached portal target when the bare roster replaces the bar span=e7ac5689c151 (fixed)

Fixed in ba24803. The page now looks the slot up only while it is not showing the bare roster (useShellSlot('mobile-topbar-slot', isMobile && !showsBareRoster)), so once the regular bar has been back it finds the shell's new slot instead of keeping the detached one. Test: finds the shell bar slot again after the bare roster had the regular bar (MembersPage.test.tsx) goes from an empty roster to a crewmate with the slot swapped in between; it fails with the old lookup.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • slot lookup never runs again after the shell swaps the slot span=84c72a0aa725 (fixed)

Fixed in ba24803, the same change as the GPT finding: the lookup is disabled while the bare roster shows and runs again when it stops, so it latches the new slot. Covered by finds the shell bar slot again after the bare roster had the regular bar, which fails without the change.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Navigation goes away by default span=e2b20c8f5b34 (fixed)

Fixed in ba24803. The page now reports a state (open, roster, gone) instead of a boolean, and the shell only keeps the single bar for open, or for the short wait before the page has reported. Unmounting reports gone, so a page taken down by its error boundary gives the regular bar back; a page that never reports (it threw before mounting) gets it after MOBILE_ROSTER_BAR_GRACE_MS (1.5 s); and the shell's nav-drawer swipe stays on until the page reports open. Tests in App.mobileSingleTopbar.test.tsx: gives the regular bar back when the Crewmates page is taken down by its error boundary and gives a bare /members the single bar before the page reports, which also checks the grace fallback. Each fails when its half of the change is reverted.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Turn the context around span=f7901adf8473 (partly adopted)

Partly adopted in ba24803: the page now reports open from a layout effect while a crewmate is open or about to open and gone on unmount, as suggested. The one part kept is the single bar before the first report. A claim-only version was measured on a pod at iPhone 13 size, sampling every animation frame of a client-side switch from /chat to /members: frames 1-3 drew the logo row, because the lazy route commits the page a few frames after the shell. That flash is the bug this PR set out to remove. The grace fallback above covers the case the claim-only design protects against.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The two bars don't match span=92f041663f2a (deferred to the owner)

Not changed here. The pill and the two toggles keep the Crewmates header's own chip styling, and this PR only moves that header into the shell's bar. Restyling them as bare icons would change how the Crewmates header looks, which is a visual call for the owner; it is put to them rather than folded into this PR.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The left toggle is now the only way to reach navigation on this route span=3b77897b15de (kept)

Kept. As the review notes, this is how the Sessions page works too: on a phone its left toggle is also the way to the navigation rail. The toggle is named Toggle crewmates and reports aria-expanded.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • move the bell into the right-hand group span=9e49dd1a721d (deferred to the owner)

Not changed here. The bell is the shell's own control and sits where it does on the Sessions page. Giving it the chip treatment is part of the same styling question as the circled controls, which is put to the owner.

@buluoray

Copy link
Copy Markdown
Contributor Author

First Principles asked to check /members?member=<unknown>. Fixed in ba24803: the page's report now wins over the URL, so a ?member= link the page cannot open keeps the regular bar. Test: keeps the regular bar for a ?member= link the page cannot open, since the page report wins over the URL (App.mobileSingleTopbar.test.tsx), which fails if the URL is allowed to win.

Backend Tests (Windows) (2) on 30e0fc7 failed in test/test_wait_discipline_ratchet.py, which flags test/test_surface_deny_notice_sites.py and test/test_webhook_permission_requests.py. The same test fails on a clean origin/main checkout, and this PR touches no backend file.

@buluoray
buluoray force-pushed the feat/crewmates-phone-single-bar branch from ba24803 to 5fe634d Compare October 12, 2026 19:52
@buluoray

Copy link
Copy Markdown
Contributor Author
  • Keep navigation available when a team link cannot resolve span=e7ac5689c151 (fixed)

Fixed in 5fe634d. A ?team= link now counts as open only while its team resolves or the teams read is still pending (teamOpening), so a link the teams read failed on reports roster and the shell gives the regular bar back. Test: a ?team= link the teams read failed on opens nothing, so it asks for the regular bar (MembersPage.test.tsx), which fails when any ?team= is treated as open.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • a ?team=<id> link opened while the teams read has failed reports 'open' span=84c72a0aa725 (fixed)

Fixed in 5fe634d, the same change as the GPT finding on this span, with the same test.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • one consumer, generalized span=ae5188ce8cac (fixed)

Fixed in 5fe634d: the enum lost 'gone'. The page now reports roster on unmount, which is what the shell already did with gone, and the grace fallback sets roster too. MobileRosterBarState is 'open' | 'roster'.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The reshaped phone top bar has no rendered evidence span=1ea5b8477b41 (fixed)

Fixed: the PR body's screenshots are re-attached as GitHub attachments, captured on 5fe634d at iPhone 13 size on /members?member=mate (the thread header sits inside #mobile-topbar-slot), with the Sessions page from the same build beside it. The earlier body edit had turned them back into local paths.

@buluoray

Copy link
Copy Markdown
Contributor Author

UX on ba24803 blocked only because no admissible screenshot was found; the attachments are back in the body for 5fe634d.

Backend Tests (Windows) (2) is red in test/test_wait_discipline_ratchet.py (test_surface_deny_notice_sites.py, test_webhook_permission_requests.py), the same as on a clean origin/main; this PR touches no backend file.

@buluoray
buluoray force-pushed the feat/crewmates-phone-single-bar branch from 5fe634d to c2321b7 Compare October 12, 2026 20:43
@buluoray

Copy link
Copy Markdown
Contributor Author
  • The two bars don't match span=c1ff1acb85db (deferred to the owner)

Not changed here, the same answer as on the previous heads: the Crewmates controls keep their own chip styling, and this PR only moves that header into the shell's bar. Whether the two bars should share one look is a visual call that has been put to the owner.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The panel toggle now sits right next to the bell span=6bf390a19b02 (kept)

Kept. The panel toggle is the same control the Crewmates header had before this PR, with the same glyph and name, and it opens the same side panel; this PR moves it into the bar, which is what puts it beside the bell. Its icon matches the Sessions page's panel toggle.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • No recording of the bar changing span=f7c837d46908 (kept)

Kept without a recording. The swap is covered by tests rather than video: the single bar before the page reports, the regular bar for the bare roster, after the 1.5 s grace, and when the page is taken down by its error boundary (App.mobileSingleTopbar.test.tsx). On a pod at iPhone 13 size, sampling every animation frame of a client-side switch from /chat to /members showed the single bar on every frame.

@buluoray

Copy link
Copy Markdown
Contributor Author

Answers to the two PASS punchlines on 5fe634d, both in c2321b7:

  • Design, a slow members read on a bare /members: it did leave the single bar with nothing in it, since the header only renders once a crewmate is open. The page now reports pending while it reads, and the shell brings the regular bar back once pending outlasts the 1.5 s grace. The page also looks the bar slot up only once it reports open, so a bar swapped during that wait is not kept. Tests: brings the regular bar back when the page is still reading past the grace (App.mobileSingleTopbar.test.tsx) and looks the shell bar slot up only once a crewmate is open (MembersPage.test.tsx); each fails with its half reverted.
  • First Principles, a /members?member= page that throws before mounting: covered by gives a bare /members the single bar before the page reports, which also waits out the grace and checks the logo row comes back. The shell reads only the page's report, never the URL, so a ?member= route takes the same path.

@buluoray
buluoray force-pushed the feat/crewmates-phone-single-bar branch from c2321b7 to bca20a7 Compare October 12, 2026 21:38
@buluoray

Copy link
Copy Markdown
Contributor Author

The 1.5 s fallback added in c2321b7 for a slow read on a bare /members is removed in bca20a7, at the request of the product owner (buluoray): a bar that switches back to the logo row partway through a load reads as a bug, and one that does so only sometimes reads as inconsistent.

What answers the Design PASS ask instead: while the page reports pending, it has not bound its drawer and does not claim the swipe, and the shell keeps its own nav-drawer swipe on until the page reports open. So the navigation stays one swipe away during a slow read, and the bar keeps one shape from the first frame. A page that threw before mounting takes the same path. A page taken down by its error boundary after mounting still reports roster on unmount and gets the regular bar back.

Tests: keeps the single bar while the page is still reading (App.mobileSingleTopbar.test.tsx) replaces the grace test; it fails if pending is treated as roster.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • the pending single bar has no visible nav control span=2d78d6eb5ac8 (deferred)

Accepted and deferred on the product owner's (buluoray) decision to land this PR and take the rest as a follow-up: tracked as item 3 of #19589, which shows the drawer toggle during pending. A timed fallback to the logo row is not the fix here; it was tried in c2321b7 and removed as looking like a bug (comment 6133090359). Until then the shell's nav-drawer swipe stays on during pending.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The two toggles can't be told apart span=9d173cf3093c (deferred)

Accepted and deferred on the product owner's (buluoray) decision to land this PR and take the rest as a follow-up: item 4 of #19589 replaces the left toggle with the Sessions page's drawer toggle.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The "same bar as Sessions" claim isn't visible in the pixels span=b5d35432431d (deferred)

Same answer as on earlier heads: the circled chip styling is a visual call for the owner, now tracked as item 4 of #19589.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • use a menu or navigation glyph on the drawer toggle span=92f42d8a6fa5 (deferred)

Accepted and deferred on the product owner's (buluoray) decision to land this PR and take the rest as a follow-up: item 4 of #19589.

@buluoray

Copy link
Copy Markdown
Contributor Author

Opus's two advisory findings on bca20a7 are real and are deferred on the product owner's (buluoray) decision to land this PR and take the rest as a follow-up:

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR gives the phone Crewmates page (with a crewmate or team open) the Sessions page's single top bar: the page reports open/pending/roster through a new MobileRosterBarContext, the shell drops its logo row, and the thread header is portalled into #mobile-topbar-slot. That fixes the actual cause of the two stacked bars by reusing the existing mobileSingle mode, not by adding a second layout. I checked the state flow in App.tsx and MembersPage.tsx: the report runs from a layout effect so the shell switches before paint, unmount reports roster, leaving the route resets the state, the slot is looked up only once the page reports open (so a swapped slot is not held stale), a failed ?team= link gives the regular bar back, and the nav-drawer swipe stays on until open. Wide windows and the bare roster page are untouched. Gaps remain and are knowingly deferred by the product owner with dispositions on this head, tracked in #19589: while pending, or when the page throws before its first report, the bar has no visible nav control (the swipe still works); the old header stays over the create flow; and the update pill is missing from this bar. All three are narrow, recoverable UX gaps, not data or safety risks, so they do not block this change. Tests cover each state transition with mutations that turn them red, checks are green, and no change request is open. — crew-pr-reviewer (deep re-check)

@iamwhatever
iamwhatever enabled auto-merge (squash) October 13, 2026 00:01
@iamwhatever
iamwhatever merged commit d710afd into main Oct 13, 2026
102 checks passed
@iamwhatever
iamwhatever deleted the feat/crewmates-phone-single-bar branch October 13, 2026 00:01
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants