Skip to content

feat: add gitlab ci failure alerts and ci runs to issue radar - #19824

Open
shane-ong wants to merge 2 commits into
kirodotdev:mainfrom
shane-ong:feat/issue-radar-gitlab-pipeline-tab
Open

shane-ong wants to merge 2 commits into
kirodotdev:mainfrom
shane-ong:feat/issue-radar-gitlab-pipeline-tab

Conversation

@shane-ong

@shane-ong shane-ong commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Third PR in the GitLab Issue Radar series, after #17525 (Graph tab) and #19820 (crews on GitLab), both merged.

Problem / Motivation

Goal: Give a GitLab repo the same CI signal a GitHub repo gets in Issue Radar: a notification when CI fails on one of your own merge requests, and its recent pipelines on the CI Runs page.

Today the background CI watch filters every non-GitHub repo out before it looks at anything, and /ci-runs lists GitHub repos only. A team on self-managed GitLab never hears when CI fails on one of their own merge requests, even with the alert turned on, and the CI Runs page shows nothing for their project.

Why it matters

With #17525 and #19820, GitLab repos get the dependency graph and working crews. CI is the last Issue Radar signal still hard-wired to GitHub, so a GitLab team's only CI news is the forge's own email.

Not a goal

  • The Pipeline tab for GitLab: it renders files an operator's triage job writes, and no job writes GitLab ones yet, so it stays GitHub-only.
  • Azure DevOps: no CI watch, no CI Runs rows.
  • Any change to the host allowlist, the glab transport, or the token scope.

What changed (motivation → approach → change)

Surface Before After
ci_watch.py key.provider == GITHUB filter Dispatches by provider; GitLab lists the viewer's open MRs via the existing search_pulls, then their pipelines, one GET /user per host per cycle
/ci-runs (http_routes/ci_runs.py) GitHub repos only GitHub and GitLab repos (CI_RUNS_PROVIDERS), each through its own provider client; a GitLab setup failure answers glab_setup
gitlab_client_ci.py (new) n/a list_recent_workflow_runs: one page of projects/:id/pipelines in the GitHub row shape, with GitHub's row bounds; running/canceling read as in_progress; an MR pipeline carries its MR number from its ref
gitlab_normalization.py failed pipeline → conclusion failed → failure, GitHub's spelling, which every consumer already compares against
Repo settings CI-alert toggle hidden for GitLab Shown for GitHub and GitLab, each with its own whole translated sentence ("merge requests", "GitLab pipeline runs", glab)
CI Runs page GitHub wording, bare owner/repo headers Forge's own terms per repo (!N, glab), the forge mark and self-managed host beside each repo, run links through safeHttpUrl; strings in the 12 locale catalogs + en.manual.json

The watch filters by author_username and re-checks each row's author against GET /user and its head SHA's format, mirroring the GitHub viewer filter; a list past the search cap keeps the tracked heads, as on GitHub. Every request is a GET through the existing glab transport with the host re-verified at spawn; nothing is written to the forge and no prose leaves the host.

The normalizer change is the one behaviour fix outside the GitLab-only paths: a failed GitLab pipeline used to come back as failed, which the watch (and the PR pane's retry tooltip) never matched, so the GitLab alert could not fire. One spelling, one place, pinned by a test that runs the real normalizer output through the watch.

Spec: docs/system-specs/modules/issue-radar.md gains "CI-failure alerts by forge", a "CI Runs page by forge" section and a GET /ci-runs route row. The ProviderClient protocol gains list_recent_workflow_runs; the Azure client refuses it and the route never calls it there.

Backwards compatibility

Compatible: the GitHub CI-watch group key, state file and /ci-runs row shape are unchanged, and ci-watch-state.json written by the old code still loads. The GitLab conclusion rename only affects GitLab rows, which no consumer matched before. Three CI Runs i18n keys are renamed in the same component; nothing else referenced them.

Tests

  • issue_radar/tests/test_ci_watch.py: own MR rows read, a teammate's row and a bad SHA dropped, a cut-off list keeps tracked heads, an unlisted host fails safely, provider dispatch, GitHub key byte-identical to before, a REAL _norm_pipeline_run({"status":"failed"}) row produces one note, one /user per host, unreadable login skips only that host.
  • issue_radar/tests/test_ci_runs.py (new): GitLab rows in the GitHub row shape, status and conclusion in GitHub's vocabulary, bounds clipped, endpoint and params, unlisted host refused before any call, the route lists a GitLab repo and excludes Azure, one repo's glab failure is an error row that leaves the others.
  • RepoSettings.test.tsx (new): toggle shown for GitHub and GitLab in forge wording, hidden for Azure. CiRunsView.test.tsx: a GitLab row uses !N and glab; a same-slug GitHub and GitLab repo get different marks and only the self-managed one a host; a javascript: run link renders no link; GitHub unchanged.
  • Mutation checks, one at a time: GitHub-only dispatch back → 5 fail; /ci-runs back to GitHub-only → 2 fail; failed→failure or running→in_progress dropped → a test fails each; !N back to #N → 1 fails; safeHttpUrl or the host tag removed → 1 fails each; toggle gate back to GitHub-only → 1 fails; author or SHA check removed → 1 fails each.

Backend: 3,178 Issue Radar and routes-facade tests pass. Frontend: 2,837 Issue Radar and i18n vitest pass, tsc clean. isort, flake8, mypy, black and the line-cap gate pass.

Manual verification

Ran a throwaway standalone gateway on this head with offline fake gh and glab CLIs: /ci-runs answers 200 with a GitHub fixture repo and a GitLab fixture repo, and the GitLab rows come back already mapped (in_progress, !17), so the real route, client and normalizer ran. Earlier, the watch and toggle were run against a real self-managed GitLab 19.3.3 EE project. Screenshots use fixture names.

Screenshots / video

Committed under temp-screenshots/issue-radar-gitlab-pipeline/ (fork PR, --attach is not available to me):

CI Runs page with a GitHub repo and a GitLab repo, GitLab rows showing pipelines and !N merge request refs

GitLab repo settings with the CI-failure alert toggle in merge-request wording

CI Runs: error, empty, none connected, cut-off list

A GitLab repo whose read failed, naming glab, with Ask the agent

A GitLab repo with no pipelines yet

No GitHub or GitLab repository connected

More repos connected than the page lists

Related Issues

no linked issue: third PR of the GitLab Issue Radar series (#17525, #19820), not a standalone issue.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 13, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from 9b87c5d to 6397772 Compare October 13, 2026 17:41
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 13, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 16, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from 6397772 to 3908277 Compare October 20, 2026 19:43
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from 3908277 to 05e037c Compare October 21, 2026 11:16
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch 8 times, most recently from f0e0c43 to b2d556a Compare October 23, 2026 06:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from b2d556a to bedbdd7 Compare October 23, 2026 07:26
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@shane-ong
shane-ong force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from bedbdd7 to fbd22e5 Compare October 23, 2026 14:56
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 27, 2026
@shane-ong
shane-ong requested a review from a team as a code owner November 6, 2026 14:05
@shane-ong
shane-ong requested a review from Zedmor November 6, 2026 14:05
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 16095fd13adadd92def08245501082c0ee86caf1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the GitLab CI watch and the CI Runs page reuse the existing provider seams, and the one shared-vocabulary fix (failed → failure) has no reader that compared against the old spelling.

Notes

[DESIGN-REVIEWED] 16095fd

Description read

[DESCRIPTION-READ] 1219be5181024b7d46346a5f7c064a67fdfe2d9764887cfe2872efb320df669e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 16095fd13adadd92def08245501082c0ee86caf1 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The normalizer fix is a one-line change in the one place GitLab's spelling is set, and Azure already maps failed → failure the same way. The Azure refusal stub is required by TestClientParity.

What this change ships

Inventory (10 items) — 8 justified

Intent: a GitLab team gets an alert when CI fails on their own MR, and sees their pipelines on CI Runs. This is an ADDITION.

  1. GitLab repos that opt in get a notification when CI fails on the user's own MR (!N, provider and host in the note meta) — justified
  2. The CI Runs page lists GitLab projects' recent pipelines — justified
  3. The CI-failure toggle now shows on GitLab repo settings, in merge-request wording — justified
  4. A failed GitLab pipeline now reads as failure, so the PR pane retry and the watch both match it — justified
  5. Each CI Runs block shows its forge mark, and the host for a self-managed instance — justified
  6. GitLab wording on the CI Runs page (!N, "No pipelines yet.", glab in the error) — justified
  7. CI Runs page copy reworded to cover both forges (three i18n keys renamed) — justified
  8. A run link that isn't http(s) shows as plain text — rides along
  9. A reported run that is running again keeps its record entry, on GitHub as well — undeclared
  10. The Azure client refuses the recent-runs read — justified

[FIRST-PRINCIPLES-REVIEWED] 16095fd

Description read

[DESCRIPTION-READ] bd49fde7e17a5698b34a4383330324a6f10f12a32497a2376ed8f7a0d8ae403b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 16095fd13adadd92def08245501082c0ee86caf1 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 16095fd

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 16095fd13adadd92def08245501082c0ee86caf1 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 16095fd

@iamwhatever
iamwhatever force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from 1bc3f56 to aae8624 Compare November 14, 2026 08:43
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 14% chance that this change introduces a defect, above the 12% limit for approving on its own.

Recommend approving: nothing blocks the merge. The PR extends the CI-failure watch and the /ci-runs page to GitLab through the existing provider client layer.

  • Normalizer rename (failed → failure): only two places read these rows, the watch and the PR pane's run list. The PR pane's Retry already compared against 'failure', so it now works for GitLab; its failed_only flag does nothing on GitLab, and rerunnable is computed from the raw status, so neither is affected.
  • Watch state: the in-memory tags now include provider and host, and the GitHub paths (search error, cut-off list, pruning) are updated consistently. The GitHub notification grouping key is the same string as before. The saved record uses the same provider-scoped location that the settings write resets.
  • GitLab MR search: it uses the existing search_pulls author filter, and the rows have the author, number and head_sha fields the watch needs. Asking for one row past the cap correctly detects a cut-off list.
  • Host allowlist: an unlisted host is refused before the MR listing and again by the glab transport. Every call is a read, and Azure is excluded in both the watch and the route.
  • GitHub behaviour change: a reported

Tier: 2, held for a person: changes requested.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 16095fd13a · 1537 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
A GitLab repo in Issue Radar got no CI signal: the CI-failure watch
filtered every non-GitHub repo out, and the CI Runs page listed GitHub
repos only.

The CI-failure watch now dispatches by provider. GitLab projects are
listed through the existing gitlab_client.search_pulls (state=open,
author_username=<viewer>, host checked against the allowlist first),
each row re-checked for author, number and head SHA, a list past
PR_SEARCH_MAX keeping the tracked heads, and their head pipelines read
with list_pr_workflow_runs, whose "failed" status is now normalized to
the shared "failure" conclusion the watch and the PR pane's run actions
test for. The signed-in user is read once per host per cycle. In-memory
tags and GitLab group keys carry provider and host so a same-slug project
never shares memory or a notification thread with a GitHub repo; notes
spell an MR ref with "!". The settings toggle is shown for GitHub and
GitLab in the forge's own words.

/ci-runs lists GitHub and GitLab repos (CI_RUNS_PROVIDERS) through each
provider client. gitlab_client_ci.list_recent_workflow_runs reads one
page of projects/:id/pipelines into the GitHub row shape, reusing the
pipeline normalizer and GitHub's row bounds; a merge-request pipeline
carries its MR number from its ref. The page uses the forge's terms
(!N, glab) and a glab_setup error code. Azure DevOps stays excluded from
both.
@iamwhatever
iamwhatever force-pushed the feat/issue-radar-gitlab-pipeline-tab branch from aae8624 to 8ed091d Compare November 14, 2026 11:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 16095fd13adadd92def08245501082c0ee86caf1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the GitLab CI-failure notification. It is the first half of the PR's stated goal, and no screenshot shows it. All six committed screenshots show the settings toggle and the CI Runs page; none shows the alert itself.

Evidence gaps

  • The GitLab CI-failure notification (ci_watch.push_ci_failure: title CI failed · kirodotdev/KiroCrew!{N}, body {listed} failed on {pr_title}, as it appears in the bell or notification panel). This is new text a user sees, and the alert is what the toggle in attachment-01 promises. To close the gap, commit a screenshot under temp-screenshots/ of one GitLab alert in the notification list, next to an existing GitHub alert so the !N and #N spellings can be compared.

Notes

  • This lane had no blind first read. The screenshots do show the toggle copy, forge marks, host tags, !N, the glab error, and the empty, none-connected and cut-off states. Nobody new to the product has read them yet, so whether those labels are clear is still unknown, not confirmed.
  • Attachment-01 shows the GitLab toggle switched off only. The switched-on state reuses the existing SettingToggle, so that part is low-risk.

[UX-REVIEWED] 16095fd

Description read

[DESCRIPTION-READ] 4962c71ad403c0680222f9680ffad7750bafd2ceb57107f64ed8ab3d37af5b38

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Review result on this head: no blocking findings. The checks covered these points:

  • The GitHub note group key keeps its ci-failure:owner/repo#N spelling.
  • The GitLab own-MR path checks the host allowlist before listing and re-checks each row's author against the login.
  • A listing over the cap skips the project.
  • Every failure branch keeps the tracked heads.
  • The failed to failure conclusion fix matches its only frontend consumer, the re-run tooltip.
  • New glab calls run off the event loop.
  • New i18n keys are in every locale file.
  • test_ci_watch.py and test_ci_runs.py pass on this head.

One thing done well: a watch test feeds the real _norm_pipeline_run output into FAILED_CONCLUSIONS, so a change in the wording on either side fails in one place.

Optional:

  • The body says the GitHub group key stays byte-identical, but no test checks this. If _note_scope returns the provider/host tag for GitHub too, every test still passes. One group_key == "ci-failure:o/r#7" assertion in an existing GitHub alert test would cover it.
  • feat(apps): pin issue-radar and auto-improvement for adoption #36446 pins issue-radar to an external app repository. If it merges first, this wheel-copy change needs an App repo: line and a matching change in that repository. A maintainer can pick the merge order.
  • The branch in ci_watch.py (around line 365) keeps a reported run in the record while it runs again. Because of that, a GitLab Retry that fails again is not announced, but GitHub announces a failed re-run. The spec presents this as a GitLab API limit. Either remove the branch to match GitHub, or say in the spec that the code makes this choice.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I read the whole diff on this head, and all checks are green. Most of it is good to keep:

  • The CI Runs page and the CI-failure watch now cover GitLab through the existing glab transport. The calls are GETs only, the host is checked against the allowlist before the listing and again at the spawn, and nothing is written to the forge. A failing project or host is skipped for the cycle without touching the other forge.
  • _own_mr_rows re-checks the author against the signed-in login, so a teammate's MR never reaches the watch. Titles and URLs use the GitHub caps.
  • The settled and failed-run tags now carry provider and host, so a same-slug GitHub repo and GitLab project never share memory. GitHub notes keep their old group_key, so existing threads still stack.
  • _PIPELINE_CONCLUSION now maps failed to failure. I checked main: nothing in the app compares a GitLab conclusion to failed, and every shared consumer tests for failure, so this only makes the PR pane's run list agree with them.
  • The Azure list_recent_workflow_runs refusal is never reached, because the route lists GitHub and GitLab repos only. The run link now goes through safeHttpUrl.

I am requesting changes on one point: a new regex in product code. gitlab_client_ci.py adds _MR_REF_RE = re.compile(r"^refs/merge-requests/([1-9][0-9]{0,9})/(?:head|merge|train)$"). Product code takes no new regex here. Plain string checks do the same job:

_MR_REF_PREFIX = "refs/merge-requests/"
_MR_REF_SUFFIXES = ("head", "merge", "train")

def _mr_iid(ref: str) -> int | None:
    if not ref.startswith(_MR_REF_PREFIX):
        return None
    iid, sep, tail = ref[len(_MR_REF_PREFIX):].partition("/")
    if not sep or tail not in _MR_REF_SUFFIXES:
        return None
    if not (iid.isascii() and iid.isdigit()) or len(iid) > 10 or iid[0] == "0":
        return None
    return int(iid)

Then import re can go. The reuse of the existing gitlab_client._SHA_RE is fine, since it is not new. Everything else can stay as it is, and I will approve once the regex is gone.

Addresses the review on kirodotdev#19824: the MR ref is parsed with plain prefix,
partition and digit checks, and import re goes. A test pins the refs the
old pattern accepted and rejected.
@iamwhatever

Copy link
Copy Markdown
Contributor

@bolichen97 thanks for the review. Done in 16095fd: _MR_REF_RE is gone and import re with it. gitlab_client_ci._mr_iid now reads the iid with the prefix, partition and digit checks you suggested. A new test, test_only_a_well_formed_mr_ref_names_an_mr, pins the refs the old pattern took (/head, /merge, /train, up to 10 digits) and the ones it refused (a leading zero, 11 digits, another suffix, no suffix, an extra segment, an empty iid, non-ASCII digits, a prefix not at the start). Nothing else changed. cc @shane-ong

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the careful GitLab work. Two things block this head.

  1. issue_radar/backend/ci_watch.py:1 (and the other 12 non-test files under the issue-radar wheel copy, backend and website/src/apps/issue-radar/). Since #36446, apps/adoption-pins.json on main (line 70) pins issue-radar to its app repository, kirocrew-app-issue-radar under the KiroCrewCaptain account, at commit 8e57db85. A host that adopts the app runs that pinned tree and not this wheel copy. So those users get neither the GitLab CI alert nor the GitLab rows on CI Runs, and the wheel copy drifts from the pinned app. The body has no App repo: line. PR Hygiene passed only because this PR's base commit (6a61c84) is from before the pin. Fix: port the change to the app repository first, or open a PR there. Then add App repo: <owner>/<repo>@<sha> (or #<pr>) to the body and rebase onto current main, so the check runs against the pin.
  2. issue_radar/backend/ci_watch.py:504. The first half of the Goal is the alert itself (title CI failed · owner/repo!N and its body), and no committed screenshot shows it. The six PNGs under temp-screenshots/issue-radar-gitlab-pipeline/ show only the settings toggle and CI Runs states. The UX lane reported that it could not evaluate the notification. Fix: commit one screenshot of a GitLab CI-failure note in the notification list, next to a GitHub one (!N beside #N), then re-run the UX lane on the new head.

Once both are fixed, a maintainer still needs to sign off the design, because this changes a shipped experience.

Optional:

  • The Tests section says a test keeps the GitHub group key byte-identical, but no test asserts it. Changing _note_scope (ci_watch.py:318) to tag GitHub keys too leaves every test green. Add self.assertEqual(note["group_key"], "ci-failure:o/r#7") to test_failed_run_on_own_pr_notifies_once, or drop the claim.
  • The lines that keep tracked heads after a failed GitHub search (ci_watch.py:154) or an unreadable GitLab login (:196) are not pinned. Seeding a settled head first and asserting it survives the failing cycle would cover them. The same goes for the exact-cap case at :212.
  • The branch that keeps a reported run while it runs again (ci_watch.py:363-369) also runs for GitHub. Please say in the spec row and the body that keeping the entry is a deliberate choice, so the maintainer can weigh the "GitLab Retry that fails again is not announced" tradeoff.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants