Skip to content

fix(issue-radar): keep focus on the remaining refresh and retry buttons while busy - #31687

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/radar-refresh-rest
Nov 7, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/radar-refresh-rest

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Keyboard focus stays on Issue Radar's other refresh and retry buttons while their fetch runs.

Seven Issue Radar buttons set the native disabled attribute on themselves while their refresh or fetch runs. A disabled button leaves the tab order, so a keyboard press drops focus to the page until the fetch ends, and it never comes back.

Why it matters

A keyboard or screen-reader user loses their place each time they refresh the PR list, the dependency graph, the pipeline or a group's reviews, or retry a failed graph or pipeline load.

Not a goal

What changed (motivation → approach → change)

Symptom: focus falls to the page on a keyboard refresh or retry. Cause: disabled={busy} takes the focused button out of the tab order. Change: the same inert-but-focusable shape as #31481 (the Refresh issues buttons) and #31360: aria-disabled={busy || undefined}, aria-disabled: classes in place of the disabled: ones, and a guard at the start of each click handler (if (!busy) …), so a press while busy still does nothing, as the native disabled did.

Sites:

  • components/PrList.tsx: Refresh pull requests (pullsRefreshing)
  • views/GraphView.tsx: header Refresh dependency data (depsQuery.isFetching), and the two RETRY buttons in the unavailable and error states (refreshing)
  • pipeline/views/PipelineView.tsx: header Refresh the pipeline, and the load-error Retry (fabricQuery.isFetching)
  • views/GroupReviewsView.tsx: Refresh (reviews.isFetching)

Backwards compatibility

Compatible: every button, name and fetch is unchanged; a press while busy is still ignored, now by the click guard.

Removes nothing: no route, key or behaviour is taken away.

Tests

  • IssueRadarPrListCoverage.test.tsx, pipeline/views/PipelineView.render.test.tsx, views/GraphView.cov80.test.tsx: each gains a case where focus stays on Refresh while busy, a press while busy sends no second fetch, and focus is still there after it ends. The two existing busy cases now assert aria-disabled instead of disabled.

All five fail on main (run in a separate worktree) and pass here.

Proof: not provable -- frontend test (prove.py runs Python only)

vitest run src/apps/issue-radar: 1644 passed. tsc -p tsconfig.app.json and eslint: clean. Local GPT 5.6 Sol and Opus 5.5 reviews: no findings.

Manual verification

N/A — unit coverage sufficient: the tests drive the mounted views.

Screenshots / video

Why no screenshot: nothing on screen changes; only whether keyboard focus stays on the button.

Related Issues

Part of #31618

Sibling sweep

Swept: git grep -niE "disabled={[^}]*(refreshing|isfetching)" -- website/src/apps/issue-radar (run on origin/main)
Sibling: website/src/apps/issue-radar/components/PrList.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/GraphView.tsx -- changed here
Sibling: website/src/apps/issue-radar/pipeline/views/PipelineView.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/GroupReviewsView.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/CiRunsView.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/components/IssueDetail.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/components/PrDetail.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/views/OverviewView.tsx -- tracked in #31481
Sibling: website/src/apps/issue-radar/components/IssueList.tsx -- tracked in #31481

Pattern harvest

Rule candidate: none
Pattern: a busy button that sets native disabled on itself while focused.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 19:13
@RohanK6
RohanK6 requested a review from Zedmor November 6, 2026 19:13
@RohanK6
RohanK6 enabled auto-merge (squash) November 6, 2026 19:13
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. Each button keeps its label, icon, spinner and dimmed look while busy, so no screenshot is required. The one change on screen is the cursor while busy: the not-allowed cursor becomes the default arrow on the two pipeline buttons.

[UX-REVIEWED] 48ca8fc

Description read

[DESCRIPTION-READ] 030d0dd18dbf91d875a6b845c48e6bf16279036b9dfcfa19656bc4c4aac8168a

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: each of the seven buttons gets the same fix at its cause (native disabled removes the focused button from the tab order). The remaining siblings are named and deferred to #31618/#31481.

What this change ships

Inventory (8 items) — 7 justified

Intent: keyboard and screen-reader users keep focus on Issue Radar's refresh and retry buttons while a fetch runs. This is a FIX.

  1. Refresh pull requests keeps focus while refreshing, and a press while busy is ignored — justified
  2. Graph header Refresh dependency data keeps focus while fetching — justified
  3. Graph failure-state RETRY keeps focus while refreshing — justified
  4. Graph empty/unavailable-state RETRY keeps focus while refreshing — justified
  5. Pipeline header Refresh keeps focus while the read runs — justified
  6. Pipeline load-error Retry keeps focus while fetching — justified
  7. Group reviews Refresh keeps focus while fetching — justified
  8. Busy buttons show a default cursor, and Pipeline's header/Retry fade to 30% while busy — undeclared, rides along

[FIRST-PRINCIPLES-REVIEWED] 48ca8fc

Description read

[DESCRIPTION-READ] 38c87c90a5534e39bff7e1bee292d9d7075cb65b6183d5cf83b3f7d160e26d09

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This applies the inert-but-focusable pattern already used in #31481 and #31360 to the busy refresh and retry buttons. Issue Radar is not in adoption-pins.json, so fixing it in core is allowed.

Notes

  • IconButton and Btn probably had their own disabled: styling. The new aria-disabled:opacity-30 classes may look a little different from the old busy look on the pipeline header and the Retry button. Check the two side by side before merging.

[DESIGN-REVIEWED] 48ca8fc

Description read

[DESCRIPTION-READ] 014db291e388c3d4b0a68fc5eb30479eb2b1faf68d21bfcdaf5e6c03c93f900e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 48ca8fc

Verdict parsed from the review's SHA-scoped output markers for commit 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 48ca8fc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 48ca8fc28c2bd526e04decbe2dcd6b6de938a39f false-positive: <reason, 20 to 500 characters>

@RohanK6
RohanK6 force-pushed the crew/conductor/radar-refresh-rest branch from bfa5ecd to 5dd94e5 Compare November 6, 2026 20:08
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/radar-refresh-rest branch from 5dd94e5 to 48ca8fc Compare November 6, 2026 22:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: issue radar refresh and retry buttons use aria-disabled plus a click guard instead of native disabled, so keyboard focus stays; tests cover focus and the ignored second press.

@RohanK6
RohanK6 merged commit cd168b4 into main Nov 7, 2026
97 of 104 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/radar-refresh-rest branch November 7, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants