Repository navigation
fix(issue-radar): keep focus on the remaining refresh and retry buttons while busy - #31687
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. Each button keeps its label, icon, spinner and dimmed look while busy, so no screenshot is required. The one change on screen is the cursor while busy: the not-allowed cursor becomes the default arrow on the two pipeline buttons. [UX-REVIEWED] 48ca8fc Description read[DESCRIPTION-READ] 030d0dd18dbf91d875a6b845c48e6bf16279036b9dfcfa19656bc4c4aac8168a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: each of the seven buttons gets the same fix at its cause (native What this change shipsInventory (8 items) — 7 justifiedIntent: keyboard and screen-reader users keep focus on Issue Radar's refresh and retry buttons while a fetch runs. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 48ca8fc Description read[DESCRIPTION-READ] 38c87c90a5534e39bff7e1bee292d9d7075cb65b6183d5cf83b3f7d160e26d09 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This applies the inert-but-focusable pattern already used in #31481 and #31360 to the busy refresh and retry buttons. Issue Radar is not in Notes
[DESIGN-REVIEWED] 48ca8fc Description read[DESCRIPTION-READ] 014db291e388c3d4b0a68fc5eb30479eb2b1faf68d21bfcdaf5e6c03c93f900e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bfa5ecd to
5dd94e5
Compare
5dd94e5 to
48ca8fc
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: issue radar refresh and retry buttons use aria-disabled plus a click guard instead of native disabled, so keyboard focus stays; tests cover focus and the ignored second press.
Problem / Motivation
Goal: Keyboard focus stays on Issue Radar's other refresh and retry buttons while their fetch runs.
Seven Issue Radar buttons set the native
disabledattribute on themselves while their refresh or fetch runs. A disabled button leaves the tab order, so a keyboard press drops focus to the page until the fetch ends, and it never comes back.Why it matters
A keyboard or screen-reader user loses their place each time they refresh the PR list, the dependency graph, the pipeline or a group's reviews, or retry a failed graph or pipeline load.
Not a goal
views/CiRunsView.tsx:34: left alone because open feat: add gitlab ci failure alerts and ci runs to issue radar #19824 rewrites the lines around it. Deferred: Issue Radar: remaining refresh controls drop keyboard focus while busy #31618IssueDetail/PrDetailRefresh menu items: picking one closes the menu and focus returns to its trigger, so no focus is dropped. Deferred: Issue Radar: remaining refresh controls drop keyboard focus while busy #31618What changed (motivation → approach → change)
Symptom: focus falls to the page on a keyboard refresh or retry. Cause:
disabled={busy}takes the focused button out of the tab order. Change: the same inert-but-focusable shape as #31481 (the Refresh issues buttons) and #31360:aria-disabled={busy || undefined},aria-disabled:classes in place of thedisabled:ones, and a guard at the start of each click handler (if (!busy) …), so a press while busy still does nothing, as the nativedisableddid.Sites:
components/PrList.tsx: Refresh pull requests (pullsRefreshing)views/GraphView.tsx: header Refresh dependency data (depsQuery.isFetching), and the two RETRY buttons in the unavailable and error states (refreshing)pipeline/views/PipelineView.tsx: header Refresh the pipeline, and the load-error Retry (fabricQuery.isFetching)views/GroupReviewsView.tsx: Refresh (reviews.isFetching)Backwards compatibility
Compatible: every button, name and fetch is unchanged; a press while busy is still ignored, now by the click guard.
Removes nothing: no route, key or behaviour is taken away.
Tests
IssueRadarPrListCoverage.test.tsx,pipeline/views/PipelineView.render.test.tsx,views/GraphView.cov80.test.tsx: each gains a case where focus stays on Refresh while busy, a press while busy sends no second fetch, and focus is still there after it ends. The two existing busy cases now assertaria-disabledinstead ofdisabled.All five fail on main (run in a separate worktree) and pass here.
Proof: not provable -- frontend test (prove.py runs Python only)
vitest run src/apps/issue-radar: 1644 passed.tsc -p tsconfig.app.jsonand eslint: clean. Local GPT 5.6 Sol and Opus 5.5 reviews: no findings.Manual verification
N/A — unit coverage sufficient: the tests drive the mounted views.
Screenshots / video
Why no screenshot: nothing on screen changes; only whether keyboard focus stays on the button.
Related Issues
Part of #31618
Sibling sweep
Swept: git grep -niE "disabled={[^}]*(refreshing|isfetching)" -- website/src/apps/issue-radar (run on origin/main)
Sibling: website/src/apps/issue-radar/components/PrList.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/GraphView.tsx -- changed here
Sibling: website/src/apps/issue-radar/pipeline/views/PipelineView.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/GroupReviewsView.tsx -- changed here
Sibling: website/src/apps/issue-radar/views/CiRunsView.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/components/IssueDetail.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/components/PrDetail.tsx -- tracked in #31618
Sibling: website/src/apps/issue-radar/views/OverviewView.tsx -- tracked in #31481
Sibling: website/src/apps/issue-radar/components/IssueList.tsx -- tracked in #31481
Pattern harvest
Rule candidate: none
Pattern: a busy button that sets native
disabledon itself while focused.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)