Repository navigation
fix(ops-mission-control): keep focus on Refresh and Poll now while they run - #32049
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The fix removes the cause, which is native What this change shipsInventory (3 items) — 3 justifiedIntent: keep a keyboard or screen-reader user's place on Ops Mission Control's Refresh and Poll now buttons while they fetch. This is a FIX (#32026).
[FIRST-PRINCIPLES-REVIEWED] 4e5cb44 Description read[DESCRIPTION-READ] 203b8e32185903ab5d942267ee1c5e749cc365353ffcb8ae8c1818ba3a347b5c That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The fix copies the Issue Radar inert-but-focusable shape, the app is not in Notes
[DESIGN-REVIEWED] 4e5cb44 Description read[DESCRIPTION-READ] 37fbd0e4aaa311d009e07c57ed161e7779efd3305c2bec7342fda91c30ae8388 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing on screen changes: the busy Refresh and Poll now buttons keep the same 30% dimming and the same "Refreshing…" / "Polling…" labels. The only change is that keyboard focus stays on the button, and a screenshot cannot show that. Notes
[UX-REVIEWED] 4e5cb44 Description read[DESCRIPTION-READ] f340e3de7c1cc07c9a0da15689a2b684ebbc848dab22c4a46f1b30f00f5e44fd That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: uses aria-disabled plus a click guard instead of disabled on Refresh and Poll now, so keyboard focus stays on the button while it runs, with tests.
Problem / Motivation
Goal: Keyboard focus stays on Ops Mission Control's Refresh and Poll now buttons while their fetch runs.
In
website/src/apps/ops-mission-control/HandoverPanel.tsx(Refresh) andwebsite/src/apps/ops-mission-control/SignalsPanel.tsx(Poll now), the button sets the nativedisabledattribute while its query is fetching. A disabled button leaves the tab order, so a keyboard press drops focus to the page for the whole fetch, and it never comes back.Why it matters
A keyboard or screen-reader user on call loses their place each time they refresh the handover digest or poll the signal sources.
Not a goal
What changed (motivation → approach → change)
Symptom: focus falls to the page on a keyboard refresh or poll. Cause:
disabled={query.isFetching}takes the focused button out of the tab order. Change: the same inert-but-focusable shape as the Issue Radar refresh buttons (#31481, #31687):aria-disabled={isFetching || undefined},aria-disabled:classes for the dimming, andif (!isFetching)at the start of each click handler so a press while busy still does nothing, as the nativedisableddid.Backwards compatibility
Compatible: both buttons, their labels and the fetch they run are unchanged; a press while busy is still ignored, now by the click guard.
Removes nothing: no route, key or behaviour is taken away.
Tests
HandoverPanel.coverage.test.tsx: new case: focus stays on Refresh while the digest refetch is held, a second press sends no second request, and focus is still there after it settles.OpsSignalsPanelCoverage.test.tsx: the same new case for Poll now, and the existing polling case now assertsaria-disabledinstead ofdisabled.All three fail on main (run in a separate worktree) and pass here. The tests hold a promise and settle it; no clock and no sleep.
Proof: not provable -- frontend test (prove.py runs Python only)
vitest run src/apps/ops-mission-control: 381 passed.tsc -p tsconfig.app.jsonand eslint: clean. Local GPT 5.6 Sol and Opus 5.5 reviews: no findings (Opus raised a test-order note in discovery; the new test now settles with the file's owndigest()fixture).Manual verification
N/A — unit coverage sufficient: the tests drive the mounted panels.
Screenshots / video
Why no screenshot: nothing on screen changes; only whether keyboard focus stays on the button.
Related Issues
Fixes #32026
Sibling sweep
Swept: git grep -nE "disabled={[^}]*(refreshing|isFetching)" -- website/src/apps (run on origin/main)
Sibling: website/src/apps/ops-mission-control/HandoverPanel.tsx -- changed here
Sibling: website/src/apps/ops-mission-control/SignalsPanel.tsx -- changed here
Sibling: website/src/apps/aws-control/AwsControlPage.tsx -- tracked in #32025
Sibling: website/src/apps/code-review-sage/components/DraftReviewActions.tsx -- tracked in #32025
Sibling: website/src/apps/mochi/src/renderer/SettingsPanel.tsx -- tracked in #32025
Sibling: website/src/apps/issue-radar/views/CiRunsView.tsx -- tracked in #31618
Pattern harvest
Rule candidate: none
Pattern: a busy button that sets native
disabledon itself while focused.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)