Skip to content

fix(a11y): keep focus on the remote artifacts Load more while it loads - #32269

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/r550-artifacts-loadmore-focus
Nov 7, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/r550-artifacts-loadmore-focus

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: pressing Load more under a remote provider's artifacts from the keyboard keeps focus on the button while the next page loads, instead of dropping it to the page.

The button took a native disabled while fetchNextPage ran. A disabled button leaves the tab order, so focus fell to the page for the whole load.

Why it matters

A keyboard or screen-reader user paging through remote artifacts loses their place on every page and has to tab back from the top.

Not a goal

What changed (motivation → approach → change)

Symptom: focus drops on Load more. Cause: native disabled while busy. Change: website/src/pages/ArtifactsPageSections.tsx marks the busy button aria-disabled with the same dimmed style and guards the click, so a second press does nothing, the way the Ops Mission Control refresh does (#32049). The stable accessible name and the spinner are unchanged.

Backwards compatibility

Compatible: the button looks and is named as before; a second press while loading still does nothing.

Removes nothing.

Tests

  • website/src/test/RemoteArtifacts.test.tsx: a new case focuses Load more, presses Enter while page 2 is held open, checks the button is aria-disabled and not disabled, keeps focus, ignores a second Enter, then keeps focus once the page lands. It fails on main (the busy button was disabled). All 241 tests in the artifacts suites pass.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the change is focus and ARIA state, covered by the test above.

Why no screenshot: the busy button keeps the same dimmed look, spinner and name; only its focusability and ARIA state change.

Related Issues

Fixes #32267

Deferred: #32268 (Snapshot, Pull latest and Overwrite remote on the artifact detail page)

Sibling sweep

Swept: git grep -n "disabled={" -- website/src/pages/ArtifactsPageSections.tsx website/src/pages/ArtifactDetailPage.tsx
Sibling: website/src/pages/ArtifactsPageSections.tsx -- fixed -- Load more
Sibling: website/src/pages/ArtifactDetailPage.tsx -- deferred -- Snapshot, Pull latest, Overwrite remote, Deferred: #32268

Pattern harvest

Not generalizable: the remaining sites are listed in #32268.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the Apache-2.0 license of this project.

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 7, 2026 11:09
@RohanK6
RohanK6 requested a review from tim-finnigan November 7, 2026 11:09
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of aae1ac83d038123791b50e88f5c93798a818dc6e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a small, reversible change to focus and ARIA state, and the dimmed look stays the same (non-primary Btn already uses disabled:opacity-30).

Notes

[DESIGN-REVIEWED] aae1ac8

Description read

[DESCRIPTION-READ] a47aa693f44928c37fa1c6401c9da50fb8c5accbb9c964afb9168c7300324414

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of aae1ac83d038123791b50e88f5c93798a818dc6e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The Load more button looks the same while busy (same opacity-30 dim, same spinner, same name); only its focusability and ARIA state change, so no screenshot was needed.

Notes

  • While loading, the cursor over the busy button changes from cursor-not-allowed to cursor-default. Hovering a busy Load more still shows no "not allowed" cue, only dimming. Use aria-disabled:cursor-not-allowed if it should stay as it was.

[UX-REVIEWED] aae1ac8

Description read

[DESCRIPTION-READ] f46ff9fb35cc598dc15f62f4fbcd879b823513faef8206555ca0f69549ae3054

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of aae1ac83d038123791b50e88f5c93798a818dc6e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The fix works at the level of the defect and adds no new surface. The sibling sweep missed about 16 artifact-page buttons with the same problem.

Notes

What this change ships

Inventory (3 items) — 3 justified

Intent: a keyboard user pressing Load more on remote artifacts keeps their place while the next page loads. This is a FIX.

  1. Load more stays focused and in the tab order while the next page loads — justified
  2. A second press while loading still does nothing; the click guard replaces disabled — justified
  3. The busy button keeps the same dimmed look through aria-disabled: classes — justified

[FIRST-PRINCIPLES-REVIEWED] aae1ac8

Description read

[DESCRIPTION-READ] 038950357e915ee82c4da1377088b3d8b9d618a864128f01dea38246a98f4511

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of aae1ac83d038123791b50e88f5c93798a818dc6e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] aae1ac8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt aae1ac83d038123791b50e88f5c93798a818dc6e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed aae1ac83d038123791b50e88f5c93798a818dc6e — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • While a page is loading, the faded Load more button still reacts to hover and shrinks when pressed, because Btn's hover:/active: classes only switch off for native disabled. This is cosmetic only: the guard still ignores the press.

[OPUS-REVIEWED] aae1ac8

Verdict parsed from the review's SHA-scoped output markers for commit aae1ac83d038123791b50e88f5c93798a818dc6e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable aae1ac83d038123791b50e88f5c93798a818dc6e false-positive: <reason, 20 to 500 characters>

The Load more button under a remote provider's artifacts used a native
disabled while the next page loaded. A disabled button leaves the tab
order, so a keyboard press dropped focus to the page for the whole
load. Mark the busy button aria-disabled and ignore a second press,
the way the Ops Mission Control refresh does.
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/r550-artifacts-loadmore-focus branch from 60ba198 to aae1ac8 Compare November 7, 2026 12:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 7, 2026 12:58

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: keeps keyboard focus on the remote artifacts Load more button while a page loads, using aria-disabled plus a guard, with a test.

@RohanK6
RohanK6 merged commit ecddebb into main Nov 7, 2026
97 of 102 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/r550-artifacts-loadmore-focus branch November 7, 2026 13:07
buluoray added a commit that referenced this pull request Nov 8, 2026
#32269)

The Load more button under a remote provider's artifacts used a native
disabled while the next page loaded. A disabled button leaves the tab
order, so a keyboard press dropped focus to the page for the whole
load. Mark the busy button aria-disabled and ignore a second press,
the way the Ops Mission Control refresh does.

(cherry picked from commit ecddebb)

Original author: Rohan Khanderia (#32269).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifacts: the remote Load more button drops keyboard focus while a page loads

2 participants