Repository navigation
fix(a11y): keep focus on the remote artifacts Load more while it loads - #32269
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a small, reversible change to focus and ARIA state, and the dimmed look stays the same (non-primary Notes
[DESIGN-REVIEWED] aae1ac8 Description read[DESCRIPTION-READ] a47aa693f44928c37fa1c6401c9da50fb8c5accbb9c964afb9168c7300324414 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The Load more button looks the same while busy (same Notes
[UX-REVIEWED] aae1ac8 Description read[DESCRIPTION-READ] f46ff9fb35cc598dc15f62f4fbcd879b823513faef8206555ca0f69549ae3054 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The fix works at the level of the defect and adds no new surface. The sibling sweep missed about 16 artifact-page buttons with the same problem. Notes
What this change shipsInventory (3 items) — 3 justifiedIntent: a keyboard user pressing Load more on remote artifacts keeps their place while the next page loads. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] aae1ac8 Description read[DESCRIPTION-READ] 038950357e915ee82c4da1377088b3d8b9d618a864128f01dea38246a98f4511 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] aae1ac8 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
The Load more button under a remote provider's artifacts used a native disabled while the next page loaded. A disabled button leaves the tab order, so a keyboard press dropped focus to the page for the whole load. Mark the busy button aria-disabled and ignore a second press, the way the Ops Mission Control refresh does.
60ba198 to
aae1ac8
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: keeps keyboard focus on the remote artifacts Load more button while a page loads, using aria-disabled plus a guard, with a test.
#32269) The Load more button under a remote provider's artifacts used a native disabled while the next page loaded. A disabled button leaves the tab order, so a keyboard press dropped focus to the page for the whole load. Mark the busy button aria-disabled and ignore a second press, the way the Ops Mission Control refresh does. (cherry picked from commit ecddebb) Original author: Rohan Khanderia (#32269).
Problem / Motivation
Goal: pressing Load more under a remote provider's artifacts from the keyboard keeps focus on the button while the next page loads, instead of dropping it to the page.
The button took a native
disabledwhilefetchNextPageran. A disabled button leaves the tab order, so focus fell to the page for the whole load.Why it matters
A keyboard or screen-reader user paging through remote artifacts loses their place on every page and has to tab back from the top.
Not a goal
What changed (motivation → approach → change)
Symptom: focus drops on Load more. Cause: native
disabledwhile busy. Change:website/src/pages/ArtifactsPageSections.tsxmarks the busy buttonaria-disabledwith the same dimmed style and guards the click, so a second press does nothing, the way the Ops Mission Control refresh does (#32049). The stable accessible name and the spinner are unchanged.Backwards compatibility
Compatible: the button looks and is named as before; a second press while loading still does nothing.
Removes nothing.
Tests
website/src/test/RemoteArtifacts.test.tsx: a new case focuses Load more, presses Enter while page 2 is held open, checks the button isaria-disabledand notdisabled, keeps focus, ignores a second Enter, then keeps focus once the page lands. It fails on main (the busy button wasdisabled). All 241 tests in the artifacts suites pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is focus and ARIA state, covered by the test above.
Why no screenshot: the busy button keeps the same dimmed look, spinner and name; only its focusability and ARIA state change.
Related Issues
Fixes #32267
Deferred: #32268 (Snapshot, Pull latest and Overwrite remote on the artifact detail page)
Sibling sweep
Swept: git grep -n "disabled={" -- website/src/pages/ArtifactsPageSections.tsx website/src/pages/ArtifactDetailPage.tsx
Sibling: website/src/pages/ArtifactsPageSections.tsx -- fixed -- Load more
Sibling: website/src/pages/ArtifactDetailPage.tsx -- deferred -- Snapshot, Pull latest, Overwrite remote, Deferred: #32268
Pattern harvest
Not generalizable: the remaining sites are listed in #32268.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the Apache-2.0 license of this project.