Repository navigation
fix(a11y): keep focus on a deploy profile's Verify while it checks - #32405
Conversation
Each AWS profile row's Verify button took a native disabled while its reachability check ran. A disabled button leaves the tab order, so a keyboard press dropped focus to the page until the check settled. Mark the busy row aria-disabled and ignore a second press instead, the way the Ops Mission Control refresh does.
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is one focus fix at mechanism level, using the same inline What this change shipsInventory (2 items) — 2 justifiedIntent: a keyboard user who presses Verify on a deploy profile row keeps focus on that button while the check runs. FIX (#32404).
[FIRST-PRINCIPLES-REVIEWED] 2ba23c5 Description read[DESCRIPTION-READ] 75697d4a127bf320d337cd763b71bce12ffa3ebc8e0a2b4e67f674b5853b1f31 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the busy Verify state. The change alters how that state renders and behaves, and the blind read was not performed because the PR attaches no image. Evidence gaps
Notes
[UX-REVIEWED] 2ba23c5 Description read[DESCRIPTION-READ] 30feca83bbc8ff33aacc5bc7e0884db29601ed642d4dee1f2c7cd40d27a17ca4 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a small fix that matches the Notes
[DESIGN-REVIEWED] 2ba23c5 Description read[DESCRIPTION-READ] 5d51e6255a19b42c75a595efb3d72718bbe61aae531df917628470da538e6893 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 2ba23c5.
What I checked on this head:
- The base is main. All 96 checks are green and none is pending. One check, the PR Readiness signal, had failed when the shared GitHub core rate limit ran out (the log shows 0 of 15000 remaining); I reran it once and it passed. The UX, Design and First Principles lanes pass, and the Opus and GPT lanes have no blocking findings.
- The fix matches the cause. A native
disabledtakes the pressed Verify button out of the tab order, so keyboard focus fell to the page while the check ran. The busy row's Verify now usesaria-disabledwith the same dimmed style, and the click handler ignores a press while that row's check is running, so other rows stay free to check. - The updated test focuses one row's Verify, presses it, and checks that it is
aria-disabledand notdisabled, still has focus, a second press does nothing, the other row is not marked, and focus is still there when the check ends. - What a check reports and which rows may check at once are unchanged. No regex, no new setting, and nothing made stricter.
I did not set auto-merge, because it is already set on this PR.
…32405) Each AWS profile row's Verify button took a native disabled while its reachability check ran. A disabled button leaves the tab order, so a keyboard press dropped focus to the page until the check settled. Mark the busy row aria-disabled and ignore a second press instead, the way the Ops Mission Control refresh does. (cherry picked from commit b94163e) Original author: Rohan Khanderia (#32405).
Problem / Motivation
Goal: pressing Verify on an AWS profile row of the Artifact deploy page from the keyboard keeps focus on that button while its check runs, instead of dropping it to the page.
The button took a native
disabledwhile its row's reachability check ran. A disabled button leaves the tab order, so focus fell to the page until the check settled.Why it matters
A keyboard or screen-reader user checking a profile loses their place in the table on every check and has to tab back from the top.
Not a goal
What changed (motivation → approach → change)
Symptom: focus drops on Verify. Cause: native
disabledwhile busy. Change:website/src/pages/ArtifactDeployPage.tsxmarks the busy row's Verifyaria-disabledwith the same dimmed style and guards the click, so a second press on that row does nothing while other rows stay free, the way the Ops Mission Control refresh does (#32049).Backwards compatibility
Compatible: the button looks and is named as before; a second press on a row being checked still does nothing, and other rows still check.
Removes nothing.
Tests
website/src/test/ArtifactDeployPage.verifyRace.test.tsx: the row-lock case now focuses alpha's Verify, presses it, and checks it isaria-disabledand notdisabled, keeps focus, leaves beta free, ignores a second press, and keeps focus once the check settles. It fails on main (the busy button wasdisabled). All 98 tests in the deploy page suites pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is focus and ARIA state, covered by the test above.
Why no screenshot: the busy Verify keeps the same dimmed look and label; only its focusability and ARIA state change.
Related Issues
Fixes #32404
Deferred: #32268 (Deploy, Deploy anyway and Dismiss on this page, with the other artifact buttons)
Sibling sweep
Swept: git grep -n "disabled={" -- website/src/pages/ArtifactDeployPage.tsx
Sibling: website/src/pages/ArtifactDeployPage.tsx:612 -- fixed -- Verify
Sibling: website/src/pages/ArtifactDeployPage.tsx:669 -- not affected -- Add profile is disabled by an empty name, not a busy state
Sibling: website/src/pages/ArtifactDeployPage.tsx:972 -- deferred -- Deploy, Deferred: #32268
Sibling: website/src/pages/ArtifactDeployPage.tsx:1140 -- deferred -- Deploy anyway, Deferred: #32268
Sibling: website/src/pages/ArtifactDeployPage.tsx:1143 -- deferred -- Dismiss, Deferred: #32268
Pattern harvest
Not generalizable: the remaining busy buttons are listed in #32268.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the Apache-2.0 license of this project.