Skip to content

fix(a11y): keep focus on a deploy profile's Verify while it checks - #32405

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/r590-deploy-verify-focus
Nov 7, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/r590-deploy-verify-focus

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: pressing Verify on an AWS profile row of the Artifact deploy page from the keyboard keeps focus on that button while its check runs, instead of dropping it to the page.

The button took a native disabled while its row's reachability check ran. A disabled button leaves the tab order, so focus fell to the page until the check settled.

Why it matters

A keyboard or screen-reader user checking a profile loses their place in the table on every check and has to tab back from the top.

Not a goal

What changed (motivation → approach → change)

Symptom: focus drops on Verify. Cause: native disabled while busy. Change: website/src/pages/ArtifactDeployPage.tsx marks the busy row's Verify aria-disabled with the same dimmed style and guards the click, so a second press on that row does nothing while other rows stay free, the way the Ops Mission Control refresh does (#32049).

Backwards compatibility

Compatible: the button looks and is named as before; a second press on a row being checked still does nothing, and other rows still check.

Removes nothing.

Tests

  • website/src/test/ArtifactDeployPage.verifyRace.test.tsx: the row-lock case now focuses alpha's Verify, presses it, and checks it is aria-disabled and not disabled, keeps focus, leaves beta free, ignores a second press, and keeps focus once the check settles. It fails on main (the busy button was disabled). All 98 tests in the deploy page suites pass.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the change is focus and ARIA state, covered by the test above.

Why no screenshot: the busy Verify keeps the same dimmed look and label; only its focusability and ARIA state change.

Related Issues

Fixes #32404

Deferred: #32268 (Deploy, Deploy anyway and Dismiss on this page, with the other artifact buttons)

Sibling sweep

Swept: git grep -n "disabled={" -- website/src/pages/ArtifactDeployPage.tsx
Sibling: website/src/pages/ArtifactDeployPage.tsx:612 -- fixed -- Verify
Sibling: website/src/pages/ArtifactDeployPage.tsx:669 -- not affected -- Add profile is disabled by an empty name, not a busy state
Sibling: website/src/pages/ArtifactDeployPage.tsx:972 -- deferred -- Deploy, Deferred: #32268
Sibling: website/src/pages/ArtifactDeployPage.tsx:1140 -- deferred -- Deploy anyway, Deferred: #32268
Sibling: website/src/pages/ArtifactDeployPage.tsx:1143 -- deferred -- Dismiss, Deferred: #32268

Pattern harvest

Not generalizable: the remaining busy buttons are listed in #32268.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the Apache-2.0 license of this project.

Each AWS profile row's Verify button took a native disabled while its
reachability check ran. A disabled button leaves the tab order, so a
keyboard press dropped focus to the page until the check settled.
Mark the busy row aria-disabled and ignore a second press instead, the
way the Ops Mission Control refresh does.
@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 7, 2026 15:11
@RohanK6
RohanK6 requested a review from tim-finnigan November 7, 2026 15:11
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2ba23c591a573500b47dcb5e2b915853006a49ed and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2ba23c5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2ba23c591a573500b47dcb5e2b915853006a49ed false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2ba23c591a573500b47dcb5e2b915853006a49ed — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is one focus fix at mechanism level, using the same inline aria-disabled pattern that about 30 other buttons in website/src already use.

What this change ships

Inventory (2 items) — 2 justified

Intent: a keyboard user who presses Verify on a deploy profile row keeps focus on that button while the check runs. FIX (#32404).

  1. While its row's check runs, Verify now stays focusable and in the tab order. It looks dimmed as before, and a second press still does nothing. — justified
  2. The row-lock test now checks that focus stays on the button, that it uses aria-disabled rather than disabled, and that a second press is ignored. — justified

[FIRST-PRINCIPLES-REVIEWED] 2ba23c5

Description read

[DESCRIPTION-READ] 75697d4a127bf320d337cd763b71bce12ffa3ebc8e0a2b4e67f674b5853b1f31

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 2ba23c591a573500b47dcb5e2b915853006a49ed — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of the busy Verify state. The change alters how that state renders and behaves, and the blind read was not performed because the PR attaches no image.

Evidence gaps

  • Busy Verify on an AWS profile row (ArtifactDeployPage.tsx:612): this is the main control the PR exists to change, and the screenshot list and blind-read report have no entry for it. The PR says it looks the same as before, but the diff changes what it shows:

    • The cursor is now aria-disabled:cursor-default instead of Btn's disabled:cursor-not-allowed.
    • Btn's hover:border-border-strong hover:bg-bg-hover and active:scale-[0.97] now apply to a dimmed button that does nothing.
    • The focus ring now shows on a button at 30% opacity.

    To close the gap, attach a still of the alpha row mid-check with keyboard focus on its Verify, and a second still with the pointer hovering it, next to the idle beta row.

Notes

  • Add aria-disabled:hover:bg-transparent aria-disabled:hover:border-border aria-disabled:active:scale-100 so the busy button stops reacting to hover and clicks like a live one.

[UX-REVIEWED] 2ba23c5

Description read

[DESCRIPTION-READ] 30feca83bbc8ff33aacc5bc7e0884db29601ed642d4dee1f2c7cd40d27a17ca4

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2ba23c591a573500b47dcb5e2b915853006a49ed — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a small fix that matches the aria-disabled-plus-guard pattern already used in #32049, and nothing visible changes.

Notes

[DESIGN-REVIEWED] 2ba23c5

Description read

[DESCRIPTION-READ] 5d51e6255a19b42c75a595efb3d72718bbe61aae531df917628470da538e6893

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2ba23c591a573500b47dcb5e2b915853006a49ed — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2ba23c5

Verdict parsed from the review's SHA-scoped output markers for commit 2ba23c591a573500b47dcb5e2b915853006a49ed.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2ba23c591a573500b47dcb5e2b915853006a49ed false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 7, 2026 17:32

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 2ba23c5.

What I checked on this head:

  • The base is main. All 96 checks are green and none is pending. One check, the PR Readiness signal, had failed when the shared GitHub core rate limit ran out (the log shows 0 of 15000 remaining); I reran it once and it passed. The UX, Design and First Principles lanes pass, and the Opus and GPT lanes have no blocking findings.
  • The fix matches the cause. A native disabled takes the pressed Verify button out of the tab order, so keyboard focus fell to the page while the check ran. The busy row's Verify now uses aria-disabled with the same dimmed style, and the click handler ignores a press while that row's check is running, so other rows stay free to check.
  • The updated test focuses one row's Verify, presses it, and checks that it is aria-disabled and not disabled, still has focus, a second press does nothing, the other row is not marked, and focus is still there when the check ends.
  • What a check reports and which rows may check at once are unchanged. No regex, no new setting, and nothing made stricter.

I did not set auto-merge, because it is already set on this PR.

@RohanK6
RohanK6 merged commit b94163e into main Nov 7, 2026
98 of 106 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/r590-deploy-verify-focus branch November 7, 2026 18:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…32405)

Each AWS profile row's Verify button took a native disabled while its
reachability check ran. A disabled button leaves the tab order, so a
keyboard press dropped focus to the page until the check settled.
Mark the busy row aria-disabled and ignore a second press instead, the
way the Ops Mission Control refresh does.

(cherry picked from commit b94163e)

Original author: Rohan Khanderia (#32405).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifact deploy: a profile's Verify button drops keyboard focus while it checks

2 participants