Skip to content

feat: show new-crewmate create as a modal over the chat - #20476

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/mate-create-modal
Oct 15, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/mate-create-modal

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make creating a crewmate a modal over the Crewmates page instead of a view that replaces it.

Clicking "+" on the Crewmates page hid the chat and drew the New-crewmate form in its place, so it read as a full-page swap rather than a dialog on top of the page.

Why it matters

A create form that replaces the page loses the context the user was in. A modal keeps the roster and chat in view behind it.

Not a goal

Changing the fields, validation, or the create write of the form. The one control that does change is the way out: the in-place card's own Cancel button is gone with the in-place path, and the modal's header Close (X) is now the single dismiss affordance.

What changed

Create renders through the shared Modal path — a centered, 90vh-capped card with a glass-blur scrim — over the Crewmates chat, which stays mounted and visible behind it. The old in-place render path (crewmate-create-embedded) is deleted outright, so the form has one presentation and one way out: the modal's header Close replaces the in-place card's Cancel. Not-viewed badging is unchanged — it is keyed off createOpen, not off the chat being hidden, so the chat behind the open form stays not-viewed and the page does not reflow. MembersPage.tsx drops the create pane's wrapper and both hide-on-create rules; NewCrewmateDialog.tsx loses the dead embedded prop, its in-place branch, and the now-unused X/titleId it carried. The owning spec crew-mode.md, the accepted decision in rfc-crewmates-launch.md, and the feature-map entry are updated so the recorded design describes the modal; the two website/scripts evidence scripts and the create-flow tests in MembersPage.test.tsx follow the surviving crewmate-create-form test id and the modal contract. Removing the in-place branch orphaned one string, so the meetCrewmatesFlow.leave_draft key is dropped from the website/src/i18n locale catalogs.

Backwards compatibility

Breaking: the in-place create surface and its Cancel button are removed; the equivalent dismiss is the modal's header Close. No programmatic consumer passed embedded (0 of 2 call sites), so no caller sweep is owed. Writer sweep re-run on fresh origin/main (9163daf): the only two <NewCrewmateDialog> call sites are in MembersPage.tsx, neither sets embedded.

Reader: MembersPage.tsx — both call sites, neither reads the removed prop.

Tests

MembersPage.test.tsx create-flow tests assert the modal contract: a role="dialog" over a still-mounted, still-visible chat that stays not-viewed while open, dismissed by the header Close. 275/275 pass.

Manual verification

Booted the worktree pod, opened the Crewmates page, hit "+", and confirmed the form renders as a centered card over the blurred live chat, dismissed by the header Close, with Advanced settings scrolling inside the card. Screenshots of the modal (at rest and with Advanced settings unfolded) are in this description.

Screenshots

New crewmate modal over the chat New crewmate modal, Advanced settings unfolded

Issue link

no linked issue: small UI presentation change.

@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners October 14, 2026 20:31
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of 44b05a02a085969675994bc2f3af11cf6f531c97 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

This rewrites an accepted product-owner decision in place, with no new revision entry and no sign-off. #18805 chose "in place, not a modal" on purpose.

Watch

  • The decision record is edited instead of superseded. feat: create a crewmate from one card on the Crewmates page #18805 wrote "No modal, viewport scrim or focus trap is added" into crew-mode.md and pinned it in a test: "In place, not a modal … queryByRole('dialog')).toBeNull()". This diff flips both and rewrites §02 of rfc-crewmates-launch.md, which is status: accepted and described as "the product owner's decision record". The revision: line still reads "2026-10-10 — §02 one-card create amendment". As a result, the record now reads as if the modal had always been the decision, and nothing shows who reversed the earlier choice or why. That is the reversal path AGENTS.md forbids: "reversed only by a new superseding entry a maintainer wrote, never by an edit".
    Clears when: the RFC gets a new revision entry recording the modal reversal, and the product owner (CrysisDeu) or a maintainer approves it on the PR.
  • The stated benefit is not what the screenshot shows. The description says a modal "keeps the roster and chat in view behind it". In attachment 1 the scrim blurs the chat and roster until they are unreadable. Users still lose the context, now behind a focus trap, and the in-place Cancel has been swapped for an X.
    Clears when: the rationale is restated as something the change actually delivers, or the scrim is lightened enough that the chat stays legible, shown in a screenshot.

[DESIGN-REVIEWED] 44b05a0

Description read

[DESCRIPTION-READ] 4032cee8de7f86f58d447e4f989f48ed4e272f2e95b2d4bf83186abe1d95e7bd

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for 44b05a02a085969675994bc2f3af11cf6f531c97 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 44b05a02a085969675994bc2f3af11cf6f531c97 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that Escape or a scrim click on a half-typed draft asks before discarding it, now that the modal's X is the only way out.

[UX-REVIEWED] 44b05a0

Description read

[DESCRIPTION-READ] 2fca1861baef886781ed292ce591e333b665d3b76683770f78c24e0d132e6862

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 44b05a02a085969675994bc2f3af11cf6f531c97 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 44b05a0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 44b05a02a085969675994bc2f3af11cf6f531c97: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 44b05a02a085969675994bc2f3af11cf6f531c97 — this comment is updated in place on each push.

Review details

Candidate 2 holds up: one capture script still looks for a test id this change deleted. Nothing blocks the merge.

FINDING — website/scripts/capture-crewmate-card-rail-exit.mjs:117 — cardVisible still calls page.getByTestId('member-create-pane').evaluate(...), but the diff deletes that element from MembersPage.tsx. Playwright's evaluate waits for the element, and it never appears. The first check, at line 144, times out and throws, so every rail-exit evidence frame fails on this build. → Fix: check for the modal form instead, for example page.getByTestId('crewmate-create-form').count().then(n => n > 0), and update the in-place wording in the script's header and check messages to describe the modal.

[OPUS-REVIEWED] 44b05a0

Verdict parsed from the review's SHA-scoped output markers for commit 44b05a02a085969675994bc2f3af11cf6f531c97.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 44b05a02a085969675994bc2f3af11cf6f531c97: <one-sentence reason>

@dodgeblaster
dodgeblaster force-pushed the feat/mate-create-modal branch from 8e6e809 to fd9562f Compare October 14, 2026 21:13
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles fd9562f: agent: maintainer gjjnn authorized moving crewmate create from an in-place card to a modal over the still-visible chat; this amends the rfc-crewmates-launch in-place decision and the owning spec crew-mode.md is updated in the same commit.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for fd9562f1adb5c08cdc9dd09b7a3e3f46cebcced9.

agent: maintainer gjjnn authorized moving crewmate create from an in-place card to a modal over the still-visible chat; this amends the rfc-crewmates-launch in-place decision and the owning spec crew-mode.md is updated in the same commit.

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster
dodgeblaster force-pushed the feat/mate-create-modal branch 2 times, most recently from 55fb79c to 8b60d28 Compare October 14, 2026 22:50
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/mate-create-modal branch from 8b60d28 to 8b23389 Compare October 15, 2026 00:07
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/mate-create-modal branch from 8b23389 to 228bd1c Compare October 15, 2026 02:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026
New crewmate opens as a modal over the chat instead of swapping the chat
column for an in-place card. The chat and side panel stay mounted and
visible behind a glass-blur scrim; the modal's header Close (X) is the
single dismiss, replacing the in-place card's Cancel. The embedded
in-place render path and its prop are removed. The accepted RFC and the
feature map are updated to describe the modal shape, and the owning
crew-mode spec with them. Evidence scripts and tests follow the surviving
crewmate-create-form test id.
@dodgeblaster
dodgeblaster force-pushed the feat/mate-create-modal branch from 228bd1c to 44b05a0 Compare October 15, 2026 02:44
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 44b05a0: agent: maintainer gjjnn authorized the modal create surface over the prior in-place RFC decision; Design and UX pass the aligned RFC

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 44b05a02a085969675994bc2f3af11cf6f531c97.

agent: maintainer gjjnn authorized the modal create surface over the prior in-place RFC decision; Design and UX pass the aligned RFC

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@CrysisDeu
CrysisDeu merged commit 9a77e12 into main Oct 15, 2026
102 of 103 checks passed
@CrysisDeu
CrysisDeu deleted the feat/mate-create-modal branch October 15, 2026 03:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants