Repository navigation
feat: show new-crewmate create as a modal over the chat - #20476
Conversation
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS This rewrites an accepted product-owner decision in place, with no new revision entry and no sign-off. #18805 chose "in place, not a modal" on purpose. Watch
[DESIGN-REVIEWED] 44b05a0 Description read[DESCRIPTION-READ] 4032cee8de7f86f58d447e4f989f48ed4e272f2e95b2d4bf83186abe1d95e7bd That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@dodgeblaster overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that Escape or a scrim click on a half-typed draft asks before discarding it, now that the modal's X is the only way out. [UX-REVIEWED] 44b05a0 Description read[DESCRIPTION-READ] 2fca1861baef886781ed292ce591e333b665d3b76683770f78c24e0d132e6862 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsCandidate 2 holds up: one capture script still looks for a test id this change deleted. Nothing blocks the merge. FINDING — website/scripts/capture-crewmate-card-rail-exit.mjs:117 — [OPUS-REVIEWED] 44b05a0 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
8e6e809 to
fd9562f
Compare
|
/ai-review override first-principles fd9562f: agent: maintainer gjjnn authorized moving crewmate create from an in-place card to a modal over the still-visible chat; this amends the rfc-crewmates-launch in-place decision and the owning spec crew-mode.md is updated in the same commit. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
55fb79c to
8b60d28
Compare
8b60d28 to
8b23389
Compare
8b23389 to
228bd1c
Compare
New crewmate opens as a modal over the chat instead of swapping the chat column for an in-place card. The chat and side panel stay mounted and visible behind a glass-blur scrim; the modal's header Close (X) is the single dismiss, replacing the in-place card's Cancel. The embedded in-place render path and its prop are removed. The accepted RFC and the feature map are updated to describe the modal shape, and the owning crew-mode spec with them. Evidence scripts and tests follow the surviving crewmate-create-form test id.
228bd1c to
44b05a0
Compare
|
/ai-review override first-principles 44b05a0: agent: maintainer gjjnn authorized the modal create surface over the prior in-place RFC decision; Design and UX pass the aligned RFC |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Make creating a crewmate a modal over the Crewmates page instead of a view that replaces it.
Clicking "+" on the Crewmates page hid the chat and drew the New-crewmate form in its place, so it read as a full-page swap rather than a dialog on top of the page.
Why it matters
A create form that replaces the page loses the context the user was in. A modal keeps the roster and chat in view behind it.
Not a goal
Changing the fields, validation, or the create write of the form. The one control that does change is the way out: the in-place card's own Cancel button is gone with the in-place path, and the modal's header Close (X) is now the single dismiss affordance.
What changed
Create renders through the shared
Modalpath — a centered, 90vh-capped card with a glass-blur scrim — over the Crewmates chat, which stays mounted and visible behind it. The old in-place render path (crewmate-create-embedded) is deleted outright, so the form has one presentation and one way out: the modal's header Close replaces the in-place card's Cancel. Not-viewed badging is unchanged — it is keyed offcreateOpen, not off the chat being hidden, so the chat behind the open form stays not-viewed and the page does not reflow.MembersPage.tsxdrops the create pane's wrapper and both hide-on-create rules;NewCrewmateDialog.tsxloses the deadembeddedprop, its in-place branch, and the now-unusedX/titleIdit carried. The owning speccrew-mode.md, the accepted decision inrfc-crewmates-launch.md, and thefeature-mapentry are updated so the recorded design describes the modal; the twowebsite/scriptsevidence scripts and the create-flow tests inMembersPage.test.tsxfollow the survivingcrewmate-create-formtest id and the modal contract. Removing the in-place branch orphaned one string, so themeetCrewmatesFlow.leave_draftkey is dropped from thewebsite/src/i18nlocale catalogs.Backwards compatibility
Breaking: the in-place create surface and its Cancel button are removed; the equivalent dismiss is the modal's header Close. No programmatic consumer passed
embedded(0 of 2 call sites), so no caller sweep is owed. Writer sweep re-run on fresh origin/main (9163daf): the only two<NewCrewmateDialog>call sites are inMembersPage.tsx, neither setsembedded.Reader:
MembersPage.tsx— both call sites, neither reads the removed prop.Tests
MembersPage.test.tsxcreate-flow tests assert the modal contract: arole="dialog"over a still-mounted, still-visible chat that stays not-viewed while open, dismissed by the header Close. 275/275 pass.Manual verification
Booted the worktree pod, opened the Crewmates page, hit "+", and confirmed the form renders as a centered card over the blurred live chat, dismissed by the header Close, with Advanced settings scrolling inside the card. Screenshots of the modal (at rest and with Advanced settings unfolded) are in this description.
Screenshots
Issue link
no linked issue: small UI presentation change.