Skip to content

fix(dashboard): clearer search status and limit copy for capped tree - #20495

Merged
bolichen97 merged 1 commit into
mainfrom
fix/capped-tree-ux-16743
Oct 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/capped-tree-ux-16743

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a project too large to list in full, the folder panel's search status and limit messages say plainly what is happening.

The capped project tree (#16029) left four rough edges, found by the UX review on that PR:

  • While a search over a capped tree is still running, the tree's own matches show at once with no "Searching…" row, so the list then grows without warning.
  • When the capped tree has no row at all, the empty state reuses the badge text "Large workspace: limit of 10,000 items reached, some not shown", which says nothing about what to do.
  • The row under a capped folder says "Not shown: limit of 10,000 items reached", which reads as if nothing is shown, while the badge for the same limit says "some items not shown".
  • The line above the results says "Too many items to filter here, so the search also covers items not listed", which reads as a filter, not a search.

Why it matters

People with big repos hit these surfaces every time they open the Files tab. Copy that contradicts itself or hides that a search is still running makes them think files are missing.

Not a goal

  • Changing the 10,000-item cap, the search itself, or how tree and server matches are merged.
  • Changing the top-of-tree "Large workspace" badge copy.

What changed (motivation → approach → change)

  • website/src/pages/chat/FolderPanel.tsx: the "Searching…" status now sits below the listed matches and also shows while the first server answer is still out, even if the tree's own matches are already listed. It also shows when a refined query still shows the previous answer as placeholder rows (react-query isPlaceholderData), but not while a wider page loads. It goes away once this query is answered.
  • website/src/pierre/PierreWorkspaceTreeImpl.tsx: the empty capped tree gets its own string (components.workspaceTree.root_truncated): "Workspace too large to list: limit of 10,000 items reached"
  • The row under a capped folder now reads "Some items not shown: limit of 10,000 items reached", matching the badge.
  • The line above the results now reads "Results can include files past the 10,000-item limit" (reads as a search and names the same limit as the other surfaces).
  • docs/system-specs/modules/learn-cron-dashboard.md: the Project tree spec quotes the new row and empty-state copy and the new search line.
  • website/src/i18n/locales/ (en.manual, zh-CN, hi, es, fr, bn, pt, ru, de, ja, ko, it, en-XA): all 12 catalogs plus the pseudolocale carry the new and changed strings. Two capture scripts (website/scripts/capture-path-chips.mjs, website/scripts/capture-files-tree-empty-folder.mjs) follow the new copy, and the truncated-tree scene now waits for the "Searching…" row.

Backwards compatibility

Compatible: copy changes plus one new catalog key; no API, setting or stored data changes.

Removes nothing: pages.chat.activityViewer.workspace_truncated is still used by the top-of-tree badge; only the empty state stops reusing it.

Tests

  • FolderPanel.tree.test.tsx new case "announces the search still running while the truncated tree already lists matches": status row present while the search is pending with tree matches shown, gone after it answers, and back for a refined query whose rows are the previous placeholder. Each half red on its parent condition, green on the fix. 3 shuffled runs (seeds 1-3): 29/29. Red on the parent (status row missing), green on the fix. 5 runs of the file with --sequence.shuffle (seeds 1-5): 29/29 each time.
  • PierreWorkspaceTreeImpl.test.tsx and FolderPanel.tree.test.tsx pins updated to the new copy.
  • root_truncated states the fact rather than telling the user to search, because the Files rail shows the same empty state above a local-only "Filter files…" box. Style guides (src/i18n/style/*Style.test.ts changed-values checks, run with I18N_BASE_REF=origin/main: 14 files, 207 tests green).
  • Local: npm run i18n:check (also with I18N_BASE_REF=origin/main), tsc -p tsconfig.app.json, eslint on the changed files, and vitest over the two test files plus src/i18n (50 files, 1094 tests): all green.

Manual verification

Captured with the repo harnesses (scripts/capture-path-chips.mjs scene folder-truncated, and scripts/capture-files-tree-empty-folder.mjs --expect-state-rows against a dist built from this branch). Both exited 0 with their assertions passing.

Screenshots / video

Search in flight on a capped tree: new line above the results, and "Searching…" shown while the tree's own match is already listed.

Search in flight, dark

Search answered: status gone, server match merged in.

Search answered, light

Row under a capped folder (big) now reads "Some items not shown: limit of 10,000 items reached".

Capped folder row

Empty capped tree: its own message.

Empty capped tree

Related Issues

Closes #16743

Pattern harvest

Not generalizable: a one-off set of copy and status polish on surfaces #16029 added; the reused-key case is already covered by the "one key, one meaning" rule in website/docs/i18n-catalog.md.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 14, 2026 21:19
@bolichen97
bolichen97 requested a review from mbriones98 October 14, 2026 21:19
@bolichen97
bolichen97 enabled auto-merge (squash) October 14, 2026 21:19
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 14, 2026
@bolichen97
bolichen97 force-pushed the fix/capped-tree-ux-16743 branch from d1b7a07 to a47c5c2 Compare October 14, 2026 21:45
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1fbe74997d3afb5713a69dafd8b6cb56171be9f5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (4 items) — 4 justified

Intent: on a project too big to list in full, the folder panel's search status and limit messages should say plainly what is happening. This is a FIX (closes #16743).

  1. While a search over a capped tree is still running, "Searching…" now shows below the tree's own matches and below a refined query's placeholder rows, not only when the list is empty. — justified
  2. An empty capped tree now shows its own message, "Workspace too large to list…", instead of reusing the badge text. — justified
  3. The row under a capped folder now reads "Some items not shown: limit…", which matches the badge. — justified
  4. The line above search results now reads "Results can include files past the 10,000-item limit". — justified

[FIRST-PRINCIPLES-REVIEWED] 1fbe749

Description read

[DESCRIPTION-READ] 928e777880ee656c2037b2aca3fc2924a584c0132ce625bf19c7c11262c0c624

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1fbe74997d3afb5713a69dafd8b6cb56171be9f5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the "Searching…" row stays hidden on a non-truncated tree while a wider page loads, since !searchData now shows it there too.

[DESIGN-REVIEWED] 1fbe749

Description read

[DESCRIPTION-READ] 182436b7db34fe234dbb6862f0e5983ee9eb3c4b5200c56658738a5bcd05ee5a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 1fbe74997d3afb5713a69dafd8b6cb56171be9f5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The rewritten search line still fails its job: the blind reader had "no idea what it really means" and read it as contradicting the other limit messages.

Watch

  • The search line was rewritten for clarity, and it still isn't clear. search_beyond_tree → "Results can include files past the 10,000-item limit" (shot-01, shot-02). The reader called it "just text… I can't tell whether this is good news… or a warning", and noted it "reads like the opposite of the others ('you'll see more' against 'you'll see less')". Making this line read plainly is one of the PR's four stated fixes. Users with big repos see it on every search over a capped tree, and it leaves them unsure whether files are missing. Fix: say outright that search reaches past the list, e.g. "Search also finds files the list can't show (over 10,000 items)".
  • The empty capped tree states the problem and offers no way forward. root_truncated → "Workspace too large to list: limit of 10,000 items reached" (shot-04). The reader: "It gives no next step: no button, and no hint to use the filter or search instead." The PR says this is on purpose, because the Filter box only covers listed items. But the screenshot shows a Name/Content switch right above the message, so the user still has no idea what they can do next. The friction is high: the panel is empty on every visit. Fix: if Content search or chat-side search reaches past the cap, name it in the empty state. If nothing does, say how to open a smaller folder.

Suggestions

  • In the finished search (shot-02), nothing replaces "Searching…", so the reader only guessed the search had ended. Show a short count such as "3 matches" when the search finishes.

[UX-REVIEWED] 1fbe749

Description read

[DESCRIPTION-READ] edebbf35fea075d7f6cfbe5519994ead11aa75a43de84b87037b958406b9b37e

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1fbe74997d3afb5713a69dafd8b6cb56171be9f5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1fbe749

Verdict parsed from the review's SHA-scoped output markers for commit 1fbe74997d3afb5713a69dafd8b6cb56171be9f5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1fbe74997d3afb5713a69dafd8b6cb56171be9f5: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1fbe74997d3afb5713a69dafd8b6cb56171be9f5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1fbe749

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1fbe74997d3afb5713a69dafd8b6cb56171be9f5: <one-sentence reason>

@bolichen97
bolichen97 force-pushed the fix/capped-tree-ux-16743 branch from a47c5c2 to 7c9b815 Compare October 14, 2026 22:59
@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=9aa51555f668
    self-added: no

fixed: The status row now also shows when this query has no answer of its own: isSearching && (matches.length === 0 || !searchData || (isPlaceholderData && !expanding)). Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=6f5c3a612358
    self-added: no

fixed: The rea then readme case is now covered: the refined query shows the previous placeholder rows under "Searching…" until its own answer lands. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=4d30c97060d0
    self-added: no

fixed: The test "announces the search still running..." now also types a refined query and asserts the status is back, then gone after the answer. That half is red without the isPlaceholderData clause. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=b112187df039
    self-added: no

fixed: Took the suggested isPlaceholderData signal, kept !searchData for the first query (no placeholder exists then), and excluded expanding, where the expand control already spins. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=3e9a3ba2bf39
    self-added: no

fixed: Confirmed: the Files rail shows this empty state above a local-only "Filter files…" box that cannot reach unlisted files. The string now states the fact, "Workspace too large to list: limit of 10,000 items reached", which is true on both surfaces. Screenshot re-captured. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=7e98a043f955
    self-added: no

rebutted: The row under "Searching…" is a real match: the tree lists that path, and mergeTreeMatches only adds paths the tree holds. "Searching…" says more may arrive, not that the listed rows are tentative. More copy here would widen the PR past its goal.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=a5b160f80909
    self-added: no

rebutted: This line renders only in tree mode, which requires the tab to sit at the project root (atProjectRoot), and the search is scoped to that cwd. So "whole workspace" is exactly the folder named on the path line directly above it.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

fixed: Not acceptable, agreed: a refined query kept the previous searchData, so the status never showed. The condition now also reads isPlaceholderData (outside expansion), with a test for the refined query. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=91b1040eabce
    self-added: no

fixed: Same root cause as the Design item: placeholderData kept the previous answer. The status now also shows on isPlaceholderData outside expansion, with a refined-query test. Fixed in 7c9b815.

@bolichen97

bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=4c25cd2d5937
    self-added: no

rebutted: The cap is workspace-wide, and "Some items not shown" names what the cap did: some of the workspace items, here this folder's, were not listed. This is the wording #16743 task 3 asked for, so one limit has one wording with the folder badge "some items not shown".

@bolichen97
bolichen97 force-pushed the fix/capped-tree-ux-16743 branch from 7c9b815 to 4cb68ec Compare October 14, 2026 23:48
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=a57ea011665e
    self-added: no

fixed: The line now names the scope the search really has: "Too many items to list here, so this searches all of this project" in all 12 catalogs. Frames re-captured. Fixed in 4cb68ec.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=89d70fd2310a
    self-added: no

rebutted: This empty state is one string shared by two surfaces with different tools: the folder panel has a server "Search files" box, the Files rail has a local filter plus Content (grep) mode. One string cannot name the right next step on both without being false on one (the round-1 UX finding). A per-surface hint or link is new UI beyond this copy-polish goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=e658b2f3b244
    self-added: no

fixed: Took the "this project" form; no {project} interpolation, since the panel header right above already names the folder. Fixed in 4cb68ec.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=f7d7e69df7c4
    self-added: no

rebutted: Content mode greps file contents, so it does not find a file by name and "Search by Content to find files" would mislead. A link into the folder panel is new navigation UI, out of this PR goal; the string states the fact, which is true on both surfaces.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: No flash on an uncapped tree: there treeFiltersLocally is true, so searching is false, the search query is disabled and isFetching never turns on. The row only shows while a real search request for the current query is in flight, after the 200ms debounce.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: No per-keystroke flicker: the query is debounced 200ms (SEARCH_DEBOUNCE_MS), so the status turns on once per settled query, and it stays a single fixed row above the placeholder rows, which are kept in place (placeholderData) rather than blanked. Captured in the during/results frames attached to the PR.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: The widened term also applies to a one-level listing search (off the project root), on purpose: there too a refined query shows the previous answer as placeholder rows until its own lands, so announcing "Searching…" is the same true claim. Same code path, same flags; the truncated-tree test exercises it.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=f8386fdb05c4
    self-added: no

accepted-and-deferred: One shared string cannot name a next step that is true on both surfaces (server "Search files" in the folder panel, local-only "Filter files…" in the Files rail). A per-surface hint or action is new UI, tracked in #20554 (deferred-finding, assigned, Due 2026-10-28).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=535aa1b433a3
    self-added: no

fixed: The "Searching…" status now renders below the listed matches, so the rows read as results and the status as "more may come". Frames re-captured. Fixed in f2209d5.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=44c158c8539d
    self-added: no

fixed: The search line no longer names a scope: "Too many items to list here, so the search also finds files not listed". Only the empty state says "Workspace", so one term remains. Fixed in f2209d5.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=c4c7d96f222a
    self-added: no

fixed: Took the intent (one term) without "whole workspace", which round 2 found ambiguous and the Opus lane found overclaiming (the server walk is budgeted). Fixed in f2209d5.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=4c25cd2d5937
    self-added: no

fixed: Agreed the walk is budgeted (_WALK_MAX_SCAN_SCOPED, _WALK_TIME_BUDGET_SECS). The copy now claims only that the search also finds files not listed, not that it covers everything. Fixed in f2209d5.

@bolichen97
bolichen97 force-pushed the fix/capped-tree-ux-16743 branch from f2209d5 to 1fbe749 Compare October 15, 2026 01:13
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=ba255bc50864
    self-added: no

fixed: The line now names what the reader can act on and the same limit as the other surfaces: "Results can include files past the 10,000-item limit". No "not listed where" left. 12 catalogs, frames re-captured. Fixed in 1fbe749.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=7863c05fe016
    self-added: no

fixed: Every new or changed string now names the same "limit of 10,000 items" (search line, folder row, empty tree), matching the unchanged top badge. The badge itself stays out of scope (Not a goal). Fixed in 1fbe749.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=127104fed549
    self-added: no

accepted-and-deferred: Same item as round-4 span f8386fdb05c4: one shared string cannot name a true next step on both surfaces. Tracked in #20554 (deferred-finding, assigned, Due 2026-10-28).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=89145b31834c
    self-added: no

rebutted: "Open a folder to browse it" has nothing to act on: this state renders only when the capped payload lists no row at all, so there is no folder to open. The per-surface next step is tracked in #20554.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: Intended: on a one-level listing search too, a refined query shows the previous answer as placeholder rows until its own lands, so "Searching…" is the same true claim. Same flags and code path as the capped tree; answered on the previous head as well.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

fixed: Yes: learn-cron-dashboard.md now quotes the new row copy, names root_truncated for the no-row state, and describes the new search line. docs-lint green. Fixed in 1fbe749.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=c3b0cae4175d
    self-added: no

fixed: The Project tree spec now says Some items not shown: limit of 10,000 items reached and that the no-row payload shows its own root_truncated sentence. Fixed in 1fbe749.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: While a wider page loads, react-query keeps the previous tier as placeholderData, so searchData is defined and !searchData is false; the placeholder term is gated by !expanding; and expanding needs rows on screen, so matches.length === 0 is false too. The row stays hidden there; only the expand control spins.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=76209eb01afc
    self-added: no

rebutted: This line has had five wordings across five rounds, each judged unclear by a different reading, and the last one was chosen to resolve the prior round (one limit, one wording; Opus: do not overclaim). It is accurate and names the same limit as the other surfaces. Another rewrite is churn, not a fix; the frozen goal is met. A maintainer may still prefer other copy.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=0703a269c71b
    self-added: no

accepted-and-deferred: Same item as spans f8386fdb05c4 and 127104fed549: one shared string cannot name a true next step on both surfaces. Tracked in #20554 (deferred-finding, assigned, Due 2026-10-28).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=0b2afdfcef3b
    self-added: no

rebutted: A match count is a new status element, not a reword of the four surfaces #16743 scopes. The finished state is shown by the status row going away and the matches header staying; adding a count is new UI beyond this PR goal.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by a maintainer who read the review lane notes and accepted them as follow-up work.

@bolichen97
bolichen97 merged commit 55b6825 into main Oct 15, 2026
101 of 102 checks passed
@bolichen97
bolichen97 deleted the fix/capped-tree-ux-16743 branch October 15, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX polish for the capped project tree: search status and limit copy

2 participants