Repository navigation
feat(files): give the empty capped tree a search next step - #21018
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 5e52e97 Description read[DESCRIPTION-READ] 2b67a8774687c55aea161c0c280840f9914cd4761a455bdc78b344675317af49 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Before merge, check that the box above the tree is still on screen when the capped tree is empty, in both the folder panel and the Files rail. What this change shipsInventory (2 items) — 2 justifiedIntent: when a project is too big to list, a user looking at the empty file tree learns that the box above it can still find their file. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 5e52e97 Description read[DESCRIPTION-READ] 80b3ecc8f02a51a3f0dfca375853b8a1f3f2fe11e054ae2bdeb69a017adc7dac That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check the hint line wrapping in the narrow Files rail: shot-03 shows the hint ending with "it." alone on its own line. [UX-REVIEWED] 5e52e97 Description read[DESCRIPTION-READ] 528cc8fdd531a8976a35bfeb2d2cc0c2a24b2dd1782142da8c2a5a2f307c7f06 That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bcf8633 to
c2d9672
Compare
|
|
|
|
c2d9672 to
41970ca
Compare
|
|
|
|
41970ca to
e230e8b
Compare
|
self-added: no
|
|
|
|
e230e8b to
8042033
Compare
|
self-added: yes
|
|
|
|
|
8042033 to
4ffc297
Compare
|
|
4ffc297 to
5e52e97
Compare
|
|
Problem / Motivation
Goal: When a project is too big to list and the tree has no rows, the folder panel and the Files rail each show one next step that works there.
The empty capped tree says "Workspace too large to list: limit of 10,000 items reached" and stops. It names what happened but not what to do. The same tree is shown by the folder panel and by the Files rail, and on both the search box above it can already find files past the limit (#20523 and #20495), but nothing points the user there.
Why it matters
A user on a very large project sees an empty panel with no way forward, even though the search a few pixels up would find their file. This is a follow-up deferred from the UX Review of #20495.
Not a goal
What changed (motivation → approach → change)
The empty capped tree had no next step. Both places that show the tree, the folder panel and the Files rail, put a box above it whose name query already goes past the cap (#20495, #20523). So the tree itself can point there.
website/src/pierre/PierreWorkspaceTreeImpl.tsx) adds one line under the limit message when the tree is capped and has no rows: "Type a file name in the box above to find it." It says "box", not "search box", because the rail's box is labelled "Filter files…".components.workspaceTree.root_truncated_search_hintinen.manual.json, all 12 translated catalogs and the regenerateden-XApseudolocale.Earlier heads used a focus button, then a host flag; review showed the button read as a copy of the box and the flag guarded a host that does not exist, so both are gone.
Backwards compatibility
Compatible: one new line of text in one empty state; no prop, API or behaviour changes.
Removes nothing: the diff only adds a line of text and a catalog key.
Tests
PierreWorkspaceTreeImpl.test.tsx: the empty capped tree shows the hint line under the limit message.Local gates: that file plus
FolderPanel.tree.test.tsx,FileBrowserRail.test.tsxandPierreWorkspaceTree.lazy.test.tsxpass (251 tests),tsc -p tsconfig.app.json, eslint on the changed files andnpm run i18n:checkare clean. The clone has no git hooks installed, so no commit hook ran.Manual verification
Driven in Chromium (scripted Playwright, real
FolderPanel, realFileBrowserRail, real Pierre tree and catalogs,/api/project/treestubbed to an empty capped payload and/api/file-searchto two hits), light and dark. On each surface the hint line shows under the limit message with the box directly above (asserted by its text); typing "invoice" in that box then lists the server's matches past the limit. The temporary capture entry was not committed.Screenshots / video
Folder panel, empty capped tree, then after typing in its search box:
Files rail, same steps:
Other theme
Related Issues
Closes #20554
Checklist