Skip to content

docs(changelog): cover the 0.9.0 release-branch backports - #20950

Merged
bolichen97 merged 1 commit into
release/0.9.0from
docs/changelog-0.9.0-backports
Oct 15, 2026
Merged

bolichen97 merged 1 commit into
release/0.9.0from
docs/changelog-0.9.0-backports

Conversation

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

What

Completes the ## [0.9.0] section so it covers the three fixes backported to release/0.9.0 after the section was written: #19189 (self-update fetch), #19309 (KAS reserved crewmate ids) and #20631 (a waiting tool no longer stalls the others). One paragraph is added at the end of ### Notable fixes. Every existing line, the heading and every other section are unchanged: 6 lines added, 0 removed.

This PR deliberately edits the in-flight [0.9.0] section. It is not a factual correction of shipped history: 0.9.0 stable has not shipped, and the stable GitHub Release body is extracted from this section, so it must describe what ships. The changelog-history gate flags the change for that reason.

Commits covered

Range 13a24b1..a9ec7fc on release/0.9.0: 3 user-visible backports, written up here; the other 6 commits are tests, CI and the 0.8.0 date fix, with nothing to describe.

This PR has no tracking issue: release PRs take issue-gate: waived.

Add one Notable fixes paragraph for the three fixes backported to release/0.9.0 after the section was written (#19189, #19309, #20631). Every existing line is unchanged.
@KiroCrewCaptain
KiroCrewCaptain requested a review from a team as a code owner October 15, 2026 21:02
@KiroCrewCaptain
KiroCrewCaptain requested review from bolichen97 and removed request for a team October 15, 2026 21:02
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d905096309ed1b4076b8b2b27b952954608f7d4c ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d905096309ed1b4076b8b2b27b952954608f7d4c touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of d905096309ed1b4076b8b2b27b952954608f7d4c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

This edits a section the immutability gate treats as shipped, and the only exception is the description's own argument; changelog.md records no in-flight carve-out.

Watch

  • Exception with no written rule. docs/build/changelog.md says "everything already in it is immutable", and check_changelog_history.py is described as flagging exactly this edit. The PR's case is "0.9.0 stable has not shipped". If that case is accepted only in this PR's text, the next person to edit a section mid-release has no rule to cite, and reviewers cannot tell an allowed edit from history loss. That is the failure the gate exists to stop.
    Clears when: changelog.md (same commit) states the rule that a section may be appended to until its stable tag is cut, or a maintainer overrides the gate in a PR comment.
  • Two copies can drift. The stable Release body is "extracted from this section" on the release branch. The doc also requires main's copy to be "byte-identical to the one on its release branch". If this lands on only one of main and release/0.9.0, either the stable body leaves out these fixes or main's section stops matching.
    Clears when: the same 6-line hunk lands on both branches, or the PR names the branch the stable body is extracted from and links the paired PR.

[DESIGN-REVIEWED] d905096

Description read

[DESCRIPTION-READ] 6793435c86e036574bd6bb066a61fa7902f4b929c103f9da4ba1f111dd7e238f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed d905096309ed1b4076b8b2b27b952954608f7d4c — this comment is updated in place on each push.

Blocking: this PR edits the existing ## [0.9.0] section of CHANGELOG.md without bumping the version, which the blocking changelog-is-written-at-version-bump-only rule forbids.

BLOCKING — CHANGELOG.md:181
+**Updates and agents.** The dashboard's Update and kirocrew update no longer
The PR only adds a paragraph inside ## [0.9.0] - 2026-10-09. __version__ stays "0.9.0-rc.1" and no other file changes, so this is neither a version bump nor a release cut → the rule says "FLAG any change to CHANGELOG.md in a PR that is not a version bump or a release cut", with blocking: true → the section changes after v0.9.0-insider.1….7 already shipped with the earlier text. docs/build/release.md § Changelog says "Editing the in-flight section after it is written needs the documented human override".
Fix: a maintainer applies the documented human override for editing the in-flight 0.9.0 section. Otherwise, drop the hunk and let the next release cut write these lines.

[BLOCK-MERGE] d905096
[OPUS-REVIEWED] d905096

Verdict parsed from the review's SHA-scoped output markers for commit d905096309ed1b4076b8b2b27b952954608f7d4c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d905096309ed1b4076b8b2b27b952954608f7d4c: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging d905096309ed1b4076b8b2b27b952954608f7d4c. Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- CHANGELOG.md:181 -- Standalone changelog edit requires a human override

Updates and agents. The dashboard's Update and kirocrew update no longer
Changelog-only PR -> appends to an existing section without a version bump or release cut -> violates the release-only changelog rule, even for an in-flight release.
Anchor: changelog-is-written-at-version-bump-only
Fix: Include these notes in the version-bump/release-cut PR, or obtain the documented human override for editing an in-flight section.
[BLOCK-MERGE] d905096
[GPT-REVIEWED] d905096

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

The finding is anchored to changelog-is-written-at-version-bump-only, and that rule is marked blocking: true in the base-branch snapshot (.review-base-rules/AUTOSDE.yaml:686-687). I don't weigh harm against remedy cost in that case. The rule's flag takes precedence.

F1, harm rung not weighed. Conditions confirmed: this PR's only change is 6 added lines in CHANGELOG.md, landing at CHANGELOG.md:181 inside the existing [0.9.0] section. The PR contains no version bump or release cut, which is what the rule flags at .review-base-rules/AUTOSDE.yaml:704-707. The real fix is cheap either way: move the paragraph into the release PR, or have a repository writer post an override.

[ADJUDICATION] d905096309ed1b4076b8b2b27b952954608f7d4c total=1 uphold=1 downgrade=0
UPHOLD F1 CHANGELOG.md:181 reason=autosde-blocking-rule
[GPT-ADJUDICATED] d905096309ed1b4076b8b2b27b952954608f7d4c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d905096309ed1b4076b8b2b27b952954608f7d4c: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@bolichen97
bolichen97 merged commit 8983b62 into release/0.9.0 Oct 15, 2026
21 of 25 checks passed
@bolichen97
bolichen97 deleted the docs/changelog-0.9.0-backports branch October 15, 2026 22:10
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants