Repository navigation
feat: rename the user-facing word crewmate to mate - #20965
Conversation
64d6b60 to
35b2f66
Compare
Sensitive Change ReviewSensitive files changed:
|
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a relabel. The only reason given is that "Crewmate" is long and repeats the product name, not that anyone was failing to find the feature. Because a maintainer signed the scope on #20937, it stays a note. Notes
What this change shipsInventory (8 items) — 6 justifiedIntent: users see the standing teammate agent called "Mate"/"Mates" everywhere they read it. This is an ADDITION (a relabel).
[FIRST-PRINCIPLES-REVIEWED] a9e5c81 Description read[DESCRIPTION-READ] 67ed83b394ade0737cb3a30d6cf24cd5cce64c770a64277aae74f8c64f0235d3 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
35b2f66 to
7d6a110
Compare
Sensitive change review
|
7d6a110 to
140025a
Compare
Sensitive change review
|
140025a to
8963f9b
Compare
Sensitive change review
|
Human judgment recorded@CrysisDeu marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Sensitive change review
|
|
/ai-review override design 0f58984: the lane failed closed on its 1 MB diff cap before reading anything; this PR is a copy-only rename of Crewmate to Mate (values, docs, test pins, regenerated files), screenshots are in the description, and the maintainer chose one PR over a split. |
12a9805 to
0f58984
Compare
|
/ai-review override ux 0f58984: the lane failed closed on its 1 MB diff cap before reading anything; this PR is a copy-only rename of Crewmate to Mate (values, docs, test pins, regenerated files), screenshots are in the description, and the maintainer chose one PR over a split. |
Human judgment recorded@CrysisDeu marked the design AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@CrysisDeu marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
buluoray
left a comment
There was a problem hiding this comment.
Re-approve at 0f58984 after the rebase onto 3d6cda4.
I compared this PR's own diff on the head I approved (4e6e07f) and on this one. The only new lines are the same crewmate → mate rename applied to text main added since (gui-user scenario selectors, the notifications and members spec paragraphs and the feature-map row); no identifier, i18n key, config key or API path moved, and the en catalogs still have no user-visible "Crewmate" left (only key names such as runs_as_crewmate, which the scope keeps).
Before merge: the branch now conflicts with main in src/kiro_crew/docs/ui-index.generated.json, a generated file, so regenerate it after rebasing rather than hand-merging.
Nit, not blocking: website/scripts/capture-agent-template-pane.mjs:193 still matches /used by this crewmate only/i. No UI string with that text exists on this head any more (the pane it captured was removed by #21748), so the capture script is stale either way; it sits outside CI.
Everywhere a person reads it, the standing teammate agent is now a Mate
(plural Mates): the Mates page, roster, create/edit/delete dialogs, chat
header, settings rows, change-card titles, thread error text and the
user-facing docs. Only values change in the i18n catalogs; keys, code
identifiers, API paths, data-file names and the crewmate.* card kinds keep
their spelling.
Translations keep the teammate sense they already carry (队友, compañero,
coéquipier, colega, напарник, compagno, साथी, সঙ্গী). Where a catalog had
leaked the English page name ("open Crewmates") it now names the page by
that locale's own title. Catalogs that use a loanword for the English term
(クルーメイト, 크루메이트, German Crewmate) are left as they are.
The two Settings rows whose derived registry ids carried the word move to
developer.mates and developer.reply-threads-on-mate-chat-messages; the old
ids are added to LEGACY_ID_EXACT so bookmarks and palette history keep
their highlight. en-XA, the settings registry, the ui index and
config-baseline.json are regenerated.
A decisions entry records the word; the maintainer restates it on the PR.
Closes #20937
Sensitive change review
|
|
/ai-review override design a9e5c81: the lane failed closed on its 1 MB diff cap before reading anything; this PR is a copy-only rename of Crewmate to Mate (values, docs, test pins, regenerated files), screenshots are in the description, and the maintainer chose one PR over a split. |
|
/ai-review override ux a9e5c81: the lane failed closed on its 1 MB diff cap before reading anything; this PR is a copy-only rename of Crewmate to Mate (values, docs, test pins, regenerated files), screenshots are in the description, and the maintainer chose one PR over a split. |
0f58984 to
a9e5c81
Compare
Human judgment recorded@CrysisDeu marked the design AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@CrysisDeu marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Everywhere a person reads it, the standing teammate agent is called a Mate (plural Mates) instead of a Crewmate.
"Crewmate" is long, and its first half repeats the product name. The self-record MCP server is already
kirocrew-mate, so the surface and the plumbing disagree. Scope was set on #20937: copy and docs only, and translations keep the crewmate/teammate feel they already carry.Why it matters
The word is on the sidebar, the page title, every create/edit/delete dialog and most of the user-facing docs. A shorter word that matches the rest of the product reads better on every one of those surfaces.
Not a goal
crewmate_*functions,CREWMATE_*constants, component and test names, i18n keys, API paths, data-file names, thecrewmate.*change-card kinds. Users never see them, and renaming them touches about 700 files and persisted state.CHANGELOG.md(the release PR writes it).What changed (motivation → approach → change)
Goal → change the word only where it is read → three layers:
en.json,en.manual.jsonanden.context.json: Crewmate → Mate, Crewmates → Mates. In the ten translated catalogs, the English page name had leaked into a few strings ("open Crewmates", "los crewmates"); those now use that locale's own teammate word (队友, Compañeros, Coéquipiers, Colegas, Напарники, Compagni, साथी, সঙ্গীরা, クルーメイト, 크루메이트). Nothing else in those catalogs changes.config/sections.py, change-card titles and refusals, thread and goal-reminder text, team errors, security-posture labels, guide catalog titles, the welcome prompt. The welcome prompt now says "the first teammate on their crew", not "their first mate", so the model is not handed the ship rank.template.htmldraws ("mate wrote this", "What this mate is doing", empty-state hints) and eachmanifest.jsondescription. Comments and field keys such ascrewmate_wroteare unchanged.dashboard/goal_setup.pycompares the goal reminder's skip reason by its text, so it now names the new wording too.memberssurface's English machine value insurfaces/surfaceData.tsis nowMates.docs/system-specs,docs/architecture,docs/ci,docs/reference,docs/feature-map,docs/build,website/docs,src/kiro_crew/docsandAGENTS.md. Inline code, link targets and fenced blocks are left alone. Two renamed headings had anchor links pointing at them; both links are updated.Settings registry ids are derived from the label, so two ids moved:
developer.crewmates→developer.matesanddeveloper.reply-threads-on-crewmate-chat-messages→developer.reply-threads-on-mate-chat-messages. Both old ids are added toLEGACY_ID_EXACT, the table that already maps the card's two earlier ids, so a bookmark or palette history entry still lands on the right row.Generated files are regenerated, not hand-edited:
en-XA.json, the settings registry (TS + JSON),ui-index.generated.json,guidePlans.gen.ts,config-baseline.json.A new decisions entry,
docs/decisions/2026-10-15-the-standing-teammate-agent-is-called-a-mate.md, records the word. The four existing entries that say "crewmate" stay byte-identical.Backwards compatibility
Compatible: config keys, API paths, i18n keys and stored data keep their names. The two settings ids that moved are aliased in
LEGACY_ID_EXACT, so old deep links still highlight their row.Reader: website/src/hooks/useSettingHighlight.ts:LEGACY_ID_EXACT -- crew page -- maps
developer.crewmatesanddeveloper.reply-threads-on-crewmate-chat-messagesonto the current ids;settingHighlightAliases.test.tspins that no alias key is a live idReader: website/src/uiLocations/descriptors.ts:PREVIEW_FLAG_ENABLERS -- crew page -- names
developer.mates, the id the registry now emits;members.locations.test.ts,uiIndex.test.tsReader: src/kiro_crew/docs/ui-index.generated.json:guide_gates -- chat -- regenerated from the same descriptor;
test_find_ui_members.py,test_guide_select_gate.py,test_guide_ui_show.pyTests
No new behaviour, so no new tests. Existing assertions that pin English copy now pin the new words: website component tests, Playwright specs, backend tests that match refusal text, GUI-user scenario prose. Tests that pin the moved settings ids now name
developer.mates.Manual verification
Built the SPA and booted an isolated pod from this worktree. On each frame below, the capture script asserted that the page shows "Mates" and that no "crewmate" text is rendered anywhere on the page.
Local static gates run green:
tsc,eslint,npm run i18n:check(diff-scoped), black, isort, flake8, mypy, docs lint, and the decisions, feature-map, brand and comment-history gates. The test suites are left to CI.Screenshots / video
Customize, Mates tab:
Mates page:
New mate dialog, Settings → Developer, zh-CN keeps 队友
Related Issues
Closes #20937
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.