Skip to content

feat: bring back the Crew Mode switch above the chat input - #21526

Closed
iamwhatever wants to merge 1 commit into
mainfrom
feat/restore-crew-mode
Closed

iamwhatever wants to merge 1 commit into
mainfrom
feat/restore-crew-mode

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let any user turn a chat into a Conductor with one switch next to "Choose memory mode", and see in plain words what it does.

The Conductor (kirocrew-conductor) splits a goal into tasks, runs each in its own chat, and reports back. Today the only way in is the agent picker, which lists several conductor agents under technical names, so most users never find it. The Crew Mode switch that fixed this shipped in #16088 and was backed out the same day in #16257, because it merged before it was meant to land. It never came back.

Why it matters

The Conductor is how a big goal gets split up and tracked without the user reading every transcript. Hidden behind the agent picker, almost nobody who would benefit from it reaches it. One visible switch, and a page that says what it does, is how a user learns it exists.

Not a goal

  • A new agent spec or new tools. Crew Mode runs the existing kirocrew-conductor unchanged.
  • Changing the Conductor's prompt or the other conductor specs (pipeline, security, ledger alias).
  • Connecting the welcome page's sample board to a real work ledger. It is a labelled Example.
  • A Crew Mode field on sessions. The chat's agent already says it.

What changed (motivation → approach → change)

Users cannot find the Conductor in the agent picker, so a Crew Mode switch now sits next to "Choose memory mode", one click away, with a page that says what the Conductor does. One switch, same chat. A chat is in Crew Mode exactly when it runs on kirocrew-conductor; nothing else stores it. Turning it on is the ordinary agent switch, in the template namespace, so memory and history stay. Turning it off sends the same switch with no agent name, so the server puts the chat back on the configured default template.

Part Where What the user sees
Crew Mode chip components/CrewModeChip.tsx, pages/chat/page/crewModeSwitch.ts, ComposerDockView.tsx On a new chat, right of "Choose memory mode", reading "Crew Mode: split into tasks" ("Crew Mode" on a phone). Once the chat has messages it stays only while Crew Mode is on, so it can be turned off; a plain chat that is off has no chip. While a reply runs it keeps its look and its hint says "Available after the reply."
Mid-chat note ComposerDockView.tsx With the mode on in a chat that has messages, a line beside the chip says "Turning off Crew Mode won't stop the chats it opened."
Welcome page components/CrewModeWelcome.tsx, ChatTranscriptView.tsx An empty Crew Mode chat says what the Conductor does, above a sample board marked Example
Memory switch pages/chat/memoryModeSwitch.ts Leaving Persistent also leaves the Conductor

The switch shows only on a plain local Persistent chat that runs the default template or the Conductor. It never shows in a crewmate's chat, an app's chat or a mode session. Incognito and Temporary chats are left out, because such a session may not create sessions (ephemeral_caller in dashboard/session_control_parts/session_create.py). It is also hidden when kirocrew-conductor is itself the default agent (agent.default_agent), because off would have nothing to switch back to. That default is already the way to start every new chat on the Conductor, so this PR adds no setting.

The switch is a ChatPage owner hook. It waits for the transcript to load, so it never slides across the memory chip. No default changes: a chat a user never touches is exactly what main shows, on the welcome state and after the first message alike.

Docs say the same in session.md, learn-cron-dashboard.md, crew-mode.md, agents.md, work-ledger.md and a feature-map row. i18n adds 25 keys to all 12 catalogs in i18n/locales/ and to en-XA; "Crew Mode" joins the do-not-translate list in i18n/glossary.json.

Backwards compatibility

Compatible: no route, field, config key or value changes; the switch calls the existing POST /api/chat/slots/{slot}/agent, and off uses its existing empty-name form, which stamps the default template.

Reader: website/src/pages/chat/memoryModeSwitch.ts:runMemorySwitch -- chat -- a kirocrew-conductor template chat switched to Incognito or Temporary is now recreated on the default template instead of the Conductor, which could not create sessions there; ChatPage.crewMode.test.tsx "leaves the conductor when the chat switches to Incognito", and "keeps a plain chat on its agent when it switches to Incognito".

Tests

  • test/test_crew_mode.py: the Conductor prompt still carries its introduction and task board.
  • lib/crewMode.test.ts: Crew Mode runs on kirocrew-conductor; the empty name and the configured default count as the default agent; only a Persistent chat qualifies.
  • CrewModeChip.test.tsx: aria-pressed, click and disabled. Off shows one label at a time ("Crew Mode" below sm, "Crew Mode: split into tasks" from sm up), and the on hint says what turning it off does. While a reply runs the chip keeps its on look and shows the busy hint; any other disabled state fades it. The welcome page has its title and four labels; its Example board has no buttons and no sample answers; its sample question has no warning tone, its ghost circles and question icon tile are muted, and its state words are muted text, with each tone on the circle beside the word.
  • ChatPage.crewMode.test.tsx: the chip sits right of the memory chip on the welcome state; on goes through chatSlotAgent(slot, 'kirocrew-conductor', 'template') and swaps in the welcome page; off mid-chat goes through ('', 'template') and the chat ends on the default the server names, also while the agent catalog is unavailable. Mid-chat with the mode on, the note is shown and named by the chip's aria-describedby; on the welcome state and mid-chat with the mode off the chip shows no note, and mid-chat with the mode off the chip is absent entirely. It is not offered on another agent, a crewmate chat, a crewmate named kirocrew-conductor, an Incognito chat, an app chat, an orchestrator-mode session, or when the Conductor is the default agent. A Crew Mode chat switched to Incognito is recreated with no agent, and a plain chat keeps its agent.
  • ChatPage.memoryChip.test.tsx: the memory chip and its row leave once the chat has messages. ChatPage.pageOwners.test.ts: useCrewModeSwitch sits in the page's owner call order.

Determinism, per testing-conventions § Proving a determinism fix:

Manual verification

Built this branch's SPA (npm run build) and drove it in headless Chromium against a stubbed gateway, with a capture script kept out of the repo. The script fails a scene when a check below does not hold.

  • A new chat shows "Crew Mode: split into tasks" right of "Choose memory mode". The two chips arrive together and do not overlap.
  • Clicking it sends the template agent switch, and the Crew Mode page pops in.
  • After the first send, while the mode is on, the memory chip leaves and the Crew Mode chip stays. While the reply runs it is disabled, keeps opacity 1 and aria-pressed="true", and its hint reads "Available after the reply."
  • A plain chat mid-conversation with the mode off shows no chip and no chip row -- the composer is exactly as on main.
  • Mid-chat with the mode on, "Turning off Crew Mode won't stop the chats it opened." sits beside the chip on desktop and wraps under it at 390px, without overlapping it or leaving the screen.
  • At a 390px phone width the off chip reads "Crew Mode" and fits beside the memory chip. With it on, the whole sample board, border included, ends 33px above the chip row.
  • Checked in light and dark themes; in the dark theme every state word (Done, Working, Needs you, Waiting) reads at 5.66:1 against the page.

Ran the kirocrew prepare-pr gate floor and the diff-scoped test surfaces locally against origin/main (b290c522e7): 0 failing gates (isort, flake8, mypy, the i18n check and render, the SPA build, bundle-size and chunk-cycle checks, the Electron smoke test, docs lint and the repository's static guards); the frontend scoped suite is 483 files / 13,053 tests green; the backend tests tied to the diff (152 files, 7,669 items) are 7,666 passed and 3 skipped on 2 workers; the flake-pattern ratchet passes (58 tests); and semgrep finds nothing on the 13 changed files. The rest of the backend suite runs on CI's shards.

Screenshots / video

A new chat, Crew Mode off:

A new chat with the Crew Mode chip right of Choose memory mode

Crew Mode on, the welcome page:

Crew Mode on: the welcome page

Mid-chat with the mode on, the note beside the chip:

Mid-chat: the Crew Mode chip and its note

A plain chat mid-conversation with the mode off: no chip, the composer as on main:

Mid-chat, Crew Mode off: no chip

The whole flow: turn it on, then the first send. The memory chip leaves, the Crew Mode chip glides over, and its note appears.

08-flow.webm
After the first send, phone and dark theme

Right after the first send: the chip keeps its on look while the reply runs

Phone width, Crew Mode off: the short label

Phone width, Crew Mode on: the board fits above the chips

Phone width, 3x: the board's bottom border and the chip row

Phone width, mid-chat: the note wraps under the chip

Dark theme, Crew Mode on

Related Issues

Closes #21503

Follow-up: #21531 (agent labels still show the code name kirocrew-conductor).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 17, 2026 07:11
@iamwhatever
iamwhatever requested a review from CrysisDeu October 17, 2026 07:11
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 74e851b9595ce40abd2af7321b6ac50d4f4b090d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm a maintainer has approved bringing Crew Mode back. #16257 removed it because it merged before it was meant to land, and this PR records no sign-off.

[DESIGN-REVIEWED] 74e851b

Description read

[DESCRIPTION-READ] 24be0d1aef5d45e645a465f3c5d4dcab5aac660f1e9c12bd7d66d2e521c78887

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 74e851b9595ce40abd2af7321b6ac50d4f4b090d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The sample board looks like live work waiting on the user, and the "kirocrew-conductor" label is unexplained jargon that appears the moment the mode turns on.

Watch

  • The sample board reads as real. In CrewModeWelcome, "Which day works for you?" and the warn-tinted "Needs you" circle sit under a small muted "Example" pill. The blind reader said: "The question and 'Needs you' look like something real is waiting on me, and the word 'EXAMPLE' is small and easy to miss". On the phone (shot-07) they said the circles "look like real status buttons". The tasks "Email, Layout, Room, Screenshot" also don't match anything the user asked for. Severity: every first Crew Mode chat, which is the first impression of the feature, and the reader hesitated.
  • The label changes to "kirocrew-conductor" with no explanation. Turning the chip on swaps "kirocrew" for "kirocrew-conductor" in both the Sessions list and the composer. The blind reader had "no idea what 'conductor' means… I'd leave it alone". They also could not tell whether shot-03 and shot-04 showed the same chat. Severity: shows on every Crew Mode chat, and it undercuts the PR's "one switch, same chat" promise.
  • The note leaves the user stuck. "Turning off Crew Mode won't stop the chats it opened." names those chats but gives no way to find or stop them. The reader: "none show up in the Sessions list, so I don't know where to find them or how to stop them". Severity: hit by every Crew Mode run, and the user loses control of running work.

Suggestions

  • In the welcome capabilities, change does_take_asks "Takes requests" to "Asks you questions". The reader couldn't tell who the requests come from.
  • Make the "Example" pill larger and give it full contrast, and drop the warn tone from the "Needs you" circle so the board reads as a picture.
  • Next to chip_off_keeps_chats, add a link to where the opened chats are listed.

[UX-REVIEWED] 74e851b

Description read

[DESCRIPTION-READ] a53a7a5b7394beaf62bf3d11459c0ea17a3e534f6c0a65e804ae5be563dff01b

That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 74e851b9595ce40abd2af7321b6ac50d4f4b090d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The Crew Mode welcome page ships an animated, fake-data "Example" board. The Goal asks for plain words, and the title, tagline and four labels already give them.

Not justified as shipped

  • Item 4 — oversized: the Goal asks a user to "see in plain words what it does". CrewModeWelcome.tsx adds more than words: 8 CREW_GHOSTS, pulsing rings, and a sampleCrew() board with four made-up tasks and a sample question. That adds 12 i18n keys (board_*, sample_*, state_*) to each of 13 catalogs. The diff then spends comments and tests making sure the board is not mistaken for real work.
    Subtraction: delete the <section> sample board, sampleCrew(), CREW_GHOSTS/PoppingGhost, the ring loop and their 12 keys. Keep the title, tagline and capabilities() list.
    Clears when: the sample board and decorative animation are removed, or a human amends the Goal to include them.

What this change ships

Inventory (8 items) — 7 justified

Intent: let a user turn a chat into the existing Conductor with one visible switch and learn what it does. ADDITION.

  1. New "Crew Mode: split into tasks" chip to the right of "Choose memory mode" on a new Persistent chat — justified
  2. Once the chat has messages, the chip stays only while Crew Mode is on, so it can be turned off — justified
  3. Mid-chat note "Turning off Crew Mode won't stop the chats it opened" — justified
  4. An empty Crew Mode chat shows a welcome page with animated art and a sample "Example" board — oversized
  5. Switching a Conductor chat to Incognito or Temporary now recreates it on the default template — justified
  6. No chip in crewmate, app, mode or remote chats, or when the Conductor is the default agent — justified
  7. Shorter "Crew Mode" label on phones — justified
  8. Spec, user-doc and glossary entries describing the switch — justified

[FIRST-PRINCIPLES-REVIEWED] 74e851b

Description read

[DESCRIPTION-READ] e3afa54a05c0ec0153ab40628e3e2001e27f7ca5a3bf25ab89e3682db86d981d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 74e851b9595ce40abd2af7321b6ac50d4f4b090d — this comment is updated in place on each push.

Review details

No findings. No blocking issues; one advisory finding.

FINDING — website/src/pages/chat/page/crewModeSwitch.ts:32 — when agent.default_agent is kirocrew-conductor, the server stamps every plain chat as the kirocrew-conductor template. While the catalog is loading or after it fails to load, defaultAgent is '' (useAgents.ts:74), so the guard defaultAgent !== CREW_MODE_AGENT passes. The chip then shows "Crew Mode on" even though the switch should be hidden in this setup. Clicking off sends switchAgent('', 'template'), and _default_template_stamp puts the conductor straight back, so the switch does nothing → Fix: also require defaultAgent !== '' in crewModeEligible.

[OPUS-REVIEWED] 74e851b

Verdict parsed from the review's SHA-scoped output markers for commit 74e851b9595ce40abd2af7321b6ac50d4f4b090d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 74e851b9595ce40abd2af7321b6ac50d4f4b090d: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 74e851b9595ce40abd2af7321b6ac50d4f4b090d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 74e851b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 74e851b9595ce40abd2af7321b6ac50d4f4b090d: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Real Adapter Contract Tests is red on main, not from this diff: #15909 bumped @agentclientprotocol/codex-acp to 2.2.2 and test/test_codex_session_mcp.py::test_the_installed_adapter_still_builds_the_frames_the_refusal_reads fails on main the same way (#21529). The fix is #21530. This PR waits for it and takes no override for that lane.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Settings default for new chats is oversized span=13d6c6abcf82

fixed in 8ba694a: the "Turn on Crew Mode for new sessions by default" setting (dashboard.default_crew_mode) and its new-chat wiring are removed.
agent.default_agent = kirocrew-conductor already starts every new chat on the conductor; with it set, the switch is not offered.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Undeclared "Could not start a new session" notices span=3517e825a4d8

fixed in 8ba694a: removed together with the setting. The flyout New and empty-pane create sites are byte-identical to main again.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The chip's purpose is a guess span=e24d29e39dc1

fixed in 8ba694a: off, the chip reads "Crew Mode: split into tasks" from sm up (chip_off_explained), and just "Crew Mode" on a phone, where the row is narrow.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Turning it on swaps the agent label to a code name span=727443400e1d

accepted-and-deferred: #21531. The agent label shows each agent's spec name on 7 surfaces, so a friendly name for the conductor is its own change.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The × mid-chat feels risky span=c7716f76c0e5

fixed in 8ba694a: the on hint (chip_hint_on) says "Turn off Crew Mode. This chat goes back to the default agent; chats it already opened keep running."

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The welcome page invites clicks on things that do nothing span=15ba1ca6673b

fixed in 8ba694a: the four capability icons are bare, with no filled circles, and the "Today · Tomorrow" answers line is gone. The board stays marked Example.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Status words are hard to read span=f6bc5db32060

fixed in 8ba694a: the board no longer carries opacity-70. Only the ghost circles are muted; names and states render at full contrast.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • On a phone, the chips cover the example span=7e7419e4f70d

fixed in 8ba694a: below sm the art row is 88px tall, the title text-4xl and the tagline text-base.
At 390x844 the board ends at y=667 and the chips start at y=673; the capture script fails the scene if they overlap.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • New chat with the default on when the conductor is missing

fixed in 8ba694a: the default_crew_mode setting is removed, so no new-chat path names kirocrew-conductor; new chats are created exactly as on main.
The conductor is reached only through the composer switch, the ordinary POST /api/chat/slots/{slot}/agent; a refused switch shows the shared agent-switch notice (sessionPicks.ts switchAgent).

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Chip stuck on when the conductor is the default template span=f7d844fcf134

fixed in 8ba694a: useCrewModeSwitch does not offer the switch when defaultAgent === CREW_MODE_AGENT (crewModeSwitch.ts), so off never points back at the conductor.
Test: ChatPage.crewMode.test.tsx "is not offered when the conductor itself is the default agent".

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Main is red on the same tests this head fails, so these are not from this PR:

Check on this PR Failing test Also red on main Fix in flight
Backend Tests (3.12, 4), Backend Tests (Windows) (4) test/test_extras.py::test_requirements_match_setup_cfg[teams] (PyJWT 2.13.0 vs 2.15.0) CI run 39013484491 on 22a0b6496c #21542; #21538, #21543, #21544
Frontend Tests (2), Frontend Coverage Merge src/test/MarkdownRenderer.domGolden.test.tsx "renders the prose document" (katex snapshot) CI run 39013484491 on 22a0b6496c #21535; #21536
Real Adapter Contract Tests codex-acp 2.2.2 frames as noted above #21529; #21530

No override and no fix here. This PR rebases once those land.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Conductor chats moved to Incognito or Temporary land on the default agent

intended, and recorded as the PR body's Reader: line: an Incognito or Temporary session may not create sessions (ephemeral_caller), so a conductor there could not conduct. That holds for a conductor chat opened from the agent picker too, since a chat on kirocrew-conductor is a Crew Mode chat by definition.
Only the template conductor moves: memoryModeSwitch.ts checks agent_kind !== 'member', so a crewmate named kirocrew-conductor keeps its agent.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 17, 2026
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. An empty chat with it on shows the Crew Mode welcome page.
The switch is not offered when the conductor itself is the default
agent, since off would have nothing to switch back to. There is no new
setting, route, config key or session field.

Re-lands the switch backed out in #16257 on the current page owners.

Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com>
@iamwhatever
iamwhatever force-pushed the feat/restore-crew-mode branch from 6cfcac7 to 74e851b Compare October 17, 2026 19:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The opened chats can't be found or stopped. span=437b8e2f1ae7

rebutted. The chats the Conductor opens are ordinary sessions. They appear in the sidebar under the goal's folder, each with the same stop square as any chat; opening one and pressing stop stops its reply. Crew Mode adds no new run or stop path, so there is nothing new to surface here.
The note beside the chip only says that turning the mode off in this chat does not reach into those chats; it is a warning, not a dead end.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The sample board looks live. span=0b55eeb27d20

rebutted. The board is a static, labelled Example: no buttons, no real answers, tied to no ledger, with fixed sample tasks (Email, Layout, Room). Each state word is muted text, and a tone shows only on the small circle beside it, so the board reads as an illustration of what a real one looks like.
Round 5 raised the muted circles from opacity-40 to opacity-60 so they read on dark themes while staying a step below the active circles. A realistic "Needs you" state is what shows the reader what the board reports.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The phone label doesn't say what the chip does. span=fe29ac0c1e64

rebutted, on space. At 390px the row already holds the memory chip and the Crew Mode chip side by side; a longer label wraps the row or pushes the mid-chat note onto a second line. The full "Crew Mode: split into tasks" shows from sm up (chip_off_explained), and below sm the welcome page, one tap away, says what it does in full.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • "Conductor" is unexplained jargon. span=9d4d12273e82

Two parts. The chip hints no longer say "Conductor": round 5 reworded chip_hint_off and chip_hint_on to speak only of Crew Mode and normal chats.
The visible agent label still changing from "kirocrew" to "kirocrew-conductor" is accepted-and-deferred: #21531. That label comes from agentOrDefaultLabel, which feeds 7 surfaces and takes no agent kind, so a friendly name for the conductor is its own change.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • chip_hint_off wording span=e97182340bf1

fixed in 74e851b: chip_hint_off now reads "Turn on Crew Mode: each task runs in its own chat and reports back here." -- the suggested wording, with "Conductor" dropped. Regenerated across all 12 catalogs and en-XA.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • chip_hint_on wording span=6b09f6d118e5

fixed in 74e851b: chip_hint_on now says "Turn off Crew Mode. This chat becomes a normal chat again; chats it already opened keep running." -- "default agent" replaced with "a normal chat", as suggested.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • CrewModeWelcome muted circle opacity span=f03684e284c3

fixed in 74e851b: the near-invisible opacity-40 muted circle is raised to opacity-60, a step below the active circles' opacity-70, so it reads on dark themes (shots 05 and 09) while keeping the muted/active distinction.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 74e851b. Crew Mode stays a view over the existing kirocrew-conductor agent with no new state. Turning it on calls the same switchAgent path the agent picker uses, in the template namespace; turning it off sends the empty name and the server sets the configured default template (agent_switch.py, stamped_default = not agent_name), so the chip and the picker cannot disagree and off works while the agent catalog is unavailable. The Incognito and Temporary handling in memoryModeSwitch is declared in the Reader line. docs/decisions has no entry recording the removal; the backout in #16257 was only about timing and said the switch would return in a fresh PR, so nothing needs superseding.

Ran on the head: the crew mode, chip, page owners and memory chip vitest files (57 passed), test_crew_mode.py, i18n-check and check-i18n-strings; all 25 keys are in every catalog and en-XA. Mutating the memory switch leaving the conductor, the conductor-as-default guard, the crewmate-name guard, off sending the empty name, and the Persistent gate each turns a named test red. CI: 89 passed, 11 skipped, 0 failed.

Follow-ups, non-blocking:

  1. Test gaps: the local slotRunning term in busy, the instance_id gate for remote-instance chats, and the slotLoading hold on the chip can each be removed with no test going red.
  2. Accessibility: the button name changes with state (Crew Mode vs Crew Mode on) while aria-pressed also changes, so a screen reader announces both; a stable name plus aria-pressed is the usual pattern. The busy and on hints live only in title, and the busy one is on a disabled button, so keyboard and touch users never reach it.
  3. First Principles shows CONCERNS on this head and its dispositions cover only earlier heads.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Require to collaborate with the marketing, so let us pause for now.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 18, 2026
@bolichen97
bolichen97 deleted the feat/restore-crew-mode branch November 6, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring back the Crew Mode switch above the chat input

2 participants