Repository navigation
refactor(dashboard): split security, memory and messaging handlers - #21619
Conversation
Sensitive change review
|
Sensitive Change ReviewSensitive files changed:
|
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] f3087da Description read[DESCRIPTION-READ] 5d3fcc29164825c34a8a4a50e3550748d3f472843e7c8edb47f56c9ee9ed0bd6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the deliberately small owners ( What this change shipsInventory (8 items) — 8 justifiedIntent: bring three dashboard handler files under the 2,000-line cap with no behaviour change. This is a refactor (ADDITION of files only, no new capability).
[FIRST-PRINCIPLES-REVIEWED] f3087da Description read[DESCRIPTION-READ] d49b707e3ed0e04f02a147e2ddc3da8a2c1d192b1ca9f1aaaeb643f5a7d11bc5 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the maintainer: code-move refactor held by the cron on a README touch or the file cap alone. Every review lane on the current head is clean (only PR Scope size notes).
45e58d9 to
984008a
Compare
|
|
handlers/security.py (2,807 lines), messaging.py (2,789) and memory.py
(2,694) were over the 2,000-line cap for hand-written files. Each keeps
its path as the only import path and patch surface; the moved code
lives in owners by responsibility.
security.py (895) and memory.py (1,555) become mirror facades
(kiro_crew._facade_mirror): security keeps the denied-commands surface,
with owners security_{audit,trusted_apps,governance_policy,
trusted_registries}; memory keeps the document, settings, vector-tier,
migration, consolidation and graph routes, with owners
memory_{services,embeddings,graph}. messaging.py (1,102) composes five
more messaging_api owners: browser_routes, channel_config_writes,
slack_workspace, channel_folder_backfill and agent_push.
Moved bodies are unchanged apart from listed comment and docstring
rewordings for the comment-history and brand gates, and phrases that
named the one-module layout. Path-keyed guards follow the moved code
(census, stays-in-facade and facade-defs pins re-keyed per ruling);
specs gain owner maps; new facade tests pin patch reach and the kept
code, and new route tests cover the browser command bus.
Part of #20192
984008a to
f3087da
Compare
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Every review lane on the head is clean (only runner notices and PR Scope size warnings); held by the triage cron on size or path rules alone. Approved on the watch holder's request.
Problem / Motivation
Goal:
dashboard/handlers/security.py,memory.pyandmessaging.pyeach fit under the 2,000-line cap, with every route, import path and test patch working exactly as before.security.pyhad grown to 2,807 lines,messaging.pyto 2,789 andmemory.pyto 2,694, all over the repository's 2,000-line rule for hand-written files (all three were listed in.github/file-line-cap-baseline.txt).messaging.pychanged 14 times in the last week, so it is where the next feature would land.Why it matters
A file this size is hard to review and easy to merge-conflict, and the line cap only shrinks: until these files are split, every change to the Security settings API, the memory API or the messaging routes adds to three of the largest files the dashboard has. Splitting them by responsibility gives each new piece of work an obvious home.
Not a goal
What changed (motivation → approach → change)
security.pyandmemory.pybecome mirror facades (kiro_crew/_facade_mirror.py, the campaign's shared mechanism): the original path stays the only import path, the moved code lives in sibling owner modules, and a patch through the facade still reaches every module that reads the name.messaging.pywas already a compose facade overdashboard/messaging_api/; five more owners join its_facade_composetuple, so their functions still run on the facade's globals.handlers/security.py2,807 → 895security_audit65 (SEL audit,ConfigCorruptError, off-loop runner),security_trusted_apps1,119,security_governance_policy391,security_trusted_registries579handlers/memory.py2,694 → 1,555memory_services100 (SEL accessor, the gateway's vector store),memory_embeddings1,030 (model choice, status, enable),memory_graph192 (graph builder)handlers/messaging.py2,787 → 1,144api_send_message, the Teams activity route, the iMessage save entry, the module state,_write_env_off_loopmessaging_api/:browser_routes726,channel_config_writes427 (the rest of the shared channel-config transaction and.envwrites),slack_workspace381 (pins, reactions, profile, manifest),channel_folder_backfill122,agent_push178What stays in each facade is what repository checks read in that file: the denied-commands parsing a
code-review.ymltripwire greps by path, the memory routes that path-keyed inventories name, and the send route with its census sites and turn dispatch._write_env_off_loopstays inmessaging.pybecause main's open code-scanning alert #1091 (py/stack-trace-exposure) sits on it, so the alert stays at the path where main tracks it. Three owners are under 150 lines on purpose:security_auditandmemory_servicesare the lowest layer the other owners import (owners never import their facade), andchannel_folder_backfillis one route with no existing owner it belongs to. Specs gain owner maps; definition-site citations name the owners; path-keyed guards are re-keyed (see "Guard changes").Backwards compatibility
Compatible: every name each facade bound at the merge-base still resolves on it as the same object (
test_campaign_facades_base_public_names,test_handlers_messaging_composition_contract); the mirror facades serve owner-bound names and route writes to every holder.Logger (L25): every security and memory family member binds
logging.getLogger("kiro_crew.dashboard.handlers.security")/("...memory")by literal name, sorecord.nameand thecaplogfilters keyed on it are unchanged, and the mirror installs underpython -m. Messaging owners log through the facade'slogger, as before.Class
__module__:ConfigCorruptErrorandTrustSettingOverlayOwnedkeep the facade's__module__(pinned bytest_the_moved_exceptions_keep_the_facade_module)._LockedSectionWritetakes its owner's module, as compose owners' classes do (_ChannelSendFailedprecedent); nothing in src or tests reads its__module__,__qualname__or pickles it.Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_apps_list -- crew page -- still bound on the facade, served from security_trusted_apps.py by the mirror (test_trusted_apps_api)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_app_grant -- crew page -- still bound on the facade, served from security_trusted_apps.py by the mirror (test_trusted_apps_api)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_app_revoke -- crew page -- still bound on the facade, served from security_trusted_apps.py by the mirror (test_trusted_apps_api)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_apps_allow_all -- crew page -- still bound on the facade, served from security_trusted_apps.py by the mirror (test_trusted_apps_api)
Reader: src/kiro_crew/dashboard/handlers/security.py:build_trusted_apps_snapshot -- chat -- still bound on the facade, served from security_trusted_apps.py by the mirror (change_cards.py imports it lazily from the facade; test_trusted_apps_api)
Reader: src/kiro_crew/dashboard/handlers/security.py:build_trusted_apps_snapshot_async -- crew page -- still bound on the facade, served from security_trusted_apps.py by the mirror (test_security_handlers_facade)
Reader: src/kiro_crew/dashboard/handlers/security.py:build_governance_policy_snapshot -- crew page -- still bound on the facade, served from security_governance_policy.py by the mirror (test_governance_policy_viewer)
Reader: src/kiro_crew/dashboard/handlers/security.py:build_governance_policy_snapshot_async -- crew page -- still bound on the facade, served from security_governance_policy.py by the mirror (test_governance_policy_viewer)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_governance_policy -- crew page -- still bound on the facade, served from security_governance_policy.py by the mirror (test_governance_policy_viewer)
Reader: src/kiro_crew/dashboard/handlers/security.py:build_trusted_registries_snapshot -- crew page -- still bound on the facade, served from security_trusted_registries.py by the mirror (test_registry_trust_grant)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_registries_list -- crew page -- still bound on the facade, served from security_trusted_registries.py by the mirror (test_registry_trust_grant)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_registry_grant -- crew page -- still bound on the facade, served from security_trusted_registries.py by the mirror (test_registry_trust_grant)
Reader: src/kiro_crew/dashboard/handlers/security.py:api_trusted_registry_revoke -- crew page -- still bound on the facade, served from security_trusted_registries.py by the mirror (test_registry_trust_grant)
Reader: src/kiro_crew/dashboard/handlers/memory.py:api_memory_embedding_model -- crew page -- still bound on the facade, served from memory_embeddings.py by the mirror (test_embedding_model_apply)
Reader: src/kiro_crew/dashboard/handlers/memory.py:api_memory_embedding_status -- crew page -- still bound on the facade, served from memory_embeddings.py by the mirror (test_enable_embeddings_faiss)
Reader: src/kiro_crew/dashboard/handlers/memory.py:api_memory_enable_embeddings -- crew page -- still bound on the facade, served from memory_embeddings.py by the mirror (test_enable_embeddings_faiss)
Reader: src/kiro_crew/dashboard/handlers/memory.py:api_memory_disable_embeddings -- crew page -- still bound on the facade, served from memory_embeddings.py by the mirror (test_handlers_memory_coverage)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_notification_agent_push -- chat -- re-imported by the facade from messaging_api/agent_push.py and composed onto its globals (test_handlers_messaging_composition_contract)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_slack_pins -- chat -- re-imported by the facade from messaging_api/slack_workspace.py and composed onto its globals (test_handlers_messaging_composition_contract)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_slack_reactions -- chat -- re-imported by the facade from messaging_api/slack_workspace.py and composed onto its globals (test_handlers_messaging_composition_contract)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_slack_profile -- chat -- re-imported by the facade from messaging_api/slack_workspace.py and composed onto its globals (test_handlers_messaging_composition_contract)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_slack_manifest -- crew page -- re-imported by the facade from messaging_api/slack_workspace.py and composed onto its globals (test_handlers_messaging_composition_contract)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_token_put -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_command -- chat -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_command_drain -- chat -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_command_result -- chat -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:stop_browser_install -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_install_get -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_install_start -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_engine_install -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_view_get -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_view_start -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_browser_open -- crew page -- re-imported by the facade from messaging_api/browser_routes.py and composed onto its globals (test_messaging_browser_routes, test_browser_cli_journeys)
Reader: src/kiro_crew/dashboard/handlers/messaging.py:api_channel_folder_backfill -- crew page -- re-imported by the facade from messaging_api/channel_folder_backfill.py and composed onto its globals (test_handlers_messaging_composition_contract)
Move audit
security.py_stop_apps_running_on_blanket_trust: docstring "can no longer be" → "cannot be" (comment-history gate on moved lines).security.pyExpr: the facade's module docstring names the three owner surfaces.memory.py_redact_pip_stderr: docstring "no longer matches" → "does not match" (comment-history gate).messaging.pyExpr: the_facade_compose(...)call lists the five new owners (glue).security_trusted_apps.pytwo "no longer" comments (comment-history), "the denied-commands opt-out above" → "in the facade", "this module's own error type" → "the handlers' own";memory_embeddings.py"is no longer authoritative" → "is not", "previously-working" → "working" (comment-history);memory_graph.pythe example project header "KiroCrew (Public)" → "Acme (Public)" twice (brand gate);memory_services.pythe comment about the one-module file's top-levelKiroCrewConfigbinding;agent_push.py"no longer says" → "does not say" (comment-history, Master ruling).security.pywas black-baselined; the 12 statements black re-wraps insecurity_trusted_apps.pyare AST-identical, andsecurity.pyleaves.github/black-baseline.txt.ConfigCorruptError.__module__/TrustSettingOverlayOwned.__module__restores; theTYPE_CHECKINGmanifests (owner-defined names, and names served from outside the family, L42).L36 (default vs
--minimaladded lines): identical for every changed file (memory.py+108/-1247;messaging.py+75/-1718;security.py+147/-2059 under both; the owners are new files).Guard changes
Master ruling (messaging Option A): each re-keyed pin is at least as strong, with a mutation proof that turns it red.
_FACADE_DEFS(messaging contract)_write_env_off_loopamong them); rows of the 15 moved defs deleted, rationale names their homestest_the_census_sites_stay_in_the_facade: facade == 12, owners grow nonetest_the_census_sites_stay_in_their_census_homes: facade 2,slack_workspace10, total 12, every other owner forbidden, both equal their census rows_STAYS_IN_THE_FACADE(messaging contract)await read_bounded_json\(= facade +agent_pushexactly; the other three unchanged_OWNER_MODULES/_BASE_OWNERS/_BASE_SHAPE_DIGESTtest_security_posture._BASELINE_LOG_SITE_CENSUSdashboard/handlers/messaging.py: 12messaging.py: 2 +messaging_api/slack_workspace.py: 10security_posture.NON_EGRESS_REDACTION_MODULEShandlers/memory_embeddings.py,handlers/memory_graph.py(classified as their facadehandlers/memory.pyis),messaging_api/slack_workspace.py(the facade stays the registered sink, as for the spawn owners)test_json_object_body_guard._CAP_REGISTERhandlers/messaging.py::api_notification_agent_push,handlers/memory.py::api_memory_embedding_modelmessaging_api/agent_push.py::...,handlers/memory_embeddings.py::...test_no_config_dir_in_async._ASYNC_CHECKED_FILESmessaging_apiownerstest_internal_python_isolationdashboard/handlers/memory.py× 2dashboard/handlers/memory_embeddings.py× 2test_vector_memory._PLUMBED_SITESdashboard/handlers/memory.pydashboard/handlers/memory_services.pytest_r6_owner_gate_regression._GATED_MODULES...handlers.securitysecurity_*owner modules (L40(8))test_handlers_memory_coverage::test_no_async_handler_calls_sync_get_vector_storegetsource(mem_mod)_OWNERSfile (L40(8) join)test_sync_io_in_async_gate::TestExemplarStaysCleanhandlers/memory.pyalone_OWNERSnames (L40(8) join; assertions unchanged)code-review.ymlbool()opt-out tripwirehandlers/security.pyhandlers/security_*.py(see CI path references)Mutation proofs (26, all red, then restored):
r6-gated-modules,msg-base-owners-dropped-name,msg-unlisted-owner,msg-facade-def-in-owner,msg-census-13th-site-in-other-owner,msg-census-site-moved-between-homes,msg-stays-planted-in-other-owner,msg-stays-removed-from-agent-push,cap-register-agent-push,cap-register-embedding-model,async-row-dropped,async-guard-reaches-owner,isolation-row-reaches-owner,plumbed-site-reaches-owner,tripwire-reaches-owner,non-egress-row,non-egress-row-slack,security-facade-owner-dropped,security-kept-code-moved,memory-facade-owner-dropped,memory-setup-status-on-facade,msg-census-13th-site-in-facade,syncio-exemplar-reaches-owner,codereview-tripwire-reaches-owner,msg-off-loop-drain-in-owner,msg-digest-moved-signature.Tests
test/test_security_handlers_facade.pyandtest/test_memory_handlers_facade.py: every name the test trees patch through each facade (scanned withtest/facade_mirror_scan.py, with a known-seams non-vacuity floor) reaches every module holding it and the undo restores them; the owners load lowest layer first; no forwarding table; names served from outside the family are visible to type checkers (L42); one logger under the facade name; the kept code stays bound on the facade; the moved exceptions keep the facade module;_embedding_setup_statuslives in one owner (itsglobalrebinding stays the binding every read sees);python -mstill runs; corpus-gate self-test.test/test_messaging_browser_routes.py: the native panel's command-bus routes (/api/browser/command,/command-drain,/command-result) for every body shape and bus outcome, with a recording stand-in bus. They were 15/83 covered in CI's report; the owner file now reaches the 80% per-file floor on its own (93% locally).test/campaign_facade_inventories/kiro_crew.dashboard.handlers.security.json(62 names, 37 re-bound) and...memory.json(88, 62), generated from the merge-base text.-n 3-- every test file that imports, patches or names a moved symbol of these modules, every whole-tree scanner (rglob/source_corpus), and the guards above: 33,445 tests, 33,444 passed (95 skipped, 5 xfailed) plustest_platformdirs_pytest_plugin_block, which reads theaddoptsmy-o addopts=override dropped and passes under the default options. Touched sets after the later edits, default options: 1,605 passed, then 443 passed (test_sync_io_in_async_gate,test_ai_review_workflows_code_review_greps, the facade, contract, mirror-guard and flake/wait-discipline ratchet tests).scripts/local-gate.py --dry-runselects 2,277 backend + 599 frontend related files, over the campaign's 600-file local cap, so the floor above ran instead; CI owns the full matrix. After the rebase onto main with theconfig/loader.pysplit (refactor: split config/loader.py into loader_* owners behind a facade #20550): the importer floor again (187 files, default options), 13,562 passed, and mypy over the package is clean. After the rebase onto main at75bead2892with_write_env_off_loopkept in the facade: every test file that imports, patches or names the messaging facade or its owners, plus the error-code, sync-io, config-dir, posture, JSON-body, flake-ratchet, line-cap, facade-inventory and mirror guards (100 files,-n 3), 5,174 passed (1 skipped), and mypy over the package is clean. After the rebase onto main at8335fa0164(fix(dashboard): take a cron's queued card down when its turn starts #21340 editsapi_send_message, which stays in the facade): every test file that names any of the three facades, their owners orsecurity_posture, plus the guards and the test files main changed that mention these modules (309 files,-n 3): 22,570 passed, 31 skipped, 1 failed, and mypy over the package is clean. The one failure istest_facade_mirror_guards.py::test_no_test_writes_a_mirrored_facade_namespace_directlyhitting the 120 s pytest timeout under host load (load average 45-67 on 32 CPUs). It reproduces on main: run alone in git-archive exports of main and of this head, it takes 141.5 s / 122.6 s of CPU on main and 138.3 s / 121.4 s on this head (two runs each). It passed alone in this worktree (115.6 s) and on CI at the previous head.-n0, each in a shuffled order (seeds printed: 1000 + 7919·i), plus one-n 3run: 83 passed every time.Manual verification
N/A: a pure move; the facade, mirror and composition guards, the importer floor and an installed-wheel import of every new module cover it.
Docs, citations and source-text pins
docs/system-specs/modules/learn-cron-dashboard.md(security, memory) andmessaging.md(the messaging_api table and what the facade keeps); definition-site citations re-pointed inapp-kit-platform.md,governance.md,security.md,config.md,memory-skills-hooks.md;docs/feature-map/README.mdfacade note names the two new facades and their owners.file:line old -> new:src/kiro_crew/apps/registry_trust.py:10dashboard/handlers/security.py->dashboard/handlers/security_trusted_registries.pysrc/kiro_crew/apps/registry_trust.py:14security.py/ it / imports -> The security handlers / they / importsrc/kiro_crew/security_posture.py:33handlers/security.py's / snapshot), -> the / snapshot inhandlers/security_governance_policy.py),src/kiro_crew/browser/command_bus.py:7wired /dashboard/handlers/messaging.py. ->dashboard/messaging_api/browser_routes.py.src/kiro_crew/dashboard/handlers/mcp.py:2386security.py's ->security_trusted_apps.py'ssrc/kiro_crew/dashboard/handlers/computer_use.py:141handlers/security.py::ConfigCorruptError, ->handlers/security_audit.py::ConfigCorruptError,src/kiro_crew/dashboard/handlers/computer_use.py:191handlers/security.py::_run_off_loop: ->handlers/security_audit.py::_run_off_loop:src/kiro_crew/dashboard/handlers/computer_use.py:560handlers/messaging.py's ->messaging_api/agent_push.py'ssrc/kiro_crew/vector_memory_lifecycle.py:352dashboard/handlers/memory.py's ->dashboard/handlers/memory_services.py'ssrc/kiro_crew/dashboard/messaging_api/__init__.py:30_LockedSectionWritetransaction, ->_ABSENTsentinel,test/test_trusted_apps_api.py:3dashboard/handlers/security.py->dashboard/handlers/security_trusted_apps.pytest/test_governance_policy_viewer.py:439security.py -> security_governance_policy.pytest/test_chat_regenerate_refusal_codes.py:50handlers/security.py:1535/ # ->handlers/security_trusted_apps.py(allow-all) / #test/test_chat_regenerate_refusal_codes.py:71handlers/security.py->handlers/security_trusted_apps.pytest/test_r8_s33_subprocess_env.py:197memory.py -> memory_embeddings.pydocs/system-specs/modules/computer-use.md:591messaging.py's ->messaging_api/agent_push.py'sdocs/system-specs/modules/app-kit-platform.md:2370dashboard/handlers/security.py->dashboard/handlers/security_trusted_apps.pydocs/system-specs/modules/app-kit-platform.md:2686dashboard/handlers/security.py). ->dashboard/handlers/security_trusted_registries.py).docs/system-specs/modules/app-kit-platform.md:2701dashboard/handlers/security.py/ (security.py/ imports ->dashboard/handlers/security_trusted_registries.py/ (the security handlers / importdocs/system-specs/modules/governance.md:2417(handlers/security.build_governance_policy_snapshot, -> (handlers/security_governance_policy.build_governance_policy_snapshot,docs/system-specs/modules/governance.md:3718dashboard/handlers/security.py/ serialization). ->dashboard/handlers/security_governance_policy.py/ serialization), served throughdashboard/handlers/security.py.docs/system-specs/modules/security.md:1406(handlers/messaging.py) -> (dashboard/messaging_api/slack_workspace.py)docs/system-specs/modules/security.md:3045dashboard/handlers/security.py)** ->dashboard/handlers/security_trusted_registries.py)**docs/system-specs/modules/config.md:2854handlers/messaging.py, ->messaging_api/channel_config_writes.py,docs/system-specs/modules/memory-skills-hooks.md:1183dashboard/handlers/memory.py, ->dashboard/handlers/memory_services.py,.github/file-line-cap-baseline.txtrows for all three targets deleted;.github/black-baseline.txtrow forsecurity.pydeleted;error-code-baseline.jsonredistributed (--update, own rows only): totals unchanged (1046 / 18 / 38).test/test_handlers_memory_coverage.pymain row 3,102 → 3,105 (the L40(8) tripwire join). Baselined growth (L56 addendum 1b):src/kiro_crew/security_posture.py+3 (three exact-path NON_EGRESS rows the drift guard requires; the shared comment re-worded in place).website/**names a moved definition's file.CI path references
.github/workflows/code-review.yml:186(Check backend security rules, thebool()opt-out tripwire): thegit diffpath list gains'src/kiro_crew/dashboard/handlers/security_*.py', so the four security owners stay in scope (path list only, no logic; Master grant under L14). Proof: a synthetic two-commit repo addingbool(denied.get('disable_all'))tosecurity_trusted_apps.pyis caught with the new path list and missed with the old one.AUTOSDE.yamlglob orSENSITIVE_GLOBSentry needs a new path. The edit tosrc/kiro_crew/security_posture.py(aSENSITIVE_GLOBSpath) brings in Sensitive Change Review; its template is posted as a PR comment for the head.Related Issues
Part of #20192
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.