Repository navigation
feat(dashboard): add a List all tabs menu to the side panel tab strip - #22024
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change adds a menu and two scroll behaviours, and the only code it moves ( [DESIGN-REVIEWED] 3f20556 Description read[DESCRIPTION-READ] d48a695f4e20e606610c880c0d20f17f315f4d4494a878a748c19ff1e567ab87 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS No blocker: the screenshots show the List all tabs chevron, its open menu, the current-row mark, both themes and a scrolled menu. Nobody has done a blind first-time read, because this is a fork review; pushing the branch to this repository runs one. Notes
[UX-REVIEWED] 3f20556 Description read[DESCRIPTION-READ] 2ba6c2e87882ded23cbc72f794362674ff12cb137a620791185a6cfe55bf4d87 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: every item addresses the reported unreachable-tab defect (#21883), adds new behaviour while every existing default stays as it was, and has one real consumer. Notes
What this change shipsInventory (6 items) — 4 justifiedIntent: let a user reach any open side-panel tab without closing other tabs. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 3f20556 Description read[DESCRIPTION-READ] 8337b4d0f513da0534dfbe1b021b777e77b3d232b01b15587c3171d831510698 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
f91ff2f to
ae1ca93
Compare
|
|
|
|
|
|
ae1ca93 to
7edc6fe
Compare
|
Hi @iamwhatever, thank you for the earlier review. Since your last pass I fixed the row blur finding. The menu now clears the tracked row when focus moves to the menu container, and I posted a disposition for it. The Windows desktop app check is also done. I ran this branch in the desktop app, and overflow, drag-reorder, the list button, auto scroll and wheel scrolling all work. Every check passes except Backend Tests (3.12, 2), which times out at 120s in test_facade_mirror_guards.py. This PR touches no backend code. The timeout is tracked in #22281, with a fix in #22320. Coverage Gate and PR Readiness fail only because of that job. I'm contributing from a fork, so I can't rerun the shard or merge. Would you please rerun that job, review the latest head, and merge if it looks good to you? I'm happy to rebase if main has moved by then. Thank you. |
5f75305 to
ac22cad
Compare
ac22cad to
1091c81
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES (tracking issue needed) at 1091c81.
The code reads soundly, and the r113 item is fixed: the row blur now clears the tracked id when focus moves to the menu container (AllTabsMenu.tsx L179-L186). CI is green and the desktop check is reported.
Two things remain:
- Deferred follow-ups need linked issues. Not a goal says the other tab strips (open-session, terminal, embed, File Explorer app tabs) have the same gap and are follow-ons. I found no issue for that. #22154 covers moving
FollowUpBarandEmbedTabStriponto the wheel hook, but it is not linked in the description. Please open one issue for the other strips and link both in the description. - One Design note on this head has no reply. The new lowercase
sidePanel…modules fall outsideOWNER_REin SidePanel.owners.test.tsx, though the ownerSidePanelTabChip.tsximports them. Please rename them as owners or reply in atarget=designdisposition that they are shared modules outside the boundary on purpose.
— crew-pr-reviewer (r125)
1091c81 to
cb9fa98
Compare
|
|
Thank you for the review. Both items are addressed in the latest push.
The description also had one wrong sentence. It said the tab icons and terminal title moved out of |
… scrolling to the side panel tab strip
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at 3f20556.
Both r125 items are cleared. #23982 now tracks the other tab strips and #22154 the shared wheel hook, and both are linked under Not a goal. The two modules are renamed to SidePanelTabNav.tsx and SidePanelTabIcons.tsx, so the owner-boundary test covers them.
The code reads soundly: the menu scrolls only its own content (AllTabsMenu.tsx L48-L64), selection goes through the existing leave guard, and the wheel hook hands the event back to the page at either end. All five AI lanes pass on this head, and every check is green.
Optional: the First Principles note about the three exported row-class constants with no non-test reader can be taken or left.
— crew-pr-reviewer (r131)
Problem / Motivation
Goal: Let a user reach any open side-panel tab without closing other tabs first.
When the side panel holds more tabs than fit, the tabs past the edge cannot be reached. Both tab groups hide their scrollbar, a vertical mouse wheel does nothing over them, and a tab that becomes active off screen stays off screen. The only way to a hidden tab is to close others until the row fits.
Why it matters
Anyone with many open files, diffs or views in the side panel loses track of tabs and has to close work to find it. On Windows desktop (0.9.0.3) the wheel does nothing over the strip.
Not a goal
FollowUpBarandEmbedTabStripeach keep their own wheel-to-horizontal code. Moving them ontouseWheelToHorizontalchanges components this PR does not otherwise touch, so it is tracked separately in Share one wheel-to-horizontal hook across the side panel, follow-up bar and embed tab strips #22154.What changed (motivation → approach → change)
A user needs three things: a way to list every tab, the active tab brought into view, and a wheel that scrolls the strip sideways. The side panel had none of the three.
A "List all tabs" chevron now sits at the trailing edge of the tab row, beside the panel controls and outside both scrollers, so it never scrolls away and
+keeps its place next to the tabs. It opens a menu of every open tab in strip order. File, folder and diff rows show a path line relative to the project (the tooltip keeps the full path), a terminal row shows its live title, and the current tab is marked with an accent title and a check. Picking a row goes through the existing leave guard. Picking the current row brings its chip back into view.When the active tab changes, its chip scrolls the minimum distance to sit fully inside its scroller. A chip wider than the scroller aligns its trailing edge when it has a close button, so the button stays clickable, and its leading edge otherwise. A plain vertical wheel over either tab group scrolls it sideways, and leaves the page alone at either end.
The menu (
components/AllTabsMenu.tsx), the wheel hook (hooks/useWheelToHorizontal.ts) and the reveal helper (sidePanelReveal.ts) are separate modules so the follow-on strips can reuse them. One new catalog string,pages.chat.sidePanel.all_tabs, is added toi18n/locales/en.json, the 11 translated locale files and theen-XA.jsonpseudo-locale. Tab icons and the live terminal title moved out ofSidePanelTabChip.tsxinto the sibling modulesSidePanelTabIcons.tsxandSidePanelTabNav.tsx, which the owner-boundary test lists as owners.docs/feature-map/README.mdhas a new row for the feature.Backwards compatibility
Compatible: this adds a control and two scroll behaviors. No tab, setting or stored value changes.
Removes nothing: the only edits to existing code move the tab-icon table and the terminal title component to sibling files and add a
data-tab-chip-idattribute to the chips.Tests
AllTabsMenu.test.tsx: rows, the current-row mark, separators, empty groups, keyboard selection, focus return when the focused tab closes, scrolling the menu itself (never the page), and a re-reveal while the menu's height settles that stops at the first wheel, touch, key or press, and a scaled-rect case for the open animation.sidePanelReveal.test.ts: fit, clipped, oversized closable, oversized fixed, and the 10px narrower, exact and 1px wider cases.useWheelToHorizontal.test.tsx: pure vertical events only, line and page deltas, clamping at both ends, listener cleanup.sidePanelAllTabs.test.tsx: placement after the flexible gap in the right dock, bottom dock and narrow viewport, project-relative path lines, rows for every tab kind in step with the chips, the leave guard, withheld views, path characters in tab ids, and reveal on pick.happy-dom has no layout, so these tests pin the logic. Wheel feel, clipping and drag-reorder need a real browser.
Manual verification
Run in headless Chromium on Linux against the built bundle of this branch, gateway-free, with 12 file tabs and the three pinned views:
Screenshots / video
The pinned group shrinking on the left of the menu frames is the existing layout tracked in #22006.
Related Issues
Closes #21883
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
By submitting this pull request, I agree that my contribution is licensed under the project's Apache-2.0 license.