Skip to content

feat(dashboard): add a List all tabs menu to the side panel tab strip - #22024

Merged
abirkel merged 1 commit into
kirodotdev:mainfrom
abirkel:feat/side-panel-all-tabs-menu
Oct 28, 2026
Merged

abirkel merged 1 commit into
kirodotdev:mainfrom
abirkel:feat/side-panel-all-tabs-menu

Conversation

@abirkel

@abirkel abirkel commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a user reach any open side-panel tab without closing other tabs first.

When the side panel holds more tabs than fit, the tabs past the edge cannot be reached. Both tab groups hide their scrollbar, a vertical mouse wheel does nothing over them, and a tab that becomes active off screen stays off screen. The only way to a hidden tab is to close others until the row fits.

Why it matters

Anyone with many open files, diffs or views in the side panel loses track of tabs and has to close work to find it. On Windows desktop (0.9.0.3) the wheel does nothing over the strip.

Not a goal

What changed (motivation → approach → change)

A user needs three things: a way to list every tab, the active tab brought into view, and a wheel that scrolls the strip sideways. The side panel had none of the three.

A "List all tabs" chevron now sits at the trailing edge of the tab row, beside the panel controls and outside both scrollers, so it never scrolls away and + keeps its place next to the tabs. It opens a menu of every open tab in strip order. File, folder and diff rows show a path line relative to the project (the tooltip keeps the full path), a terminal row shows its live title, and the current tab is marked with an accent title and a check. Picking a row goes through the existing leave guard. Picking the current row brings its chip back into view.

When the active tab changes, its chip scrolls the minimum distance to sit fully inside its scroller. A chip wider than the scroller aligns its trailing edge when it has a close button, so the button stays clickable, and its leading edge otherwise. A plain vertical wheel over either tab group scrolls it sideways, and leaves the page alone at either end.

The menu (components/AllTabsMenu.tsx), the wheel hook (hooks/useWheelToHorizontal.ts) and the reveal helper (sidePanelReveal.ts) are separate modules so the follow-on strips can reuse them. One new catalog string, pages.chat.sidePanel.all_tabs, is added to i18n/locales/en.json, the 11 translated locale files and the en-XA.json pseudo-locale. Tab icons and the live terminal title moved out of SidePanelTabChip.tsx into the sibling modules SidePanelTabIcons.tsx and SidePanelTabNav.tsx, which the owner-boundary test lists as owners. docs/feature-map/README.md has a new row for the feature.

Backwards compatibility

Compatible: this adds a control and two scroll behaviors. No tab, setting or stored value changes.

Removes nothing: the only edits to existing code move the tab-icon table and the terminal title component to sibling files and add a data-tab-chip-id attribute to the chips.

Tests

  • AllTabsMenu.test.tsx: rows, the current-row mark, separators, empty groups, keyboard selection, focus return when the focused tab closes, scrolling the menu itself (never the page), and a re-reveal while the menu's height settles that stops at the first wheel, touch, key or press, and a scaled-rect case for the open animation.
  • sidePanelReveal.test.ts: fit, clipped, oversized closable, oversized fixed, and the 10px narrower, exact and 1px wider cases.
  • useWheelToHorizontal.test.tsx: pure vertical events only, line and page deltas, clamping at both ends, listener cleanup.
  • sidePanelAllTabs.test.tsx: placement after the flexible gap in the right dock, bottom dock and narrow viewport, project-relative path lines, rows for every tab kind in step with the chips, the leave guard, withheld views, path characters in tab ids, and reveal on pick.

happy-dom has no layout, so these tests pin the logic. Wheel feel, clipping and drag-reorder need a real browser.

Manual verification

Run in headless Chromium on Linux against the built bundle of this branch, gateway-free, with 12 file tabs and the three pinned views:

  • The chevron sits at the trailing edge with few tabs and with many.
  • On a restored panel with the last tab active, that tab's chip lands fully inside its scroller.
  • The menu lists every tab in strip order with one checked row. On a 520px-tall window the menu scrolls so the current row is inside it. That run found a bug: the menu's open animation draws it at 95% scale, so the first reveal stopped about 38px short. The reveal now converts rects to scroll distance, and a unit test covers it.
  • The author checked wheel scrolling and drag-reorder by hand in Firefox, Chrome and Edge on Windows. Touch long-press was not checked.

Screenshots / video

01-strip-few-tabs 02-strip-many-tabs-active-revealed 03-menu-light 04-menu-dark 05-menu-short-window-current-row-visible

The pinned group shrinking on the left of the menu frames is the existing layout tracked in #22006.

Related Issues

Closes #21883

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

By submitting this pull request, I agree that my contribution is licensed under the project's Apache-2.0 license.

@abirkel
abirkel requested review from a team and KiroCrewCaptain as code owners October 19, 2026 02:31
@abirkel
abirkel requested a review from iamwhatever October 19, 2026 02:31
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 3f20556f6c23da4ab84a95e4aa9149fdd8230af5 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change adds a menu and two scroll behaviours, and the only code it moves (KIND_ICON, iconForKind, TerminalTabTitle) was module-private, so no reader outside the patch breaks.

[DESIGN-REVIEWED] 3f20556

Description read

[DESCRIPTION-READ] d48a695f4e20e606610c880c0d20f17f315f4d4494a878a748c19ff1e567ab87

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 3f20556f6c23da4ab84a95e4aa9149fdd8230af5 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

No blocker: the screenshots show the List all tabs chevron, its open menu, the current-row mark, both themes and a scrolled menu. Nobody has done a blind first-time read, because this is a fork review; pushing the branch to this repository runs one.

Notes

  • No screenshot shows a terminal row with its live title, or a diff or folder row. Attaching one would show how the menu looks with mixed tab types.
  • The trigger is a bare ChevronDown labelled only by its title/aria-label "List all tabs". It can be mistaken for the strip's overflow menu, because the ⋯ button sits right next to it in attachment-01. A small open-tab count beside the chevron would make its job clearer.

[UX-REVIEWED] 3f20556

Description read

[DESCRIPTION-READ] 2ba6c2e87882ded23cbc72f794362674ff12cb137a620791185a6cfe55bf4d87

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 3f20556f6c23da4ab84a95e4aa9149fdd8230af5 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: every item addresses the reported unreachable-tab defect (#21883), adds new behaviour while every existing default stays as it was, and has one real consumer.

Notes

What this change ships

Inventory (6 items) — 4 justified

Intent: let a user reach any open side-panel tab without closing other tabs. ADDITION.

  1. A "List all tabs" chevron at the trailing edge of the tab row opens a menu of every tab, with path lines and a check on the current tab — justified
  2. The active tab's chip scrolls into view automatically whenever the active tab changes — justified
  3. A vertical mouse wheel over either tab group scrolls it sideways — duplicate of FollowUpBar/EmbedTabStrip inline handlers (deferred, Share one wheel-to-horizontal hook across the side panel, follow-up bar and embed tab strips #22154)
  4. Picking the current tab in the menu brings its chip back into view — justified
  5. Tab icons and the terminal title moved into SidePanelTabIcons.tsx/SidePanelTabNav.tsx, chips gain data-tab-chip-id, feature-map rows updated — justified
  6. Three exported row-class constants — zero consumers outside tests

[FIRST-PRINCIPLES-REVIEWED] 3f20556

Description read

[DESCRIPTION-READ] 8337b4d0f513da0534dfbe1b021b777e77b3d232b01b15587c3171d831510698

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 3f20556f6c23da4ab84a95e4aa9149fdd8230af5 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3f20556

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 3f20556f6c23da4ab84a95e4aa9149fdd8230af5 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3f20556

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026
@abirkel
abirkel force-pushed the feat/side-panel-all-tabs-menu branch from f91ff2f to ae1ca93 Compare October 19, 2026 05:05
@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author
  • 8146e2bff9e3

Fixed in part. The chevron moved to the trailing edge, beside the panel controls, so it no longer sits against + and the pair cannot read as one split button. No gap, divider or count was added, because they cost width and other products do not use them. The glyph stays a down chevron, which is what Chrome's tab search uses.

@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author
  • aef7ed9fe832

Not changed. Showing it only on overflow would move or resize the neighbouring controls when a tab is opened, and the overflow test would depend on the control's own width. The menu also reaches tabs clipped by the pinned-group squeeze in #22006, where no scroller reports overflow.

@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author
  • dbc6dd5998c5

Fixed. The second line is now relative to the project root (src/db/migrations/0042_add_plans.sql), through the existing makeRelative. A path outside the root stays absolute, and the tooltip keeps the full path. A test pins both cases.

@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author
  • b433c7d16aef

Deferred, and now stated under Not a goal. FollowUpBar and EmbedTabStrip keep their own wheel code, because moving them changes components this PR does not touch. They follow with the other strips. The two line constants differ on purpose: usePinchZoom's 33 maps Firefox's 3-line notch onto the 100px notch its zoom divisor expects, while 16 is the line height for scrolling.

@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author
  • dbf1c3f7b1ed

Fixed. The testId prop is deleted and the trigger carries data-testid="all-tabs-trigger".

@abirkel

abirkel commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Checked by hand in Firefox, Chrome and Edge on Windows: wheel scrolling and drag-reorder both work. The PR body says so.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 19, 2026
@abirkel
abirkel force-pushed the feat/side-panel-all-tabs-menu branch from ae1ca93 to 7edc6fe Compare October 19, 2026 07:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@abirkel

abirkel commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi @iamwhatever, thank you for the earlier review.

Since your last pass I fixed the row blur finding. The menu now clears the tracked row when focus moves to the menu container, and I posted a disposition for it. The Windows desktop app check is also done. I ran this branch in the desktop app, and overflow, drag-reorder, the list button, auto scroll and wheel scrolling all work.

Every check passes except Backend Tests (3.12, 2), which times out at 120s in test_facade_mirror_guards.py. This PR touches no backend code. The timeout is tracked in #22281, with a fix in #22320. Coverage Gate and PR Readiness fail only because of that job.

I'm contributing from a fork, so I can't rerun the shard or merge. Would you please rerun that job, review the latest head, and merge if it looks good to you? I'm happy to rebase if main has moved by then.

Thank you.

@abirkel
abirkel force-pushed the feat/side-panel-all-tabs-menu branch from 5f75305 to ac22cad Compare October 22, 2026 00:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 22, 2026
@abirkel
abirkel force-pushed the feat/side-panel-all-tabs-menu branch from ac22cad to 1091c81 Compare October 25, 2026 02:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 25, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST_CHANGES (tracking issue needed) at 1091c81.

The code reads soundly, and the r113 item is fixed: the row blur now clears the tracked id when focus moves to the menu container (AllTabsMenu.tsx L179-L186). CI is green and the desktop check is reported.

Two things remain:

  1. Deferred follow-ups need linked issues. Not a goal says the other tab strips (open-session, terminal, embed, File Explorer app tabs) have the same gap and are follow-ons. I found no issue for that. #22154 covers moving FollowUpBar and EmbedTabStrip onto the wheel hook, but it is not linked in the description. Please open one issue for the other strips and link both in the description.
  2. One Design note on this head has no reply. The new lowercase sidePanel… modules fall outside OWNER_RE in SidePanel.owners.test.tsx, though the owner SidePanelTabChip.tsx imports them. Please rename them as owners or reply in a target=design disposition that they are shared modules outside the boundary on purpose.

— crew-pr-reviewer (r125)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 25, 2026
@abirkel
abirkel force-pushed the feat/side-panel-all-tabs-menu branch from 1091c81 to cb9fa98 Compare October 25, 2026 09:47
@abirkel

abirkel commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Fixed. I renamed sidePanelTabNav and sidePanelTabIcons to SidePanelTabNav and SidePanelTabIcons, so they now match OWNER_RE. SidePanel.owners.test.tsx lists both as owners, and its import-boundary checks cover them.
sidePanelReveal.ts stays lowercase. It is pure arithmetic with no owner imports, and only the two owner modules import it.

@abirkel

abirkel commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the review. Both items are addressed in the latest push.

  1. I filed Reach every tab in the other tab strips: session, terminal, embed and File Explorer #23982 for the other tab strips (session, terminal, embed and File Explorer). I read each strip's code but did not run any of them with overflowing tabs, and the issue says so. The description now links Reach every tab in the other tab strips: session, terminal, embed and File Explorer #23982 and Share one wheel-to-horizontal hook across the side panel, follow-up bar and embed tab strips #22154.
  2. I renamed the two modules to SidePanelTabNav.tsx and SidePanelTabIcons.tsx, so the owner boundary test covers them, and posted a target=design disposition.

The description also had one wrong sentence. It said the tab icons and terminal title moved out of SidePanel.tsx. They moved out of SidePanelTabChip.tsx, and the description now says so.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 25, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 3f20556.

Both r125 items are cleared. #23982 now tracks the other tab strips and #22154 the shared wheel hook, and both are linked under Not a goal. The two modules are renamed to SidePanelTabNav.tsx and SidePanelTabIcons.tsx, so the owner-boundary test covers them.

The code reads soundly: the menu scrolls only its own content (AllTabsMenu.tsx L48-L64), selection goes through the existing leave guard, and the wheel hook hands the event back to the page at either end. All five AI lanes pass on this head, and every check is green.

Optional: the First Principles note about the three exported row-class constants with no non-test reader can be taken or left.

— crew-pr-reviewer (r131)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Side panel tabs: overflowed tabs can't be reached without closing others

2 participants