Skip to content

test: split four oversized test files by behaviour under test - #22190

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t64-test-dashboard-updates-coverage
Oct 20, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t64-test-dashboard-updates-coverage

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring four test files of 2,449 to 2,565 lines each down to at most 1,530 lines, so none of them exceeds the 2,000-line cap, without changing a single test.

test/test_dashboard_updates_coverage.py (2565 lines), test/test_chat_mirror.py (2475), test/test_taskq_runner_adapter.py (2453) and test/test_mcp_gatewayd_coverage.py (2449) are each over the 2,000-line cap that scripts/check_file_line_cap.py enforces, and each is listed in .github/file-line-cap-baseline.txt. A file that large is hard to navigate and review, and every PR that adds a test to one pushes it further past the cap.

Why it matters

The maintainers' rule is that no hand-written file may exceed 2,000 lines. These four files break it today, and each new test makes the eventual split larger and harder to review. Splitting by the behaviour under test gives each file room to grow and makes each topic findable by file name.

Not a goal

  • Changing, renaming, fixing, de-flaking or re-parametrizing any test. Every test body moves with an identical AST.
  • Changing production code. This PR touches only tests, test helpers, the four line-cap rows, one exemption row and the docs and comments that name where the moved tests live.
  • Fixing the pre-existing semgrep findings, sleeps and unbounded awaits that move with their tests (they are marked, not rewritten).
  • Splitting any file outside these four.

What changed (motivation → approach → change)

Each file splits along its own test classes and section banners, grouped by the behaviour under test. Each original keeps its module docstring, the imports its remaining code uses and a contiguous run of its own tests; where one middle block moves, the original keeps the tests on both sides of it, so the moved block leaves the original as one contiguous deletion. Helpers and fixtures that more than one file uses move to a non-test *_helpers.py module, and every file imports them by name. A recipe tool did the move, reading each file at BASE, so it can be re-run after a rebase instead of hand-merged.

Origin (lines) Stays in the original New files (lines)
test_dashboard_updates_coverage.py (2565 → 1098) the update check and its git timeouts and checkout failures, the update-info accessors, the auto-update switch, the changelog cache _apply (639): POST /api/update's refusals and worker, the pip-install report, simulate and cancel; _streams (774): the log level endpoint, the log handlers, GET /api/logs, the chat-message door scan, the dashboard SSE stream
test_chat_mirror.py (2475 → 1526) the mirror-link request contract, the Discord DM mirror, unlink, reminder mode, pause, the channel-target listing _link_delivery (901): the mirror-link edge cases, the non-Slack backfill and its claim ordering, the inbound claim
test_taskq_runner_adapter.py (2453 → 1468) lanes, accept, admit and its cancel arms, the claim/start boundary, stop-reason recovery, the dependency and input waits _durability (953): _requeue_unstarted's refusals, the adopt sweep, the factory, the store as the only admission path, terminal writes through an outage or a crash, answers read back from the wake event
test_mcp_gatewayd_coverage.py (2449 → 1408; 1427 at HEAD, which carries main's new TestWriteDiagnostic test from #22310) the CLI socket default, the sweepers, the shutdown and credential-change paths, the abort frame, audit emitters, frame codec, inbox drain, declared env and target resolution, the zombie diagnostic, the CLI entry points, metrics, PID extraction and the connection index _acquire_respawn (1012): _acquire_backend and _respawn_backend_for_stub

Helper modules: dashboard_updates_coverage_helpers.py (174 lines), chat_mirror_helpers.py (118), taskq_runner_adapter_helpers.py (112), mcp_gatewayd_coverage_helpers.py (117). Each holds only what two or more files of its family share; three are under 150 lines for that reason.

Glue, the only lines whose AST or comments change:

  • Each original's module docstring gains one paragraph naming what it holds and where the rest lives; each new file has its own docstring.
  • Import blocks: each original drops the imports only its moved code used and imports its helpers by name; each new file and helpers module takes the origin's imports pruned to what it uses.
  • The taskq clock and store fixtures, which tests request by parameter, are re-declared @pytest.fixture(name="x") def x_fixture (the test/meetings_helpers.py convention), so a parameter never shadows an import. The two module autouse fixtures (_isolated_module_state, _clean_gateway_globals) keep their names. Every file of a family imports its fixtures with # noqa: F401, so each test keeps its BASE fixture set.
  • The gatewayd part copies the origin's pytestmark = pytest.mark.xdist_group("mcp_gateway"), the group the gateway test files share.
  • Own-line # nosemgrep: / # flake-ok: comments sit above the moved semgrep sites, sleeps, yields, unbounded awaits and clock stamps (listed under Move audit).

Rows and citations:

  • The four rows in .github/file-line-cap-baseline.txt are deleted (each file is under the cap at HEAD).
  • test/test_mcp_launch_approval_gateway.py: _GATEWAY_LAUNCH_FIXTURE_EXEMPTIONS gains test_mcp_gatewayd_coverage_acquire_respawn.py, the part that holds the respawn tests the test_mcp_gatewayd_coverage.py row exempts at BASE. That row stays, because the declared-env and target-resolver tests stay in the original (a row addition; deleting the new row makes test_gateway_spawn_and_env_tests_choose_launch_approval_fixture fail, naming the part).
  • Citations re-pointed (L29), one line per edit; citations of kept tests are unchanged:
    • docs/system-specs/modules/taskq.md:316 test_taskq_runner_adapter.py -> test_taskq_runner_adapter_durability.py (_requeue_unstarted's read-back)
    • docs/system-specs/modules/taskq.md:952 test_taskq_runner_adapter.py -> test_taskq_runner_adapter_durability.py (one case per refusal)
    • docs/system-specs/modules/taskq.md:1364 test_taskq_runner_adapter.py::test_crash_during_a_deferred_terminal_write_reconciles_the_row -> test_taskq_runner_adapter_durability.py::test_crash_during_a_deferred_terminal_write_reconciles_the_row (line 1365's :: shorthand names a test in the same file and is unchanged)
    • docs/system-specs/modules/taskq.md:1559 test_taskq_runner_adapter.py::test_adopt_pages_past_its_scan_size_so_no_queued_row_is_stranded -> test_taskq_runner_adapter_durability.py::test_adopt_pages_past_its_scan_size_so_no_queued_row_is_stranded
    • docs/system-specs/modules/taskq.md:1694-1696 "ran; adopt over accept-only + admit-only rows, twice, ..." -> "ran), test_taskq_runner_adapter_durability.py (adopt over accept-only + admit-only rows, twice, ..." (the cancel and starting-write cases before it keep test_taskq_runner_adapter.py)
    • docs/system-specs/modules/taskrunner.md:613 test/test_taskq_runner_adapter.py -> test/test_taskq_runner_adapter_durability.py
    • docs/system-specs/common/testing-conventions.md:3214 test_taskq_runner_adapter.py -> test_taskq_runner_adapter_durability.py (_one_warning)
    • docs/system-specs/modules/mcp-gateway-backend-replacement.md:87 test_mcp_gatewayd_coverage.TestRespawnBackendForStub -> test_mcp_gatewayd_coverage_acquire_respawn.TestRespawnBackendForStub
    • test/test_mcp_tool_surface.py:12 (module docstring) test_mcp_gatewayd_coverage.py -> test_mcp_gatewayd_coverage_acquire_respawn.py
    • test/test_runner_facade.py:457 (comment) test_taskq_runner_adapter.py -> test_taskq_runner_adapter_durability.py

Backwards compatibility

Compatible: test-only change. Every collected test keeps its class, name, parameters and markers (the multiset is identical before and after). The one test module that imports from an original, test/test_cross_surface_mirror.py, still imports its three names from test_chat_mirror; no production module, import path, patch target or CLI changes.

Removes nothing: every test, fixture and helper still exists; each moved unit keeps an identical AST except the clock and store fixtures, re-declared with name= and unchanged bodies.

Tests

No test was added or rewritten. These proofs show the move lost nothing:

Check Result
pytest --collect-only at BASE (4 originals) vs HEAD (9 test files) 466 = 466; the (class, name, params) multiset is identical
pytest --fixtures-per-test at BASE vs HEAD identical fixture set for every test
item markers at BASE vs HEAD identical
the 9 split files at -n0 466 passed, 100 warnings (BASE: 466 passed, the same 100 warnings)
the 9 split files at -n 3 466 passed
the 9 split files at -n0 in three seeded shuffled orders 466 passed each time
the importer test_cross_surface_mirror.py, the path readers test_mcp_launch_approval_gateway.py, test_runner_facade.py and test_updates_handlers_facade.py, and test_mcp_tool_surface.py (re-pointed docstring), plus test_flake_pattern_ratchet.py, test_wait_discipline_ratchet.py, test_file_line_cap.py, -n0 355 passed
the backend related set (71 files) plus every corpus gate scripts/leaf_test_scope.py derives (609) and every source_corpus / repo_files( scanner (122), plus the ratchets: 701 files, -n 3 39467 passed, 130 skipped, 5 xfailed
semgrep 1.78 with the CI configs and --baseline-commit BASE over the 16 changed .py files 0 findings, no parse errors; with --disable-nosem over the new files exactly the 5 marked sites
woke 0.19.0 with .woke.yml over the added lines no findings
static floor: isort (CI command), black, flake8 (CI command), black baseline, subprocess encoding, comment history, brand, docs-lint, line cap, testpaths, feature map, harness parity, cwd reads, agent-sdk boundary, memory-store seam, focus cue all exit 0

scripts/local-gate.py --base <BASE> --dry-run: backend related set 71 test files (12 in the diff, 43 name-matched, 16 referencing a changed file); frontend 379 cross-surface files (this PR changes no frontend file).

Move audit

test/test_dashboard_updates_coverage.py: 2565 -> 1098 lines; moved 99.11% (python-ast)
   changed: Expr [Expr] 21 lines    (module docstring: one appended paragraph naming what stays and where the rest lives)
test/test_chat_mirror.py: 2475 -> 1526 lines; moved 99.96% (python-ast)
   changed: Expr [Expr] 1 lines    (module docstring: one appended paragraph naming what stays and where the rest lives)
test/test_taskq_runner_adapter.py: 2453 -> 1468 lines; moved 99.57% (python-ast)
   changed: Expr [Expr] 5 lines    (module docstring: one appended paragraph naming what stays and where the rest lives)
   changed: clock [FunctionDef] 2 lines    (re-declared with name=, body unchanged)
   changed: store [FunctionDef] 2 lines    (re-declared with name=, body unchanged)
test/test_mcp_gatewayd_coverage.py: 2449 -> 1408 lines; moved 99.42% (python-ast)
   changed: Expr [Expr] 13 lines    (module docstring: one appended paragraph naming what stays and where the rest lives)

Every test function and class moved with an identical AST; the changed units are the four module docstrings (one appended layout paragraph each) and the two fixtures re-declared with name= (bodies unchanged). verify_test_split.py: no leftovers (rename-ok for both fixtures). git diff BASE...HEAD is about 447 KB.

Moved semgrep sites, each with an own-line # nosemgrep: (no module of these families calls monkeypatch.undo()): dashboard_updates_coverage_helpers.py (_isolated_module_state) and, in test_dashboard_updates_coverage_streams.py, the class-level _own_shutdown_event (twice) and _warm_status_counts fixtures (test-autouse-shared-monkeypatch, between the decorator and the def) and the 10 ms pause in the stubbed wait_for (test-sleep-as-barrier). Pre-emptive own-line # flake-ok: markers sit above the 19 moved timing shapes: one-iteration yields and the fake sleep's yield, the 10 ms pause, unbounded awaits of cancelled or parked tasks, the unbounded gather of the update worker, a parked Event().wait() task, the hanging writer double, two real-clock stamps and one process-wide asyncio.wait_for stub. Kept in their originals: every other timing shape and semgrep sleep site of the four files, among them the asyncio.sleep(0) yield and the gather in the dashboard original's TestExternallyManagedCheck. AKIAIOSFODNN7EXAMPLE, AWS's documented example id, moves bare once inside TestMirrorBackfillFidelity.

Moved findings and their markers (BASE site = the line in the original):

Marker line Site Construct BASE site
test/dashboard_updates_coverage_helpers.py:27 :28 def _isolated_module_state(monkeypatch, tmp_path): test/test_dashboard_updates_coverage.py:48
test/test_dashboard_updates_coverage_streams.py:309 :310 def _own_shutdown_event(self, monkeypatch): test/test_dashboard_updates_coverage.py:1892
test/test_dashboard_updates_coverage_streams.py:411 :412 await asyncio.sleep(0.01) test/test_dashboard_updates_coverage.py:1991
test/test_dashboard_updates_coverage_streams.py:481 :482 def _own_shutdown_event(self, monkeypatch): test/test_dashboard_updates_coverage.py:2058
test/test_dashboard_updates_coverage_streams.py:488 :489 def _warm_status_counts(self, monkeypatch): test/test_dashboard_updates_coverage.py:2064
Marker line Site Shape BASE site
test/test_dashboard_updates_coverage_apply.py:60 :61 await asyncio.sleep(0) test/test_dashboard_updates_coverage.py:1044
test/test_dashboard_updates_coverage_apply.py:110 :111 await hold.wait() test/test_dashboard_updates_coverage.py:1093
test/test_dashboard_updates_coverage_apply.py:417 :418 await asyncio.gather(*list(state._background_tasks)) test/test_dashboard_updates_coverage.py:1399
test/test_dashboard_updates_coverage_apply.py:601 :602 await asyncio.gather(*list(state._background_tasks)) test/test_dashboard_updates_coverage.py:1582
test/test_dashboard_updates_coverage_streams.py:387 :388 await task test/test_dashboard_updates_coverage.py:1969
test/test_dashboard_updates_coverage_streams.py:410 :412 await asyncio.sleep(0.01) test/test_dashboard_updates_coverage.py:1991
test/test_dashboard_updates_coverage_streams.py:416 :417 monkeypatch.setattr(asyncio, "wait_for", _no_waiting) test/test_dashboard_updates_coverage.py:1995
test/test_dashboard_updates_coverage_streams.py:424 :425 await task test/test_dashboard_updates_coverage.py:2002
test/test_dashboard_updates_coverage_streams.py:498 :499 monkeypatch.setattr(sc, "_counts_cache_ts", time.monotonic()) test/test_dashboard_updates_coverage.py:2073
test/test_dashboard_updates_coverage_streams.py:770 :771 resp = await task test/test_dashboard_updates_coverage.py:2344
test/taskq_runner_adapter_helpers.py:37 :38 await asyncio.sleep(0) test/test_taskq_runner_adapter.py:46
test/test_taskq_runner_adapter_durability.py:532 :533 live = await parked # the slot freed and the live admission claimed it test/test_taskq_runner_adapter.py:2035
test/test_taskq_runner_adapter_durability.py:610 :611 await wait test/test_taskq_runner_adapter.py:2112
test/test_taskq_runner_adapter_durability.py:863 :864 await wait test/test_taskq_runner_adapter.py:2364
test/mcp_gatewayd_coverage_helpers.py:45 :46 await asyncio.sleep(3600) test/test_mcp_gatewayd_coverage.py:68
test/mcp_gatewayd_coverage_helpers.py:77 :78 now = time.monotonic() test/test_mcp_gatewayd_coverage.py:112
test/mcp_gatewayd_coverage_helpers.py:104 :105 await task test/test_mcp_gatewayd_coverage.py:138
test/test_mcp_gatewayd_coverage_acquire_respawn.py:253 :254 old_task = asyncio.create_task(asyncio.Event().wait()) test/test_mcp_gatewayd_coverage.py:1242
test/test_mcp_gatewayd_coverage_acquire_respawn.py:255 :256 await asyncio.sleep(0) test/test_mcp_gatewayd_coverage.py:1243

Diff alignment (L36): for every changed file, git diff BASE -- <file> and git diff --minimal BASE -- <file> give the same added/deleted counts: dashboard 17/1484, chat mirror 21/970, taskq 19/1004, gatewayd 18/1059, line-cap baseline 0/4, taskq.md 7/7, taskrunner.md 1/1, testing-conventions.md 1/1, mcp-gateway-backend-replacement.md 1/1, test_mcp_tool_surface.py 1/1, test_runner_facade.py 1/1, test_mcp_launch_approval_gateway.py 1/0, and each new file only added lines.

Logger names (L25): no new module defines a logger; _RUNNER_LOGGER is the string "kiro_crew.taskq.adapters.runner", unchanged.

CI path references

None: no workflow filter, explicit file list, AUTOSDE.yaml glob or sensitive-change glob names these four files.

Manual verification

N/A: unit coverage is sufficient. This is a test-only move, and the collected-test multiset plus the full run of every moved test prove it.

Related Issues

Part of #20192

Follow-up: #20383 (pre-existing shapes moved verbatim; de-flake there)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 19, 2026 14:53
@bolichen97
bolichen97 requested a review from CrysisDeu October 19, 2026 14:53
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision dbf7db5eaf517b067a4b290a69f9f070acda9328 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision dbf7db5eaf517b067a4b290a69f9f070acda9328 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of dbf7db5eaf517b067a4b290a69f9f070acda9328 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] dbf7db5

Description read

[DESCRIPTION-READ] cb3b76070afa6e54c14a9e2c9bdc7033b920fae21785d17dec88432f7b96d07c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of dbf7db5eaf517b067a4b290a69f9f070acda9328 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] dbf7db5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt dbf7db5eaf517b067a4b290a69f9f070acda9328: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed dbf7db5eaf517b067a4b290a69f9f070acda9328 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] dbf7db5

Verdict parsed from the review's SHA-scoped output markers for commit dbf7db5eaf517b067a4b290a69f9f070acda9328.

False positive or not applicable? A repository writer can comment:
/ai-review override fable dbf7db5eaf517b067a4b290a69f9f070acda9328: <one-sentence reason>

@bolichen97
bolichen97 enabled auto-merge (squash) October 19, 2026 15:05
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 2826298 to pick up #22178 (main's Harness Parity, frame-replay and set-gate reds); the change itself is identical to the reviewed head 9de8b78 (-U0 patch compared in the push slot). CI re-running.

@bolichen97
bolichen97 force-pushed the refactor/linecap-t64-test-dashboard-updates-coverage branch from 9de8b78 to b4a5841 Compare October 19, 2026 19:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 19, 2026
chenmingwei23
chenmingwei23 previously approved these changes Oct 20, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main aa71296: the PR conflicted only in .github/file-line-cap-baseline.txt rows, resolved as main's rows minus this PR's four; the change itself is identical to the reviewed head b4a5841 (-U0 patch compared in the push slot). CI re-running.

@bolichen97
bolichen97 force-pushed the refactor/linecap-t64-test-dashboard-updates-coverage branch from b4a5841 to c24b4ca Compare October 20, 2026 00:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 20, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

@chenmingwei23 a rebase dismissed your approval. The new head c24b4ca is green, with readiness: passed and Opus/GPT/Design/First Principles all passing. Could you re-approve when you have a moment?

[operator: bolichen97]

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Holding at c24b4ca: GitHub reports a merge conflict with main. Please rebase.

The split itself looks faithful. Comparing AST units against the merge base, every test body in the four files is unchanged. The only differences are module docstrings, a repeated pytestmark, and fixtures renamed to *_fixture with name= keeping the old names. test_cross_surface_mirror.py L21 still finds its three names in test_chat_mirror.py. Checks on this head are green. A rebase that only resolves the conflict would need another look before approval.

— crew-pr-reviewer (r114)

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 453cc4b: the PR conflicted only in .github/file-line-cap-baseline.txt rows, resolved as main's rows minus this PR's four; the change itself is identical to the reviewed head c24b4ca (-U0 patch compared in the push slot). CI re-running.

@bolichen97
bolichen97 force-pushed the refactor/linecap-t64-test-dashboard-updates-coverage branch from c24b4ca to f200160 Compare October 20, 2026 05:49
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 20, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every review lane on the head is clean (only runner notices and PR Scope / Opus size warnings); held by the triage cron on size, path, tie or checklist rules alone. Approved on the watch holder's request.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
test_dashboard_updates_coverage.py (2565 lines), test_chat_mirror.py
(2475), test_taskq_runner_adapter.py (2453) and
test_mcp_gatewayd_coverage.py (2449) were each over the 2,000-line cap.
Each now keeps a contiguous run of its own tests (1098, 1526, 1468 and
1408 lines), and the rest moves verbatim into topic siblings: the update
apply and the log streams; the mirror-link delivery cases; the
runner-adapter durability cases; gatewayd's backend acquire and respawn.
Support units that two or more files read live in per-family
*_helpers.py modules.

Every test moves with an identical AST: the collected (class, name,
params) multiset, the fixtures per test and the markers are unchanged.
The only non-move lines are the docstrings, the import headers, the
taskq clock/store fixtures re-declared with name=, own-line nosemgrep
and flake-ok markers above moved findings, the four line-cap rows, one
launch-approval exemption row for the respawn part, and the citations
that name where the moved tests live.

Part of #20192
@bolichen97
bolichen97 force-pushed the refactor/linecap-t64-test-dashboard-updates-coverage branch from f200160 to dbf7db5 Compare October 20, 2026 17:01
@bolichen97

Copy link
Copy Markdown
Contributor Author

@KiroCrewCaptain a rebase dismissed your approval of f200160. Rebased onto main ac8a408: the PR conflicted only in .github/file-line-cap-baseline.txt rows, resolved as main's rows minus this PR's four. The rest of the change is identical to the head you approved (-U0 patch compared). New head dbf7db5; CI re-running. Could you re-approve once it is green?

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 20, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every review lane on the new head is clean (Design PASS, UX and First Principles skipped as test-only; only runner notices); held by the triage cron on the 21-file cap alone. Approved on the watch holder's request.

@bolichen97
bolichen97 merged commit a06fa9c into main Oct 20, 2026
104 of 105 checks passed
@bolichen97
bolichen97 deleted the refactor/linecap-t64-test-dashboard-updates-coverage branch October 20, 2026 19:51
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
@rubencu rubencu mentioned this pull request Oct 22, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants