Repository navigation
fix(dashboard): keep feature-preview switches on the gateway - #22298
mbriones98 wants to merge 2 commits into
Conversation
The Feature previews switches lived only in browser localStorage, so a new origin, the desktop app beside a browser tab, or cleared site data turned them back off. Each switch is now stored in the gateway config under dashboard.feature_previews.<name>, written through the existing owner-only config PATCH, with localStorage kept as a cache. A switch set only in this browser is carried up once with if_unset; a refused toggle names the switch that went back and says why. A carry-up refused as owner-only says the switch stays on in this browser only, with no reload step. Each browser records which switches it has seen the gateway hold, so a switch removed there reads as off even when another switch's carry-up failed. Fixes #21396
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The one-time migration of six preview bools uses a 329-line client-side state machine that never retires. Watch
Suggestions
[DESIGN-REVIEWED] ea33f88 Description read[DESCRIPTION-READ] 65296e7b2063c1e362c8e66575472c1d911ebcbb18c6b0eb82f399aa5b820ec9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS One cause, "not the owner", has two opposite outcomes: one notice says the switch "was switched back", the other says it "stays on in this browser only". The blind reader couldn't tell why. Watch
Suggestions
[UX-REVIEWED] ea33f88 Description read[DESCRIPTION-READ] 45690a452e48fb5698a573af04eb874159b6d8367514c4fbf6ba991d5ae1a212 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The write queue in Not justified as shipped
What this change shipsInventory (8 items) — 6 justifiedIntent: a preview switch stays on across browsers and the desktop app on one gateway. This is a FIX (#21396).
Blockers
[FIRST-PRINCIPLES-REVIEWED] ea33f88 Description read[DESCRIPTION-READ] 2a585fbbc8613587d11188e5c8a47f9ea8ff95f9624594eeb14a242db5749fc5 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — docs/system-specs/modules/learn-cron-dashboard.md:4980 — the spec that owns this code still says a preview flag is "the localStorage key of a per-device opt-in", but this PR makes the gateway's [OPUS-REVIEWED] ea33f88 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…sist-21396-v6 # Conflicts: # src/kiro_crew/dashboard/handlers/core.py
|
Superseded by #22544, the same change rebuilt as one commit off current main, with the cache write using the shared setConfigPathValue helper. |
Pull request was closed
Problem / Motivation
Goal: A Feature previews switch (such as Crewmates) stays on once you turn it on, in every browser and in the desktop app that use the same Kiro Crew.
The switches under Settings > Developer > Feature previews were kept only in browser localStorage (
mc-preview-*). A new origin or port, the desktop app next to a browser tab, or cleared site data each read the switch as off, so Crewmates and the other previews kept turning themselves off.Why it matters
Anyone trying a preview has to turn it on again on every surface and after every storage reset. A preview that seems to switch itself off reads as broken.
Not a goal
DURABLE_PREF_KEYS//api/ui-prefsbackup, so there is one source of truth.configKey/ settings-registry entries for the new paths (<SettingRef>deep links). That is a separate navigation feature.What changed (motivation → approach → change)
Symptom: a switch turned on in one surface is off in another. Root cause: localStorage was the only copy.
#21396 was filed by its owner asking for the switches to sync across surfaces, so moving them from per-device to gateway-wide is the requested behaviour, not a side effect.
Approach: the gateway config keeps each switch, and localStorage stays as a fast cache. Config rather than adding the keys to
DURABLE_PREF_KEYS: the uiPrefs backup restores only on a cold profile, so a warm desktop app and a warm browser tab would never pick up each other's change. The config route reaches every open dashboard through the configrefreshframe it already receives.sections_dashboard.py,loader_builders.py,loader.py,sections.py,handlers/core.py,change_card_catalog.py):dashboard.feature_previews.<name>, for the 6 live flags:webhooks,artifact_deploy,crew,remote_crew_chat,layout_harness,folder_conductor.configuration.mdandconfig-baseline.jsonare updated.mc-preview-instance-sessionskey is not kept on the gateway. Its ON is carried up asremote_crew_chat.usePreviewFlagServerSync.ts, mounted inshell/appShell.tsxbeside the shell's existing reader of the same config query, so boot order is unchanged):if_unset, so it never replaces a stored value.kc-feature-previews-syncedmarker makes a cache-only ON read as off, so a key the operator removed stays off. The marker is not set while a toggle is in flight, or after a refused toggle or a refused carry, so a browser-only value is never wiped.kc-feature-previews-server-backed, with an in-memory copy for when storage is full). A recorded switch that the gateway no longer holds reads as off even before the browser is marked synced, so another switch's failed carry-up cannot send a removed switch back up.{{productName}}), without the word "gateway".en-XAis regenerated.Overlap: open PR #20420 also edits
DURABLE_PREF_KEYS. This PR does not touch that list, so the two do not conflict.Backwards compatibility
Compatible: the new config fields are optional and default to off, the PATCH allowlist only gains names, and an existing browser-only ON is carried up once instead of being dropped.
The diff takes one thing away: localStorage is no longer the source of truth for a switch. Once synced, a cache-only ON that the gateway does not hold reads as off, and a non-owner's toggle no longer overrides the gateway's stored value.
Reader: website/src/utils/previewFlags.ts:readPreviewFlag -- chat|crew page -- still reads the cache, which reconcile keeps equal to the gateway copy | previewFlagServerSync.test.tsx "lets the server copy win over a stale browser copy"
Reader: website/src/hooks/usePreviewFlag.ts:usePreviewFlag / useRemoteCrewChat -- chat|crew page -- re-renders on the same cache write event | previewFlagServerSync.test.tsx "turns Crewmates on from the server when this browser has no copy"
Reader: website/src/surfaces/registry.ts:surfacePreviewEnabled (nav rail, pagesProvider, appNavHidden, CommandBarOverlay) -- chat|crew page -- reads the cache via readPreviewFlag | previewSurfaces.test.tsx
Reader: website/src/pages/settings/FeaturePreviewsSection.tsx -- crew page -- toggles still write the cache first, then the gateway | previewSurfaces.test.tsx "says why a switch went back when the gateway refuses the write"
Reader: non-owner dashboard session (e.g. a QR session) -- chat|crew page -- intended: config saves are owner-only, so it sees every switch the owner set (the config GET is not owner-gated), its own toggle is refused and switched back with the owner-only notice, and a switch it had already turned on in that browser stays on there | featurePreviewsSectionNotice.test.tsx "names the %s switch when the owner-only write is refused", "names the owner, not a reload, when a one-time carry is refused as owner-only"
Reader: retired mc-preview-instance-sessions -- chat -- carried up as remote_crew_chat, then cleared | previewFlagServerSync.test.tsx "carries the retired Remote crew sessions switch up as Chat on a crew", "never lets the retired key turn Chat on a crew back on after it was turned off"
Tests
website/src/test/previewFlagServerSync.test.tsx(33 tests). The repro: Crewmates turns on from the server when localStorage is empty, and it fails with the sync disabled. The other tests cover:if_unsetcarry-up, not replacing a stored value, a 409 counted as synced, and a refused carry reported and kept on;PREVIEW_FLAGSand every declared flag constant.I removed each of these lines on a scratch copy, and each removal makes a test fail:
pending.sizeguard;website/src/test/previewSurfaces.test.tsx: the section shows the owner-only notice naming the switch when the PATCH returns 403.website/src/test/featurePreviewsSectionNotice.test.tsx(11 tests), with the sync mounted as the shell mounts it:It lifts
FeaturePreviewsSection.tsxabove the 80% per-file coverage floor (93.9% of lines locally, across the tests that render it).test/test_feature_previews_config.py(25 tests):if_unsetwrites an absent switch and never replaces a stored one;Local runs on this commit:
src/i18nfolder including thestyle/French U+202F and Korean checks, and every test that mounts the shell orApp.FeaturePreviewsSection.tsxis at 93.9% of lines andusePreviewFlagServerSync.tsat 100% in that run.tsc(app),eslint --max-warnings 0on the touched files,check-i18n-strings.mjs,check-i18n-keys.mjsandi18n-check.mjsare clean withI18N_BASE_REFset to the base commit, and the regenerateden-XAhas no diff.test_feature_previews_config.py,test_facade_mirror_guards.py,test_config_baseline.pyandtest_change_card_setting_classes.pypass (116). The full backend run on the previous cut matchedorigin/main's failure set on this host, which come from the host itself (enterprise profile, liveKIROCREW_HOME, no userns). black, isort, flake8 and mypy are clean on the changed Python.Local AI review: GPT (
gpt-6.1-sol) and Opus read-only reviews ran over several rounds. Each quoted the commit SHA it read, and I checked those against the worktree. Every Critical/High/Medium finding is fixed in this commit, and the final round on the last code change found none open. On this rebuild, a GPT (gpt-6.1-sol) and an Opus review of the new commit each quoted its SHA, confirmed the diff matches fix(dashboard): keep feature-preview switches on the gateway #22000 apart from theshell/appShell.tsxline kept from main, and found nothing Critical or High.Manual verification
I took screenshots against the built SPA, with
/api/config/kirocrewreturningcrew: true:Screenshots / video
Synced from the gateway (Crewmates on, empty browser storage):
A toggle refused with 403, naming the switch:
A toggle refused with 500 (the same notice shows for an expired session's 403), naming the switch:
A browser-only switch whose carry-up failed:
A browser-only switch whose carry-up was refused as owner-only (403): the switch stays on, the notice names the owner and has no reload step:
Known unrelated CI failures: Backend Tests (Windows) (1) hits the
test_ci_ipv6_routingcollect timeout (#21943), and Backend Tests (3.12, 2) hits thetest_facade_mirror_guardstree-scan timeout on a slow runner (#22004/#22007). This change touches neither test.Related Issues
Fixes #21396
Related: #16237, #17424, #14232, #9876
Replaces #22000, which began conflicting with main after #15370 renamed a value on the
useKiroUsageReadout()line inshell/appShell.tsx, right above this change's hook call, and already had the two commits PR Hygiene allows. This is the same change as one commit off current main: it keeps main's version of that line and calls the sync hook after it. Earlier versions: #21722, #21624, #21602 and #21569.Pattern harvest
Rule candidate: review-prompt
Pattern: a user-visible setting persisted only in browser localStorage, when it is meant to hold across surfaces of the same gateway; check whether it should live in gateway config with localStorage as a cache.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.