Skip to content

fix(dashboard): keep feature-preview switches on the gateway - #22544

Closed
mbriones98 wants to merge 2 commits into
mainfrom
fix/preview-flags-persist-21396-v7
Closed

mbriones98 wants to merge 2 commits into
mainfrom
fix/preview-flags-persist-21396-v7

Conversation

@mbriones98

@mbriones98 mbriones98 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Feature previews switch (such as Crewmates) stays on once you turn it on, in every browser and in the desktop app that use the same Kiro Crew.

The switches under Settings > Developer > Feature previews were kept only in browser localStorage (mc-preview-*). A new origin or port, the desktop app next to a browser tab, or cleared site data each read the switch as off, so Crewmates and the other previews kept turning themselves off.

Why it matters

Anyone trying a preview has to turn it on again on every surface and after every storage reset. A preview that seems to switch itself off reads as broken.

Not a goal

  • No change to what any preview does once it is on.
  • No new route and no auth change: writes go through the existing owner-only config PATCH.
  • No per-user scope. The switches belong to the gateway, like every other dashboard setting in config.
  • No change to the DURABLE_PREF_KEYS / /api/ui-prefs backup, so there is one source of truth.
  • No configKey / settings-registry entries for the new paths (<SettingRef> deep links). That is a separate navigation feature.

What changed (motivation → approach → change)

Symptom: a switch turned on in one surface is off in another. Root cause: localStorage was the only copy.

#21396 was filed by its owner asking for the switches to sync across surfaces, so moving them from per-device to gateway-wide is the requested behaviour, not a side effect.

Approach: the gateway config keeps each switch, and localStorage stays as a fast cache. Config rather than adding the keys to DURABLE_PREF_KEYS: the uiPrefs backup restores only on a cold profile, so a warm desktop app and a warm browser tab would never pick up each other's change. The config route reaches every open dashboard through the config refresh frame it already receives.

  • Backend (sections_dashboard.py, loader_builders.py, loader.py, sections.py, handlers/core_config_schema.py, handlers/core.py, change_card_catalog.py):
    • One bool per switch under dashboard.feature_previews.<name>, for the 6 live flags: webhooks, artifact_deploy, crew, remote_crew_chat, layout_harness, folder_conductor.
    • The PATCH allowlist accepts only those names, typed bool. The loader drops unknown names and non-bool values.
    • The change card classifies the new paths, and configuration.md and config-baseline.json are updated.
    • The retired mc-preview-instance-sessions key is not kept on the gateway. Its ON is carried up as remote_crew_chat.
  • Dashboard (usePreviewFlagServerSync.ts, mounted in shell/appShell.tsx beside the shell's existing reader of the same config query, so boot order is unchanged):
    • Reconcile: the server value wins over the cache, except for a flag whose write is still in flight.
    • Write order: each toggle is PATCHed, and writes for one flag are sent one after another so the last click is what the gateway keeps. An accepted write is stored in the cached config with the shared setConfigPathValue helper.
    • One-time carry-up: a switch set only in this browser before the gateway kept the switches is carried up once with if_unset, so it never replaces a stored value.
    • Sync marker: afterwards a kc-feature-previews-synced marker makes a cache-only ON read as off, so a key the operator removed stays off. The marker is not set while a toggle is in flight, or after a refused toggle or a refused carry, so a browser-only value is never wiped.
    • Per-switch record: each browser also records which switches it has seen the gateway hold (kc-feature-previews-server-backed, with an in-memory copy for when storage is full). A recorded switch that the gateway no longer holds reads as off even before the browser is marked synced, so another switch's failed carry-up cannot send a removed switch back up.
    • Refused toggle: the switch goes back to the last value the gateway accepted, and the section shows an error notice naming the switch. On a 403 it says only the owner can change feature previews. On any other failure, including a 403 from an expired session, it says the save failed.
    • Refused carry: the notice says the switch is on in this browser only. When the carry is refused as owner-only (403), it says only the owner can save the switch for everyone, with no reload step, since a reload would be refused the same way.
  • Copy:
    • The section description no longer says "per-device". It now says the switches are saved for everyone using this Kiro Crew ({{productName}}), without the word "gateway".
    • Four new notice strings.
    • All 12 translated catalogs are updated, and en-XA is regenerated.

Why this does not use useOptimisticConfigPaths: that hook gives one settings component an in-flight display value per config path and lets saves run side by side. The switches here are shared by every surface outside any one component, so the sync keeps its own small queue. It sends one switch's writes in click order, so the gateway keeps the last click, and when a write is refused it puts the switch back to the last value the gateway accepted, in the cache and in localStorage. The hook does neither of those, so only its path-write helper is reused.

Overlap: open PR #20420 also edits DURABLE_PREF_KEYS. This PR does not touch that list, so the two do not conflict.

Backwards compatibility

Compatible: the new config fields are optional and default to off, the PATCH allowlist only gains names, and an existing browser-only ON is carried up once instead of being dropped.

The diff takes one thing away: localStorage is no longer the source of truth for a switch. Once synced, a cache-only ON that the gateway does not hold reads as off, and a non-owner's toggle no longer overrides the gateway's stored value.
Reader: website/src/utils/previewFlags.ts:readPreviewFlag -- chat|crew page -- still reads the cache, which reconcile keeps equal to the gateway copy | previewFlagServerSync.test.tsx "lets the server copy win over a stale browser copy"
Reader: website/src/hooks/usePreviewFlag.ts:usePreviewFlag / useRemoteCrewChat -- chat|crew page -- re-renders on the same cache write event | previewFlagServerSync.test.tsx "turns Crewmates on from the server when this browser has no copy"
Reader: website/src/surfaces/registry.ts:surfacePreviewEnabled (nav rail, pagesProvider, appNavHidden, CommandBarOverlay) -- chat|crew page -- reads the cache via readPreviewFlag | previewSurfaces.test.tsx
Reader: website/src/pages/settings/FeaturePreviewsSection.tsx -- crew page -- toggles still write the cache first, then the gateway | previewSurfaces.test.tsx "says why a switch went back when the gateway refuses the write"
Reader: non-owner dashboard session (e.g. a QR session) -- chat|crew page -- intended: config saves are owner-only, so it sees every switch the owner set (the config GET is not owner-gated), its own toggle is refused and switched back with the owner-only notice, and a switch it had already turned on in that browser stays on there | featurePreviewsSectionNotice.test.tsx "names the %s switch when the owner-only write is refused", "names the owner, not a reload, when a one-time carry is refused as owner-only"
Reader: retired mc-preview-instance-sessions -- chat -- carried up as remote_crew_chat, then cleared | previewFlagServerSync.test.tsx "carries the retired Remote crew sessions switch up as Chat on a crew", "never lets the retired key turn Chat on a crew back on after it was turned off"

Tests

  • website/src/test/previewFlagServerSync.test.tsx (33 tests). The repro: Crewmates turns on from the server when localStorage is empty, and it fails with the sync disabled. The other tests cover:

    • writes, in-flight protection, and rapid toggles applied in click order;
    • a refused toggle reverting in synced and unsynced browsers, with no config body, after two or three refused clicks, and behind a refused carry;
    • the notice waiting for the last queued click, and being cleared only by a save of the same switch;
    • a 403 from an expired session reported as a failed save;
    • the one-time if_unset carry-up, not replacing a stored value, a 409 counted as synced, and a refused carry reported and kept on;
    • the sync marker not being set while a toggle is in flight, whether the in-flight read lands from the config read or from another switch's carry;
    • a switch the gateway held and then dropped reads as off when another switch's carry-up failed, also when the per-switch record cannot be stored, and the browser-only switch stays on;
    • an unreadable per-switch record reads as empty;
    • the retired key;
    • parity between PREVIEW_FLAGS and every declared flag constant.
  • I removed each of these lines on a scratch copy, and each removal makes a test fail:

    • the revert itself;
    • the per-flag baseline;
    • the in-flight guards;
    • the pending.size guard;
    • the last-queued-click guard on the notice;
    • the same-switch notice clear;
    • the per-switch record check, and its in-memory copy.
  • website/src/test/previewSurfaces.test.tsx: the section shows the owner-only notice naming the switch when the PATCH returns 403.

  • website/src/test/featurePreviewsSectionNotice.test.tsx (11 tests), with the sync mounted as the shell mounts it:

    • a 403 on each of the 6 switches shows the owner-only notice naming that switch;
    • a 500 shows the "couldn't save" notice;
    • a refused one-time carry says the switch is on in this browser only, and it stays on;
    • a one-time carry refused as owner-only names the owner and has no reload step;
    • the Artifact Deploy and Webhooks links open their pages.

    It lifts FeaturePreviewsSection.tsx above the 80% per-file coverage floor (93.9% of lines locally, across the tests that render it).

  • test/test_feature_previews_config.py (25 tests):

    • the gateway list matches the dashboard flags, and nothing is on by default;
    • the loader keeps only known names with bool values;
    • each switch is writable, and unknown names or non-bools write nothing;
    • if_unset writes an absent switch and never replaces a stored one;
    • a non-owner cannot write a switch.
  • Local runs on this commit:

    • Frontend: 130 test files (2,062 tests) pass on this commit: the preview sync, notice and surfaces tests, useOptimisticConfigPaths, the settings pages, the whole src/i18n folder including the style/ French U+202F and Korean checks, and every App and shell test. FeaturePreviewsSection.tsx is at 93.9% of lines and usePreviewFlagServerSync.ts at 100% in that run. tsc (app), eslint src/ --max-warnings 0, check-i18n-strings.mjs, check-i18n-keys.mjs and i18n-check.mjs are clean with I18N_BASE_REF set to the base commit, and the regenerated en-XA has no diff.
    • Backend: test_feature_previews_config.py, test_facade_mirror_guards.py, test_config_patch.py, test_config_schema.py and test_dashboard_config_gitlab_hosts.py pass (305), with the slowest tree scan well under the 120 s limit.
  • Local AI review: GPT (gpt-6.1-sol) and Opus read-only reviews ran over several rounds. Each quoted the commit SHA it read, and I checked those against the worktree. Every Critical/High/Medium finding is fixed in this commit, and the final round on the last code change found none open. On this rebuild, a GPT (gpt-6.1-sol) and an Opus review of the new commit each quoted its SHA, confirmed the diff matches fix(dashboard): keep feature-preview switches on the gateway #22298 apart from the setConfigPathValue write, and found nothing Critical or High.

Manual verification

I took screenshots against the built SPA, with /api/config/kirocrew returning crew: true:

  • With empty localStorage, Crewmates shows on.
  • With the PATCH returning 403, flipping Webhooks puts it back and the notice names it.
  • With the PATCH returning 500, flipping Webhooks puts it back and the notice says it couldn't be saved.
  • With a browser-only Webhooks ON and the carry PATCH returning 500, the notice says it is on in this browser only.

Screenshots / video

Synced from the gateway (Crewmates on, empty browser storage):

Feature previews section synced from the gateway

A toggle refused with 403, naming the switch:

Owner-only notice naming Webhooks

A toggle refused with 500 (the same notice shows for an expired session's 403), naming the switch:

Couldn't save notice naming Webhooks

A browser-only switch whose carry-up failed:

On in this browser only notice

A browser-only switch whose carry-up was refused as owner-only (403): the switch stays on, the notice names the owner and has no reload step:

Owner-only carry-up notice, switch still on

Known unrelated CI failure: Backend Tests (Windows) (1) hits the test_ci_ipv6_routing collect timeout (#21943). This change does not touch that test.

Related Issues

Fixes #21396

Related: #16237, #17424, #14232, #9876

Replaces #22298, which already had the two commits PR Hygiene allows, so the switch to the shared setConfigPathValue helper could not be added there. This is the same change as one commit off current main, with that cache write as the only code difference. Earlier versions: #22000, #21722, #21624, #21602 and #21569.

Pattern harvest

Rule candidate: review-prompt
Pattern: a user-visible setting persisted only in browser localStorage, when it is meant to hold across surfaces of the same gateway; check whether it should live in gateway config with localStorage as a cache.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

The Feature previews switches lived only in browser localStorage, so a
new origin, the desktop app beside a browser tab, or cleared site data
turned them back off. Each switch is now stored in the gateway config
under dashboard.feature_previews.<name>, written through the existing
owner-only config PATCH, with localStorage kept as a cache. A switch set
only in this browser is carried up once with if_unset; a refused toggle
names the switch that went back and says why. A carry-up refused as
owner-only says the switch stays on in this browser only, with no
reload step. Each browser records
which switches it has seen the gateway hold, so a switch removed there
reads as off even when another switch's carry-up failed. An accepted
save is written into the cached config with the shared
setConfigPathValue helper.

Fixes #21396
@mbriones98
mbriones98 requested review from a team and KiroCrewCaptain as code owners October 20, 2026 19:01
@mbriones98
mbriones98 requested a review from bolichen97 October 20, 2026 19:01
@mbriones98
mbriones98 enabled auto-merge (squash) October 20, 2026 19:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of bdb8e75fcad93911f70040694cf79c300e727e7b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the client reconcile logic in usePreviewFlagServerSync.ts cannot leave a browser stuck with a switch the gateway no longer holds after a carry-up is refused. It uses two markers: the synced marker and the per-switch server-backed record.

[DESIGN-REVIEWED] bdb8e75

Description read

[DESCRIPTION-READ] 50f9e9d4194928ea58a776586c02e4c6220924c40e980174ef1a8192b49f1507

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of bdb8e75fcad93911f70040694cf79c300e727e7b — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

Carrying old browser-only switches up to the gateway costs two permanent localStorage concepts, two notices and a retired-key path, all to spare one re-toggle of an unreleased preview.

Not justified as shipped

  • Item 3 — oversized: the Goal is "stays on once you turn it on". The one-time carry-up is the only reason kc-feature-previews-synced, kc-feature-previews-server-backed (plus its in-memory copy), carryFailed and the carry-only branches of the write queue exist. Without it, someone who had a switch on before upgrading turns it on once more.
    Subtraction: delete the carry-up, PREVIEW_FLAGS_SYNCED_KEY, PREVIEW_FLAGS_SERVER_BACKED_KEY, the two feature_previews_carry_* strings and the PREVIEW_INSTANCE_SESSIONS carry (items 4 and 5), so reconcile becomes "the server value wins except for a write still in flight".
    Clears when: the carry-up machinery is removed, or an issue shows that losing a browser-only ON once harms someone.
  • Item 2 — inherited: Crewmates feature-preview toggle does not persist (stored only in browser localStorage) #21396 asks for sync, not for non-owner sessions to lose their own switch. That loss comes only from reusing the owner-only PATCH, and the Goal never names it.
    Clears when: Crewmates feature-preview toggle does not persist (stored only in browser localStorage) #21396 or a maintainer explicitly takes away a non-owner's own preview switch.
  • Item 6 — undeclared: the askAgent hand-off on the save-error notice is never mentioned in the description.

What this change ships

Inventory (9 items) — 4 justified

Intent: keep a Feature previews switch on across every browser and the desktop app using one gateway. FIX.

  1. Feature-preview switches are stored on the gateway, the same on every surface — justified
  2. Non-owner sessions can no longer turn a preview on or off for themselves — inherited
  3. Switches set only in one browser are carried up once, with sync markers — oversized
  4. The retired Remote crew sessions switch carries up as Chat on a crew — rides along
  5. Settings shows a notice naming a refused switch (4 strings) — rides along
  6. The notice offers an "ask the agent" hand-off — undeclared
  7. New dashboard.feature_previews config key, writable by name, documented — justified
  8. The change card treats a preview toggle as non-widening — justified
  9. The section copy no longer says "per-device" — justified

[FIRST-PRINCIPLES-REVIEWED] bdb8e75

Description read

[DESCRIPTION-READ] 5a1e5003a767987e1d89e13142b67b6f5ed5112b7cb847ab80a606ca4933e729

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of bdb8e75fcad93911f70040694cf79c300e727e7b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The new notices and intro talk about "everyone" and "the owner" without saying who that is, and two non-owner results read as contradictory.

Watch

  • "Saved for everyone" puts people off trying previews. The new intro opens with "These switches are saved for everyone using this {{productName}}". The blind reader took that to mean other people are affected, and said "It makes me nervous to touch anything below it." In a single-user tool the real point is that a switch stays on in every browser and in the desktop app, but the sentence leads with the audience instead. Every visitor to this section reads it, so it works against the PR's goal of previews that stay on. Fix: start with the result for the user.
  • "Owner" is never explained, and two owner-only outcomes look the same. feature_previews_save_denied ends "was switched back". feature_previews_carry_denied says "stays on in this browser only". The reader's words: "same cause… but the result is different… I can't predict which one will happen to me." They also asked: "I don't know who 'the owner' is, or whether that's me." This only reaches non-owner sessions, but it leaves them confused each time they see it. Fix: say who the owner is (for example, "whoever runs this {{productName}}"). Make the carry notice say why this browser differs: the switch was already on here before.
  • "Reload the page to try again" makes users afraid to reload. The reader on feature_previews_carry_failed: "I wouldn't reload, because I'm afraid of losing the setting." A refused carry does not clear the cached ON, so a reload is safe, but the copy never says so. That leaves the one repair step unused. Fix: add that the switch stays on here until the save works.

Suggestions

  • feature_previews_desc: "Unreleased features and pages. Each switch stays set in every browser and in the desktop app connected to this {{productName}}. …"
  • feature_previews_carry_failed: "“{{name}}” is on in this browser only, because it couldn't be saved to this {{productName}}. It stays on here; reload to try saving again."
  • feature_previews_save_failed: change "Try again." to "Flip the switch to try again." The blind reader read "Try again" as a missing button.

[UX-REVIEWED] bdb8e75

Description read

[DESCRIPTION-READ] 4fd31a1b1700d7cc12332b94852a62f425b3551ce970c749c5170220aef94baa

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed bdb8e75fcad93911f70040694cf79c300e727e7b — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] bdb8e75

Verdict parsed from the review's SHA-scoped output markers for commit bdb8e75fcad93911f70040694cf79c300e727e7b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable bdb8e75fcad93911f70040694cf79c300e727e7b: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of bdb8e75fcad93911f70040694cf79c300e727e7b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] bdb8e75

False positive or not applicable? A repository writer can comment:
/ai-review override gpt bdb8e75fcad93911f70040694cf79c300e727e7b: <one-sentence reason>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one should-fix. Not approving yet: required checks and the two code review lanes are still running on this head, and readiness is "checking".

Head reviewed: 664d1d8.

What I checked:

  • The config PATCH stays owner-only, and the allowlist adds only the six dashboard.feature_previews.<name> bool paths. The loader drops unknown names and non-bool values.
  • if_unset is already supported on main by the config PATCH (checked under the write lock), so the one-time carry-up cannot replace a stored value.
  • Main does not already contain this change. Linked issue is a T1 bug.
  • No file is on the security path list. No secret, auth or sandbox change.

🔴 0 must-fix, 🟡 1 should-fix (inline).

Still open from the bots on this head: First Principles CONCERNS (the per-switch server-backed record) and UX CONCERNS (the four notices read alike). Neither has a reply yet. Please answer both, either with a change or a short reason. I do not repeat them here.

* own API is unaffected either way), which is exactly the shape of the existing
* Developer Mode gate (`mc-dev-mode`). Putting it in `config.json` would imply
* a fleet-wide setting and a backend contract that does not exist.
* Stored in the gateway config (`dashboard.feature_previews.<name>`), with

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The owning spec still says preview flags are a per-device localStorage opt-in.

This PR moves the source of truth to dashboard.feature_previews.<name> and keeps localStorage as a cache. The dashboard spec was not updated. docs/system-specs/modules/learn-cron-dashboard.md (the "Preview-gated surfaces" paragraph) still reads:

a registry entry may carry `previewFlag`, the localStorage key of a per-device opt-in (`utils/previewFlags.ts`, all keys prefixed `mc-preview-`)

Why it matters: The next reader of the spec will believe a switch is per device and per origin. That is the exact assumption this PR removes, so a later change can bring the bug back.

Suggestion: In the same commit, update that paragraph. Say the switch is kept on the gateway under dashboard.feature_previews.<name>, that localStorage is a cache, that writes are owner-only, and name usePreviewFlagServerSync.
Rule: AGENTS.md "Read before you touch" (owning spec updated in the same commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in bdb8e75. The opening of the "Preview-gated surfaces" paragraph in docs/system-specs/modules/learn-cron-dashboard.md now says each switch is kept on the gateway under dashboard.feature_previews.<name>, that localStorage is a cache, that writes go through the owner-only config PATCH, and that usePreviewFlagServerSync keeps the two in step. It also notes where a browser's cache can differ (a write in flight, a refused carry-up) and what a non-owner session sees. No code changed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026
The Preview-gated surfaces paragraph still described each switch as a
per-device localStorage opt-in. It now says the switch is kept under
dashboard.feature_previews.<name>, that localStorage is a cache, that
writes go through the owner-only config PATCH, and names
usePreviewFlagServerSync.
@mbriones98

Copy link
Copy Markdown
Contributor Author

Disposition for the First Principles CONCERNS (item 6, the per-switch record): keeping it.

Without the record, a switch the operator turned off on the gateway can be written back ON for everyone, not just shown again in one browser. That happens when another switch's one-time carry-up fails, because the sync marker then stays unset and the browser's old ON looks like a value still waiting to be carried. An earlier version of this change had exactly that gap, and the GPT review blocked it. previewFlagServerSync.test.tsx covers the sequence, including when the record cannot be stored. The record is one small localStorage key plus an in-memory copy, and it can be removed together with the carry-up code once no browser needs the one-time carry.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author

Disposition for the UX CONCERNS: no copy change in this PR.

  • The two owner-only notices differ because the outcomes differ: a toggle the user clicks is refused and switched back, while a switch that was already on in this browser before the gateway kept the switches stays on there. Each notice says which of those happened to the named switch.
  • "The owner" is the account that runs this Kiro Crew. The notices name the owner only so the user knows the save was refused on permissions, not lost.
  • The "on in this browser only" notices appear only during the one-time carry-up of older browser-only values, so they are a short-lived exception to the "saved for everyone" intro.

The suggested rewording is reasonable as a later copy pass across all four notices and 13 catalogs, separate from this fix.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at bdb8e75.

The earlier finding is fixed: the Preview-gated surfaces paragraph in docs/system-specs/modules/learn-cron-dashboard.md now says the switch is kept on the gateway under dashboard.feature_previews.<name>, that localStorage is a cache, and how usePreviewFlagServerSync reconciles the two, including the refused-write rollback, the if_unset carry-up and the non-owner case. That matches the code in this PR. No new findings on the incremental change, which touches only that one paragraph.

Backend Tests (Windows) (1) is red again, on the same two tests as the previous head: test_ci_ipv6_routing.py::test_real_collected_nodes_are_the_disjoint_fleet_and_hosted_union and test_a_nested_collection_reads_only_the_named_files, both a subprocess.TimeoutExpired in a nested --collect-only. That collection reads only a fixed set of target files this PR does not touch, and the same two tests fail on Windows shard 1 on several other open PRs right now, so I read it as a shared Windows timeout, not something this change caused.

The change looks good to ship. Approval waits on the maintainer gates: readiness is still checking, four Linux and four Windows backend shards are still running, and Windows shard 1 needs a green rerun.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author

Superseded by #22830, the same change rebuilt as one commit off current main after #21999 made this one conflict.

@mbriones98 mbriones98 closed this Oct 21, 2026
auto-merge was automatically disabled October 21, 2026 17:17

Pull request was closed

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 21, 2026
@bolichen97
bolichen97 deleted the fix/preview-flags-persist-21396-v7 branch November 6, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmates feature-preview toggle does not persist (stored only in browser localStorage)

2 participants