Repository navigation
fix(chat): keep the session menu chevron left of the title on the phone - #22656
Pearcekieser wants to merge 2 commits into
Conversation
|
note (non-blocking): This is a bug fix for #22655. The fork account cannot add labels, so could a maintainer add |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a small, reversible change to the order of two children inside one button, and the committed screenshots show it. Notes
[DESIGN-REVIEWED] 54e8423 Description read[DESCRIPTION-READ] e49e94479b450873be31bbda0cca04477373e20e3d0b5779c34ca1176a327ea1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The phone chevron move undoes a layout the code records as the approved mock, and the description never says so. Its only stated reason is matching desktop. What this change shipsInventory (5 items) — 3 justifiedIntent: the session-menu chevron sits on the same side of the title on phone and desktop. This is a FIX.
BlockersReverses the approved-mock layout without saying so — unjustified move [FIRST-PRINCIPLES-REVIEWED] 54e8423 Description read[DESCRIPTION-READ] 8bd5ef0cebd5eb1553b29debba822212caaae5168262e4c53fa628f8078bff5e That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS The committed before/after phone shots and the desktop shot show the moved chevron. No blind reader has seen them, which is a limit of this fork lane and not a gap in the author's evidence. Notes
[UX-REVIEWED] 54e8423 Description read[DESCRIPTION-READ] 028cd5c4187cbd8ee342345274d18443305fbc73e3a7736964eb8a92229c1793 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES. The code change is small and its test pins the new order, but the PR leaves the phone-layout record contradicting what now renders, and no review concern has a reply.
Reviewed head: 78285dc.
The defect: website/docs/narrow-viewport.md#L283 still says the phone header is 'the session title with the menu chevron flush after it' (
KiroCrew/website/docs/narrow-viewport.md
Line 283 in 78285dc
KiroCrew/website/src/pages/chat/page/MobileTopBar.tsx
Lines 96 to 108 in 78285dc
The same records raise a product question. Answer it on the PR before or with that fix:
- UX: the trailing chevron was an approved mock. Confirm with its owner that the phone should change, and attach a capture of the real MobileTopBar at phone width that shows the sessions toggle next to the chevron.
- First Principles: the move rests on symmetry with desktop. A maintainer ruling on #22655 that the sides should match would settle it.
CI is green.
— crew-pr-reviewer (r116)
78285dc to
f2cb2b4
Compare
|
Replies to the open review concerns, at head f2cb2b4 (rebased on latest main, plus one docs commit):
CI is re-running on the new head. |
|
@kirodotdev maintainers: First Principles now BLOCKs at f2cb2b4. It says this PR reverses the "approved mock" (title first, chevron trailing) on the phone, and the only reason is matching the desktop order. Neither I nor the PR can show the mock was wrong. Only a maintainer can decide this. If the phone should match desktop (chevron first), please post this override (draft, not posted by me): If the trailing chevron from the mock should stay, this PR should be closed instead. Still open for UX (advisory): a capture of the full phone |
narrow-viewport.md, MobileTopBar.tsx and the ChatHeaderMenu triggerLabel doc still described the chevron trailing the title. Update them to the chevron-then-title order the trigger now renders, so a later change that follows the records does not undo the fix.
f2cb2b4 to
54e8423
Compare
|
[operator: bolichen97] Continuing this in #31406; thanks for the start. |
|
Closing in favour of #31406, which continues this fix. |
Problem / Motivation
Goal: The session menu chevron sits on the same side of the session title on desktop and on the phone.
On desktop the chat header reads
⌄ Session title. On the phone it readsSession title ⌄. Switching between the two moves the control a user reaches for.Why it matters
Anyone who uses the dashboard on both a laptop and a phone sees the session menu control jump sides. It is cosmetic, but it is the first control in the header.
Not a goal
SessionTitleControl.What changed (motivation → approach → change)
The two viewports render different triggers of
ChatHeaderMenu. Desktop uses the icon-only trigger, placed beforeSessionTitleControlinChatTitleOverlay.tsx, and the two halves share a split-pill hover shape (rounded-l-mdon the chevron,rounded-l-[2px] rounded-r-mdon the title). The phone uses the titled trigger, whose button put the chevron after the title span.In
website/src/pages/chat/ChatHeaderMenu.tsxI moved the chevron ahead of the title inside the titled trigger, so the phone matches desktop. The other direction, moving the desktop chevron to the right, would mean reversing the pill rounding inSessionTitleControl, which the split-view pane headers also use. The button's accessible name does not change: the chevron icon has no text, so the name is still the title followed by the screen-reader-only "session options" suffix.Backwards compatibility
Compatible: only the order of two children inside one button changes. The test id, accessible name and menu contents stay the same.
Removes nothing: no element, test id or behaviour is taken away.
Tests
website/src/test/ChatHeaderMenu.chevronSide.test.tsxrenders the titled trigger and asserts that the chevron comes before the title in document order. It fails onorigin/mainand passes with the fix. The existingChatHeaderMenu.*,ChatPage.mobileSingleTopbarandChatPage.mobileTopBarActionssuites pass (43 tests), andtsc -p tsconfig.app.jsonis clean.Manual verification
I built a throwaway static page that mounts the real
ChatHeaderMenutriggers andSessionTitleControlwith dummy data, using the classes from the desktop title row inChatTitleOverlay.tsx. I captured it with Playwright for the phone trigger before and after the fix, and for the desktop row. The page is not part of this diff.Screenshots / video
Phone, before. The chevron trails the title.
Phone, after. The chevron leads the title.
Desktop, unchanged. The chevron leads the title.
Related Issues
Pattern harvest
Not generalizable: one button ordered its children differently from the sibling trigger of the same menu. No lint rule can tell which order is intended.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Fixes #22655