Repository navigation
fix(chat): put the phone session menu chevron ahead of the title - #31406
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The fix reverses the order set by the "approved mock". The description says so openly, and the linked issue #22655 shows why. Nothing blocks. Notes
What this change shipsInventory (3 items) — 2 justifiedIntent: make the phone's session-menu chevron sit on the same side of the title as on desktop. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 6dab3e6 Description read[DESCRIPTION-READ] cc66fded6dd2869c8271e860c979be6e1d99c467a7f0bc3a6833a3916acad076 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change reorders two children in one phone-only trigger, the evidence is rendered, and no decision under Notes
[DESIGN-REVIEWED] 6dab3e6 Description read[DESCRIPTION-READ] cdac36133dd30785c746165029c854edb005841cd182ed277eb1c53b927b724b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the phone now matches the desktop order, and all three screenshots show the moved chevron. Notes
[UX-REVIEWED] 6dab3e6 Description read[DESCRIPTION-READ] d382e3523cc77e54d3e8ba5090e6d829ffd733a3b11cc59de3c07d3a2a0c8db0 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
[operator: bolichen97] |
77cc3c8 to
d68af4d
Compare
|
Rebased: main moved in website/src/pages/chat/BrowserLiveCardViews.tsx, website/src/pages/chat/SubagentProgressBar.tsx, website/src/pages/chat/useChatPageSessionController.ts and test/test_chat_handlers_composition_contract.py since this head went green (090dad8 -> 85ce466); CI re-running. The diff is unchanged (same patch id); the 7 related frontend test files (80 tests) pass on the rebased head. [operator: bolichen97] |
|
[operator: bolichen97] The three red checks on this head (Backend Tests shard 2 on Linux and Windows, and the Coverage Gate that folds them) are |
The desktop header shows the session menu chevron before the session title, but the phone's single top bar put it after the title, so the control switched sides between viewports. The phone's titled trigger now renders the chevron first, matching desktop.
d68af4d to
6dab3e6
Compare
|
Rebased: main moved in test/test_chat_folder_cleanup.py, test/test_chat_runner_redact_across_tool_boundary.py, test/test_chat_runner_turn_sequence.py, test/test_chat_slot_facade_contract.py, test/test_chat_tag_column_infinite_order.py, website/src/pages/chat/AssistantMessage.tsx, website/src/pages/chat/ChatSettings.tsx, website/src/pages/chat/ErrorCard.tsx, website/src/pages/chat/FileBrowserRail.tsx, website/src/pages/chat/NewFileDialog.tsx, website/src/pages/chat/SessionTitleControl.tsx, website/src/pages/chat/SidePanel.tsx, website/src/pages/chat/SidePanelTabBodies.tsx, website/src/pages/chat/StopEventCard.tsx, website/src/pages/chat/ToolCallLine.tsx, website/src/pages/chat/ToolDetails.tsx, website/src/pages/chat/page/ChatTranscriptView.tsx, website/src/pages/chat/page/ComposerDockView.tsx, website/src/pages/chat/page/busyTurnControls.ts, website/src/pages/chat/page/composerSend.ts, website/src/pages/chat/page/eventBridges.ts, website/src/pages/chat/useChatPageResourcesController.tsx and website/src/pages/chat/useDirectoryUpload.tsx since this head went green (85ce466 -> 10e0a06); CI re-running. The diff is unchanged (same patch id). The previous head's Backend Tests shard 2 and Coverage Gate reds were main's security package line-budget test, which #31625 fixed on main; the new base includes it. The 10 related frontend test files (116 tests), eslint on the touched files and [operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved for the on-call. Review lanes pass on 6dab3e6, no conflict, no open change request.
) The desktop header shows the session menu chevron before the session title, but the phone's single top bar put it after the title, so the control switched sides between viewports. The phone's titled trigger now renders the chevron first, matching desktop. (cherry picked from commit 277b277)
Problem / Motivation
Goal: The session menu chevron sits on the same side of the session title on the phone as on desktop.
On desktop the chat header reads
⌄ Session title. On the phone it readsSession title ⌄, so the control moves to the other side when the viewport changes.Builds on #22656 by @Pearcekieser.
Why it matters
Anyone who uses the dashboard on both a laptop and a phone sees the first control in the chat header jump sides. It is cosmetic, but it is the control a user reaches for to rename, pin or open session options.
Not a goal
SessionTitleControl.What changed (motivation → approach → change)
The phone's chevron sat after the title, while desktop puts it before. Both viewports render
ChatHeaderMenu. Desktop uses its icon-only trigger, placed ahead of the title inChatTitleOverlay.tsx. The phone uses its titled trigger (triggerLabel), and that button rendered the chevron after the title.The fix moves the phone to the desktop order, not the other way round. That changes one viewport. Moving desktop instead would mean reversing the hover-pill rounding of
SessionTitleControl, which the split-view pane headers also use. The phone order came from an earlier mock, and no recorded decision depends on it.ChatHeaderMenu.tsxrenders the chevron first inside the titled trigger. The comments inMobileTopBar.tsxand the phone top-bar row inwebsite/docs/narrow-viewport.mdnow describe the chevron-then-title order.Backwards compatibility
Compatible: only the order of two children inside one button changes. The test id, the accessible name ("<title>, Session options") and the menu contents stay the same.
Removes nothing: no element, test id or behaviour is taken away.
Tests
website/src/test/ChatPage.mobileSingleTopbar.test.tsxnow asserts that the chevron is the first child of the phone's session menu trigger. With theChatHeaderMenu.tsxchange reverted it fails (expected <span> to be SVGSVGElement). With the change it passes.Proof: not provable -- frontend test (prove.py runs Python only)
Determinism: the file passed 20 sequential runs (
--maxWorkers=1), and 10 shuffled runs at--maxWorkers=4besideChatPage.mobileTopBarActionsand a siblingChatHeaderMenuspec (--sequence.shuffle, seeds 20248 to 20257). The related frontend set (7 files, 80 tests),tsc -p tsconfig.app.jsonandeslint src/at the CI warning ceiling are clean.Manual verification
I built the SPA and loaded it against the shared stub API (
website/scripts/lib/stub-dashboard-api.mjs) in headless Chromium, once at a 390px touch viewport and once on desktop. Each pass checked that the chevron's left edge is left of the title's. Before the fix the phone check failed (chevron at x=225, title at x=50). After it, both pass (phone: chevron x=50, title x=70; desktop: chevron x=360, title x=392).Screenshots / video
Phone, before: the chevron trails the title.
Phone, after: the chevron leads the title.
Desktop, unchanged: the chevron leads the title.
Related Issues
Closes #22655
Sibling sweep
Swept: git grep -n "<ChatHeaderMenu" -- website/src
Sibling: website/src/pages/chat/page/ChatTitleOverlay.tsx:172 -- not affected -- the desktop header already renders the chevron ahead of the title
Pattern harvest
Not generalizable: one button ordered its children differently from the sibling trigger of the same menu, and no lint rule can tell which order is intended.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license (see the Licensing section of CONTRIBUTING.md).