Skip to content

feat(notifications): stack notes by sender, clear by group - #22744

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/notif-grouping-22585
Oct 22, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/notif-grouping-22585

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Notifications group together by who sent them, and every "clear" sits right next to the notes it clears.

User feedback (#22585): "we need some work to group the notifications together better, and make the clear all more connected."

Today the bell feed groups rows by date only. Rows stack only when the producer sets group_key. Cron, subagent and most agent notes never set it, so one cron job firing four times shows four near-identical rows. Clear-all is a small trash icon in a separate header card (a red "Clear" button on the inbox page) behind a native confirm(), far from the rows it removes.

Why it matters

The bell is the inbox for everything the crew does unattended. When repeats pile up, the one note that needs a person (an approval, a red build) gets buried. When clear-all is a disconnected trash icon behind a modal, there is no way to clear one sender's or one day's notes, so people either scroll past the noise or wipe everything.

Not a goal

What changed (motivation → approach → change)

Goal: mimic macOS Notification Center, which stacks by app and puts the clear control on the stack and on each section.

  • Stacks by sender. notificationStacks.stackKeyOf picks the key: the producer's group_key when set, else the crewmate (member), the cron job (job_id), or the channel narrowed by session_key. An approval or a critical note without a group_key never stacks: an approval is its own decision, and a deck shows only its head's priority, so a critical failure followed by an ok note from the same sender would hide under it. Deep-link reveal uses the same key.
  • Expanded stack header row (mockup option A, picked from three real-UI mockups): sender name (stackLabelOf: crewmate, else non-system app source, else kind label such as "Cron Job"), Show less, and the stack's own clear. The clear shows the word Clear at rest and Clear this group once armed, so it never reads as "hide" or as the inbox-wide clear-all. Show less moved off the head card into this row. In the inbox page variant the "N more" pill shows only on a collapsed stack.
  • Clear where it acts. Each date header has its own hover ⓧ, which arms to "Clear " and deletes that day's visible rows except approvals, read or not (reading one does not resolve it; it keeps waiting on Approve/Reject). A collapsed deck's ⓧ dismisses only its newest note (the deck shrinks by one); clearing a whole stack is the expanded header's two-press Clear. Clear-all stays in the bell controls card (a trash glyph, as before, because an ⓧ in the sheet's top-right corner reads as "close") and in the inbox toolbar (a trash glyph with the text "Clear all", since an ⓧ "Clear" beside the search field reads as "clear the search").
  • Two-press clear instead of confirm(). NotificationClearButton: the first press turns the control into a confirm capsule, the second press clears, and pointer-leave, blur or Escape disarm it. Armed, its visible text is its accessible name; after a clear, focus moves to the next remaining row instead of <body>, waiting until every note in the clear has left the list (each delete commits on its own). It is one element whose size animates between states (Framer Motion layout; reduced motion drops the motion, not the continuity). It forwards its ref to the <button>, so the uiLocation spreads on both clear-all sites register with the guide. This also removes the native confirm() on this surface (see Native confirm dialog (delete session / clear notifications) kills keyboard input in the whole window until the window is re-activated #15976).
  • Failures are shown. Every clear path (day, stack header, single-note dismiss, both clear-alls) awaits its deletes; if any fail, the feed shows one ErrorNotice ("Some notifications could not be cleared. Try again.") with the agent hand-off, the failed rows stay, and the next successful clear removes the notice unless another clear failed while it was running.
  • One control height. Every header control (ⓧ, Clear, Show less) is 26px via NOTIF_CONTROL_HEIGHT.
  • 5 new catalog keys, translated in all 12 shipped locales in each locale's house register; en-XA regenerated.
  • Spec updated: docs/system-specs/modules/app-notifications.md.

Backwards compatibility

Compatible: no API, payload, config or persisted-state change; producers that set group_key stack exactly as before.

Removes nothing: clear-all is still reachable in both places and still asks for confirmation (a second press instead of a native dialog); Show less moved from the head card to the header row; every existing control still exists.

Tests

  • website/src/test/NotificationFeed.senderStacks.test.tsx (new):
    • stackKeyOf precedence, approvals and critical notes (without group_key) never stack, shape-checked persisted fields; a critical cron failure stays visible beside a later ok run.
    • Same-sender notes stack; different senders stay apart; closing a collapsed deck dismisses only its newest note (mac and panel).
    • Expanded header (mac and panel): sender label, exactly one Show less, a text "Clear" that arms to "Clear this group" (never "Clear all"); Show less folds it; a crewmate stack is named by the crewmate.
    • Header clear, day clear, bell clear-all (trash glyph, no ⓧ) and page clear-all all need two presses; pointer-leave, blur and Escape disarm; no window.confirm.
    • A day clear skips every approval, read or not, and a day holding only approvals offers no clear; the armed day clear's name is its visible "Clear Today"; clearing a day hands focus to the next row, also when its deletes resolve in separate ticks.
    • Concurrent clears: a success already in flight does not hide a later failure's notice.
    • NotificationClearButton forwards its ref to the <button>, and both clear-all call sites register their UI location.
    • Clear failures, both variants: a failed day clear keeps the rows and shows the notice; a partial day or stack-header clear keeps only the failed rows; a failed deck-head dismiss keeps and restores the row; a failed clear-all shows the notice; a later successful clear removes it.
  • website/src/test/NotificationCard.shared.test.tsx: its framer-motion stub now also provides motion.span (used by the clear control).
  • website/src/uiLocations/uiIndex.test.ts: NotificationClearButton joins FORWARDING_PROVEN, pointing at the senderStacks tests that prove it forwards the marker's ref to its <button>.
  • website/src/uiLocations/shell-notifications.locations.test.ts, website/src/guide/GuideLayer.uiFind.test.tsx and test/test_find_ui_shell.py: the bell clear-all label is "Clear all notifications" (no question mark) and the page clear-all label is "Clear all".
  • Existing feed, deep-link, arrow-key, card, UI-location, guide and locale-style tests pass unchanged.

Determinism proof (the four added/changed vitest files, 87 tests):

for i in $(seq 20); do npx vitest run --maxWorkers=2 src/test/NotificationFeed.senderStacks.test.tsx src/test/NotificationCard.shared.test.tsx src/uiLocations/shell-notifications.locations.test.ts src/guide/GuideLayer.uiFind.test.tsx || break; done
-> 20/20 green, 87 passed each run

npx vitest run --maxWorkers=2 --sequence.shuffle --sequence.seed=14397 src/test/NotificationFeed.senderStacks.test.tsx src/test/NotificationCard.shared.test.tsx src/uiLocations/shell-notifications.locations.test.ts src/guide/GuideLayer.uiFind.test.tsx
-> seed=14397, 87 passed

Manual verification

Ran the worktree build in an isolated pod (kirocrew pod up --seed minimal) and drove the real bell sheet and inbox page with Playwright, notes served in the browser. Asserted and recorded: stacks by sender with the approval alone; a deck's ⓧ deletes only its newest note and the deck shrinks to 2; day clear arms then clears; bell clear-all shows a trash glyph, arms, cancels on pointer-leave, then clears; expanded header shows sender + Show less + "Clear", arms to "Clear this group", and removes all 4 notes; inbox toolbar trash "Clear all" arms and clears; a failed day clear shows the shared notice and keeps the rows; a critical cron failure stays visible beside a later ok run. Measured in the browser: every header control is 26px tall.

Screenshots / video

Bell sheet and inbox page, dark theme, desktop.

Same-sender notes stack; the approval stays alone; clear-all is a trash glyph

Expanded stack: header row with sender, Show less and a text Clear

Stack header clear after the first press: Clear this group

Day clear (hover, armed, failed), critical note, bell clear-all and inbox toolbar

Day header on hover: its ⓧ clear

Day clear after the first press: Clear Yesterday

A failed day clear: one shared notice, rows kept

A critical cron failure stays out of its sender stack

Bell clear-all after the first press

Inbox page toolbar at rest: trash Clear all

Inbox page toolbar after the first press: Clear all

Full flow (stacks, expand, deck head dismiss, day clear, clear-all with cancel):

notif-grouping-demo.mp4

Stack header row (expand, arm, cancel, fold, clear the stack):

stack-header-demo.mp4

Related Issues

Closes #22585

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 21, 2026 10:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6235dd933b37a912d9d8324f98ba483bd761d214 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Sender stacking runs client-side over existing fields, and approvals and critical notes stay out of stacks. The only key the patch renames has its readers updated in the same patch, and rendered evidence of this revision is attached.

Notes

  • stackKeyOf stacks every channel note that has no session_key under one key per channel. A busy channel with no session would then fold unrelated notes into a single deck. If that turns up in use, narrowing the key further is a small client-only follow-up.

[DESIGN-REVIEWED] 6235dd9

Description read

[DESCRIPTION-READ] b4a29f95a616c59096c974d81d0b1ca324c4096a06752fcf29c0f2e5eae42caa

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 6235dd933b37a912d9d8324f98ba483bd761d214 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6235dd933b37a912d9d8324f98ba483bd761d214 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: every added control appears in a screenshot, two recordings cover the state changes, and the blind reader read each primary clear correctly. Its one hesitation was "not sure" on the day ⓧ, not a refusal.

Notes

  • The day-header ⓧ only shows on hover, and an ⓧ reads as "close". The blind reader on shot-04 said "an 'x' usually just closes something", and on shot-07 said "the 'x' seems to show up only sometimes". Give the resting control the word "Clear", as the stack header already does.
  • clear_failed ends "Try again." but there is no retry button, only "Ask the agent" (shot-06: "I can't see a 'Try again' button anywhere"). Either add a Retry action next to the notice or change the text to "Some notifications could not be cleared. Clear them again to retry."
  • In the "Cron Job" stack, the header name (stackLabelOf's kind label) doesn't match the "Cron: gh-issue-triage" titles on the cards under it. The reader "can't tell whether these are one thing or several." The PR lists the job name as out of scope, so this is for a follow-up.

[UX-REVIEWED] 6235dd9

Description read

[DESCRIPTION-READ] ed3724c60513b0b3899c1dcd6545e254accf1420b3a4b9bf5104b1e2697c3b24

That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6235dd933b37a912d9d8324f98ba483bd761d214 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6235dd9

Verdict parsed from the review's SHA-scoped output markers for commit 6235dd933b37a912d9d8324f98ba483bd761d214.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6235dd933b37a912d9d8324f98ba483bd761d214: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @CrysisDeu overrides the GPT 6.1 finding for 6235dd933b37a912d9d8324f98ba483bd761d214; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] 6235dd9

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6235dd933b37a912d9d8324f98ba483bd761d214: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/notif-grouping-22585 branch from ae4caea to ef56d51 Compare October 21, 2026 11:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=ce0c86e55c68 — clear-all ⓧ read as close

Fixed in ef56d51: the bell clear-all is a Trash2 glyph at rest again (NotificationClearButton icon="trash"), so an ⓧ in the sheet corner never means "delete everything".
It still needs a second press ("Clear all") and disarms on pointer-leave, blur or Escape. Pinned by the senderStacks test asserting svg.lucide-trash-2 and no svg.lucide-x.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=fb5640018b0c — stack header ⓧ unidentifiable

Fixed in ef56d51: the stack header clear shows the word "Clear" at rest (no glyph) and "Clear this group" once armed, so it reads as delete-this-stack and never as hide or as the inbox-wide "Clear all".
Pinned by "the header clear says Clear at rest and names its scope when armed".

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=ecab350708ce — uiLocation ref dropped by a function component

Fixed in ef56d51: NotificationClearButton is a forwardRef component and puts the ref on the that carries data-ui-location.
Pinned by tests that a createRef lands on the button and that both clear-all call sites appear in registeredCopies('location', ...).

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=b99c8286b17b — group clearing ignored failed deletes

Fixed in ef56d51: clearNotes awaits every deleteNotification(...).unwrap() with Promise.allSettled; both clear-alls await clearNotifications().unwrap().
Any failure renders one ErrorNotice (askAgent on; no draft is at stake) and the failed rows stay; the next successful clear removes it.
Pinned by the "clear failures" tests in both variants (day, partial day, stack header, deck, clear-all).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/notif-grouping-22585 branch from ef56d51 to b34cd55 Compare October 21, 2026 19:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles b34cd55: #22585 asks for notifications grouped by sender; sender stacking is the requested behavior, and the deck ⓧ now deletes only the top note as before. Posted at Zezhen's explicit direction.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for b34cd554bc082b415141bfac6b99f7bad826104a.

#22585 asks for notifications grouped by sender; sender stacking is the requested behavior, and the deck ⓧ now deletes only the top note as before. Posted at Zezhen's explicit direction.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/notif-grouping-22585 branch from b34cd55 to 781731e Compare October 21, 2026 20:35
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 781731e: #22585 asks for notifications grouped by sender; sender stacking is the requested behavior, and the deck ⓧ now deletes only the top note as before. Posted at Zezhen's explicit direction.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 21, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 21, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at bfeaa5d.

Thanks, my blocker is fixed: stackKeyOf now returns null for a critical note without a group_key (notificationStacks.ts:29), with both tests (never stacks a critical note that carries no group_key, keeps a critical note out of its sender stack...). The eslint native-dialog allowlist entry is gone, and the focus, label-in-name, clear-all label, day-clear wording, clearFailed race and blur follow-ups are all addressed.

Still requesting changes, for the upheld GPT 6.1 BLOCK on this head (no reply yet): day clear still deletes an approval that was read but not decided. isPendingApproval (notificationStacks.ts:7-8) treats an approval as pending only while !n.acked, and opening a note acks it. So: open a pending approval, go back, clear its day, and the approval row and its Approve/Reject controls disappear while the request is still waiting. Read is not resolved. Please exclude kind === 'approval' rows from day clearing regardless of acked (or key on the approval's own resolved state), with a test that acks an approval and then clears its day.

Also on this head, each needs a fix or a reply:

  • Opus 5.5 BLOCK (NotificationFeed.tsx:283): with real network timing each deleteNotification lands in its own commit, so the refocus target is dropped on the first items change while the clicked Clear is still mounted, and focus still falls to <body>. The test at NotificationFeed.senderStacks.test.tsx:233 passes because its mocked deletes resolve in one flush.
  • GPT 6.1 second finding (not upheld, worth a look): the "Ask the agent" hand-off from a failed clear inside the mobile bell sheet navigates to /chat without closing the sheet.
  • UX BLOCK: shot-04 still shows the armed day capsule as plain "Clear"; reshoot it with the new "Clear Today" text.

The bell feed grouped rows by date only and stacked them only when a
producer set group_key, which cron, subagent and most agent notes never
do, so repeats piled up as near-identical rows. Clear-all sat in a
separate header card behind a native confirm(), away from the rows it
cleared.

Notes now stack by sender the way macOS Notification Center stacks by
app: the producer's group_key, else the crewmate, the cron job, or the
channel and session. Approvals without a group_key stay unstacked.
An expanded stack gets a header row (sender, Show less, its own clear),
each date header gets a clear for that day, and closing a collapsed
deck clears the whole deck. Every clear is a two-press control that
disarms on pointer-leave, blur or Escape, replacing confirm(). The
header controls share one 26px height.

Refs #22585
@CrysisDeu
CrysisDeu force-pushed the feat/notif-grouping-22585 branch from bfeaa5d to 6235dd9 Compare October 22, 2026 02:33
@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=b25cdd5924f5 — armed day clear did not say what it clears

Fixed in 6235dd9: the shot was stale. The armed day capsule renders "Clear Yesterday" / "Clear Today" (clear_group with the day), reshot from the real build in the bell sheet.
Added the missing evidence too: the hovered day header's idle ⓧ and the failed-clear ErrorNotice. Pinned by the armed-text test asserting "Clear Today".

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=aad7d7da8a73 — refocus target dropped on the first items commit

Fixed in 6235dd9: the refocus target keeps the cleared ts set and the control that had focus, and waits until every cleared note has left items (or the clear settles) before it moves focus or drops the target.
New test resolves the two deletes in separate ticks and asserts focus lands on the next row's open control; it fails on the old effect (focus on body).

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • fixed span=3fa02522a15d — day clear deleted read-but-unresolved approvals

Fixed in 6235dd9: day clears skip every approval-kind note regardless of acked (keepsOutOfDayClear); only its own Approve/Reject resolution removes it.
Tests: a read and an unread approval both survive a day clear, and a day of only approvals (read or not) shows no clear.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • rebutted span=b99c8286b17b — mobile sheet stays open after the error hand-off

Adjudication downgraded this to LOW: it needs a phone layout, the user already on /chat, and a failed clear at once.
The chat does open; the sheet closes with one tap and nothing is lost. Threading a close callback through NotificationFeed for that case is disproportionate.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 6235dd9: #22585 asks for notifications grouped by sender; sender stacking is the requested behavior, and the deck ⓧ now deletes only the top note as before. Posted at Zezhen's explicit direction.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

@buluoray thanks again. All four points from your re-review are in 6235dd9 (rebased on current main, which now carries #22951):

  • Read approvals and day clear: day clears now skip every kind === 'approval' note, read or not (keepsOutOfDayClear). Tests ack an approval, clear its day, and check it stays; a day holding only approvals offers no clear.
  • Refocus under real timing: the target now waits until every cleared note has left items (or the clear settles). The new test resolves the deletes in separate ticks and fails on the old code.
  • Mobile hand-off (GPT, downgraded): replied on the ledger with why no change; happy to add the close callback in a follow-up if you want it.
  • UX shot-04: reshot from the real build; the armed day clear reads "Clear Yesterday". Also added the hovered idle ⓧ and the failed-clear notice.

Also: the inbox toolbar clear-all is now the trash glyph with "Clear all", matching the bell (your earlier UX note).

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 6235dd933b37a912d9d8324f98ba483bd761d214.

#22585 asks for notifications grouped by sender; sender stacking is the requested behavior, and the deck ⓧ now deletes only the top note as before. Posted at Zezhen's explicit direction.

This decision applies only to this commit. A new push requires a new judgment.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 6235dd9 (rebased; I compared this PR's own diff against bfeaa5d). Approve.

Both items from my last review are fixed:

  • Approvals no longer leave with a day clear, read or not. keepsOutOfDayClear (notificationStacks.ts:7-9) keys on kind === 'approval' alone, so reading one does not make it clearable. The new tests cover an unread and a read approval surviving a day clear, and a day holding only read approvals offering no clear at all.
  • The refocus target now survives deletions that commit one at a time: it holds the set of cleared notes and the control that had focus, and is only resolved once every cleared note has left items or the clear settles (a tick re-runs the effect if the last delete committed first). Focus the user moved elsewhere is left alone, and a partial failure leaves focus on the surviving Clear. a day clear whose deletions commit one at a time still hands focus to the next row drives exactly the Opus case with deferred deletes, and a failed day clear leaves focus on the clear it pressed pins the failure side.

Checked locally on this head: NotificationFeed senderStacks, phase3, phase4 and NotificationCard.shared pass (84), and tsc -p tsconfig.app.json is clean. CI on this head has no failures so far.

Still for you, not blocking from me: the UX lane asked for shot-04 to be reshot with the "Clear Today" armed text, and the GPT note on the mobile sheet staying open after "Ask the agent".

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 6235dd9: LOW harm per adjudication; needs a keyboard clear of the only remaining stack plus a partial delete failure, and Tab returns focus. Fix tracked in #23000 so the approved PR can merge. Posted at Zezhen's explicit direction.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the gpt AI finding as false positive, not applicable, or explicitly accepted for 6235dd933b37a912d9d8324f98ba483bd761d214.

LOW harm per adjudication; needs a keyboard clear of the only remaining stack plus a partial delete failure, and Tab returns focus. Fix tracked in #23000 so the approved PR can merge. Posted at Zezhen's explicit direction.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 22, 2026
@CrysisDeu
CrysisDeu merged commit c4fbcf0 into main Oct 22, 2026
105 of 108 checks passed
@CrysisDeu
CrysisDeu deleted the feat/notif-grouping-22585 branch October 22, 2026 03:37
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 22, 2026
@abirkel abirkel mentioned this pull request Oct 25, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(notifications): group notes by source and tie clear-all to the list

2 participants