Repository navigation
fix(test): skip the sibling-list bash cross-check on Windows - #23264
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This is a test-only skip that uses the same guard the other bash-calling tests already use, and the Windows CI shard will confirm it. Notes
[DESIGN-REVIEWED] a23866c Description read[DESCRIPTION-READ] fc8a13051bf610d447f69769239f37471a31e97322d6031bafbd1e214849f30a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
CI note (head a23866c): Coverage Gate red is not a coverage miss. It failed closed on |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only fix that skips the bash cross-check of the sibling-list test on Windows or when no bash is on PATH.
Problem / Motivation
Goal:
Backend Tests (Windows) (7)goes green on main again.test/test_sibling_list_check.py::test_a_heading_is_found_exactly_when_the_template_check_finds_itfails all 33 of its cases on the Windows runner. The test runsbash .github/scripts/pr-description-check.sh, and on Windows that call exits 1. Every open PR whose base includes #22957 is red on that shard: #23150, #23202, #23153 and #23146.Why it matters
Main has been red on a required backend shard since #22957 merged, so every author on the repo sees a failure that has nothing to do with their diff.
Not a goal
pr-description-check.shrun under Windows bash. CI runs that script on Linux only.What changed (motivation → approach → change)
The cross-check that compares the sibling-list reader with the template check needs a POSIX bash to run the template check. The other tests that run this script already skip on Windows with
os.name == "nt" or shutil.which("bash") is None(test/test_fork_pr_description_workflow.py,test/test_prepare_pr_diff_signals.py). This applies the same guard to the one test intest/test_sibling_list_check.pythat shells out. Every other test in the file still runs on Windows.Backwards compatibility
Compatible: test-only change. No product code or CI script moves.
Removes nothing: the cross-check still runs on Linux and macOS CI, where the script itself runs.
Tests
test/test_sibling_list_check.py: 147/147 pass on Linux, so the cross-check still runs there.bashonPATH, the 33 cross-check cases skip, with the reason given, and the other 114 tests in the file are unaffected. That is the same guard expression theos.name == "nt"branch uses.Manual verification
N/A: no Windows host locally. The proof is the next
Backend Tests (Windows) (7)run on this PR.Related Issues
Closes #23259
Sibling sweep
Siblings: none -- every other test that runs a repo script under
bashalready carries a POSIX-bash skip or never reaches the Windows shards. On #23150, #23202, #23153 and #23146 the onlybashfailures on the Windows shards are these 33 cases intest/test_sibling_list_check.py.Pattern harvest
Rule candidate: semgrep
Pattern: a test that runs
subprocess.run(["bash", ...])on a repo script with noos.name == "nt"/shutil.which("bash")skip guard.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)