Skip to content

fix(test): skip the sibling-list bash cross-check on Windows - #23264

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/sibling-list-check-windows-bash
Oct 23, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/sibling-list-check-windows-bash

Conversation

@JLargent42

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backend Tests (Windows) (7) goes green on main again.

test/test_sibling_list_check.py::test_a_heading_is_found_exactly_when_the_template_check_finds_it fails all 33 of its cases on the Windows runner. The test runs bash .github/scripts/pr-description-check.sh, and on Windows that call exits 1. Every open PR whose base includes #22957 is red on that shard: #23150, #23202, #23153 and #23146.

Why it matters

Main has been red on a required backend shard since #22957 merged, so every author on the repo sees a failure that has nothing to do with their diff.

Not a goal

  • Making pr-description-check.sh run under Windows bash. CI runs that script on Linux only.
  • Changing the reader or the corpus the test compares.

What changed (motivation → approach → change)

The cross-check that compares the sibling-list reader with the template check needs a POSIX bash to run the template check. The other tests that run this script already skip on Windows with os.name == "nt" or shutil.which("bash") is None (test/test_fork_pr_description_workflow.py, test/test_prepare_pr_diff_signals.py). This applies the same guard to the one test in test/test_sibling_list_check.py that shells out. Every other test in the file still runs on Windows.

Backwards compatibility

Compatible: test-only change. No product code or CI script moves.

Removes nothing: the cross-check still runs on Linux and macOS CI, where the script itself runs.

Tests

  • test/test_sibling_list_check.py: 147/147 pass on Linux, so the cross-check still runs there.
  • With no bash on PATH, the 33 cross-check cases skip, with the reason given, and the other 114 tests in the file are unaffected. That is the same guard expression the os.name == "nt" branch uses.

Manual verification

N/A: no Windows host locally. The proof is the next Backend Tests (Windows) (7) run on this PR.

Related Issues

Closes #23259

Sibling sweep

Siblings: none -- every other test that runs a repo script under bash already carries a POSIX-bash skip or never reaches the Windows shards. On #23150, #23202, #23153 and #23146 the only bash failures on the Windows shards are these 33 cases in test/test_sibling_list_check.py.

Pattern harvest

Rule candidate: semgrep
Pattern: a test that runs subprocess.run(["bash", ...]) on a repo script with no os.name == "nt" / shutil.which("bash") skip guard.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision a23866ca335d3892c9cd9744ac9b4a7c52230b0d ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision a23866ca335d3892c9cd9744ac9b4a7c52230b0d touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a23866ca335d3892c9cd9744ac9b4a7c52230b0d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This is a test-only skip that uses the same guard the other bash-calling tests already use, and the Windows CI shard will confirm it.

Notes

  • The skip has no deadline. A test that compares the sibling-list reader with the shell check should run wherever that check runs, which is Linux CI only. So this is a real constraint, not something to remove later.

[DESIGN-REVIEWED] a23866c

Description read

[DESCRIPTION-READ] fc8a13051bf610d447f69769239f37471a31e97322d6031bafbd1e214849f30a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a23866ca335d3892c9cd9744ac9b4a7c52230b0d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a23866c

Verdict parsed from the review's SHA-scoped output markers for commit a23866ca335d3892c9cd9744ac9b4a7c52230b0d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a23866ca335d3892c9cd9744ac9b4a7c52230b0d: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a23866ca335d3892c9cd9744ac9b4a7c52230b0d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a23866c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a23866ca335d3892c9cd9744ac9b4a7c52230b0d: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

CI note (head a23866c): Coverage Gate red is not a coverage miss. It failed closed on backend-test=cancelled because Backend Tests (3.12, 4) hit the 60-min job cap during its leaf corpus-gate pass (687 files, 35240 passed in 59:05) and was cancelled on changed-file pass 3/3 (passes 1-2 green, 147 passed each). The new skipif decorator adds no uncovered lines. No code change; re-ran the cancelled job once.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 23, 2026 06:02

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only fix that skips the bash cross-check of the sibling-list test on Windows or when no bash is on PATH.

@KiroCrewCaptain
KiroCrewCaptain merged commit 48f035e into main Oct 23, 2026
198 of 205 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/sibling-list-check-windows-bash branch October 23, 2026 06:03
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red on Windows: test_sibling_list_check.py fails 33 cases on Backend Tests (Windows) (7)

2 participants