Skip to content

feat(dashboard): hide every scrollbar - #23550

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/hide-all-scrollbars-23539
Oct 25, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/hide-all-scrollbars-23539

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: No scroll box in the dashboard shows a scrollbar at rest: a box either hides it entirely or shows a thin thumb only while it is being scrolled, without changing its width.

The crewmate chat (Members DM, ChatPane) painted a permanent 6px thumb down the right edge of its transcript. So did the main chat: both mount TranscriptScrollShell (.chat-container), which has no scrollbar styling of its own and inherited the global always-visible thumb from index.css. A permanently scrollable region (a long chat, a long sidebar) turns a thumb into a fixed stripe, not a transient hint. The sessions sidebar had already hidden its own for that reason, which left the dashboard with three treatments and no rule: the global always-on thumb, the sidebar's fully hidden one, and the hover-revealed overlay on capped lists and code blocks.

Why it matters

Every new scroll surface was making its own call, and the most-read surface of all, the chat transcript, carried the least considered one. One rule removes the decision from every future surface and the stripe from the two chats, while a scroller keeps a visible, grabbable thumb for the moments it is actually in use.

Not a goal

  • Removing the scrollbar-none class and inline scrollbarWidth: 'none' from the surfaces that carry them. Fully hidden is one of the two allowed forms; those sites are correct as they are.
  • A hover-revealed thumb. The pointer rests over the chat transcript most of the time, so hover is "at rest" there; the decision names scroll-reveal and fully hidden as the only two forms.
  • The Mochi app's own windows (src/apps/mochi/). They do not read the dashboard stylesheet; named out of scope in the gate.
  • A scroll cue for capped lists and wide code blocks beyond the thumb they show while scrolling (edge fades, "more below"); tracked in Scroll cues for capped lists and wide code blocks under the scroll-only scrollbar #23547.

What changed (motivation → approach → change)

Goal → one global rule with a scrolling state the stylesheet can key on, rather than another per-surface class → the base layer in website/src/index.css keeps the 6px WebKit column (::-webkit-scrollbar{width:6px;height:6px}) with a transparent thumb and paints the thumb (--muted) under [data-scrolling]. Firefox takes the same two states through scrollbar-width: thin / scrollbar-color, fenced behind @supports (-moz-appearance:none): Blink drops the pseudo-elements the moment a standard scrollbar property is set on a box and draws its 15px native bar instead (measured on the Pierre scroller before the fence went in).

  • website/src/lib/scrollReveal.ts (new, installed in main.tsx before render): one capturing scroll listener on the document sets data-scrolling on the element that scrolled and clears it 800ms after the last event. scroll is not composed, so a scroll inside a shadow root never reaches that listener; a MutationObserver watches for the two shadow-drawing hosts (diffs-container, file-tree-container) and attaches to their roots once each.
  • Pierre code and diff surfaces (every CodeBlock / DiffBlock / DiffPanel / ContentRenderer / PapyrusEditor / WorkflowSourceCode block, the editor, the file-change chips) resolve options through pierreFileOptions / pierreDiffOptions; both now fold in PIERRE_SCROLL_REVEAL_CSS (src/pierre/config.ts), which lands in the library's @layer unsafe and replaces its hover-painted thumb with the same [data-scrolling] reveal in the library's own token. The track stays 6px, so the reveal moves nothing. The @pierre/trees tree gets the same gate on --trees-scrollbar-thumb-current in PIERRE_TREE_STATE_ROW_CSS.
  • styles/scrollbars-and-touch-hit.css: the .scroll-fade thumb rules, the whole .scrollbar-overlay / -thin block and both coarse-pointer branches are gone (hover-reveal is not an allowed form); the horizontal .edge-fade-x mask (worn by the composer control row) stays. The 19 JSX sites that carried those classes drop them (13 files). apps/file-explorer/styles.ts loses the .mc-fe-tabs always-on thumb; components/crew/layout/layoutEditor.css loses a redundant scrollbar-width: thin.
  • Nothing about the reserved column changes, so TranscriptScrollShell's scrollbar-gutter: stable, the title overlays' right-1.5 inset, composerDockMetrics' measured gutter and the composer / paste-mirror gutter pairing are untouched from main.
  • Rule, gate and record: website/AUTOSDE.yaml gains the blocking no-scrollbar-at-rest rule (regex on added lines: a thumb colour or scrollbar-color whose line lacks data-scrolling, scrollbar-width: auto, a revived utility); docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md records the decision and is indexed in the decisions README; website/docs/frontend-conventions.md § Styling states the rule; website/docs/narrow-viewport.md drops a reference to the removed overlay block.

Backwards compatibility

Compatible: CSS, one small DOM attribute setter, and prompt/rule text; no API, config or data shape changes. Removes nothing: the .scrollbar-overlay / .scroll-fade class names were internal utilities with no reader outside website/src (grep on origin/main: 31 + 9 JSX uses, all changed here; no app bundle, skill or doc references them). Every box still scrolls by wheel, trackpad, touch and keyboard, the column each box reserved on main is the column it reserves now, and the thumb is still grabbable while it shows.

Tests

  • website/src/test/scrollReveal.test.ts (new): the attribute appears on a scroll, survives the linger while scrolling continues, clears after it, lands on the scrolled element only, reaches a scroller inside a shadow host added after install (directly and nested in an added subtree), and stops after uninstall. Fake timers; no sleeps.
  • website/src/test/scrollbarRevealOnly.test.ts (new): anchors both engine halves of the global rule and the -moz fence; asserts the Pierre hooks ride on both factories and the tree sheet; walks src/ and fails on any ::-webkit-scrollbar-thumb colour or scrollbar-color whose selector lacks [data-scrolling], any scrollbar-width other than thin/none, and the React inline spellings; names the Mochi files out of scope and checks each still paints; measures the revealed --muted thumb against --bg, --bg-elevated and --card in every theme (36+) for the WCAG 1.4.11 3:1 floor. Mutation-checked locally: a scratch CSS file and a scratch .ts with five bad shapes produced exactly five failures, and two [data-scrolling]-gated rules passed.
  • Deleted scrollbarThumbContrast.test.ts and scrollbarOverlayTouch.test.ts: both measured resting thumbs that no longer exist. The contrast floor they pinned lives on in scrollbarRevealOnly.test.ts; the palette-resolver anchors move into themeFillForeground.test.ts.
  • Updated: ChatPage.composerChromeOcclusion.test.tsx (drops the two overlay-utility cases), SkillsTab.test.tsx (asserts the list is a scroll box, not which utility it wears), ChatSidebar.scrollbar.test.tsx (header only), cross-reference comments in focusRingContrast.test.ts, themePalette.ts, touchHitArea.test.ts.

Run locally: the twelve touched vitest files pass; tsc -p tsconfig.app.json, eslint on the changed files, i18n-check.mjs, check-phantom-classes.mjs and scripts/docs-lint.sh are clean.

Manual verification

website/scripts/capture-23539-hidden-scrollbars.mjs (new) mounts the REAL Members page with a 41-bubble Radar thread (the last one a fenced block wide enough to scroll sideways) behind route-intercepted /api, launches Chromium with --hide-scrollbars turned OFF so a painted bar reserves width, and probes two scrollers at rest, immediately after a driven scroll, and after the linger: the transcript (light DOM) and Pierre's [data-code] inside its shadow root.

transcript, rest transcript, mid-scroll transcript, after linger Pierre [data-code], rest Pierre, mid-scroll
data-scrolling absent present absent absent present
reserved column 6px 6px 6px 6px (horizontal) 6px
still overflows / moves yes yes yes yes (sideways) yes
page errors 0 0 0 0 0

Both themes. A recording of the same run (wheel down, rest, wheel up, wheel the code block sideways) is attached under Screenshots. The before frame (main) shows the thumb at rest; this head shows nothing at rest and the thumb mid-scroll in the same column. (The capture harness entry capture/members-page.tsx installs scrollReveal as main.tsx does, so it exercises the real mechanism.)

Screenshots / video

Recording, dark theme: the crewmate transcript is wheel-scrolled down, left alone (thumb fades after the linger), wheeled back up, then the wide code block is wheel-scrolled sideways. The thumb appears only while scrolling, and the bubbles' right edges never move:

after-scroll-dark.webm

Right edge of the transcript, dark, 2x. Left: main at rest (permanent thumb). Middle: this head at rest (nothing). Right: this head mid-scroll (thumb shown, same 6px column):

transcript edge: main at rest, this head at rest, this head mid-scroll

Light theme
after-scroll-light.webm

light: main at rest, this head at rest, this head mid-scroll
light, mid-scroll on this head

Related Issues

Closes #23539
Related: #23547 (scroll cues on capped lists and wide code blocks), #23568 (the UX reviewer rule)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 23, 2026 20:44
@CrysisDeu
CrysisDeu requested a review from buluoray October 23, 2026 20:44
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 27e1a9523117d481360de1d51d1825421dd30d19 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a recorded maintainer decision (#23539) covers removing the touch and hover thumbs, and the scroll-reveal keeps every box's reserved column, so showing the thumb moves no content.

Notes

  • Touch and keyboard users now get no sign at rest that a capped list or a wide code block scrolls, because the coarse-pointer thumb was dropped on purpose. That makes Scroll cues for capped lists and wide code blocks under the scroll-only scrollbar #23547 (edge fades, "more below") the only fix for this, not a nice-to-have, so rank it that way.
  • SHADOW_SCROLL_HOST_TAGS is a hand-kept list. A new shadow-rendering library would get no reveal at all and nothing would fail. scrollbarRevealOnly.test.ts could fail on any attachShadow host that is not in the list, so the list cannot fall behind without a red test.

[DESIGN-REVIEWED] 27e1a95

Description read

[DESCRIPTION-READ] 9d60ebebdaa424de88d7e874166559031958042f0b12c939ef00fc4dd1cbeaa0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 27e1a9523117d481360de1d51d1825421dd30d19 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 27e1a9523117d481360de1d51d1825421dd30d19 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The PR adds no new controls, the screenshots show the scrollbar both at rest and mid-scroll in two themes, and two recordings cover the reveal.

Notes

  • Hiding the thumb at rest takes away the only "more below" cue on capped boxes like composer-status-stack, the Skills list and the browser modals. The blind reader on the bar-less middle slice: "If the scrollbar is there to tell me there is more to see, I'd miss it." Scroll cues for capped lists and wide code blocks under the scroll-only scrollbar #23547 should treat an edge fade on those capped boxes as required follow-up work, not optional polish.

[UX-REVIEWED] 27e1a95

Description read

[DESCRIPTION-READ] 5469e7bad2d96b6166124299494a1706a03833ee10c32ac3ef9129849ae7da89

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 27e1a9523117d481360de1d51d1825421dd30d19 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 27e1a95

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 27e1a9523117d481360de1d51d1825421dd30d19 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 27e1a9523117d481360de1d51d1825421dd30d19 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 27e1a95

Verdict parsed from the review's SHA-scoped output markers for commit 27e1a9523117d481360de1d51d1825421dd30d19.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 27e1a9523117d481360de1d51d1825421dd30d19 false-positive: <reason, 20 to 500 characters>

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Round 1 on 5e659ac1b6, triaged. Fixes are folded into the single commit locally and land in one push once this round's remaining lanes finish.

Fixed (defects in code this PR touches)

  • Opus / Frontend Tests (2): ChatPage.overlaySelection.test.tsx:27 pinned the removed right-1.5; regex now matches right-0.
  • Opus / E2E: playwright/composer-paste-highlight-scrollbar.spec.ts guarded on a >0 gutter that the rule removes by design. Rewritten: with --hide-scrollbars off it now asserts the global rule reaches the composer (scrollbar-width: none, 0 reserved) and that the paste mirror and autosize twin still match the textarea's text-box width, which is the invariant the spec existed for.
  • Design review note: scripts/capture-scrollbar-thumb-contrast.mjs deleted (its subject is the thumb this PR removes); the one cross-reference in capture-warn-text-contrast.mjs now points at capture-focus-ring.mjs.

Rebutted

  • UX note "MarkdownPanel drops pr-6": it does not; the class string went from 'scrollbar-overlay pr-6' to 'pr-6' (MarkdownPanel.tsx:1337), the reading margin is unchanged.
  • First Principles item 7 (AUTOSDE rule duplicates the test): they are two gates on purpose with different readers. noScrollbarPaint.test.ts fails CI after a push; the no-visible-scrollbar rule reaches the reviewer prompts before that, carries the decision and names the allowed cues (edge-fade-x, MORE_BELOW_MASK), which a red test line cannot. Same shape as use-lucide-icons next to its lint.

Deferred (outside the frozen goal)

  • UX note: capped lists that lost the hover thumb (MarkdownToc, SkillDirectoryBrowser, Skills/Prompts/Steering/Templates panes) have no scroll cue for a mouse user. A cue is new scope; recorded on Scroll cues for capped lists and wide code blocks under the scroll-only scrollbar #23547 alongside the scrollbar-none retirement.
  • UX note: a before/after frame of a capped list. Not added; the decision and this PR are about the paint, and the rule is exercised on the real Members page already.

Needs a maintainer

  • First Principles BLOCK (product-shape change without an RFC). The decision is the maintainer's (Hide every scrollbar in the dashboard; crewmate chat paints a permanent one #23539, docs/decisions/2026-10-23-scrollbars-are-hidden-everywhere.md); the clear path is /ai-review override first-principles <head-sha>: <decision> on the pushed head. That same comment is the on-record restatement docs/decisions/README.md rule 4 asks for.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/hide-all-scrollbars-23539 branch from 5e659ac to e090ad0 Compare October 23, 2026 21:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles e090ad0: Dashboard paints no scrollbar anywhere; decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-hidden-everywhere.md.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for e090ad0fd4c4cea4f1c62055b7ac7acd8b4f62a5.

Dashboard paints no scrollbar anywhere; decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-hidden-everywhere.md.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 23, 2026

@cruisercohen cruisercohen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting at e090ad0, not approving yet: one common surface still paints a scrollbar.

Code blocks and file views drawn by @pierre/diffs keep the library's own scrollbar. Pierre renders into a shadow root, and its stylesheet there gives [data-code] a ::-webkit-scrollbar of height: var(--diffs-scrollbar-gutter) (6px fallback), a var(--diffs-bg-context) thumb on [data-file]:hover / [data-diff]:hover, and on Firefox scrollbar-width: thin; scrollbar-color: var(--diffs-bg-context) transparent. The new base-layer rule in index.css is a document style: scrollbar-width does not inherit and ::-webkit-scrollbar does not match across the shadow boundary, so neither half reaches it. A non-prose CodeBlock (no overflow: 'wrap', so Pierre's default horizontal scroll) is the common case, and it gets exactly the hover-revealed thumb #23539 decided against.

Probe in Chromium 145 with --hide-scrollbars off, the PR's rule verbatim in @layer base, Pierre's shipped stylesheet in a shadow root, and a 600-character line in a 300px box:

scroller computed scrollbar-width gutter (offsetHeight - clientHeight)
light-DOM overflow-x:auto div none 0
shadow [data-code] auto 6px

Adding @layer unsafe{[data-code]{scrollbar-width:none}[data-code]::-webkit-scrollbar{display:none}} to the shadow sheet took it to none / 0.

Suggested fix: one shared fragment in the unsafeCSS that every Pierre File / FileDiff / editor mount receives (it lands in @layer unsafe, which outranks the library's @layer base; CodeBlock passes none today), optionally with --diffs-scrollbar-gutter-override: 0px on the host, mirroring the @pierre/trees block in chat-transcript.css. noScrollbarPaint.test.ts cannot see this because it scans src/ only; an assertion that the shared fragment carries both halves would pin it.

Smaller, non-blocking: noScrollbarPaint.test.ts matches only the kebab-case property, so an inline style={{ scrollbarWidth: 'thin' }} in a .tsx passes it (checked with a scratch file), and an inline style beats the global rule. The no-visible-scrollbar rule in AUTOSDE.yaml already catches that shape; the test could match the camelCase form too.

Everything else reads correct. On the PR merged with current main, the 12 related vitest files (378 tests) pass. With the old index.css, scrollbars-and-touch-hit.css and file-explorer styles.ts put back, noScrollbarPaint.test.ts fails 2 of 4 cases and names each painted rule.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at e090ad0fd4c4cea4f1c62055b7ac7acd8b4f62a5.

The light-DOM half of this works: the global rule hides the transcript, sidebar, list and modal scrollbars, the gutter and right-1.5 clean-ups are right, and the new gate catches the shapes it scans for. One part of the goal is not met, though. #23539 names "code and diff blocks: hidden at rest, shown on hover" as one of the three treatments to remove, and this PR closes that issue. But every code and diff block still paints that hover thumb.

Blocking

Code and diff blocks still paint a scrollbar. The global rule cannot reach them.

Every code and diff surface (CodeBlock.tsx:341, DiffBlock.tsx:341, DiffPanel.tsx:52, ContentRenderer.tsx:214, PapyrusEditor.tsx:126, WorkflowSourceCode.tsx:55) renders through @pierre/diffs, which draws into a shadow root. A document rule like *{scrollbar-width:none} / ::-webkit-scrollbar{display:none} (index.css:132-133) does not match anything inside a shadow tree. The library's own sheet (@pierre/diffs/dist/style.js, 1.3.5) gives [data-code] a ::-webkit-scrollbar with height: var(--diffs-scrollbar-gutter) (6px fallback), and [data-file]:hover [data-code]::-webkit-scrollbar-thumb { background-color: var(--diffs-bg-context) }. Under @supports (-moz-appearance: none) it also sets scrollbar-width: thin with a visible scrollbar-color. Dropping scroll-fade from CodeBlock.tsx changed nothing here: that class styled the light-DOM wrapper, which is not the box that scrolls.

I checked this in Chromium with headless scrollbar hiding turned off. I used the library's real stylesheet in a shadow root and the exact base-layer rule from this PR:

Probe Result
light-DOM overflow box scrollbar-width: none, 0px gutter (the rule works)
Pierre [data-code] box scrollbar-width: auto, 6px gutter
thumb pixels in that 6px strip, at rest / on hover 0 / 124 (painted in --diffs-bg-context)
same, with --diffs-scrollbar-gutter-override: 0px set on the host 0px gutter, 0 / 0

So in Chrome and Electron, every wide code block and diff still shows the hover thumb. In Firefox it shows a permanent thin one. This also makes three new texts wrong: the decision entry, the no-visible-scrollbar rule ("One rule in src/index.css … covers every scroll box") and the frontend-conventions.md paragraph. noScrollbarPaint.test.ts cannot catch it, because it scans src/ only.

Suggested fix, about three lines:

  • Add --diffs-scrollbar-gutter-override:0px to the .pierre-surface diffs-container rule in chat-transcript.css. Custom properties do cross the shadow boundary, and the probe above shows this removes the WebKit bar.
  • For Firefox, add [data-code]{scrollbar-width:none} to the shared Pierre unsafeCSS. That is the library's sanctioned way into the shadow root (see src/pierre/config.ts).
  • Word the rule and docs so they name this hook next to the @pierre/trees one. Optionally, extend noScrollbarPaint.test.ts to assert the override is present.

One side effect to check: Pierre sets padding-bottom: max(0px, gap - var(--diffs-scrollbar-gutter)). A 0 gutter makes each block a few px taller, so check that the pierre-plain stand-in in CodeBlock.tsx still keeps its height match with the highlighted surface.

Non-blocking

  1. The @pierre/trees Firefox rule has no effect (chat-transcript.css:436-440). [data-file-tree-virtualized-scroll] is rendered inside the file-tree-container shadow root (@pierre/trees/dist/render/FileTree.js appends the wrapper to shadowRoot), so none of the three light-DOM selectors match it. Removing the rule leaves every test green. The transparent thumb override still blanks the paint, so the only effect is a reserved thin column in Firefox. If that column matters, scrollbar-width:none belongs in PIERRE_TREE_STATE_ROW_CSS (unsafeCSS, PierreWorkspaceTreeImpl.tsx:825). If not, drop the rule and fix the comment.
  2. The PR body overstates the horizontal cue. It says the .edge-fade-x mask "stays as the cue for sideways-scrolling code blocks". On both main and this head, only the composer control row (ChatInput.tsx:1505) carries edge-fade-x. Code blocks never had it. Once their thumb is really gone, a wide code block has no cue, and a plain-wheel mouse user scrolls it only with Shift+wheel or the keyboard (the region keeps tabIndex=0). The decision accepts losing the thumb, so this is a wording fix, unless you want the edge fade on code blocks too, which #23547 could track.
  3. Test gap: noScrollbarPaint.test.ts misses React inline styles. Changing SessionTabStrip.tsx's scrollbarWidth: 'none' to 'thin' keeps all four cases green. The AUTOSDE regex covers scrollbarWidth at review time, but adding a camelCase scrollbarWidth/scrollbarColor shape to PAINTS would close the CI side.

Checked

  • website/AGENTS.md, frontend-conventions.md, narrow-viewport.md and the decision entry were read against the diff. No user-visible strings were added, so i18n is not affected. No theme values are hardcoded.
  • Keyboard and pointer: no scroller loses overflow-*. CodeBlock keeps its focusable role="region". The ChatInput / paste-mirror scrollbar-gutter:stable pairing still matches on both boxes. Touch hit areas are unchanged.
  • The removed tests (scrollbarThumbContrast, scrollbarOverlayTouch) only measured the thumb that is now gone. Their palette-resolver anchors moved into themeFillForeground.test.ts, and the capture-script swap follows the existing website/scripts/capture-*.mjs convention.
  • The no-visible-scrollbar regex compiles, and lookahead already appears in other rules in that file.

Tests run

  • 9 touched vitest files: 240 passed. tsc -p tsconfig.app.json --noEmit: clean.
  • Mutations, each applied alone and then restored:
Mutation Result
drop *{scrollbar-width:none} from index.css red: anchors the premise…
drop ::-webkit-scrollbar{display:none} red: anchors the premise…
new sheet with scrollbar-width:thin red: lets no file in src/ paint a scrollbar back
new sheet with a coloured ::-webkit-scrollbar-thumb red: lets no file in src/ paint a scrollbar back
--trees-scrollbar-thumb-override back to var(--muted) red: lets no file in src/ paint a scrollbar back
scrollbarGutter: 'stable' back on TranscriptScrollShell red: reserves no scrollbar gutter…
right-1.5 back on ChatTitleOverlay red: 5 cases in ChatPage.composerChromeOcclusion / overlaySelection
pane-1 list in the Overview library tab, overflow-y-auto to overflow-hidden red: the "list is its own scroll box" case in that tab's test
SessionTabStrip inline scrollbarWidth to 'thin' survives (non-blocking 3)
delete the @pierre/trees light-DOM scrollbar-width rule survives (non-blocking 1)
  • CI on this head: 92 check runs passed, 11 skipped, 0 failed. Statuses (both CodeBuild builds and PR Readiness) are green. Design, UX, GPT and Opus pass. The First Principles block was overridden by the maintainer and recorded. The earlier UX notes were triaged in the round-1 comment.
  • I merge-checked this head against the open frontend PRs #23565, #23577, #23540, #23209 and #23579: all merge cleanly. #23579 also edits ChatInput.tsx, but it adds nothing that conflicts with the new rule.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 23, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/hide-all-scrollbars-23539 branch from e090ad0 to 6f35765 Compare October 23, 2026 23:40
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

@buluoray thanks, the shadow-root miss was real. Head 6f35765780 addresses the review:

Blocking, fixed

  • Pierre code and diff surfaces: PIERRE_NO_SCROLLBAR_CSS in src/pierre/config.ts carries :host{--diffs-scrollbar-gutter-override:0px} plus [data-code]{scrollbar-width:none} and is folded into both pierreFileOptions and pierreDiffOptions, so every surface that resolves through them (all six you listed, the editor, and the file-change chips) gets it without naming it; a call site's own unsafeCSS is appended after it. The gutter override also makes padding-bottom equal the top padding, so block height and the pierre-plain stand-in match as before.
  • Reproduced your probe in the capture harness (--hide-scrollbars off, real Members page, a wide fenced block): [data-code] on e090ad0fd4 read scrollbar-width: auto, 6px horizontal gutter; on this head none, 0. Table in the PR body's Manual verification.
  • noScrollbarPaint.test.ts now asserts the hook: both halves present in PIERRE_NO_SCROLLBAR_CSS, both factories carry it, the tree's in-shadow rule and gutter override present. The AUTOSDE rule and frontend-conventions.md name the shadow-root path next to the light-DOM one.

Non-blocking, taken

  1. Dead light-DOM [data-file-tree-virtualized-scroll] rule removed; scrollbar-width:none now lives in PIERRE_TREE_STATE_ROW_CSS (the tree's unsafeCSS), where it reaches the shadow root.
  2. PR body and the scrollbars-and-touch-hit.css comment reworded: .edge-fade-x is the composer control row's cue, code blocks never had it. A cue for wide code blocks is on Scroll cues for capped lists and wide code blocks under the scroll-only scrollbar #23547.
  3. PAINTS gained the camelCase shapes (scrollbarWidth: 'thin'|'auto', scrollbarColor with a visible thumb); a mutation on SessionTabStrip-style inline style now fails the gate.

@CrysisDeu
CrysisDeu force-pushed the feat/hide-all-scrollbars-23539 branch from 6f35765 to f87ac9f Compare October 24, 2026 00:03
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 24, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/hide-all-scrollbars-23539 branch from f87ac9f to 5074cdb Compare October 24, 2026 00:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 24, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 5074cdb: No scrollbar in the dashboard is visible at rest; a box hides it or shows a thumb only while scrolling without changing width. Decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Head 5074cdb4c3. Round on f87ac9fc9f triaged:

Fixed

  • Automated Rule Check: document.body.innerHTML = '' in the new scrollReveal.test.ts → replaceChildren().
  • Frontend Lint (i18n all-caps-const): SHADOW_SCROLL_HOSTS is now built from SHADOW_SCROLL_HOST_TAGS = ['diffs-container', 'file-tree-container'], each a lowercase token the catalog exempts by shape; the joined selector is derived, not a literal.
  • Design note (observer cost): installScrollReveal's MutationObserver now skips text nodes outright and runs only matches() on a childless added element; the subtree query runs for an added subtree alone.
  • UX evidence gap: the capture harness records the scroll (wheel down, rest past the linger, wheel up, wheel the code block sideways) in both themes; the .webm recordings and a rest / rest / mid-scroll edge strip are attached, and the body's What changed / Tests / Manual verification describe this revision (both lanes read the previous body, which was edited minutes after their run).

Rebutted

  • UX note "add a transition on the thumb": Blink does not animate ::-webkit-scrollbar-thumb properties and Gecko does not animate scrollbar-color, so the old utilities' transition: background .2s never did anything; adding it back would be a dead declaration. The 800ms linger is what keeps the thumb from flickering.

The reviews from @buluoray and @cruisercohen are on e090ad0fd4; the shadow-root finding and the camelCase gap are addressed as described two comments up, now in the scroll-reveal form.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 5074cdb4c3f2450566e4a75f55c8f4d3715ea92a.

No scrollbar in the dashboard is visible at rest; a box hides it or shows a thumb only while scrolling without changing width. Decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 24, 2026
The crewmate chat painted a permanent 6px thumb down the transcript's
right edge, and so did the main chat: both mount TranscriptScrollShell,
which inherited the global always-visible thumb from index.css. Three
scrollbar treatments coexisted (always-on, hidden, hover-revealed) with
no rule deciding which a surface got.

One rule now: no scrollbar is visible at rest. A scroll box either hides
its scrollbar entirely (`.scrollbar-none`, unchanged) or shows a thin
thumb only while it is being scrolled, in the 6px column it reserves
anyway, so the reveal moves no content. The base layer keeps the column
with a transparent thumb and paints it under `[data-scrolling]`;
`lib/scrollReveal.ts` sets that attribute on the scrolling element and
clears it after a short linger, on the document and inside the two
shadow roots the light-DOM rule cannot reach (Pierre's code/diff
surfaces through both option factories' `unsafeCSS`, the workspace tree
through its own). The Firefox half is fenced behind the `-moz-appearance`
probe because Blink drops the pseudo-elements once a standard scrollbar
property is set. The `.scrollbar-overlay` / `.scroll-fade` utilities and
the file-explorer tab-strip thumb are removed.

`scrollbarRevealOnly.test.ts` scans src/ for any thumb painted outside
`[data-scrolling]` and measures the revealed thumb's 3:1 contrast per
theme, replacing the two specs that measured the resting thumbs;
`scrollReveal.test.ts` pins the attribute lifecycle. The
`no-scrollbar-at-rest` AUTOSDE rule blocks a repaint in review, and the
decision is recorded under docs/decisions/.

Closes #23539
@CrysisDeu
CrysisDeu force-pushed the feat/hide-all-scrollbars-23539 branch from 5074cdb to 27e1a95 Compare October 24, 2026 21:13
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 27e1a95: No scrollbar in the dashboard is visible at rest; a box hides it or shows a thumb only while scrolling without changing width. Decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Head 27e1a95231 is 5074cdb4c3 rebased onto current main (the only conflict was the appended row in docs/decisions/README.md; both rows kept, no code change). The round on 5074cdb4c3 finished 100/100 green. @buluoray your CHANGES_REQUESTED is still pinned to e090ad0fd4; the shadow-root finding is addressed in the scroll-reveal form described above, when you have a moment to re-review.

@CrysisDeu
CrysisDeu requested a review from buluoray October 24, 2026 21:13
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a legacy release (class legacy) for the first-principles AI finding on 27e1a9523117d481360de1d51d1825421dd30d19.

No scrollbar in the dashboard is visible at rest; a box hides it or shows a thumb only while scrolling without changing width. Decided in #23539, recorded in docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

This override used the old command without a class. It was recorded as class legacy, and the old command stops working on 2026-12-09. Name a class from now on. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 24, 2026
@CrysisDeu
CrysisDeu merged commit 63440c2 into main Oct 25, 2026
106 of 108 checks passed
@CrysisDeu
CrysisDeu deleted the feat/hide-all-scrollbars-23539 branch October 25, 2026 07:46
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
CrysisDeu added a commit that referenced this pull request Oct 25, 2026
The dashboard shows no scrollbar at rest (maintainer decision,
docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md,
landing in #23550): a box either hides it or shows a thin thumb only
while it is scrolling, without changing its width. The UX lane had no
lens for it: on #23550 it passed the change but could only note the
capped lists that lost their hover thumb, with no rule to hold a future
diff to.

Lens 7 (consistency) now carries the rule in both UX lane prompts: a
diff that paints a thumb at rest, a hover-revealed thumb, a reveal that
pushes content, or a screenshot showing a scrollbar while nothing
scrolls is a finding; a scroll box that needs a cue gets an edge fade or
a "more below" affordance, never a resting thumb; hiding one is never a
regression.

Refs #23539
CrysisDeu added a commit that referenced this pull request Oct 26, 2026
The dashboard shows no scrollbar at rest (maintainer decision,
docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md,
landing in #23550): a box either hides it or shows a thin thumb only
while it is scrolling, without changing its width. The UX lane had no
lens for it: on #23550 it passed the change but could only note the
capped lists that lost their hover thumb, with no rule to hold a future
diff to.

Lens 7 (consistency) now carries the rule in both UX lane prompts: a
diff that paints a thumb at rest, a hover-revealed thumb, a reveal that
pushes content, or a screenshot showing a scrollbar while nothing
scrolls is a finding; a scroll box that needs a cue gets an edge fade or
a "more below" affordance, never a resting thumb; hiding one is never a
regression.

Refs #23539
iamwhatever pushed a commit that referenced this pull request Oct 26, 2026
The dashboard shows no scrollbar at rest (maintainer decision,
docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md,
landing in #23550): a box either hides it or shows a thin thumb only
while it is scrolling, without changing its width. The UX lane had no
lens for it: on #23550 it passed the change but could only note the
capped lists that lost their hover thumb, with no rule to hold a future
diff to.

Lens 7 (consistency) now carries the rule in both UX lane prompts: a
diff that paints a thumb at rest, a hover-revealed thumb, a reveal that
pushes content, or a screenshot showing a scrollbar while nothing
scrolls is a finding; a scroll box that needs a cue gets an edge fade or
a "more below" affordance, never a resting thumb; hiding one is never a
regression.

Refs #23539

Co-authored-by: CrysisDeu <crysisDeu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide every scrollbar in the dashboard; crewmate chat paints a permanent one

4 participants