Skip to content

ci(ux-review): flag a painted scrollbar as a finding - #23568

Merged
iamwhatever merged 1 commit into
mainfrom
ci/ux-review-no-scrollbar-lens
Oct 26, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
ci/ux-review-no-scrollbar-lens

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The UX AI reviewer holds every frontend PR to the "no scrollbar is visible at rest" decision instead of passing one that paints a resting scrollbar back.

#23550 makes "no scrollbar is visible at rest; a box hides it or shows a thin thumb only while scrolling, without changing its width" one global rule, recorded in docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md. The UX Review lane had no lens for it: on #23550 it could only note that some capped lists lost their hover thumb, with no rule to judge the note by, and a later diff that reintroduced a thumb would meet no UX finding at all. The maintainer asked for the decision to become a UX reviewer rule (#23539).

Why it matters

A design rule that lives only in a stylesheet and a CI test is enforced after the fact; the UX lane reads the diff and the screenshots and can name the cue a box should carry instead. Without the lens, every review of a new scroll surface re-litigates the decision.

Not a goal

What changed (motivation → approach → change)

Decision → the lens that already holds house style (lens 7, "Consistency & habituation", where the flat-fills rule sits) → one new bullet in both UX lane prompts (ux-review.yml owns the text, fork-ux-review.yml carries the copy the parity test checks):

  • A scroll box either hides its scrollbar (scrollbar-none) or shows a thin thumb only while scrolling (data-scrolling), in a column it already reserves. A diff that paints one at rest is a finding: a coloured ::-webkit-scrollbar-thumb or scrollbar-color whose selector lacks [data-scrolling], scrollbar-width: auto, a hover-revealed thumb, a revived .scrollbar-overlay / .scroll-fade, a screenshot showing a scrollbar while nothing scrolls, or a reveal that pushes content.
  • "The box needs a scroll affordance" is not an exception: the cue is an edge fade (.edge-fade-x, useScrollEdges) or a "more below" affordance (MORE_BELOW_MASK, JumpToBottomButton), never a resting thumb.
  • Hiding a scrollbar is never a regression to flag; the decision outranks the report.

The bullet cites the decision file by path, so once #23550 lands the lane can open it.

Backwards compatibility

Compatible: prompt text only. Removes nothing: no lens, marker or step is removed; the prompt stays expression-free and under the size the workflow header documents.

Tests

  • test/test_review_lane_prompt_parity.py (unchanged) pins that the lens block is identical across the two lanes; it covers the new bullet because the bullet sits inside the compared block.
  • test/test_ai_review_workflows_ux.py (unchanged) covers the lane's step shape and markers.
  • Both run green locally (56 passed, -n0).

Manual verification

N/A — prompt-text change; the parity test and YAML parse are the verification, and the lane's behaviour on a real PR is what the next frontend PR shows.

Screenshots / video

N/A — no user-facing surface changes; this is a CI workflow prompt.

Related Issues

Refs #23539
Depends on #23550 (the decision file the lens cites)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 23, 2026 21:47
@CrysisDeu
CrysisDeu requested a review from buluoray October 23, 2026 21:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 915da2b7d476e7612c76c201c4de2ebcdb0ef948 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 915da2b7d476e7612c76c201c4de2ebcdb0ef948 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The rule is a recorded decision (docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md, on base) and a maintainer asked for it (#23539). The only overlap with existing work is the CSS-pattern list.

Notes

  • Item 2 — duplicate of website/src/test/scrollbarRevealOnly.test.ts: its test "lets no file in src/ paint a thumb at rest" already fails CI on a ::-webkit-scrollbar-thumb or scrollbar-color outside [data-scrolling], and on a scrollbar-width other than thin or none. The prompt hunk re-lists exactly those source patterns ("a coloured ::-webkit-scrollbar-thumb or scrollbar-color whose selector lacks [data-scrolling], scrollbar-width: auto"). Subtraction: delete those two clauses from both lane prompts and keep the parts the test cannot see: screenshots, a reveal that pushes content, a hover-revealed thumb, and the scroll-cue guidance.

What this change ships

Inventory (5 items) — 4 justified

Intent: make the UX AI reviewer hold every frontend PR to the recorded "no scrollbar at rest" decision. ADDITION.

  1. The UX reviewer flags a screenshot that shows a scrollbar at rest — justified
  2. The UX reviewer flags CSS that paints a thumb outside [data-scrolling], or sets scrollbar-width: auto — duplicate of website/src/test/scrollbarRevealOnly.test.ts
  3. The UX reviewer flags a scrollbar reveal that changes the box's width — justified
  4. The UX reviewer points to an edge fade or a "more below" cue instead of a resting thumb — justified
  5. The UX reviewer no longer reports a hidden scrollbar as a regression (in both lanes, fork copy kept identical) — justified

[FIRST-PRINCIPLES-REVIEWED] 915da2b

Description read

[DESCRIPTION-READ] 37a658893736c6036f02a40de5b75d5599705b2def30418a983483117105bccd

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 915da2b7d476e7612c76c201c4de2ebcdb0ef948 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This PR only adds prompt text, and every file, symbol and AUTOSDE rule it cites already exists on the base.

[DESIGN-REVIEWED] 915da2b

Description read

[DESCRIPTION-READ] 48f0fd144dd717dd78c98edf16a6f93b44f957b72498b084cbc29ae6105314e9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 915da2b7d476e7612c76c201c4de2ebcdb0ef948 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 915da2b

Verdict parsed from the review's SHA-scoped output markers for commit 915da2b7d476e7612c76c201c4de2ebcdb0ef948.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 915da2b7d476e7612c76c201c4de2ebcdb0ef948 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 915da2b7d476e7612c76c201c4de2ebcdb0ef948 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 915da2b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 915da2b7d476e7612c76c201c4de2ebcdb0ef948 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@CrysisDeu
CrysisDeu marked this pull request as draft October 23, 2026 23:42
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Opus BLOCK is the ordering, not the rule: the decision file and the index.css rule the bullet cites are in #23550 and not on main yet. Parked as draft until #23550 merges; then this rebases onto main and the lane re-reads it against a base where both exist. No change to the bullet in the meantime.

@CrysisDeu CrysisDeu mentioned this pull request Oct 24, 2026
5 tasks done
@CrysisDeu
CrysisDeu force-pushed the ci/ux-review-no-scrollbar-lens branch from 859bb82 to ed2f1d6 Compare October 24, 2026 00:07
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 24, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Bullet rewritten for the refined decision (maintainer, 2026-10-23): a scrollbar is never visible at rest; the two allowed forms are fully hidden and shown-only-while-scrolling without a width change. Hover-reveal is now named as a finding. The goal line was updated on that instruction; still draft until #23550 lands.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 24, 2026
@CrysisDeu
CrysisDeu marked this pull request as ready for review October 25, 2026 07:46
@CrysisDeu
CrysisDeu force-pushed the ci/ux-review-no-scrollbar-lens branch from ed2f1d6 to 3eed0fe Compare October 25, 2026 07:46
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

#23550 merged (63440c2899). Rebased onto main at 3eed0fe0cb; the decision file, the index.css rule and the no-scrollbar-at-rest AUTOSDE rule this bullet cites are all on base now. Out of draft.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 25, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 25, 2026
The dashboard shows no scrollbar at rest (maintainer decision,
docs/decisions/2026-10-23-scrollbars-are-never-always-visible.md,
landing in #23550): a box either hides it or shows a thin thumb only
while it is scrolling, without changing its width. The UX lane had no
lens for it: on #23550 it passed the change but could only note the
capped lists that lost their hover thumb, with no rule to hold a future
diff to.

Lens 7 (consistency) now carries the rule in both UX lane prompts: a
diff that paints a thumb at rest, a hover-revealed thumb, a reveal that
pushes content, or a screenshot showing a scrollbar while nothing
scrolls is a finding; a scroll box that needs a cue gets an edge fade or
a "more below" affordance, never a resting thumb; hiding one is never a
regression.

Refs #23539
@CrysisDeu
CrysisDeu force-pushed the ci/ux-review-no-scrollbar-lens branch from 3eed0fe to 915da2b Compare October 26, 2026 08:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Reviewed 915da2b7d476e7612c76c201c4de2ebcdb0ef948.

The change adds the same lens-7 bullet to both UX lane prompts (ux-review.yml#L971-L993, fork-ux-review.yml#L975-L997). It is prompt text only: no permissions, secrets or steps change. Every file and identifier it cites (the decision record, lib/scrollReveal.ts, data-scrolling, .edge-fade-x, useScrollEdges, MORE_BELOW_MASK, JumpToBottomButton, the AUTOSDE rule) is on main now that #23550 has merged, which also settles the earlier ordering BLOCK. Current-head lanes are PASS or no findings, checks are green, and there are no change requests.

Optional: First Principles notes that the two CSS clauses duplicate scrollbarRevealOnly.test.ts; dropping them is a valid simplification but not required.

— crew-pr-reviewer (r127)

@iamwhatever
iamwhatever merged commit 1dfee86 into main Oct 26, 2026
107 checks passed
@iamwhatever
iamwhatever deleted the ci/ux-review-no-scrollbar-lens branch October 26, 2026 17:37
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants