Repository navigation
chore(ops_mission_control): drop history and restating comments - #24468
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Only comments change: every added or removed line in the patch is a [DESIGN-REVIEWED] c455772 Description read[DESCRIPTION-READ] 195cffd1c17ae5685a6b6f39e9a923918fc0b2549961ee6b26f363a2a2506936 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. Every changed line is a What this change shipsInventory (2 items) — 2 justifiedIntent: make the comments in
[FIRST-PRINCIPLES-REVIEWED] c455772 Description read[DESCRIPTION-READ] 7ea65209503d0222ef1b21e91193ff873167312d5424bffdd0ce78bfa30cf71e That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Backend Tests (Windows) (2) red at 6563e7b: |
bolichen97
left a comment
There was a problem hiding this comment.
This looks good to ship at 6563e7b. I am not approving yet because required checks are red.
What I checked:
- For each of the 17 changed files, I compared the merge base and the head with ast.dump and with the full token stream minus comments. All 17 are identical, so this is a comment-only change.
- I read every rewritten comment. Each one still states the current behaviour correctly. The rewrites in board.py, lifecycle.py, dispatch.py and providers/init.py keep the rule and drop the history.
- No file is on the security path list, and the files the description lists as skipped are not in the diff.
- File count is 17, the category is chore, and there is no linked issue.
What remains:
- Backend Tests (3.12, 2) and Backend Tests (Windows) (2) fail on one test, test_a_first_history_page_in_a_new_process_reads_the_page_not_the_file in test/test_crew_log_fullscan_guard.py. It is a strict xfail that now passes (XPASS). This PR does not touch that test or the code it covers, and main carries the same strict marker, so the failure comes from the base. Coverage Gate fails only because those shards failed.
- When main drops or updates that marker, rebase with
gh pr update-branch --rebaseand the checks should go green. I will approve then.
Non-blocking: a few untouched lines in these files still narrate history, for example "swept for exactly this class last round" in dispatch.py, "the review suggested False" in pagerduty.py, and "that review suggested" in lifecycle.py. A follow-up pass can take them.
6563e7b to
d916ff4
Compare
|
Rebased onto main to pick up #24467 (f98073d), which drops the stale strict xfail behind the Backend Tests (3.12, 2) / Windows (2) reds. @bolichen97's update-branch rebase (d916ff4) is replaced by new head 5d833a4: the same commit plus the fixes below. @bolichen97 the four leftover narrations you named are fixed, each as a plain rule:
Still comments only: astcheck against the merge base, 17 files, 0 code changed; no added line over 100 columns. |
d916ff4 to
5d833a4
Compare
|
Backend Tests (3.12, 2) and Windows (2) red at 5d833a4: |
5d833a4 to
c0c1ba7
Compare
bolichen97
left a comment
There was a problem hiding this comment.
This looks good to ship at c0c1ba7. I am not approving yet because Backend Tests and PR Readiness are still running on this head. A maintainer can approve once readiness passes.
What I checked at this head:
- Comment-only claim: for all 17 changed files, the AST of each module (docstrings included) and its token stream with comments removed are identical to the parent commit. No code, string or docstring changed.
- The rebase onto main kept the same patch: the stable patch id matches the reviewed 5d833a4 diff.
- New wording: each rewritten comment keeps its reason and states current behaviour. Removed text is review tags and revision history only. The reworded "before" and "the review proposed" passages now read as present-tense invariants, which matches the repo comment rule.
- No file is on the security path list, the diff changes no runtime behaviour, and the file count is 17.
- The Backend Tests reds at 5d833a4 were only the strict xfail that main fixed. This head contains that fix.
Optional follow-up, not blocking: a few untouched neighbours still narrate history, for example "That companion PR is this one" in configuration.py and "The bare sequence here bypassed that lock" in ledger_sync.py. Some reflowed comment lines also end short and could be rewrapped.
c0c1ba7 to
ddc5460
Compare
|
Rebased onto main to pick up #24485 (8f18fd5), which drops the three stale strict xfails behind the shard-2 reds. New head ddc5460, same patch (astcheck against the merge base: 17 files, 0 code changed). Main is also red on Backend Tests shard 4 (two telegram dispatcher tests, #24514); that is not this diff. |
ddc5460 to
f83f0be
Compare
|
Rebased onto main to pick up #24531 (dbf207c), which fixes the telegram shard-4 red (#24514). New head f83f0be, same patch (astcheck against the merge base: 17 files, 0 code changed; comment-history and brand gates pass). Windows (7) was |
|
Integration (in-process gateway) red at f83f0be: |
|
Rebased onto main 96c4fef, new head 5feb5d2, same patch (astcheck against the merge base: 17 files, 0 code changed; comment-history and brand gates pass). Integration (in-process gateway) passed on #24642 at that main without #24530, so the second-boot globals red (#24528) does not show up on every run; this re-runs it. The new main also has #24536 for the macOS lease teardown errors. |
f83f0be to
5feb5d2
Compare
Remove "Found in review (GPT 5.6)" style tags, "an earlier revision" narration and "this change exists to" scope notes from `#` comments in src/kiro_crew/apps/builtins/ops_mission_control/. A history comment that also carried a real reason keeps only the reason, stated as a rule. Comments only: every touched file has the same AST as its base. Secrets, policy-store, Slack redaction, Datadog credential and action authorization files are left for their own reviewed pass.
5feb5d2 to
c455772
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: chore (17 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits in the ops_mission_control backend; no code line changes.
Problem / Motivation
Goal: Remove review-provenance tags and PR-history narration from
#comments insrc/kiro_crew/apps/builtins/ops_mission_control/, with no behaviour change, as part 3 of theapps/builtins/*step of the source-comment rollout piloted in #23966 (slack/).About sixty comments in this app end with "Found in review.", "Found in review (GPT 5.6).", "(Opus 4.8)", "(Design Review, Fable 5)" or "(First Principles)", and a few tell the story of an earlier revision ("An earlier revision of this handler reasoned...", "the review proposed deleting both calls", "the exact accidental tolerance this change exists to close"). The reason in each comment stands without the tag. AGENTS.md and the worktree-dev skill say comments state current behaviour and the non-obvious why, with no review rounds or task log.
Why it matters
A review tag tells a reader who asked, not why the code is right, and "this change" stops meaning anything once the PR merges.
Not a goal
What changed (motivation → approach → change)
17 non-test files in
ops_mission_control/touched. Only#comment lines changed.Every rewrite states the rule, not its history. Before pushing I checked the added lines for anything over 100 columns and for leftover "this change", "earlier revision", round, GPT, Opus, Fable or "found in review" wording; there is none.
Examples, one per kind
1. Trailing review tag (
backend/rotation.py)2. Tag-only line (
backend/routes.py)- # Found in review.3. "An earlier revision" narration, kept as the rule (
backend/http_routes/board.py)4. Review proposal, kept as the decision (
backend/http_routes/lifecycle.py)5. "This change exists to" scope note (
backend/store.py)Most tags were removed by a token-aware script that edits only
COMMENTtokens and deletes a line only when the tag was its whole text; tags split across lines and narration were edited by hand. The AST check below covers both.What was kept, and why
incidenteverywhere: it is this app's domain noun (an incident record, the incident index).Design Review/First Principlesonly where they named the review lane that found something; the reasons around them stay.Skipped security files
Not edited, even where they carry the same tags:
backend/secrets.py,backend/policy_store.py(keystone writes),backend/slack_out.py(redaction),backend/providers/datadog.py(credential handover),backend/http_routes/actions.py(authorize_action). They get their own reviewed pass.Backwards compatibility
Compatible: only comments change; every touched file has the same AST as its base.
Removes nothing: no code, key, record, validator or public function changes.
Tests
Proof: not provable -- copy-only change
AST-identical proof.
goal_scan.py astcheck origin/maincomparesast.dump(ast.parse(src))for every.pyfile changed against the base; docstring-only differences would be reported separately and there are none:Files:
backend/{dispatch,ledger_sync,notify_out,registry,rotation,routes,slot_watch,store}.py,backend/http_routes/{_shared,board,configuration,lifecycle}.py,backend/providers/{__init__,base,cloudwatch,pagerduty,webhook}.py.Gates on the touched files:
flake8: cleanisort --check-only: cleanblack:scripts/check_black_formatting.pypassesmypy:Success: no issues found in 17 source filescheck_comment_history.pyandcheck_brand_name.py: passKIROCREW_PROFILE=standalone pytest src/kiro_crew/apps/builtins/ops_mission_control -n 4: 1154 passed, 44 skippedManual verification
N/A — comment-only change; the AST check proves the compiled code is unchanged.
Related Issues
None.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.