Skip to content

chore(ops_mission_control): drop history and restating comments - #24468

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
chore/src-comments-ops-mission-control
Oct 27, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
chore/src-comments-ops-mission-control

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Remove review-provenance tags and PR-history narration from # comments in src/kiro_crew/apps/builtins/ops_mission_control/, with no behaviour change, as part 3 of the apps/builtins/* step of the source-comment rollout piloted in #23966 (slack/).

About sixty comments in this app end with "Found in review.", "Found in review (GPT 5.6).", "(Opus 4.8)", "(Design Review, Fable 5)" or "(First Principles)", and a few tell the story of an earlier revision ("An earlier revision of this handler reasoned...", "the review proposed deleting both calls", "the exact accidental tolerance this change exists to close"). The reason in each comment stands without the tag. AGENTS.md and the worktree-dev skill say comments state current behaviour and the non-obvious why, with no review rounds or task log.

Why it matters

A review tag tells a reader who asked, not why the code is right, and "this change" stops meaning anything once the PR merges.

Not a goal

  • No docstring edits.
  • No code, behaviour, or formatting change.
  • No edits to secrets, policy, redaction, credential or action-authorization code (list below).
  • No other builtin app. Each gets its own PR.

What changed (motivation → approach → change)

17 non-test files in ops_mission_control/ touched. Only # comment lines changed.

lines
Tag-only comment lines deleted 2
Comment lines with a tag or narration rewritten 82 -> 74
Comment lines deleted / added 84 / 74
Net comment lines removed 10
Non-comment lines touched 0

Every rewrite states the rule, not its history. Before pushing I checked the added lines for anything over 100 columns and for leftover "this change", "earlier revision", round, GPT, Opus, Fable or "found in review" wording; there is none.

Examples, one per kind

1. Trailing review tag (backend/rotation.py)

-    # check that cannot type its input refuses. Found in review (GPT 5.6).
+    # check that cannot type its input refuses.

2. Tag-only line (backend/routes.py)

-    # Found in review.

3. "An earlier revision" narration, kept as the rule (backend/http_routes/board.py)

-    # An earlier revision of this handler reasoned that the awaited `resolve_shift()` above
-    # always warms that cache first, so an inline call was safe. That was WRONG, and review
-    # caught it: `resolve_shift` wraps each source in `asyncio.wait_for(...,
+    # The awaited `resolve_shift()` above does NOT always warm that cache first, so an
+    # inline call is not safe: `resolve_shift` wraps each source in `asyncio.wait_for(...,

4. Review proposal, kept as the decision (backend/http_routes/lifecycle.py)

-    # thread-safety. Found in review (GPT 5.6); the review proposed deleting both calls,
-    # which would have removed the replyable-thread link and the needs-human alert —
-    # features, not incidental work — so they are marshalled instead.
+    # thread-safety. Deleting both calls is not an option: they carry the replyable-thread
+    # link and the needs-human alert — features, not incidental work — so they are
+    # marshalled instead.

5. "This change exists to" scope note (backend/store.py)

-        # unwrapped it slips past every corruption clause in this change and lands in the
-        # tolerant `except (KeyError, ValueError, OSError)` arms instead, silently swallowed:
-        # the exact accidental tolerance this change exists to close, reached through a
-        # sibling exception type. Found in review (GPT 5.6). Wrapped so a corrupt byte stream
+        # unwrapped it slips past every corruption clause and lands in the tolerant
+        # `except (KeyError, ValueError, OSError)` arms instead, silently swallowed: an
+        # accidental tolerance reached through a sibling exception type. Wrapped so a
+        # corrupt byte stream

Most tags were removed by a token-aware script that edits only COMMENT tokens and deletes a line only when the tag was its whole text; tags split across lines and narration were edited by hand. The AST check below covers both.

What was kept, and why

  • incident everywhere: it is this app's domain noun (an incident record, the incident index).
  • Design Review / First Principles only where they named the review lane that found something; the reasons around them stay.
  • Measured or recorded facts that are not about who asked.
  • Where unsure, the comment stayed.

Skipped security files

Not edited, even where they carry the same tags: backend/secrets.py, backend/policy_store.py (keystone writes), backend/slack_out.py (redaction), backend/providers/datadog.py (credential handover), backend/http_routes/actions.py (authorize_action). They get their own reviewed pass.

Backwards compatibility

Compatible: only comments change; every touched file has the same AST as its base.

Removes nothing: no code, key, record, validator or public function changes.

Tests

Proof: not provable -- copy-only change

AST-identical proof. goal_scan.py astcheck origin/main compares ast.dump(ast.parse(src)) for every .py file changed against the base; docstring-only differences would be reported separately and there are none:

files checked: 17  code-changed: 0  docstring-only: 0

Files: backend/{dispatch,ledger_sync,notify_out,registry,rotation,routes,slot_watch,store}.py, backend/http_routes/{_shared,board,configuration,lifecycle}.py, backend/providers/{__init__,base,cloudwatch,pagerduty,webhook}.py.

Gates on the touched files:

  • flake8: clean
  • isort --check-only: clean
  • black: scripts/check_black_formatting.py passes
  • mypy: Success: no issues found in 17 source files
  • check_comment_history.py and check_brand_name.py: pass
  • App tests, KIROCREW_PROFILE=standalone pytest src/kiro_crew/apps/builtins/ops_mission_control -n 4: 1154 passed, 44 skipped

Manual verification

N/A — comment-only change; the AST check proves the compiled code is unchanged.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 26, 2026 13:37
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision c4557722b2a665433ef657ad17726f511ed42b63 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c4557722b2a665433ef657ad17726f511ed42b63 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Only comments change: every added or removed line in the patch is a # comment, so there is no design surface to judge.

[DESIGN-REVIEWED] c455772

Description read

[DESCRIPTION-READ] 195cffd1c17ae5685a6b6f39e9a923918fc0b2549961ee6b26f363a2a2506936

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c4557722b2a665433ef657ad17726f511ed42b63 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. Every changed line is a # comment. Each change removes review tags or history narration, which AGENTS.md's comment rules call for.

What this change ships

Inventory (2 items) — 2 justified

Intent: make the comments in ops_mission_control/ describe current behaviour rather than review history. This is a FIX (comment hygiene).

  1. Review-provenance tags such as "Found in review (GPT 5.6)" are removed from about sixty comments across 17 files — justified
  2. Narration of earlier revisions and "this change" is rewritten to state the rule it describes — justified

[FIRST-PRINCIPLES-REVIEWED] c455772

Description read

[DESCRIPTION-READ] 7ea65209503d0222ef1b21e91193ff873167312d5424bffdd0ce78bfa30cf71e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c4557722b2a665433ef657ad17726f511ed42b63 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c455772

Verdict parsed from the review's SHA-scoped output markers for commit c4557722b2a665433ef657ad17726f511ed42b63.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c4557722b2a665433ef657ad17726f511ed42b63 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c4557722b2a665433ef657ad17726f511ed42b63 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c455772

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c4557722b2a665433ef657ad17726f511ed42b63 false-positive: <reason, 20 to 500 characters>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Backend Tests (Windows) (2) red at 6563e7b: test/test_crew_log_fullscan_guard.py::test_a_first_history_page_in_a_new_process_reads_the_page_not_the_file is a strict xfail that now passes (XPASS(strict)). Not this diff (comments only under ops_mission_control/, AST-identical). Main's Windows shard 2 is red on the same test (job 121587656703); the fix is open as #24467. I will rebase once it merges.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to ship at 6563e7b. I am not approving yet because required checks are red.

What I checked:

  • For each of the 17 changed files, I compared the merge base and the head with ast.dump and with the full token stream minus comments. All 17 are identical, so this is a comment-only change.
  • I read every rewritten comment. Each one still states the current behaviour correctly. The rewrites in board.py, lifecycle.py, dispatch.py and providers/init.py keep the rule and drop the history.
  • No file is on the security path list, and the files the description lists as skipped are not in the diff.
  • File count is 17, the category is chore, and there is no linked issue.

What remains:

  • Backend Tests (3.12, 2) and Backend Tests (Windows) (2) fail on one test, test_a_first_history_page_in_a_new_process_reads_the_page_not_the_file in test/test_crew_log_fullscan_guard.py. It is a strict xfail that now passes (XPASS). This PR does not touch that test or the code it covers, and main carries the same strict marker, so the failure comes from the base. Coverage Gate fails only because those shards failed.
  • When main drops or updates that marker, rebase with gh pr update-branch --rebase and the checks should go green. I will approve then.

Non-blocking: a few untouched lines in these files still narrate history, for example "swept for exactly this class last round" in dispatch.py, "the review suggested False" in pagerduty.py, and "that review suggested" in lifecycle.py. A follow-up pass can take them.

@bolichen97
bolichen97 force-pushed the chore/src-comments-ops-mission-control branch from 6563e7b to d916ff4 Compare October 26, 2026 15:07
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@iamwhatever

iamwhatever commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto main to pick up #24467 (f98073d), which drops the stale strict xfail behind the Backend Tests (3.12, 2) / Windows (2) reds. @bolichen97's update-branch rebase (d916ff4) is replaced by new head 5d833a4: the same commit plus the fixes below.

@bolichen97 the four leftover narrations you named are fixed, each as a plain rule:

  • dispatch.py: "swept for exactly this class last round" -> "The guard test that keeps this class out of routes.py covers dispatch.py too."
  • http_routes/lifecycle.py: "the coded refusal that review suggested" -> "a coded refusal"
  • providers/pagerduty.py: "the review suggested False, and that is the wrong direction" -> "False is the wrong direction here."
  • rotation.py: "the review's fix (deny whenever any source is unknown)" -> "denying whenever any source is unknown"

Still comments only: astcheck against the merge base, 17 files, 0 code changed; no added line over 100 columns.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 2) and Windows (2) red at 5d833a4: test_a_cold_prime_copies_the_fold_state_a_fixed_number_of_times is a strict xfail that now passes (XPASS(strict)) after #24261 merged; two WS guards in the same file are stale the same way after #24268. Not this diff (comments only). Main-red issue #24484, fix #24485. I will rebase once it merges.

@bolichen97
bolichen97 force-pushed the chore/src-comments-ops-mission-control branch from 5d833a4 to c0c1ba7 Compare October 26, 2026 16:05

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to ship at c0c1ba7. I am not approving yet because Backend Tests and PR Readiness are still running on this head. A maintainer can approve once readiness passes.

What I checked at this head:

  • Comment-only claim: for all 17 changed files, the AST of each module (docstrings included) and its token stream with comments removed are identical to the parent commit. No code, string or docstring changed.
  • The rebase onto main kept the same patch: the stable patch id matches the reviewed 5d833a4 diff.
  • New wording: each rewritten comment keeps its reason and states current behaviour. Removed text is review tags and revision history only. The reworded "before" and "the review proposed" passages now read as present-tense invariants, which matches the repo comment rule.
  • No file is on the security path list, the diff changes no runtime behaviour, and the file count is 17.
  • The Backend Tests reds at 5d833a4 were only the strict xfail that main fixed. This head contains that fix.

Optional follow-up, not blocking: a few untouched neighbours still narrate history, for example "That companion PR is this one" in configuration.py and "The bare sequence here bypassed that lock" in ledger_sync.py. Some reflowed comment lines also end short and could be rewrapped.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever force-pushed the chore/src-comments-ops-mission-control branch from c0c1ba7 to ddc5460 Compare October 26, 2026 17:59
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main to pick up #24485 (8f18fd5), which drops the three stale strict xfails behind the shard-2 reds. New head ddc5460, same patch (astcheck against the merge base: 17 files, 0 code changed). Main is also red on Backend Tests shard 4 (two telegram dispatcher tests, #24514); that is not this diff.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever force-pushed the chore/src-comments-ops-mission-control branch from ddc5460 to f83f0be Compare October 26, 2026 20:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main to pick up #24531 (dbf207c), which fixes the telegram shard-4 red (#24514). New head f83f0be, same patch (astcheck against the merge base: 17 files, 0 code changed; comment-history and brand gates pass). Windows (7) was test_stuck_turn_watchdog.py::test_backend_silence_without_a_park_still_trips_the_arm, a timing test outside this diff; the new run re-tests it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Integration (in-process gateway) red at f83f0be: test_a_second_boot_touches_only... sees executors._memory_background_pool and vector_memory_lifecycle._loop_lock_sites, two boot globals from #24290. Main is red on the same test (#24528); the fix is #24530. Not this diff (comments only). I will rebase once #24530 merges.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever

iamwhatever commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto main 96c4fef, new head 5feb5d2, same patch (astcheck against the merge base: 17 files, 0 code changed; comment-history and brand gates pass). Integration (in-process gateway) passed on #24642 at that main without #24530, so the second-boot globals red (#24528) does not show up on every run; this re-runs it. The new main also has #24536 for the macOS lease teardown errors.

@iamwhatever
iamwhatever force-pushed the chore/src-comments-ops-mission-control branch from f83f0be to 5feb5d2 Compare October 27, 2026 00:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Backend Tests (Windows) (6) red at 5feb5d2: test_slack_team_id_env.py::TestSpawnEnv fails with WinError 2 on main. That is tracked in #24612, with open fixes #24609 and #24613, and is not this diff (comments only). I will rebase as soon as either fix merges.

Remove "Found in review (GPT 5.6)" style tags, "an earlier revision"
narration and "this change exists to" scope notes from `#` comments in
src/kiro_crew/apps/builtins/ops_mission_control/. A history comment
that also carried a real reason keeps only the reason, stated as a
rule. Comments only: every touched file has the same AST as its base.
Secrets, policy-store, Slack redaction, Datadog credential and action
authorization files are left for their own reviewed pass.
@iamwhatever
iamwhatever force-pushed the chore/src-comments-ops-mission-control branch from 5feb5d2 to c455772 Compare October 27, 2026 01:18
@iamwhatever

iamwhatever commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto main 8a518e1 to pick up #24609 (5c11e4d), the fix for the Windows (6) red (#24612). New head c455772, same patch (astcheck against the merge base: 17 files, 0 code changed; comment-history and brand gates pass).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 27, 2026 03:05

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: chore (17 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits in the ops_mission_control backend; no code line changes.

@KiroCrewCaptain
KiroCrewCaptain merged commit be396c0 into main Oct 27, 2026
108 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the chore/src-comments-ops-mission-control branch October 27, 2026 03:08
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants