Skip to content

test(crew-log): drop three stale strict xfails on full-scan guards - #24485

Merged
iamwhatever merged 1 commit into
mainfrom
fix/drop-stale-cold-prime-xfail
Oct 26, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/drop-stale-cold-prime-xfail

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Turn main's Backend Tests (3.12, 2) and Windows (2) shards green again by dropping three strict xfail markers whose fixes have merged.

Closes #24484

test/test_crew_log_fullscan_guard.py marks each full-scan guard xfail(strict=True) until its fix lands. Three fixes have landed, so those guards now pass and strict mode reports each pass as XPASS(strict), failing the shard on every PR based on main (seen on #24468):

guard fixed by
test_a_cold_prime_copies_the_fold_state_a_fixed_number_of_times #24261 (merged)
test_a_ws_connect_does_not_fold_every_open_slot #24268 (merged)
test_a_ws_reconnect_with_nothing_new_reads_a_fixed_number_of_entries #24268 (merged)

Why it matters

Every PR on current main is red on those two shards, and the Coverage Gate and PR Readiness follow, for a reason none of them caused.

Not a goal

  • No product code change.
  • The nine markers whose fixes are still open stay as they are.
  • No change to any guard's assertions.

What changed (motivation → approach → change)

The three @pytest.mark.xfail(strict=True, ...) decorators above are deleted; each test body is unchanged, so the guard now runs as an ordinary test and fails if the full scan comes back. Same shape as #24467, which dropped the first-history-page marker.

Backwards compatibility

Compatible: test-only change.

Removes nothing: three xfail markers on tests whose fixes merged; the tests themselves stay and now enforce their guard.

Tests

Proof: not provable -- test-only change

On current main (279c84f), pytest test/test_crew_log_fullscan_guard.py:

  • before: 2 failed (XPASS(strict) on the two WS guards), 3 passed, 9 xfailed; CI also showed the cold-prime guard as XPASS(strict)
  • after: 5 passed, 9 xfailed, three runs in a row with -n 0, and once with -n 4 (xdist, a different order)
  • flake8, isort --check-only, black --check: clean. test_flake_pattern_ratchet.py: 60 passed.

Determinism: the changed tests count entries read and state copies through the file's meter fixture; they use no clock, sleep, port or randomness, and the diff adds no new test code.

Manual verification

N/A — test-only change, covered above.

Related Issues

Closes #24484. Same class as #24467.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

#24261 fixed the cold-prime state copies and #24268 fixed the WS
connect and reconnect full scans, so the three guards now pass and
their strict xfail markers fail the shard as XPASS(strict). Drop those
three markers; the nine whose fixes are still open stay.

Closes #24484
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 26, 2026 15:48
@iamwhatever
iamwhatever requested a review from buluoray October 26, 2026 15:48
@iamwhatever
iamwhatever enabled auto-merge (squash) October 26, 2026 15:49
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. The fixes behind these three markers have merged, and with the markers gone each guard runs as an ordinary test and enforces its bound.

[DESIGN-REVIEWED] 2b0ae14

Description read

[DESCRIPTION-READ] 6d34cac68caf7f25a64444b0361cb7173c7dea32b22b7f746e0911b4bbbe076e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2b0ae14

Verdict parsed from the review's SHA-scoped output markers for commit 2b0ae149addf2281c4e32c76a44c216b8d8dbb47.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2b0ae14

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2b0ae149addf2281c4e32c76a44c216b8d8dbb47 false-positive: <reason, 20 to 500 characters>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 2b0ae14. This fixes the red on main: #24261 (merged 15:05Z) and #24268 (merged 15:29Z) made three strict xfails in test/test_crew_log_fullscan_guard.py pass, so main's Backend Tests (3.12, 2) and Windows (2) fail on XPASS(strict) for test_a_cold_prime_copies_the_fold_state_a_fixed_number_of_times. The diff only removes those three markers and keeps every assertion. Locally at this head the file runs 5 passed, 9 xfailed, 0 failed. #24482 carries the identical diff.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at head 2b0ae14: looks good to ship.

The diff deletes exactly three xfail(strict=True) decorators in test/test_crew_log_fullscan_guard.py and leaves every test body unchanged. The guarded fixes (#24261 and #24268) are in this branch's base, and Backend Tests shard 2 on Linux and Windows, the shards red on main, is green here. #24482 carries the identical diff; this one is preferred because it closes #24484.

Not approving yet: Backend Tests shards 7 and 8 lost their self-hosted runner mid-run (no test failure in either log), so the readiness check has not passed on this head. The failed jobs were rerun once. Approval and auto-merge remain once readiness passes.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever merged commit 8f18fd5 into main Oct 26, 2026
156 of 159 checks passed
@iamwhatever
iamwhatever deleted the fix/drop-stale-cold-prime-xfail branch October 26, 2026 17:57
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main red: three strict xfails in test_crew_log_fullscan_guard.py now pass after #24261 and #24268

3 participants