Skip to content

test(crew-log): drop strict xfails the merged full-scan fixes now pass - #24482

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/fullscan-guard-drop-xpass-markers
Oct 26, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/fullscan-guard-drop-xpass-markers

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Main's full-scan guard suite passes again, with each guard that now passes enforced as a plain test.

Three xfail(strict=True) markers in test/test_crew_log_fullscan_guard.py now XPASS on main, so the file fails with 3 errors. The paths those markers guard were fixed by merged PRs:

Test Fixed by
test_a_cold_prime_copies_the_fold_state_a_fixed_number_of_times #24261
test_a_ws_connect_does_not_fold_every_open_slot #24268
test_a_ws_reconnect_with_nothing_new_reads_a_fixed_number_of_entries #24268

Why it matters

Every PR whose CI runs this file goes red on a failure it did not cause, and the three fixed paths are not yet guarded against regressing.

Not a goal

  • Changing any test body or any production code.
  • Dropping markers of guards that still fail on main (for example test_a_warm_baseline_does_not_list_the_crew_log_root, which still XFAILs).

What changed

Symptom: strict XPASS failures on main. Cause: the guarded paths were fixed while the markers stayed. Change: remove exactly the three @pytest.mark.xfail(...) decorators on the tests listed above. The other nine markers stay.

Backwards compatibility

Compatible: test-only change; no runtime code is touched.

Removes nothing: only test decorators are removed, which turns three expected failures into enforced passes.

Tests

KIROCREW_PORT=1 pytest test/test_crew_log_fullscan_guard.py -n 2 -rxX -p no:cacheprovider
  • main: 3 failed (XPASS strict), 2 passed, 9 xfailed
  • this branch: 5 passed, 9 xfailed

Proof: not provable -- test-only change

Manual verification

N/A -- the change is three test decorators, covered by running the file above.

Related Issues

Refs #24265

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

The cold-prime copy guard and the two WS connect/reconnect guards now
pass on main, so their strict xfail markers fail the suite. Drop exactly
those three markers; every guard that still fails keeps its marker.
@chenmingwei23
chenmingwei23 requested review from a team and KiroCrewCaptain as code owners October 26, 2026 15:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. The PR removes three strict-xfail markers that now XPASS because their merged fixes landed, so these tests move from expected-failure to enforced.

[DESIGN-REVIEWED] 648e4a2

Description read

[DESCRIPTION-READ] c0fb725ea6572f8f3f8d6a9bde0826c85cebe25c2bad072fdc37d8afdc279dbb

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 648e4a2

Verdict parsed from the review's SHA-scoped output markers for commit 648e4a2144d57aaf13082fcc98fbdbfa64d4d849.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 648e4a2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 648e4a2144d57aaf13082fcc98fbdbfa64d4d849 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. This change is identical, line for line, to #24485, which drops the same three strict xfail decorators in test/test_crew_log_fullscan_guard.py and also closes the tracking issue #24484. Both diffs remove the same 18 lines and nothing else.

I am moving forward with #24485 because it already has a maintainer approval and its Backend Tests shard 2 (Linux and Windows) is green at its head. Once it merges, this branch will have nothing left to add, so it can be closed at your discretion. I am leaving it open for you to decide.

Checked at head 648e4a2: the diff is the same as #24485; PR Hygiene on this head is red from the description check, which reran on an earlier description.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 26, 2026 18:02

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that removes three strict xfail markers in test/test_crew_log_fullscan_guard.py whose guarded paths now pass; no test body or runtime code changes.

@KiroCrewCaptain
KiroCrewCaptain merged commit d40b2c0 into main Oct 26, 2026
163 of 169 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/fullscan-guard-drop-xpass-markers branch October 26, 2026 18:05
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants