Repository navigation
test(crew-log): drop strict xfails the merged full-scan fixes now pass - #24482
Conversation
The cold-prime copy guard and the two WS connect/reconnect guards now pass on main, so their strict xfail markers fail the suite. Drop exactly those three markers; every guard that still fails keeps its marker.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. The PR removes three strict-xfail markers that now XPASS because their merged fixes landed, so these tests move from expected-failure to enforced. [DESIGN-REVIEWED] 648e4a2 Description read[DESCRIPTION-READ] c0fb725ea6572f8f3f8d6a9bde0826c85cebe25c2bad072fdc37d8afdc279dbb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. This change is identical, line for line, to #24485, which drops the same three strict xfail decorators in test/test_crew_log_fullscan_guard.py and also closes the tracking issue #24484. Both diffs remove the same 18 lines and nothing else.
I am moving forward with #24485 because it already has a maintainer approval and its Backend Tests shard 2 (Linux and Windows) is green at its head. Once it merges, this branch will have nothing left to add, so it can be closed at your discretion. I am leaving it open for you to decide.
Checked at head 648e4a2: the diff is the same as #24485; PR Hygiene on this head is red from the description check, which reran on an earlier description.
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that removes three strict xfail markers in test/test_crew_log_fullscan_guard.py whose guarded paths now pass; no test body or runtime code changes.
Problem / Motivation
Goal: Main's full-scan guard suite passes again, with each guard that now passes enforced as a plain test.
Three
xfail(strict=True)markers intest/test_crew_log_fullscan_guard.pynow XPASS on main, so the file fails with 3 errors. The paths those markers guard were fixed by merged PRs:test_a_cold_prime_copies_the_fold_state_a_fixed_number_of_timestest_a_ws_connect_does_not_fold_every_open_slottest_a_ws_reconnect_with_nothing_new_reads_a_fixed_number_of_entriesWhy it matters
Every PR whose CI runs this file goes red on a failure it did not cause, and the three fixed paths are not yet guarded against regressing.
Not a goal
test_a_warm_baseline_does_not_list_the_crew_log_root, which still XFAILs).What changed
Symptom: strict XPASS failures on main. Cause: the guarded paths were fixed while the markers stayed. Change: remove exactly the three
@pytest.mark.xfail(...)decorators on the tests listed above. The other nine markers stay.Backwards compatibility
Compatible: test-only change; no runtime code is touched.
Removes nothing: only test decorators are removed, which turns three expected failures into enforced passes.
Tests
Proof: not provable -- test-only change
Manual verification
N/A -- the change is three test decorators, covered by running the file above.
Related Issues
Refs #24265
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.