Repository navigation
chore(apps): drop history and restating comments - #24642
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check: the change touches comments only and leaves no code, contract or user-visible surface different. [DESIGN-REVIEWED] c5b7c06 Description read[DESCRIPTION-READ] f58d65cffc5628e9a207d3e1fa2fbb864b23a63ec40bdd1b72c53a6290cb7d1a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Only comments change; every rewrite drops the review-round history and keeps the rule. Nothing ships that a user or the runtime would notice. What this change shipsInventory (5 items) — 5 justifiedIntent: make the app platform core's comments explain the rule rather than how the fix was reached. This is a FIX (comment hygiene).
[FIRST-PRINCIPLES-REVIEWED] c5b7c06 Description read[DESCRIPTION-READ] 7f01aea4f2df8c770919a6bdd9d2053d4bf317290c38dde972797d163602e9c6 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Rewrite five comments in src/kiro_crew/apps (outside builtins) that narrated review rounds or 'this change' so each states the rule it guards. Comments only; the AST of every touched file is unchanged.
a481f9b to
c5b7c06
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: chore (5 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits in five source files; no code line changes.
Problem / Motivation
Goal: Remove PR-history narration from
#comments in the app platform core (src/kiro_crew/apps/outsidebuiltins/), with no behaviour change, as part of the source-comment rollout piloted in #23966 (slack/).The builtin apps were cleaned in their own PRs; this is the app platform around them. Its comments narrate how the code was reached instead of the rule: "three review rounds found three different unbounded fields", "three reviewer findings were three exits from the same mistake", "four review rounds landed here", "this catch is what hid the KeyError above for four review rounds", "two opposite review findings about this exact line", "does not belong in this change". AGENTS.md and the worktree-dev skill say comments state current behaviour and the non-obvious why, with no review rounds or task log.
Why it matters
A count of review rounds tells a reader how long a fix took, not what the code guards, and "this change" stops meaning anything once the PR merges.
Not a goal
registry_pipeline/recovery.py,bridges_agents.pyandjob_sdk_returns.pystay).apps/builtins/, which had their own PRs.What changed (motivation → approach → change)
5 files touched. Only
#comment lines changed.Files:
plugin_import.py,registry_pipeline/checkout.py,registry_pipeline/install.py,routes_uninstall.py,teardown.py.Every rewrite states the rule, not its history. Before pushing I checked the added lines for anything over 100 columns and for leftover "this change", "this PR", "earlier revision", round, GPT, Opus or "before this feature" wording; there is none.
Examples, one per kind
1. Review-round count, kept as the rule (
plugin_import.py)2. "Earlier drafts" narration, kept as the invariant (
registry_pipeline/checkout.py)3. A bug's history, kept as the reason for the log level (
registry_pipeline/install.py)4. "This change" (
routes_uninstall.py)What was kept, and why
teardown.py: the two opposed risks (a) and (b) and the reason (b) wins stay word for word; only "two opposite review findings" became "two opposite risks".keep_data, notification kinds and config writers inroutes_registry.py,routes_art.py,routes_uninstall.py,routes_enable.pyandupdate_notify.py: old data the code still reads.registry_pipeline/install_*.py: the moved-aside checkout, a runtime object.Skipped security files
None in this package carried a history comment.
dashboard/chat_tag_grants.pyandskills_body_reads.pystill do and stay out of scope (grants and sensitive body reads).Backwards compatibility
Compatible: only comments change; every touched file has the same AST as its base.
Removes nothing: no code, key, record, validator or public function changes.
Tests
Proof: not provable -- copy-only change
AST-identical proof.
goal_scan.py astcheck <merge-base>comparesast.dump(ast.parse(src))for every.pyfile changed against the merge base (96c4fef57c); docstring-only differences would be reported separately and there are none:Gates on the touched files:
flake8,isort --check-only: cleanblack:scripts/check_black_formatting.pypasses (teardown.pyis on the existing baseline)mypy:Success: no issues found in 5 source filescheck_comment_history.pyandcheck_brand_name.py: passtest_plugin_import*,*checkout*,*teardown*,*uninstall*;KIROCREW_PROFILE=standalone pytest -n 4): 557 passedManual verification
N/A — comment-only change; the AST check proves the compiled code is unchanged.
Related Issues
None.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.