Repository navigation
feat(security): let the owner download flagged files directly - #24792
Conversation
Sensitive Change ReviewSensitive files changed:
|
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: this PR only removes things (the Flagged-file delivery card and rail row, and the large-file confirm). It adds no control and no new copy, so there is no new surface to check. [UX-REVIEWED] 900c901 Description read[DESCRIPTION-READ] 52fdb533b1dd8c447bae4d63300230242965ffcbca46479c80186dd429c6abfb That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshot of the Security settings rail without the "Flagged-file delivery" row, and of the dashboard Download for a file over 50 MB with no confirm dialog. The design itself holds up: the Slack and channel upload legs still scan in BlockersNo rendered evidence for the Security panel and Download flow this PR changes Notes
[DESIGN-REVIEWED] 900c901 Description read[DESCRIPTION-READ] 33800304da45a424fa75e6a211c83101e0eb9cb186992af00ab0dc08106e707a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
db41254 to
bcbd6b6
Compare
|
|
|
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: This change only loosens the gates. It removes the TIGHTENING: No mechanism gets stricter. The closest thing is the outbox download content scan, which is kept but now applies only to non-owners. The ONE threat it refuses is a Slack allow-listed non-owner pulling a flagged file through ADJUDICATED: 14 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: Rows go to three legs:
The diff adds no new assumption about paths, separators or interpreters in the shell tier. Its only path-shaped edits are leaf names removed from the sandbox and sensitive-leaf lists, and the posix and windows rows above cover both spellings of the data-home path. UNADJUDICATED: The outbox download content gate is the only refusal still in place in the touched area, and no classifier verdict is possible for it. The only change to its admission is the new owner check,
The file-viewer [SCOPE-REVIEWED] 900c901 |
bcbd6b6 to
de3c0d9
Compare
|
AI-review override not recorded: |
Human judgment recorded@bolichen97 recorded a false-positive release (class
This decision applies only to this commit. A new push requires a new judgment. |
Sensitive change reviewHead: de3c0d9
|
de3c0d9 to
1a5b9b8
Compare
Sensitive change reviewHead: 3ae9094
|
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Remove the Settings > Security "Flagged-file delivery" consent and all of its code: the consent store and nonce leaf, the dashboard consent routes, the host CLI approve step, its sandbox leaves and its denied-command floor, and the SPA panel. The owner's own delivery surfaces no longer scan file content: file_send, the outbox notify card, an owner's outbox download and the owner-only file download. Large downloads stream with no confirm step. The Slack and channel upload legs, file-stream and a non-owner's outbox download keep their content scan. Closes #24789
3ae9094 to
900c901
Compare
|
/ai-review override first-principles 900c901 owner-decision: agent: maintainer decision recorded at #24792 (comment) (#24789); third-party legs keep scanning; override authorized by bolichen97 |
|
/ai-review override fable 900c901 owner-decision: agent: maintainer decision recorded at #24792 (comment) (#24789); third-party legs keep scanning; override authorized by bolichen97 |
|
/ai-review override gpt 900c901 owner-decision: agent: maintainer decision recorded at #24792 (comment) (#24789); third-party legs keep scanning; override authorized by bolichen97 |
|
/ai-review override scope 900c901 owner-decision: agent: maintainer decision recorded at #24792 (comment) (#24789); third-party legs keep scanning; override authorized by bolichen97 |
Sensitive change reviewHead: 900c901
|
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: The owner downloads their own files directly, with no content check and no consent setting.
Today a file the credential scanner flags is refused on every owner surface:
file_send, the outbox card, the outbox download and the dashboard Download. A VPN key or.envthe agent made for the owner cannot reach them. The only way past it is Settings > Security > Flagged-file delivery, which arms a request and needs a host-only CLI step. Files over 50 MB also stop on a "download unscanned?" confirm.Why it matters
The owner is asking for a file that is already on their own disk. Blocking it, or making them grant consent through two steps, gets in the way and protects nothing.
Not a goal
/api/file-streamor the scanner itself.What changed (motivation → approach → change)
The owner's own delivery surfaces stop reading file content.
file_send,POST /api/outbox/notify, an owner'sGET /api/outbox/{filename}and the owner-onlyGET /api/file-downloadhand the bytes over as-is. The binary MIME allowlist and the filename check stay. A file over 50 MB streams straight away, with no 409 and no confirm.With nothing left to consent to, the Flagged-file delivery setting goes, with all of its code: the consent store, the dashboard routes, the host CLI step, the sandbox leaves, the denied-command floor and the Security panel card. The confirm dialog for big files goes too. The dashboard Download still fetches small files so a failed answer shows "Download failed", and hands files over 50 MB to the browser so they are never held in page memory.
file_send, outbox card/api/file-download(owner-only)/api/file-streamsrc/kiro_crew/mcp_tools(messaging.py),src/kiro_crew/dashboard(file_api/outbox.py,file_api/transfer.py,handlers/files.py)src/kiro_crew/file_delivery_consent.py,dashboard/handlers/file_delivery_consent.py,dashboard/routes/system.py,dashboard/server_internal_paths.pysrc/kiro_crew/cli.py,cli_help.py,cli_parser_admin.py,cli_server.pyfile-deliverycommand deletedsrc/kiro_crew/security(deny_gate.py,argv_floor*.py,denied_rules_*.py,vocabulary.py,paths_lists.py),sandbox_leaves.py,sandbox_precreate.pysrc/kiro_crew/config(loader_locations.py)src/kiro_crew/platform(context.py),src/kiro_crew/aws_consent.py,ssh_auth_sock_consent.py,security_posture.py,security_posture_sinks_delivery.pysrc/kiro_crew/docs(ui-index.generated.json),kirocrew-commands/SKILL.mdwebsite/src/pages/settings,website/src/api,website/src/i18nwebsite/src/utils/fileReadUrl.ts,website/src/App.tsx,website/src/components(FileDownloadLink.tsx,UnscannedDownloadConfirmHost.tsx),website/src/pierre(PierreWorkspaceTreeImpl.tsx)website/src/test,test/docs/,error-code-baseline.jsonBackwards compatibility
Breaking:
kirocrew file-delivery approve, the/api/file-delivery/consent*routes and theconfirm_unscanned/ 409large_file_unscanneddownload step are removed. Writer sweep on origin/main @ 6b1b65d: the only callers were the SPA Security panel, the SPA download helper and thekirocrew-commandsskill table, all changed here. A stalefile_delivery_consent.jsonleft on disk is no longer read by anything.Reader: website/src/pages/settings/SecurityPanelApprovals.tsx:FileDeliveryConsentCard -- crew page -- removed with the routes it read
Reader: website/src/utils/fileReadUrl.ts:downloadFileToDisk -- chat -- no longer sends
confirm_unscanned;website/src/utils/fileReadUrl.download.test.tsReader: src/kiro_crew/builtin_skills/kirocrew-commands/SKILL.md -- chat -- the
file-delivery approverow is removedReader: src/kiro_crew/sandbox_leaves.py -- subagent -- the consent leaves leave the masks with the files they guarded;
test/test_sandbox_governance_mask.pyTests
test/test_outbox_binary.py: notify delivers flagged text, media and wide-encoded files; the outbox download serves flagged bytes to the owner and still refuses a non-owner.test/test_file_download.py: flagged text, keys, wide keys and credential-bearing binary download whole; big files stream with no confirm; a non-owner is still stopped at the front gate.test/test_mcp_core_coverage.py:file_sendputs a flagged file in the outbox.website/src/utils/fileReadUrl.download.test.ts: small files save from the fetch, big files go to the browser download, failures report "Download failed".test_dashboard_files_composition_contract.py,error-code-baseline.json) are updated.Proof: not provable -- other: removal of a feature; the new tests assert the removed refusals are gone
Manual verification
N/A -- unit coverage sufficient: every changed route has handler tests on both the owner and non-owner path.
Screenshots / video
The Security settings rail no longer has a "Flagged-file delivery" row.
Related Issues
Closes #24789
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)