Repository navigation
fix(crew-mode): a crew member's tool approval alerts the person, pointed at its conductor - #25847
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the old mute pin is reversed openly through a new maintainer decision entry rather than treated as a gap, and the screenshots cover the changed row and note. Notes
[DESIGN-REVIEWED] c87441d Description read[DESCRIPTION-READ] 3f75fed26da38899de1730350ce1f4db78a623a045c7abeb2c517b6a8b413bca That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item is a fix for the defect in #25810. It reuses the existing What this change shipsInventory (7 items) — 7 justifiedIntent: when a Crew member is blocked on a tool approval, the person finds out even if they are in another chat or away from the window. FIX.
[FIRST-PRINCIPLES-REVIEWED] c87441d Description read[DESCRIPTION-READ] e4f9cf397d76d880cdc3c399063e1b99331cfbc713a01f3e5b09b4abc17faec1 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS The blind reader read every primary control correctly: the banner, "Approval needed · 1" and "Go to Chat". The screenshots show all of them. Notes
[UX-REVIEWED] c87441d Description read[DESCRIPTION-READ] fa33fccf5e372d7aa94d580543057ea3d5f2fd2573c2c5982cedec9ea7cad687 That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
5c8948c to
7944c6d
Compare
|
self-added: yes
|
7944c6d to
8772291
Compare
840f371 to
bc71d32
Compare
bc71d32 to
27c24d3
Compare
|
self-added: yes
|
27c24d3 to
a761ad3
Compare
|
self-added: yes
|
|
self-added: no
|
a41ab5c to
fd39f29
Compare
|
self-added: yes
|
fd39f29 to
001ca1e
Compare
…ted at its conductor
001ca1e to
c87441d
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head, UX skipped or pass, no conflict, no open change request.
Problem / Motivation
Goal: A Crew member's tool approval tells the person, even when they are in another chat or away from the window.
While its Crew chat (the conductor) is open, a Crew member's tool approval made no chime, no unread mark, no bell note, no banner and no OS toast. The person's session list leaves the Crew member's row out, and the Crew chat's row only reads its own approval, so a running Crew chat showed "Thinking…" while its Crew member waited. Nobody was told.
Why it matters
A Crew member that waits on an approval has stopped. Every Crew Mode user who switches chats or leaves the window can leave work blocked with no sign of it, and the approval card in the Crew chat only helps once someone opens it.
Not a goal
What changed (motivation → approach → change)
Root cause: two early returns muted a Crew member's approval everywhere while its Crew chat was open (
approvals.tson the live frame and on reconnect,chatStream.tson the native permission row). The server keeps the wait on the Crew member's own row, which the list hides.The note offers no Approve or Reject: opening it shows "Go to Chat", which opens the Crew chat and its approval card. The banner stays quiet while the Crew chat is on screen (
targetsCurrentView). With the Crew chat closed, nothing changes: the Crew member alerts like any chat.Both of the review's options are here. The bell note alone cannot mark the row: a native permission row makes no bell note for any chat, so the Crew chat's row (
SessionRow.tsx, counted by the existingcrewWaitingApprovals) shows the wait whenever work or status would hide the crew summary; a decision the Crew chat itself owes keeps the line. The rule is recorded indocs/decisions/2026-10-29-crew-member-approvals-notify.md, and thecrew-mode.mdspec line that described the mute now describes this.Backwards compatibility
Compatible: the
Notificationtype (types/index.chat.ts) gains one optional client-made field,crew_member; every other note and chat behaves as before.Removes nothing: the mute removed here was a quiet path, not a capability; every surface it skipped now runs.
Tests
crewMemberApprovalNotify.test.ts: with the Crew chat open but another chat on screen, a Crew member's approval frame chimes, adds a bell note pointed at the Crew chat under the Crew member's name, and banners; its native permission row chimes, posts an OS toast in its name and marks the Crew chat unread, and leaves the Crew chat read while it is on screen; opening the Crew chat relays a read that covers that prompt, so other windows clear its mark. Both cases fail onmain'sapprovals.ts,chatStream.tsandattention.ts, and pass with this change.crewMemberApprovalNotify.test.tsalso checks that a window showing the Crew chat relays the prompt as read, for both the native row and the approval frame.NotificationFeed.phase4.test.tsx: a Crew member's approval note shows no Approve or Reject.ChatSidebar.conductorLane.test.tsx: a running Crew chat's row says "Approval needed · 1" while a Crew member waits, and goes back to its running line when nothing waits.attention.crewWorker.test.ts,crewWorkerQuiet.test.ts: updated to the new rule.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
The built SPA was driven in Chromium with fixture data and a live
approvalframe over the dashboard socket, onmainand on this branch, in light and dark at DPR 1 and 2. Onmain: no banner, no bell note, the Crew chat's row says "Thinking…". Here: a "Rain haiku needs approval" banner, the row says "Approval needed · 1", and the note's detail shows "Go to Chat" with no Approve or Reject.Screenshots / video
Before (
main), light, DPR 1: no banner, row says "Thinking…".After, light, DPR 1: banner named for the Crew member, row says "Approval needed · 1".
After, dark, DPR 1: the note opened, "Go to Chat" and no Approve or Reject.
Every variant
Related Issues
Closes #25810
Follow-up to #24860.
Sibling sweep
Swept: git grep -nE "crew_root|isCrewWorkerSlot|crewWorkerRoot" -- website/src/hooks website/src/components/notifications
Sibling: website/src/hooks/websocket/turnCompletion.ts -- not affected -- a finished Crew member turn stays quiet by design; a paused or errored turn already sounds
Pattern harvest
Not generalizable: the mute was one rule written in two hooks for one feature; both sites are removed here.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)