Repository navigation
fix(mcp): heal a saved absolute Windows command's PATHEXT extension - #25945
Conversation
7fcfade to
5b47e91
Compare
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Linked issue #25927 supports the fix, and it repairs the persisted spelling at all three resolvers that accept an absolute command verbatim. What this change shipsInventory (6 items) — 6 justifiedIntent: on Windows, an MCP server whose saved command ends in an upper-case
[FIRST-PRINCIPLES-REVIEWED] c9ba33f Description read[DESCRIPTION-READ] 8113957db01a3e411400c337208b0b0c8dabf7bf8ee46791c5f31c824419bef4 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the fix applies the existing casing repair, narrowed to an extension-only difference, at all three resolvers. The provenance record heals with the command. Windows CI runs on this diff because the added tests patch Notes
[DESIGN-REVIEWED] c9ba33f Description read[DESCRIPTION-READ] 1613b9cfa191ade46645ca89782b52f21c9d03f7920b021f93cc3426899eecbb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
5b47e91 to
db0fb13
Compare
1ee397e to
880434c
Compare
|
self-added: yes
|
880434c to
c74601c
Compare
c74601c to
5bbde38
Compare
5bbde38 to
c9ba33f
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head, UX skipped or pass, no conflict, no open change request.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56)
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent. - fix(acp): remove a new KAS session's app launch snapshots at shutdown (#28954) (cherry picked from commit 1217a85) adapted: only this PR's launch_snapshots lines (request_identity is another PR's); 0.11.0's hoist_managed_servers name; the two test_runtime_bindings signature digests re-measured.
…28835) Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent. - fix(acp): remove a new KAS session's app launch snapshots at shutdown (#28954) (cherry picked from commit 1217a85) adapted: only this PR's launch_snapshots lines (request_identity is another PR's); 0.11.0's hoist_managed_servers name; the two test_runtime_bindings signature digests re-measured.
Problem / Motivation
Goal: On Windows, an MCP server whose saved command ends in an upper-case
.EXEstarts again on its own, without the user hand-editingkirocrew.json.Builds before v0.10.0 saved
shutil.whichresults such asC:\Users\<user>\tools\bin\demo-mcp.EXEas the server's absolutecommand. The file on disk isdemo-mcp.exe, and a tool manager's launcher shim picks its tool by its ownargv[0]name, case-sensitively, so it refuses to run. The dashboard probe fails three times, the server is quarantined and it vanishes from new chats. Upgrading Kiro Crew or reinstalling the tool does not help.Why it matters
Windows users lose every MCP server launched through such a shim that is also declared in
mcp.json. Nothing in the error points at casing, so users loop on approvals, restarts and reinstalls, and some give up on Kiro Crew.Not a goal
acp/launch.py's_normalize_exe_casingor the kiro-cli resolver.What changed (motivation → approach → change)
...\demo-mcp.EXE, file isdemo-mcp.exe.EXE, launcher refuses.exe...\DEMO-MCP.exe(operator's stem)Symptom: a stale
.EXEabsolute command never heals. Root cause: #15071 repaired casing only for commands resolved from a bare name, and all three MCP command resolvers accept an existing absolute command verbatim. So a spelling an older build saved looks operator-authored forever, unless the provenance record re-derives it, which it does not for a server also declared inmcp.json.Change: a new
saved_command_casinginsrc/kiro_crew/env.pywraps the existingresolved_command_casing. It keeps the repair only when the stem matches the directory entry exactly and the extension differs in case alone, the one spellingPATHEXTproduces. The three resolvers' absolute branches call it: the agent-config resolver (agent_parts/spec_rebuild.py), the dashboard probe (mcp_discovery_probe.py) and the gateway rewriter (mcp_gateway/rewriter_launch.py). Because the agent-config resolver persists its result, the next rebuild writes the healed spelling intokirocrew.json. When a provenance record is kept rather than refreshed (its bare source does not resolve, or another scope declares the command),agent_materialization/mcp_sources.pymoves the record'semittedvalue to the healed path when that is the value the oldemittedheals to, so a later rebuild still recognises the entry as Kiro Crew's and can rebind it.agent.py,mcp_discovery.pyandmcp_gateway/rewriter.pyserve the new name through their facades, anddocs/architecture/mcp.mdnames the exception.Backwards compatibility
Compatible: only a Windows absolute command whose extension differs from its file in case alone changes, and that spelling could not start under a case-sensitive launcher. Every other absolute command, POSIX path and bare command resolves as before.
Removes nothing: the diff adds one helper and three call sites; no key, record, path or validator is taken away.
Tests
TestSavedCommandCasingintest/test_mcp_command_casing_shared.py: a saved.EXEheals; a stem in different case, a stem and extension both differing, an exact match and a POSIX path are kept. The Windows directory is described throughos.scandir, so no verdict depends on the host filesystem.TestSavedCommandAtEachResolver: the agent-config resolver persists the healed spelling tokirocrew.json, the probe spawns it, and the rewriter emits it.TestHealedCommandKeepsItsProvenance: the kept record'semittedvalue follows the healed command, both when the bare source is unresolvable and when another scope declares the command.test/test_mcp_gateway_command_casing.py::test_resolution_preserves_platform_command_spelling: the Windows absolute case now expects the on-disk spelling.test/test_agent_parts.py: the facade import check reads a decorated owner function's unwrapped body, so a name read only insiderebuild_agent_configcounts as used.Negative control: with the three call sites reverted, the three new resolver tests and the rewriter's Windows absolute case fail; with the
mcp_sources.pychange reverted, the provenance test fails.Proof: PROVEN test/test_mcp_gateway_command_casing.py::test_resolution_preserves_platform_command_spelling[True-True] (head c9ba33f)
Also run:
test_mcp_gateway_rewriter_fingerprint.py,test_mcp_discovery_sync.py,test_campaign_facades_base_public_names.py,test_facade_mirror_guards.py(442 passed).scripts/local-gate.py's related set: 18,283 passed; its 26 failures (Copilot ACP launch, OTLP inventory) fail the same way on cleanorigin/mainon this host. black, isort, flake8, mypy clean.Manual verification
N/A — unit coverage sufficient: the Windows directory semantics are faked at
os.scandir, the one thing the helper reads, and each resolver is exercised end to end.Related Issues
Closes #25927
Sibling sweep
Swept: git grep -nE "isabs(.*) and os.path.isfile|os.path.isabs(.*command" -- src/
Sibling: src/kiro_crew/agent_parts/spec_rebuild.py:705 -- changed here
Sibling: src/kiro_crew/mcp_discovery_probe.py:401 -- changed here
Sibling: src/kiro_crew/mcp_gateway/rewriter_launch.py:210 -- changed here
Sibling: src/kiro_crew/acp/mcp_startable.py:69 -- not affected -- only checks the command exists, never chooses a spawn spelling
Sibling: src/kiro_crew/install_liveness.py:73 -- not affected -- only checks the respawn command exists and is executable
Sibling: src/kiro_crew/agent_parts/kirocrew_launcher.py:424 -- not affected -- resolves Kiro Crew's own launcher, outside the MCP resolvers
Pattern harvest
Not generalizable: the class is "a repair applied at resolve time never reaches values persisted before the repair existed", and its only instance here is this casing repair, now covered at every MCP resolver.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)