Repository navigation
feat(crew): search past workers in the Crew Mode Workers panel - #25948
chenmingwei23 merged 1 commit into
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the search runs on the client over the list the panel already reads, reuses [DESIGN-REVIEWED] 2c4b665 Description read[DESCRIPTION-READ] b09732b980d50135bb0bf5d678bbebc0990c3e41660f57e89a625a179a5cd677 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No blockers. The blind reader understood the search box and the clear button, and the screenshots cover every state the PR adds: at rest, English and CJK queries, no match, zh-CN and the light theme. Notes
[UX-REVIEWED] 2c4b665 Description read[DESCRIPTION-READ] 6ef265d800dc5640de3b05a8e0a93b81248bfa86739a2ef69e00004a72ca4e9c That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item removes the harm the Goal names. The only note is the unmeasured 6-worker threshold for showing the search box. Notes
What this change shipsInventory (8 items) — 7 justifiedIntent: find any past or live worker in a long Crew Mode Workers panel without scrolling through Done. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 2c4b665 Description read[DESCRIPTION-READ] 9e5a68c10ad24028cb4dc6711e1b3f6f8139277b5826b40a5ff8b8a08d42c353 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
dba8284 to
2c4b665
Compare
|
|
1f7870e
into
fix/crew-panel-collapse-finished
…in the Workers panel Finished workers fold under a Done toggle, closed by default, so live workers stay on top. From 6 workers up, a search box (the shared SearchFilterBar) filters live and finished workers by title or task line; matches inside a folded Done group show while the query is on, and clearing it restores the fold. Includes the search work from #25948. Closes #25857 Closes #25943
…in the Workers panel Finished workers fold under a Done toggle, closed by default, so live workers stay on top. From 6 workers up, a search box (the shared SearchFilterBar) filters live and finished workers by title or task line; matches inside a folded Done group show while the query is on, and clearing it restores the fold. Includes the search work from #25948. Closes #25857 Closes #25943
…in the Workers panel (kirodotdev#25876) Finished workers fold under a Done toggle, closed by default, so live workers stay on top. From 6 workers up, a search box (the shared SearchFilterBar) filters live and finished workers by title or task line; matches inside a folded Done group show while the query is on, and clearing it restores the fold. Includes the search work from kirodotdev#25948. Closes kirodotdev#25857 Closes kirodotdev#25943 Co-authored-by: Joe Guo <zejiangg@amazon.com>
Problem / Motivation
Goal: In a Crew Mode chat's Workers panel, a search box finds any worker, live or finished, by its title or task line.
A long Crew Mode session collects many finished workers. #25876 folds them under Done. Finding one past worker still means opening Done and scrolling through every card.
Why it matters
A conductor often goes back to a finished worker to read what it did or to reopen it. With dozens of workers, scrolling to find it is slow.
Not a goal
What changed (motivation → approach → change)
The list view of the Workers panel now has a labelled search box once the crew has 6 or more workers. It is the shared list search row,
SearchFilterBar, the same field the Sessions sidebar and the Crew Members roster use. A shorter list is easy to scan. As you type, cards are filtered by title or task line. Case is ignored, full-width letters match plain ones, and Chinese and other CJK text matches as typed. Live and finished workers are both searched. While a query is on, finished matches show under a plain Done heading even if Done is folded. The saved fold choice is never touched, so clearing the query folds Done back as it was. Once the list has been read, no match shows "No crew member matches “…”." It is not shown while the read is pending or failed, because finished workers are not loaded yet. Esc or the clear button empties the box. The query is kept per Crew Mode root for the browser tab, so opening a match does not wipe the search.website/src/lib/crewWorkers.tsaddssearchCrewWorkers(), beside thefinishedCrewWorkers()seam that #25876 left. Four new strings are in every catalog underwebsite/src/i18n/locales/, anden-XAis regenerated. A capture page shows the real component with a fixture list.Backwards compatibility
Compatible: under 6 workers the panel is unchanged; with more, the only addition is the search box above the same list.
Tests
CrewWorkerList.test.tsx, newCrewWorkerList searchblock:登录finds a finished worker titled修复登录页面, and已合并matches its task line)CREW_WORKER_SEARCH_MINsearchCrewWorkersfolds case and full-width forms; a blank query matches allDeterminism: the file passed 5 runs with
--sequence.shuffleand random seeds (34/34 each). No timers or clocks in the new tests.Local:
tsc -p tsconfig.app.json, eslint, lint:theme-colors, lint:phantom-classes, lint:restyle-ratchet and lint:i18n are green. Vitest for command-center, lib, components, theSearchFilterBarparity test and the other suites that mount the list passes (2590 tests), and the i18n suite passes (1039). Local GPT-contract and Opus reviews: PASS. Opus's one note, that the query was lost when a match was opened, is fixed in this commit. Round 2 fixes the CI findings: the field reusesSearchFilterBar, query storage usessafeStorage, and the empty-result line waits for the full list.Manual verification
I loaded
website/capture/crew-worker-search.htmlin Chromium through Playwright. I checked the empty box at rest, an English query, a CJK query and a query with no match, pressed Esc, and checked the light theme and zh-CN.Screenshots / video
Screenshots are attached below: the box empty at rest with Done folded, English query, CJK query, no match, zh-CN, and the light theme.
Related Issues
Closes #25943
Stacked on #25876 (base
fix/crew-panel-collapse-finished). It will be rebased ontomainonce #25876 merges.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)