Repository navigation
feat(crew): fold finished workers under a collapsible Done group in the Workers panel - #25876
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: this is a reversible, frontend-only fold and filter over the list the panel already reads, and 11 rendered screenshots were provided. [DESIGN-REVIEWED] 7c116eb Description read[DESCRIPTION-READ] d9334624d227ea60399c9004236a9cac266c8413b31e9ebf37d3cd11c3cfc46a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item traces to the two linked issues (#25857, #25943), and no item copies an existing mechanism: the search row reuses Notes
What this change shipsInventory (10 items) — 9 justifiedIntent: let a conductor keep live workers in view and still find any past worker. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 7c116eb Description read[DESCRIPTION-READ] 283a2c890af61705395bd04865a5aead8ad46c5f2af75bab473b25a5a7df0be3 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader identified the Done toggle, the search box and the clear button correctly, said they were sure what each does, and would use them. Notes
[UX-REVIEWED] 7c116eb Description read[DESCRIPTION-READ] a33d9f3ff95186011763856474f50bde7315ebd79fcd388a0c556cba72a116a6 That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approving at 509c6c2. Keeping live workers on top while a long run piles up finished ones is a good trade, and the fold keeps the on-screen finished worker visible and marked current, which is the case most likely to confuse.
Docs gap (spec + feature map) is tracked in #25976 rather than holding this.
Please also fix before merge if you can: five of the six screenshots in the description point at website/temp-screenshots/..., which is gitignored and not in the diff, so they do not render.
Owner question, not blocking: at the end of a run, when every worker is finished, the panel opens to a single "Done · N" heading and needs one more click to see results. Starting open when there is no live group may read better. The open/closed choice is also shared across every Crew Mode chat in the browser; say so if it is meant to be per chat.
Optional: aria-controls on the toggle pointing at the list. Heads-up: #25888 also edits CrewWorkerList.tsx; whichever lands second merges the two lucide-react imports.
Checked: CI green on this head. Locally the worker-list and timeline tests pass (48), and making the folded group drop the on-screen worker turns "a folded Done group still shows the finished worker on screen" red.
1f7870e to
fd8b7f9
Compare
…in the Workers panel Finished workers fold under a Done toggle, closed by default, so live workers stay on top. From 6 workers up, a search box (the shared SearchFilterBar) filters live and finished workers by title or task line; matches inside a folded Done group show while the query is on, and clearing it restores the fold. Includes the search work from #25948. Closes #25857 Closes #25943
fd8b7f9 to
7c116eb
Compare
Problem / Motivation
Goal: In a Crew Mode chat's Workers panel, finished workers fold away under one Done toggle so the live workers stay in view, and a search box finds any worker, live or finished, by its title or task line.
Finished workers (ledger item closed or reported done, or tab closed) stayed in the Workers panel at full size under "Done". Over a long session that group grows long and pushes the live workers out of view. Once they are folded away, finding one past worker means opening Done and scrolling through every card.
Why it matters
A conductor with many finished workers has to scroll past them to find the ones that need attention. A conductor also often goes back to one finished worker to read what it did or to reopen it.
Not a goal
groupfield stays the source).What changed (motivation → approach → change)
The panel already groups workers by the gateway's
groupfield, with finished ones indone. The Done heading is now a button witharia-expanded. It starts shut, and the choice is kept per browser withusePersistedBool. The live groups stay on top. A shut Done group still shows the worker on screen, marked current. A finished worker still opens, or reopens from its transcript.From 6 workers up (
CREW_WORKER_SEARCH_MIN), the list view has a labelled search box. It is the shared list search row,SearchFilterBar. Typing filters cards by title or task line (searchCrewWorkers()inwebsite/src/lib/crewWorkers.ts). Case is ignored, full-width letters match plain ones, and CJK text matches as typed. While a query is on, finished matches show under a plain Done heading even when Done is folded. The saved fold choice is not written, so clearing the query folds Done back. Once the list is read, no match shows a line that says so. Esc or the clear button empties the box. The query is kept per Crew Mode root for the browser tab (safeStorage), so opening a match does not wipe it.Four new strings are in every catalog under
website/src/i18n/locales/, anden-XAis regenerated:commandCenter.workers_search_label,workers_search_placeholder,workers_search_clear,workers_search_empty. Two capture pages show the real component with a fixture list.This PR now holds #25948 (merged into this branch), rebased on
mainand squashed to one commit.Backwards compatibility
Compatible: the list renders the same rows; the Done group starts shut and one click shows it. Under 6 workers there is no search box.
Removes nothing: every finished worker is still listed and still opens.
Tests
CrewWorkerList.test.tsx:donejoins the folded countsearchCrewWorkersfolds case and full-width formsCrewTimeline.test.tsxopens the Done group before clicking a finished worker and clears the fold key inafterEach.Determinism:
CrewWorkerList.test.tsxpassed 5 shuffled runs with random seeds. No timers or clocks in the new tests.Local, on the rebased tree:
tsc -p tsconfig.app.json, eslint, lint:theme-colors, lint:phantom-classes, lint:restyle-ratchet and lint:i18n are green. Vitest for command-center, lib, components/crew, theSearchFilterBartests, the Crew Mode page suites and i18n passes (1930 tests).Manual verification
I loaded
website/capture/crew-finished-fold.htmlandwebsite/capture/crew-worker-search.htmlin Chromium. I checked dark and light, folded and open, a finished worker on screen, the empty search box, English, CJK and no-match queries, Esc, and zh-CN.Screenshots / video
Fold: folded (dark), open (dark), a finished worker on screen while folded, light, zh-CN.
Search: empty box at rest, English query, CJK query, no match, zh-CN, light.
Related Issues
Closes #25857
Closes #25943
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)