Repository navigation
fix(chat): open a Crew Mode chat's side panel on the Crew tab - #25936
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this fixes the cause (the order of two effects on one strip), reuses the strip's stored focus history instead of adding a store, and the rendered before/after evidence is attached. Notes
[DESIGN-REVIEWED] aac36cd Description read[DESCRIPTION-READ] aa937b68319ee1a588f49775ba76a8223a99e726d89f0f5a92294c606a1cefa8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The diff adds no controls or copy; it only changes which existing tab opens by default. The before and after screenshots show Crew selected for a Crew Mode chat and Changes for a normal chat. Notes
[UX-REVIEWED] aac36cd Description read[DESCRIPTION-READ] f68c4df5d2067be038d8cf531831ccae965b3d1e4943c5a23461e362c78d3581 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The default this changes is recorded in What this change shipsInventory (7 items) — 7 justifiedIntent: let a Crew Mode user land on the Crew tab when they open the side panel, without clicking it on every visit. This is a FIX to the default focus, and it changes a default the RFC decided.
[FIRST-PRINCIPLES-REVIEWED] aac36cd Description read[DESCRIPTION-READ] 99c6e4db305c0eced1e25c4cd235d298ba2b8bc901e3d0046fcf475d4113cfce That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
The decision this PR needs is recorded in the RFC #26002 (amends Crew Mode UI rule U1). Once it merges, this PR is rebased onto main once and pushed once. |
6a18c58 to
aac36cd
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: frontend bug fix; a Crew Mode chat's side panel opens on the Crew tab until the user picks another, with tests.
Problem / Motivation
Goal: A Crew Mode chat's side panel opens on the Crew tab until the user picks another tab.
Opening the right side panel in a Crew Mode chat (a conductor root, or one of its worker views) lands on Changes. The Crew tab (workers and goal board) is on the strip, but the user has to click it every time.
Why it matters
The Crew tab is what a Crew Mode user opens the panel for. Landing on Changes costs a click on every visit and hides the workers the chat is about.
Not a goal
What changed (motivation → approach → change)
Root cause: when the panel mounts, the pinned-block reconcile writes Changes as the strip's focus first. The Crew Mode effect then adds Crew with
offerPanelView, which took focus only on a strip with no focus at all, so it never did.Fix:
offerPanelViewinwebsite/src/hooks/usePanelTabs.tsfocuses Crew when nobody has picked a tab. "Not picked" is read from what the strip already stores: no focus, or focus still on Changes with the focus history never having left it and no tab asked for in this page session (a PR chip that opens Changes counts as asked). Any other stored focus is kept, so a tab the user picks wins on every later open. The comment inwebsite/src/pages/chat/SidePanel.tsxsays the same.The decision is recorded in rfc-crew-panel-default-tab.md (
status: accepted, merged in #26002), which amends Crew Mode UI rule U1.Backwards compatibility
Compatible: the stored strip shape is unchanged; only which tab an unpicked Crew Mode strip focuses changes.
Removes nothing: no key, record, path or function is taken away.
Tests
Proof: not provable -- frontend test (prove.py runs Python only)
The three Crew-tab cases in
sidePanelCrewDefaultTab.test.tsxfail with theusePanelTabs.tschange reverted (checked locally).website/src/test/sidePanelCrewDefaultTab.test.tsx(new, renders the realSidePanel): a Crew Mode root opens on Crew; a Crew Mode worker view opens on Crew; a normal chat opens on Changes with no Crew tab; a tab the user clicks is kept when the panel opens again; switching Crew Mode → normal → Crew Mode → normal picks the right default each time.website/src/test/crewModeUiR1.test.tsx: the default Changes focus is taken, but Changes picked after another tab is kept; Changes asked for before the panel mounted (a PR chip) is kept.tsc -p tsconfig.app.jsonandeslintclean.Manual verification
Checked in a real browser (Chromium) against the real
SidePanelin an isolated capture page: the Crew Mode chat selects Crew, the normal chat selects Changes; with the fix reverted the Crew Mode chat selects Changes. Not run against a live gateway.Screenshots / video
Real
SidePanelin an isolated capture page (dark theme, 460px dock), with the slot list seeded with one Crew Mode root and one normal chat.Before: the Crew Mode chat opens on Changes. After: it opens on Crew; the normal chat opens on Changes in both.
Related Issues
Closes #25934
Sibling sweep
Swept: git grep -n "offerPanelView|activeId: b.activeId ?? " -- website/src/
Siblings: none -- offerPanelView has one caller (SidePanel's Crew Mode effect); other opens are explicit tab choices that already take focus.
Pattern harvest
Not generalizable: a one-off ordering between two effects on one strip; the fix reads stored focus history rather than effect order.
Checklist