Skip to content

docs(rfc): open a Crew Mode chat's side panel on the Crew tab - #26002

Merged
dodgeblaster merged 1 commit into
mainfrom
docs/rfc-crew-panel-default-tab
Oct 30, 2026
Merged

dodgeblaster merged 1 commit into
mainfrom
docs/rfc-crew-panel-default-tab

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the owner's decision that a Crew Mode chat's side panel opens on the Crew tab, amending Crew Mode UI rule U1.

#25936 makes a Crew Mode chat's panel open on Crew instead of Changes. Its First Principles lane blocks because U1 ("Workers is offered on a Crew Mode slot's strip without taking focus") is the recorded choice and nothing on main reverses it.

Why it matters

Without this record, #25936 cannot pass First Principles without an override, and Crew Mode users keep clicking Crew on every visit.

Not a goal

What changed (motivation → approach → change)

File Change
docs/request-for-change/rfc-crew-panel-default-tab.md new RFC, status: accepted
docs/request-for-change/README.md index row

The RFC amends U1. A Crew Mode root or worker view opens on Crew while nobody has picked a tab. A picked tab stays picked. Every other chat keeps Changes. It names the two known edge cases as risks.

Backwards compatibility

Compatible: docs only.

Removes nothing: no code, key or path changes.

Tests

Docs only. scripts/docs-lint.sh passes.

Manual verification

N/A — docs-only change.

Related Issues

Part of #25934
Refs #25936

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 30, 2026 00:04
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 30, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-crew-panel-default-tab branch from f9bff8c to d088c97 Compare October 30, 2026 00:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d088c97de9064b59ef20260f5f4518812533f750 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d088c97de9064b59ef20260f5f4518812533f750 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d088c97de9064b59ef20260f5f4518812533f750 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This PR only adds docs: an RFC and its index row. Nothing renders or is taken away. The amended default is implemented and gated in #25936.

Notes

  • The RFC already names the risk that, after a reload, a Changes tab opened from a PR chip looks the same as the default. Have fix(chat): open a Crew Mode chat's side panel on the Crew tab #25936 test that case so the "one click away" outcome is pinned instead of incidental.
  • Decision 2 makes "nobody has picked a tab" mean what the strip's focus history happens to contain. If that history's shape changes, this default changes with it. Name this coupling in the spec that owns usePanelTabs.ts.

[DESIGN-REVIEWED] d088c97

Description read

[DESCRIPTION-READ] 926c296afd4b2f573d090615541647134e6bfeec0e21e244939360383eb71f39

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d088c97de9064b59ef20260f5f4518812533f750 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d088c97

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d088c97de9064b59ef20260f5f4518812533f750 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d088c97de9064b59ef20260f5f4518812533f750 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d088c97

Verdict parsed from the review's SHA-scoped output markers for commit d088c97de9064b59ef20260f5f4518812533f750.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d088c97de9064b59ef20260f5f4518812533f750 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 30, 2026
@dodgeblaster
dodgeblaster merged commit d7785f2 into main Oct 30, 2026
93 checks passed
@dodgeblaster
dodgeblaster deleted the docs/rfc-crew-panel-default-tab branch October 30, 2026 04:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants