Skip to content

feat(crew): show the conductor's worker counts without opening the side panel - #25892

Closed
iamwhatever wants to merge 1 commit into
mainfrom
feat/crew-status-strip
Closed

iamwhatever wants to merge 1 commit into
mainfrom
feat/crew-status-strip

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In Crew Mode, the person sees how the conductor's workers are doing without opening the side panel.

Today the conductor chat says nothing about its workers while the side panel is closed. The person must open the panel to learn whether anything is working, done, or waiting on a tool approval only they can give.

Why it matters

A conductor runs several workers at once. The approval only the person can give is easy to miss when nothing on the chat shows it, and opening the panel to check is a step they repeat all day.

Not a goal

  • The worker view's breadcrumb or a "Back to conductor" banner (separate work).
  • A notice after a dispatch telling the person to open the side panel (separate work).
  • Any change to how a worker's state is decided, read or pushed.

What changed (motivation → approach → change)

A small strip (CrewStatusStrip, mounted in website/src/pages/chat/page/ComposerDockView.tsx) above the conductor's composer counts its workers by state: Approval needed, Working, Waiting on conductor, Waiting, Done. Approvals come first in their warning tone; the strip only counts them, since CrewApprovalCards beside it is where an approval is decided. Its end says "Crew ›", the side panel tab a press opens. A press closes the chat's find pane first, since that pane hides the panel.

It reads what the panel and the session row already read, useCrewWorkerSummary: the shared worker-list query merged with the live slot rows the socket keeps current. So it adds no request, no poll and no state of its own, and the counts match the panel's groups.

It is hidden while the conductor has no workers and while the side panel is on screen, so it never repeats the panel. A failed re-read is said under the counts with the existing notice. It sits in the composer stack, not the title row, so it stays on a phone, where the title row moves into the shell bar.

One new catalog string, components.crewMode.status_strip_open, in all 12 languages under website/src/i18n/locales/; en-XA regenerated.

Backwards compatibility

Compatible: a new, read-only element on conductor chats; other chats render as before.

Removes nothing: the diff only adds a component, one string and tests.

Tests

  • website/src/components/crew/CrewStatusStrip.test.tsx: counts match the worker list's states in panel order; the approval count comes first in the warning tone with no decision control, and the "Crew" label is on screen; a worker that changes state in the live slot rows changes the counts; nothing drawn with zero workers; click and Enter open the Workers tab; the find-pane close runs first; a failed re-read keeps the counts and adds the notice; a failed first read shows only the notice; accessible name and reduced-motion class.

  • website/src/test/ChatPage.crewMode.test.tsx: on a conductor chat the strip shows with the panel closed and goes away once a press opens the panel; it is absent with the panel open and with no workers; a plain chat shows no strip and reads no worker list.

  • website/src/test/ChatPage.statusStackLayering.test.tsx: the strip joins the composer status stack's pinned children and declares its own layer (z-[2], as the task and workflow bars do).

Absence checks wait for the read to settle first. Both files pass on repeat runs.

Manual verification

The strip was rendered alone in a local Vite page with a seeded worker list, in dark, light, Chinese and a 360px width (shots below). A full gateway run was not done.

Screenshots / video

Dark, 900px, one approval waiting:

dark

A re-read failed (last counts kept, notice under them), and the first read failed (notice only):

re-read failed

first read failed

Light, Chinese, 360px

light

zh-CN

360px

The strip is rendered alone in a local Vite page from a seeded list; the box under it stands in for the composer. The failure shots answer the worker-list route with a 500.

Related Issues

Closes #25870

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Rebased onto main a826987 (2026-10-30): the strip now uses crewModeRoot() and shows once the person closes the side panel that Ultra Mode opens on entry.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 29, 2026 19:02
@iamwhatever
iamwhatever requested a review from CrysisDeu October 29, 2026 19:02
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 70e8d8d7768b544f2ee00266f1513c40961d9508 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: it adds a read-only view of existing data (useCrewWorkerSummary), removes nothing, and the description includes rendered screenshots.

Notes

[DESIGN-REVIEWED] 70e8d8d

Description read

[DESCRIPTION-READ] bdc57b90e0c0a9c6a1f21067546fd6704581352c310960ae453441952877861a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 70e8d8d7768b544f2ee00266f1513c40961d9508 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The worker counts are new and back a real request (#25870). The approval chip repeats the CrewApprovalCards that already sit above the same composer, so the approval part of the stated harm is already handled.

Notes

  • Item 2 — duplicate of website/src/components/crew/CrewApprovalCards.tsx: the description says "The approval only the person can give is easy to miss when nothing on the chat shows it". But ComposerDockView.tsx:547 already renders {crewModeRoot(currentSlot) && activeSlot && <CrewApprovalCards root={activeSlot} />} on every conductor chat, whether the panel is open or not. Subtraction: drop the approval group from the strip's groupCrewWorkers output, so the strip counts only states nothing else on the chat shows.

What this change ships

Inventory (6 items) — 5 justified

Intent: let a Crew Mode user see how the conductor's workers are doing without opening the side panel. ADDITION.

  1. A strip above the conductor's composer counts workers by state (Working, Waiting on conductor, Waiting, Done) — justified
  2. An approval-count chip leads the strip in warning tone — duplicate of components/crew/CrewApprovalCards.tsx, shown on the same screen
  3. Pressing the strip opens the side panel on the Workers tab — justified
  4. A press closes the find pane first — justified
  5. The strip hides while the panel is showing or there are no workers; a failed re-read shows a notice — justified
  6. One new catalog string in 12 languages — justified

[FIRST-PRINCIPLES-REVIEWED] 70e8d8d

Description read

[DESCRIPTION-READ] 19f63630404571291efeab764b76a010c3618276cdc25093ffb2c82ead8e6445

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 70e8d8d7768b544f2ee00266f1513c40961d9508 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

No blocker: the blind reader read the strip correctly from shots 07–12 and would press it. The remaining risks are notes.

Notes

  • In CrewStatusStrip, "Waiting on conductor" (filled grey dot) and "Waiting" (empty circle) next to each other: the reader said "Waiting on what?" Give the plain waiting group label the thing it waits on, like the conductor label does.
  • In shot 11, the old counts sit above "Could not load the crew.", so "I would not trust the counts." When failed && groups.length > 0, mute the chips or label them as the last counts read.
  • The reader thought "Only 'Crew >' looks clickable" and missed that the whole strip is one button. Give the whole strip a resting hover cue, or make the "Crew ›" end look like a link instead of text-muted.

[UX-REVIEWED] 70e8d8d

Description read

[DESCRIPTION-READ] 7229d352b3c33f303434c69c941557bb88c2ce67de28f3db5beff09be8ec41ba

That sha256 names everything this verdict read: the PR description, plus the 24 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 70e8d8d7768b544f2ee00266f1513c40961d9508 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 70e8d8d

Verdict parsed from the review's SHA-scoped output markers for commit 70e8d8d7768b544f2ee00266f1513c40961d9508.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 70e8d8d7768b544f2ee00266f1513c40961d9508 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @iamwhatever overrides the GPT 6.1 finding for 70e8d8d7768b544f2ee00266f1513c40961d9508; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] 70e8d8d

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 70e8d8d7768b544f2ee00266f1513c40961d9508 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@iamwhatever
iamwhatever force-pushed the feat/crew-status-strip branch from 60da9bd to b8a9973 Compare October 29, 2026 19:28
@iamwhatever

Copy link
Copy Markdown
Contributor Author

target=first-principles span=c79a5d8e36ca disposition: fixed in b8a9973

The needsYou highlight is gone: no data-highlight, no pill, no color-mix background, no bold.
The approval group keeps only its group tone and first place, the same tone the side panel's Workers list gives it.
CrewApprovalCards stays the one place an approval is shown as something to decide; the strip only counts it, and a test asserts it has no decision control.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

target=ux span=fcc0394c799c disposition: fixed in b8a9973

The strip now ends with a visible "Crew ›" (the side panel tab a press opens, existing string commandCenter.workers), so it reads as a link.
The two failure states are now in the description's screenshots: a failed re-read (counts plus notice) and a failed first read (notice only).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 29, 2026
@iamwhatever
iamwhatever force-pushed the feat/crew-status-strip branch from b8a9973 to 35302a7 Compare October 29, 2026 20:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 29, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@iamwhatever
iamwhatever force-pushed the feat/crew-status-strip branch from 35302a7 to c778815 Compare October 29, 2026 23:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 29, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 30, 2026
buluoray
buluoray previously approved these changes Oct 30, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approving at c778815. The only gap is docs: crew-mode.md and the feature-map "Crew panel" row do not describe the new strip above a conductor's composer. That is folded into #25976 (already tracking the same gap for #25876 and #25888) rather than holding this.

The panel-open guard is pinned: removing it fails both "shows the conductor's worker counts above its composer while the side panel is closed, and opens it" and "shows no worker strip while the side panel is open, or with no workers". The strip adds no read of its own and no approve control.

Non-blocking, for you to decide:

  • On a 360 px screen the five chips wrap to three lines above the composer, and the Done chip keeps the strip on screen after every worker has finished. Consider leaving Done out of the strip (the panel already folds it) or one line on narrow screens.
  • A first read that fails on a conductor with no workers now shows the error above the composer. Consider showing the notice only once there are counts.
  • #25917 adds a second control that opens the same Crew tab; see the note there.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 30, 2026
@iamwhatever
iamwhatever force-pushed the feat/crew-status-strip branch from c778815 to 70e8d8d Compare October 30, 2026 17:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Security Scope Review -- 🔴 could not complete (fails closed)

No scope verdict for 70e8d8d7768b544f2ee00266f1513c40961d9508 (the candidate stage failed). This lane fails CLOSED: an unmeasured tightening must not read as "nothing newly refused". See the job logs, then re-run -- or record /ai-review override scope 70e8d8d7768b544f2ee00266f1513c40961d9508 <class>: <reason> if a human has judged the scope by hand.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 30, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 70e8d8d false-positive: finding targets AUTOSDE.yaml H17 and crewmate_harness.py, both already on main via #25798; this PR changes only website/ and temp-screenshots/.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever recorded a false-positive release (class false-positive) for the gpt AI finding on 70e8d8d7768b544f2ee00266f1513c40961d9508.

finding targets AUTOSDE.yaml H17 and crewmate_harness.py, both already on main via #25798; this PR changes only website/ and temp-screenshots/.

This decision applies only to this commit. A new push requires a new judgment.

@iamwhatever iamwhatever added enhancement New feature or request and removed enhancement New feature or request labels Oct 30, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 30, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Closing per owner decision. main already shows Crew Mode worker status on the conductor's sidebar row (CrewRootSummaryLine in website/src/pages/chat-sidebar/SessionRow.tsx, added in #25872 and refined in #26291), from the same worker list, and the Crew panel is already one click away. This strip would duplicate it. Same reason as #25917.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crew Mode: show the conductor's worker status without opening the side panel

2 participants