Repository navigation
feat(crew): show the conductor's worker counts without opening the side panel - #25892
iamwhatever wants to merge 1 commit into
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: it adds a read-only view of existing data ( Notes
[DESIGN-REVIEWED] 70e8d8d Description read[DESCRIPTION-READ] bdc57b90e0c0a9c6a1f21067546fd6704581352c310960ae453441952877861a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The worker counts are new and back a real request (#25870). The approval chip repeats the Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: let a Crew Mode user see how the conductor's workers are doing without opening the side panel. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 70e8d8d Description read[DESCRIPTION-READ] 19f63630404571291efeab764b76a010c3618276cdc25093ffb2c82ead8e6445 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No blocker: the blind reader read the strip correctly from shots 07–12 and would press it. The remaining risks are notes. Notes
[UX-REVIEWED] 70e8d8d Description read[DESCRIPTION-READ] 7229d352b3c33f303434c69c941557bb88c2ce67de28f3db5beff09be8ec41ba That sha256 names everything this verdict read: the PR description, plus the 24 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ human override acceptedHuman judgment by @iamwhatever overrides the GPT 6.1 finding for [GPT-OVERRIDE] 70e8d8d This comment is updated in place on each push. The model was not re-run because an authorized human decision supersedes it. False positive or not applicable? A repository writer can comment: |
60da9bd to
b8a9973
Compare
|
target=first-principles span=c79a5d8e36ca disposition: fixed in b8a9973
|
|
target=ux span=fcc0394c799c disposition: fixed in b8a9973
|
b8a9973 to
35302a7
Compare
35302a7 to
c778815
Compare
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approving at c778815. The only gap is docs: crew-mode.md and the feature-map "Crew panel" row do not describe the new strip above a conductor's composer. That is folded into #25976 (already tracking the same gap for #25876 and #25888) rather than holding this.
The panel-open guard is pinned: removing it fails both "shows the conductor's worker counts above its composer while the side panel is closed, and opens it" and "shows no worker strip while the side panel is open, or with no workers". The strip adds no read of its own and no approve control.
Non-blocking, for you to decide:
- On a 360 px screen the five chips wrap to three lines above the composer, and the Done chip keeps the strip on screen after every worker has finished. Consider leaving Done out of the strip (the panel already folds it) or one line on narrow screens.
- A first read that fails on a conductor with no workers now shows the error above the composer. Consider showing the notice only once there are counts.
- #25917 adds a second control that opens the same Crew tab; see the note there.
c778815 to
70e8d8d
Compare
Security Scope Review -- 🔴 could not complete (fails closed)No scope verdict for |
Human judgment recorded@iamwhatever recorded a false-positive release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Closing per owner decision. main already shows Crew Mode worker status on the conductor's sidebar row ( |
Problem / Motivation
Goal: In Crew Mode, the person sees how the conductor's workers are doing without opening the side panel.
Today the conductor chat says nothing about its workers while the side panel is closed. The person must open the panel to learn whether anything is working, done, or waiting on a tool approval only they can give.
Why it matters
A conductor runs several workers at once. The approval only the person can give is easy to miss when nothing on the chat shows it, and opening the panel to check is a step they repeat all day.
Not a goal
What changed (motivation → approach → change)
A small strip (
CrewStatusStrip, mounted inwebsite/src/pages/chat/page/ComposerDockView.tsx) above the conductor's composer counts its workers by state: Approval needed, Working, Waiting on conductor, Waiting, Done. Approvals come first in their warning tone; the strip only counts them, sinceCrewApprovalCardsbeside it is where an approval is decided. Its end says "Crew ›", the side panel tab a press opens. A press closes the chat's find pane first, since that pane hides the panel.It reads what the panel and the session row already read,
useCrewWorkerSummary: the shared worker-list query merged with the live slot rows the socket keeps current. So it adds no request, no poll and no state of its own, and the counts match the panel's groups.It is hidden while the conductor has no workers and while the side panel is on screen, so it never repeats the panel. A failed re-read is said under the counts with the existing notice. It sits in the composer stack, not the title row, so it stays on a phone, where the title row moves into the shell bar.
One new catalog string,
components.crewMode.status_strip_open, in all 12 languages underwebsite/src/i18n/locales/;en-XAregenerated.Backwards compatibility
Compatible: a new, read-only element on conductor chats; other chats render as before.
Removes nothing: the diff only adds a component, one string and tests.
Tests
website/src/components/crew/CrewStatusStrip.test.tsx: counts match the worker list's states in panel order; the approval count comes first in the warning tone with no decision control, and the "Crew" label is on screen; a worker that changes state in the live slot rows changes the counts; nothing drawn with zero workers; click and Enter open the Workers tab; the find-pane close runs first; a failed re-read keeps the counts and adds the notice; a failed first read shows only the notice; accessible name and reduced-motion class.website/src/test/ChatPage.crewMode.test.tsx: on a conductor chat the strip shows with the panel closed and goes away once a press opens the panel; it is absent with the panel open and with no workers; a plain chat shows no strip and reads no worker list.website/src/test/ChatPage.statusStackLayering.test.tsx: the strip joins the composer status stack's pinned children and declares its own layer (z-[2], as the task and workflow bars do).Absence checks wait for the read to settle first. Both files pass on repeat runs.
Manual verification
The strip was rendered alone in a local Vite page with a seeded worker list, in dark, light, Chinese and a 360px width (shots below). A full gateway run was not done.
Screenshots / video
Dark, 900px, one approval waiting:
A re-read failed (last counts kept, notice under them), and the first read failed (notice only):
Light, Chinese, 360px
The strip is rendered alone in a local Vite page from a seeded list; the box under it stands in for the composer. The failure shots answer the worker-list route with a 500.
Related Issues
Closes #25870
Checklist
Rebased onto main a826987 (2026-10-30): the strip now uses
crewModeRoot()and shows once the person closes the side panel that Ultra Mode opens on entry.