Repository navigation
fix(dashboard): return to the MCP Servers list as you left it - #25967
alparamonov wants to merge 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS No control is added or changed: the PR restores the sub-tab, filter and open tool lists, and screenshots 02–04 show each state. This lane has no blind read; a same-repo run would add one. [UX-REVIEWED] fa0771d Description read[DESCRIPTION-READ] c04eb900afd642c9b037d45133169d4dbae2199f4ed67a716faffc6122db1ad9 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (7 items) — 7 justifiedIntent: when someone goes from Customize to a chat and back, the MCP Servers list should be as they left it. This is a FIX (#25961).
[FIRST-PRINCIPLES-REVIEWED] fa0771d Description read[DESCRIPTION-READ] cf8e76a4d46fb0f2ecd93bf2f1e097cddce08c11383106cafddebea3d03d528f That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: this is browser-tab-only state, an explicit Notes
[DESIGN-REVIEWED] fa0771d Description read[DESCRIPTION-READ] 598254848a7aec7047f705289ad04fa6a5a78f73bd3425697d522f47b0a0963e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. None of the three candidates holds up as a defect. Each one describes behaviour the PR chose on purpose: its own tests pin the [OPUS-REVIEWED] fa0771d |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
The red checks on this head come from its base,
I'll rebase onto main once #25944 lands, so a single re-run clears all of them. |
2ace41f to
fa0771d
Compare
|
Hold for CI: two checks are red on this head because the runs hit GitHub's API rate limit, so they never checked the diff. Reviewed head: fa0771d.
Re-running the failed jobs of those two runs should clear this. The code itself looks sound: the sub-tab resumes from sessionStorage unless the URL names /connections resuming the last sub-tab describes the intended behaviour.
— crew-pr-reviewer (r136) |
|
[operator: bolichen97] Continuing this in #32347; thanks for the start. |
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
|
Thanks for this fix, @alparamonov. Closing because the same behavior has landed on main: #32347 (#32347, "fix(dashboard): return to the mcp servers list as you left it") merged and closed the linked issue #25961. If anything from this branch is still missing on main, please reopen with the gap and we will take another look. |
Problem / Motivation
Goal: Coming back to Customize from a chat reopens the MCP Servers list the way you left it.
Open Customize → Connections → MCP Servers, filter the list to one server and open its tool list. Click Sessions in the left pane, open a chat, then click Customize again. You land on the Services sub-tab, the filter is empty and every tool list is closed, so you click through to your server again.
Why it matters
Fixing or testing an MCP server is a back-and-forth: read the next step in a chat, check the server under Customize, go back to the chat. Every return costs the same three or four clicks to find the server again, on exactly the loop where you return most often.
Not a goal
view=mcp-serverslink opens.sessionStorage.What changed (motivation → approach → change)
You now come back to the MCP Servers list exactly as you left it, within the same browser tab.
The sidebar's Customize entry opens a bare
/capabilities.SidePanelLayoutalready remembers the Customize tab for that case, but the Connections sub-tab lived only in?view=, and the list's filter and open rows lived in component state, so all three reset.useConnectionsSubTabnow treatsview=mcp-serversas the one value that picks a sub-tab outright. Any other URL resumes the last sub-tab, including aviewthat a switch from another Customize tab carries over, such as Skills'budget, so that value cannot overwrite the memory. The URL is rewritten to name what is shown, re-written afterSidePanelLayout's own?tab=write in the same flush drops it, and every write keeps the history entry's state so the phone back bar still pops.McpTabkeeps its filter and open tool lists insessionStorage, the pattern the memories filter uses. The Connections row ofdocs/feature-map/README.mdnames both.Backwards compatibility
Compatible: a link with
view=mcp-serversopens MCP Servers as before. A URL with any otherview, or none, changes from always Services to the sub-tab last shown in that browser tab, which is Services in a fresh tab; no link in the codebase points at Services throughview.Removes nothing: no route, query param, export or stored key is removed; the change only adds two
sessionStoragekeys.Tests
website/src/test/ConnectionsPage.subTabUrl.test.tsx: a fresh tab opens Services; a return withoutviewreopens MCP Servers and writesview=mcp-serversback; a last pick of Services reopens Services; aviewthat names no Connections sub-tab resumes MCP Servers and leaves the memory intact. Four cases drive the realSidePanelLayout: a return through a bare/capabilitieslands on MCP Servers; clicking the sidebar entry while on Customize keeps it; picking Connections from Skills'?view=budgetkeeps MCP Servers; on a phone, resuming MCP Servers keeps the drill-in marker and the back bar pops.website/src/test/McpTab.listViewMemory.test.tsx: the filter survives an unmount and remount; an opened tool list stays open and a closed one stays closed; a fresh tab opens unfiltered; an unreadable saved value is ignored.setTab, the URL write-back, theparamsdependency of the write-back, the narrowed explicit-viewrule, the kept history state) turns the matching tests red.--sequence.shuffle, seeds 1-10).Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Ran the user's flow in headless Chrome against a test-mode gateway (fake agent backend, two stdio MCP servers
demo-alphaanddemo-beta): Customize → Connections → MCP Servers, filteralpha, open its tools, Sessions → New chat session, Customize. On the base commit the return lands on/capabilities?tab=mcpwith Services selected. With this change it lands on/capabilities?tab=mcp&view=mcp-serverswith the filter and the open tool list intact, and opening Connections from/capabilities?tab=skills&view=budgetlands on the same MCP Servers list.Screenshots / video
Base commit, after returning from a chat: Services is selected.
With this change, before leaving: MCP Servers filtered to
alpha, tools open.With this change, after returning from a chat: the same list.
With this change, Connections opened from Skills' Context Budget view: still MCP Servers.
Related Issues
Closes #25961
Sibling sweep
Swept:
git grep -nE "get\(['\"]view['\"]\)" -- website/src/pages, plus theuseState-held view state of the Customize panesSibling: website/src/pages/overview/SkillsTab.tsx:142 -- not affected --
?view=budgetis a pushed drill-in with its own Back step, and the Skills list is its exitSibling: website/src/pages/OverviewPage.tsx:218 -- not affected -- a drill-in with a Back control, not a sub-tab selector
Sibling: website/src/pages/system/PerformanceTab.tsx:97 -- not affected -- a drill-down with a Back control, not a sub-tab selector
Sibling: website/src/pages/connections/ConnectionsPage.tsx:71 -- tracked in #25962 -- the Services search box is component state and resets the same way
Pattern harvest
Rule candidate: review-prompt
Pattern: a pane keeps a sub-tab or list state only in a query param or
useStateon a page whose sidebar entry opens the bare routeChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)