Repository navigation
fix(dashboard): return to the mcp servers list as you left it - #32347
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Issue #25961 is linked, and six of the new tests fail on base. The three pieces of remembered state are all there is to the fix, and grepping What this change shipsInventory (5 items) — 5 justifiedIntent: coming back to Customize from a chat lands on the MCP Servers list the way the person left it. FIX.
[FIRST-PRINCIPLES-REVIEWED] ffdc62a Description read[DESCRIPTION-READ] 0fc7ae7c04e4871a62063f04732effc3e5c179982dc80ee9a01a7a78a7f0e753 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the PR adds no new control, and the screenshots show both the before and after states of the restored MCP Servers list. Notes
[UX-REVIEWED] ffdc62a Description read[DESCRIPTION-READ] 6af3b306665811922201d11bd1479d2aee84a8e217ef385877018523095fbeb7 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: keeping the sub-tab, filter and open tool lists in Notes
[DESIGN-REVIEWED] ffdc62a Description read[DESCRIPTION-READ] 0565a20bde0346eb066ae6b209ef59b0ba869e809a0f4e042c580fcb4223dda1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
08fbcbf to
2d0c756
Compare
2d0c756 to
7782cd4
Compare
[operator: bolichen97] |
7782cd4 to
a73309a
Compare
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961
a73309a to
ffdc62a
Compare
|
Rebased: the branch conflicted with main in [operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
The review checked this head. In useConnectionsSubTab.ts, view=mcp-servers still opens MCP Servers, and only that exact string is accepted from session storage. We traced the write-back against SidePanelLayout's ?tab= sync: it settles with no loop and keeps the phone back bar's push marker. The McpTab saved view is type-checked and wrapped in try/catch, and it is never rendered as HTML. Reverting each production hunk turns at least one of the new tests red, and the tests follow the determinism rules.
Done well: the tests mount the real SidePanelLayout instead of a mock, so they catch the same-flush ?tab= overwrite that the params dependency exists to beat.
Optional: in the "ignores a saved view it cannot read" test, also seed {"q":5,"open":"x"}. That pins both type guards in loadListView. Without the q guard, McpTab.tsx:766 would throw.
Optional: the Connections row in docs/feature-map/README.md says the Apply & Restart mount is on line 670. It is on line 815. This was already wrong on main.
Optional: after this merges, close #25967 as superseded and credit its author.
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Coming back to Customize from a chat opened Connections on Services, with the MCP Servers filter empty and every tool list closed. The sidebar's Customize entry opens a bare /capabilities, and the sub-tab lived only in ?view= while the filter and open rows were McpTab state. The sub-tab, the filter and the open tool lists are now kept in sessionStorage for the browser tab, and a resumed MCP Servers is written back into the URL. A view=mcp-servers link still opens MCP Servers. Builds on #25967 by @alparamonov. Closes #25961 Original author: Bolin Chen (cherry picked from commit 1823c3e)
Problem / Motivation
Goal: Coming back to Customize from a chat reopens the MCP Servers list the way you left it.
Builds on #25967 by @alparamonov.
Open Customize → Connections → MCP Servers, filter the list to one server and open its tool list. Click Sessions in the left pane, open a chat, then click Customize again. You land on the Services sub-tab, the filter is empty and every tool list is closed, so you click through to your server again. Opening Connections from Skills' Context Budget view (
?view=budget) lands on Services too.Why it matters
Fixing or testing an MCP server is a back-and-forth: read the next step in a chat, check the server under Customize, go back to the chat. Every return costs the same three or four clicks to find the server again, on exactly the loop where you return most often.
Not a goal
view=mcp-serverslink opens.sessionStorage.What changed (motivation → approach → change)
You now come back to the MCP Servers list as you left it, within the same browser tab.
The sidebar's Customize entry opens a bare
/capabilities.SidePanelLayoutalready remembers the Customize tab for that case, but the Connections sub-tab lived only in?view=, and the list's filter and open rows lived inMcpTabcomponent state, so all three reset.useConnectionsSubTabtreatsview=mcp-serversas the one value that picks a sub-tab outright. Any other URL resumes the sub-tab last shown in the browser tab, including aviewthat a switch from another Customize tab carries over, such as Skills'budget, so that value cannot overwrite the memory. A resumed MCP Servers is written back into the URL, the waySidePanelLayoutkeeps?tab=copy-pasteable, and that write keeps the history entry's state so the phone back bar still pops.McpTabkeeps its filter and open tool lists insessionStorage, the pattern #29273 uses for the Services search. The Connections row ofdocs/feature-map/README.mdnames both.Backwards compatibility
Compatible: a link with
view=mcp-serversopens MCP Servers as before. A URL with any otherview, or none, changes from always Services to the sub-tab last shown in that browser tab, which is Services in a fresh tab; no link in the codebase points at Services throughview.Removes nothing: no route, query param, export or stored key is removed; the change only adds two
sessionStoragekeys.Tests
website/src/test/ConnectionsPage.subTabUrl.test.tsx: a last pick of Services reopens Services. Four cases drive the realSidePanelLayout: a return through a bare/capabilitieslands on MCP Servers and writesview=mcp-serversback; clicking the sidebar entry while on Customize keeps MCP Servers; picking Connections from Skills'?view=budgetkeeps MCP Servers; on a phone, resuming MCP Servers keeps the drill-in marker and the back bar pops.website/src/test/McpTab.listViewMemory.test.tsx: the filter survives an unmount and remount; an opened tool list stays open and a closed one stays closed; an unreadable saved value is ignored.useConnectionsSubTab.tsandMcpTab.tsxreverted toorigin/main, six of the new tests fail: all four layout cases, the kept filter and the kept tool list.--sequence.shuffle, seeds 1-10).Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Walked the issue's trip in a browser against this head's built dashboard (
website/tree acaf6def), with scripted Playwright and every/apicall answered from fixtures, so no gateway and no data home: Customize, Connections, MCP Servers, filteralpha, open its tool list, then Sessions, open a chat, then Customize in the sidebar./capabilities?tab=mcp&view=mcp-serversagain.?view=budget), then Connections keeps MCP Servers and the filter; the URL becomes/capabilities?tab=mcp&view=mcp-servers.website/tree cdf01403) lands on Services at/capabilities?tab=mcp.The capture script asserted each of those states before writing its frame.
Screenshots / video
Captured from this head's
website/tree (acaf6def), dark theme (the change adds no style).Base commit, after returning from a chat: Services is selected.
With the change, before leaving: MCP Servers filtered to
alpha, its two tools open.With the change, after returning from a chat: the same list, filter and open tool list.
With the change, Connections picked from Skills' Context Budget view: still MCP Servers, filter kept.
Related Issues
Closes #25961
Sibling sweep
Swept:
git grep -nE "get\(['\"]view['\"]\)" -- website/src/pages, plus theuseState-held list state of the Connections panesSibling: website/src/pages/overview/SkillsTab.tsx:149 -- not affected --
?view=budgetis a pushed drill-in with its own Back step, and the Skills list is its exitSibling: website/src/pages/OverviewPage.tsx:233 -- not affected -- a drill-in with a Back control, not a sub-tab selector
Sibling: website/src/pages/system/PerformanceTab.tsx:99 -- not affected -- a drill-down with a Back control, not a sub-tab selector
Sibling: website/src/pages/SettingsPage.tsx:262 -- not affected -- Settings Overview's
view=memoryis a declared drill-in that a rail pick drops on purposeSibling: website/src/pages/connections/ConnectionsPage.tsx:79 -- not affected -- the Services search is already kept in
sessionStorage(#29273)Pattern harvest
Rule candidate: review-prompt
Pattern: a pane keeps a sub-tab or list state only in a query param or
useStateon a page whose sidebar entry opens the bare routeChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)