Skip to content

feat(desktop): accept kirocrew://apps/detail/<name> deep links - #26281

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
devsdmf:feat/app-detail-deep-link
Nov 7, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
devsdmf:feat/app-detail-deep-link

Conversation

@devsdmf

@devsdmf devsdmf commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A program on the same machine can send the user to one app's detail page in the desktop app with kirocrew://apps/detail/<name>, instead of raising the window and describing the clicks.

The kirocrew:// scheme accepts two shapes: bare kirocrew:// raises the window, and kirocrew://chat?sid=<key> opens one session. Nothing points at an app. An app driven by a companion program outside the dashboard (Keeb Control and its keeb-crew app are the case at hand) sometimes needs the user on the app's own detail page: to grant a permissions.sessionApproval consent that only the dashboard can grant (kirocrew app enable refuses it from the CLI and prints the page's link), to review a pending update, or to see what the app is. Today the program can only bring the window forward and then explain, in its own UI, where to click: Apps, Library, the tile, Details.

Why it matters

The consent case is the sharp one. An app's sessionApproval grant is deliberately a dashboard-only click, so a program that needs it can do nothing but describe a route through the store, and a user following a described route through an unfamiliar page is the one most likely to click the wrong thing. A link that lands on the page, and does nothing else, keeps the click where the design put it and removes the walkthrough. For app authors the scheme becomes usable for the one page that describes their app; for users the dashboard opens where they were sent. Every companion program for a path-installed app pays this on every release that changes a permission.

Not a goal

  • No deep link triggers install, update or enable. The detail page takes those from router state only (AppDetailPage's autoAction), never from a URL, because a URL-driven trigger would be reachable by a cross-site navigation with the session cookie riding along; this PR leaves that unchanged and relies on it.
  • No other apps/ target: not /apps (Discover), /apps/library, /apps/-/updates, /apps/migrate/<name>, and not /apps/<name>, the app's own page, where the app's code runs. The detail page is the one page that merely describes an app.
  • No settings/<tab>, artifacts/<slug> or any other dashboard route. The allowlist grows by exactly one shape; the pins that refuse those stay.
  • No --app NAME flag on kirocrew open. A program that wants the link opens the URL itself (open, xdg-open, start).
  • No change to how a link arrives or is delivered: deep-link-handler.js, main.js and preload.js are untouched. The renderer changes only so an app detail link is visible over a Remote Crew pane.

What changed (motivation → approach → change)

A companion program can now open one app's detail page with kirocrew://apps/detail/<name>. The link only navigates: it never installs, updates or enables anything.

The approach: website/electron/deep-link.js already decides which URLs may drive navigation, as a deny-by-default allowlist that rebuilds each route from validated pieces. The new shape lives there and nowhere else. Two alternatives were rejected: accepting any /apps/... path (the store pages act on apps, and /apps/<name> runs the app's code) and a flag on kirocrew open (the URL is one line in the calling program).

Part Change
Resolver (deep-link.js) Accepts host apps with exactly detail/<name>, no query, no fragment. <name> is checked by isAppName with plain logic, no regex: at most 200 characters, split on - into non-empty parts made only of a-z and 0-9. That is the manifest's kebab-case grammar (KEBAB_RE). A percent-encoded name is refused, not decoded. The chat shape resolves exactly as before.
Renderer (website/src/shell/appShell.tsx, website/src/utils/navIntent.ts) Over a Remote Crew pane, an app detail link brings the local Crew forward before navigating, so it lands on a visible page. The leave check then runs as for any other exit. Other native paths (Settings, About) are unchanged.
Docs website/electron/README.md, the kirocrew open row in docs/system-specs/modules/cli.md, the Detail row in src/kiro_crew/docs/apps.md, and the sessionApproval note in docs/app-kit/manifest-reference.md describe the link.

As for a session link, the handler holds the link until the dashboard reports navigate-ready.

Not a product-shape change: no default changes and nothing user-facing is removed or replaced, so no RFC is cited.

Backwards compatibility

Compatible: both existing shapes resolve exactly as before, and the pre-existing resolver and handler tests pass unchanged apart from one describe title. refuse()'s reasons are only logged. The renderer change applies only to /apps/detail/<name> paths, which no native sender produced before this PR.

Removes nothing: the diff adds one accepted shape, its renderer handling, tests and docs; no route, key, record or function is hidden, removed, renamed or tightened.

Tests

website/electron/test/deep-link.test.js and deep-link-handler.test.js (65 cases under node --test):

  • apps/detail/<name> resolves to /apps/detail/<name> with no session; a trailing slash and an upper-case host are normalised as for chat.
  • The name grammar: upper case, _, leading, trailing or double hyphens, ., %2D and 201 characters are refused; 200 characters are admitted.
  • Refused shapes: apps, apps/library, apps/-/updates, apps/<name>, apps/migrate/<name>, apps/detail, apps/detail/<name>/settings, ?autoAction=install, ?sid=x, #enable, a port, and dot-segment traversals.
  • An app detail link is held until navigate-ready and delivered once, like a session link.

website/src/test/App.navLeaveGuard.test.tsx:

  • Over a Remote Crew pane, an app detail link clears activeId and lands on /apps/detail/demo-app.
  • A declined leave prompt keeps the page and the draft, with the prompt shown on the local Crew.

website/src/test/popoutNavForwarding.test.ts: isAppDetailPath accepts /apps/detail/<name> and rejects /apps/detail/, /apps, /settings/about and a chat path that carries apps/detail in its query.

website/electron/test/fixtures/app-name-samples.json lists valid and invalid app names. deep-link.test.js runs each one through isAppName and test/test_cli_open.py runs each one through the manifest's KEBAB_RE, so the two grammars cannot drift apart. test_cli_open.py also checks that deep-link.js has no APP_NAME_RE.

Proof: not provable -- frontend test (prove.py runs Python only). By hand: with the appShell.tsx switch removed, both App.navLeaveGuard app detail tests fail (expected 'remote-1' to be null) and pass with it restored.

Results on macOS: vitest 110 passed across App.navLeaveGuard, popoutNavForwarding, App.shell.owners and AppRootCoverage; test/test_cli_open.py 20 passed; the two Electron deep-link suites 65 passed; eslint and flake8 clean.

Manual verification

Still required. The shape needs a packaged build: a dev run (process.defaultApp) deliberately registers no scheme, and an installed build predates this branch.

  1. Package and install the desktop app from this branch (the README's "Install as macOS App" recipe: npx electron-builder --mac --dir, then copy the bundle to /Applications), with at least one app installed. From a terminal: open "kirocrew://apps/detail/<name>" (macOS; xdg-open / start elsewhere). Expect the window to come forward on that app's detail page and nothing else to happen: no install, update or enable starts.
  2. Quit the app and run the same command. Expect the app to launch and land on the detail page once the dashboard has loaded (the link is held until navigate-ready).
  3. open "kirocrew://apps/detail/<name>?autoAction=install", then open "kirocrew://apps/library". Expect no navigation, and the desktop launch log to carry deep link refused (unknown query parameter) and deep link refused (unknown route) with the URL's length, never its text.
  4. With a Remote Crew pane active, run step 1's command. Expect the local Crew to come forward on the detail page.

Screenshots / video

Why no screenshot: No component, layout or string changes; the link opens the existing /apps/detail/:name page as a sidebar click does, and over a Remote Crew pane it selects the existing local Crew pane first.

Related Issues

Related: #23197 (shipped the kirocrew:// scheme as da4eb1c32a; its stated scope stopped at two shapes and framed any further route as a deliberate allowlist change, which this PR is) and #23195 (its originating issue). No issue is linked.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license, per the Licensing section of CONTRIBUTING.md.

@devsdmf
devsdmf requested review from a team and KiroCrewCaptain as code owners October 30, 2026 16:57
@devsdmf
devsdmf requested a review from chenmingwei23 October 30, 2026 16:57
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 30b7fbee927654a71cdca13dcac2b222d4b5b059 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change adds one allowlisted deep-link shape that rebuilds the route from a validated name, and it relies on the existing router-state-only autoAction trigger (AppDetailPage.tsx:545).

Notes

  • The description says the name cap is "at most 200 characters" and that the tests cover "201 characters are refused; 200 characters are admitted". The diff uses APP_NAME_MAX_LENGTH = 128, which matches manifest_names.py, and tests 129 and 128. The description is wrong here, not the code; correct it so the next reviewer is not misled.
  • The resolver and the manifest each keep their own copy of the app-name grammar, and only the shared sample fixture keeps them in step. A grammar change can still ship that no sample covers. That is acceptable for one small grammar, but whoever changes KEBAB_RE must also add samples to the fixture.

[DESIGN-REVIEWED] 30b7fbe

Description read

[DESCRIPTION-READ] b491641489afb89edb1d7e6e877c88bcb924ee858f0d8312414ddc2267c3e00a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 30b7fbee927654a71cdca13dcac2b222d4b5b059 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

No new control, label or string; the link opens the existing app detail page and reuses the session link's pane switch and leave prompt.

Notes

  • If the user declines the leave prompt, dispatch(setActiveId(null)) has already run, so they stay on the local Crew instead of the Remote Crew pane they were viewing. The new test pins this (expect(store.getState().instances.activeId).toBeNull() after decline). If that is intended, say so in the comment at appShell.tsx:470. If not, restore the previous activeId when mayLeaveForNavigation() returns false.

[UX-REVIEWED] 30b7fbe

Description read

[DESCRIPTION-READ] b1b02803f481dc9eb8dd09dc5bb1c6e48fbca51413e25bb21cf7bc241e4aca4b

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 30b7fbee927654a71cdca13dcac2b222d4b5b059 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 30b7fbe

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 30b7fbee927654a71cdca13dcac2b222d4b5b059 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The PR adds one deep-link shape next to the existing ones and changes no default. Every item fixes a nameable problem with nothing else already doing that job. The ## What changed section still quotes a 200-character cap, but the diff uses the manifest's 128.

What this change ships

Inventory (6 items) — 6 justified

Intent: let a companion program on the same machine send the user straight to one app's detail page in the desktop app, for example to grant a dashboard-only consent. ADDITION.

  1. kirocrew://apps/detail/<name> opens that app's detail page and does nothing else — justified
  2. Over a Remote Crew pane, an app detail link brings the local Crew forward before navigating, as a session link already does at appShell.tsx:835 — justified
  3. Every other apps/… target, any query, any fragment and any percent-encoded name is refused with a logged reason — justified
  4. App names are checked against the manifest's kebab-case grammar and its 128-character cap (manifest_names.KEBAB_RE, APP_NAME_MAX_LENGTH) — justified
  5. A shared sample fixture plus Python and JS tests keep the JS check and KEBAB_RE in agreement — justified
  6. The Electron README, cli.md, apps.md and manifest-reference.md describe the new link — justified

[FIRST-PRINCIPLES-REVIEWED] 30b7fbe

Description read

[DESCRIPTION-READ] f98d4e618639c6db6f6cdcd9225d3649d0fab93d4ed179de70bf75c6222f6cee

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings (all downgraded on adjudication)

Reviewed 30b7fbee927654a71cdca13dcac2b222d4b5b059 via the fork AI-review pipeline; updated in place on each push.

Opus 5.5 adjudication downgraded every blocking finding. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

Review details

BLOCKING -- website/src/shell/appShell.tsx:855 -- Commit the local-pane switch before invoking its leave guard

dispatch(setActiveId(null))
Trigger: Edit a local prompt under /capabilities?tab=prompts, switch to Remote Crew, then open kirocrew://apps/detail/demo-app. The native navigation callback dispatches this update and immediately calls mayLeaveForNavigation() → SidePanelLayout → PromptsTab’s synchronous confirm().
Outcome: The concurrent React root has not committed the visibility update when confirmation blocks execution. The discard dialog appears over Remote Crew while the local draft it asks about remains hidden until the dialog closes.
Anchor: defect
Fix: Flush the local-pane switch synchronously before asking the leave guard, or invoke the guard after the visibility update commits.

[BLOCK-MERGE-DOWNGRADED] 30b7fbe
[GPT-REVIEWED] 30b7fbe

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1: LOW harm. The failure needs two things: a Remote Crew pane is active and the local pane has an unsaved draft (diff appShell.tsx:854), and a synchronous confirm() runs before the deferred re-render triggered by setActiveId(null) commits (appShell.tsx:855 → mayLeaveForNavigation() at base :851). The result is a dialog over the wrong pane, visible for a moment. Nothing is lost: declining keeps the draft and the route (the PR's own test, App.navLeaveGuard.test.tsx:526-529), and accepting navigates as asked. The existing session-link path already orders things the same way (dispatch, then a synchronous leave check) at base appShell.tsx:835→844. The real fix is a new flush-before-guard ordering rule that both native-navigate branches would need, which costs more than a one-off, recoverable, cosmetic misplacement.

[ADJUDICATION] 30b7fbee927654a71cdca13dcac2b222d4b5b059 total=1 uphold=0 downgrade=1
DOWNGRADE F1 website/src/shell/appShell.tsx:855 reason=disproportionate-remedy
[GPT-ADJUDICATED] 30b7fbee927654a71cdca13dcac2b222d4b5b059

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 30, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch from f4e5605 to 6752170 Compare October 31, 2026 19:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 2, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch 2 times, most recently from 1fe3767 to 7e73d06 Compare November 2, 2026 17:16
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch from 7e73d06 to 12d4c22 Compare November 2, 2026 21:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 2, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch from 12d4c22 to c73b790 Compare November 2, 2026 23:26
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch from c73b790 to dbcfe04 Compare November 3, 2026 14:20
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 4, 2026
@devsdmf
devsdmf force-pushed the feat/app-detail-deep-link branch from 510ab82 to 7396367 Compare November 4, 2026 22:22
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 4, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Re-checked at 7396367. The deep-link name check is still plain logic, and the shared app-name-samples.json fixture keeps the two sides in step.

One small thing, under our no-new-regex rule: this head adds a new regex in test/test_cli_open.py:

match = re.search(r"const APP_NAME_MAX_LENGTH = (\d+);", source)

It parses JS source text to find the constant. An exact string check does the same job with no pattern:

expected = f"const APP_NAME_MAX_LENGTH = {manifest_names.APP_NAME_MAX_LENGTH};"
assert expected in source, "deep-link.js APP_NAME_MAX_LENGTH differs from the manifest cap"

Another option is to put the cap in app-name-samples.json and have both test suites read it from there.

With that swapped, I'll approve once CI is green.

@bolichen97

Copy link
Copy Markdown
Contributor

Correction to my last review: the re.search in test/test_cli_open.py is not a blocker. Our no-new-regex rule covers product code only, and that line is in a test file. I withdraw that change request. Sorry for the noise. No change is needed for it.

I'll approve once the remaining checks on 7396367 are green.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@devsdmf

devsdmf commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for re-checking, and for the quick correction on the test-file regex. No change made there.

Everything on 7396367 is green now: 81 checks passed, none failed or pending. The earlier reds were a flaky decisions test (#29457) and a content scan that never finished, and both passed on this run.

What changed since your first review:

  • isAppName in website/electron/deep-link.js is plain logic, with no regex.
  • website/electron/test/fixtures/app-name-samples.json is checked against both isAppName and the manifest's KEBAB_RE.
  • The name length cap is now 128, the manifest's own APP_NAME_MAX_LENGTH, with a test in test/test_cli_open.py that keeps the two equal.

Ready for your approval when you have a moment.

@devsdmf
devsdmf disabled auto-merge November 5, 2026 13:55
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the feat/app-detail-deep-link branch from ca4f1aa to eafaff8 Compare November 7, 2026 08:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Backend Tests (3.12, 2) and (3.12, 4) are red at eafaff83af on tests this PR does not touch:

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
The kirocrew:// scheme accepts two shapes: a bare link that raises the
window, and chat?sid=<key> that opens one session. A companion program
whose app needs the user's attention on its own detail page (to review
it, or to grant a permissions.sessionApproval consent that only the
dashboard can grant) has no link to send them there, so it falls back to
raising the window and describing the clicks through the store.

Add a third allowlisted shape, kirocrew://apps/detail/<name>, resolving
to /apps/detail/<name>. The name is checked against the manifest's own
app-name grammar (KEBAB_RE in manifest_names.py) with a length bound,
the route is rebuilt from the validated name rather than copied, and a
query parameter, a fragment, an extra segment or any other apps/ path
(the store pages, the app's own page) is still refused. The detail page
takes its install, update and enable trigger from router state only, so
a link can show the page and nothing more: the click stays the user's.

The handler, main.js, the preload and the renderer are unchanged: the
route travels the same hold-until-navigate-ready path and the same
guarded navigate as a native menu entry. kirocrew open gets no flag for
it; a program that wants the link opens the URL itself.

Docs move in the same commit: the Electron README names the three
shapes, the cli.md row that owns the resolver's grammar names this one,
and the apps and manifest-reference docs tell users and app authors.
@bolichen97
bolichen97 force-pushed the feat/app-detail-deep-link branch from eafaff8 to 30b7fbe Compare November 7, 2026 11:25
@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main @ bab2387339, which carries the line-budget fix (#32252, superseding #32183); new head 30b7fbee92, no change to the diff. CI re-running.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 30b7fbe as maintainer. All 95 checks pass. This replaces my change request on 7396367.

That review asked about a re.search in test/test_cli_open.py. Our no-new-regex rule covers product code only, so a pattern in a test is not a blocker. I'm withdrawing that point, and you don't need to change it.

What I checked in the product code:

  • resolveDeepLink accepts exactly one new shape, kirocrew://apps/detail/<name>: two path segments, the first detail, no query parameters. Anything else is refused with a reason. The route is rebuilt from the parsed name, never copied from the input.
  • isAppName checks the manifest's kebab grammar with plain logic: dash-separated non-empty parts of a-z and 0-9, length capped at the manifest's APP_NAME_MAX_LENGTH (128). So a percent-encoded segment is refused, not decoded, and the shared app-name-samples.json fixture keeps both sides in step.
  • The link only shows the detail page. Install, update and enable stay router-state triggers, so the click stays the user's.
  • Over a Remote Crew pane, appShell brings the local Crew forward first, as a session link does.

@bolichen97

Copy link
Copy Markdown
Contributor
  • Commit the local-pane switch before invoking its leave guard (span=96a7c8d01039): rebutted

Disproportionate, not a data-loss defect: the worst case is the discard prompt drawn over Remote Crew for the moment it is open. Declining keeps the draft and the route, and accepting navigates as asked.
The PR follows the ordering every native-navigate branch already uses: dispatch(setActiveId(null)), then the synchronous leave guard. That is the session link at website/src/shell/appShell.tsx:844 and the Remote Crew add link at :864-865 on main 9924e53.
Pinned by website/src/test/App.navLeaveGuard.test.tsx:524 (the app link brings the local Crew forward) and :541 (declined confirm keeps the page).
A flush-before-guard rule would be a new ordering contract for all three branches; that is its own change, not this PR's. The fork adjudication downgraded it at this head for the same reason (disproportionate-remedy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants