Skip to content

feat(connections): register TickTick, launch-gated - #26407

Closed
martchellop wants to merge 1 commit into
kirodotdev:mainfrom
martchellop:feat/connections-ticktick
Closed

martchellop wants to merge 1 commit into
kirodotdev:mainfrom
martchellop:feat/connections-ticktick

Conversation

@martchellop

@martchellop martchellop commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: TickTick users get a one-click, catalogue-governed Connect for TickTick's hosted MCP server, hidden behind the launch gate until the manual check passes.

The Connections catalogue has no TickTick entry. A user who wants an agent to read and manage their TickTick tasks has to add https://mcp.ticktick.com by hand on the MCP Servers tab, and gets none of the catalogue's guarantees: no nightly OAuth metadata watch, no consent-banner allowlisting, no card copy saying what the grant can do, and no rename declaration when another connected server also ships search and fetch.

Why it matters

TickTick runs its own hosted MCP server and documents the connection for Claude, ChatGPT, Cursor, VS Code, Codex and Claude Code, so it is a catalogue-grade provider. A registry entry gives it the same treatment as the other 29: Connect, the L0 metadata probe, the banner allowlist and the card copy. Nothing is installed on the host; kiro-cli runs the sign-in and keeps the token, the same way on macOS, Windows and Linux.

Not a goal

  • Flipping launch_gate_passed: the Connect grid renders the same cards as main until a human walks the flow on a test gateway with a real TickTick account.
  • Verifying the revoke surface: revoke_verified_note says pending manual check, like Todoist's did.
  • Any change to the alias pass, the registry loader or the Connections page.

What changed (motivation → approach → change)

TickTick joins src/kiro_crew/connections/registry.json hidden, mirroring the Todoist entry (#14177). The entry is tier 2, project-management, with launch_gate_passed: false.

The sign-in shape comes from live discovery on 2026-10-30. https://mcp.ticktick.com/.well-known/oauth-protected-resource names https://ticktick.com/ as the authorization server and tasks:read / tasks:write as the whole scopes_supported list; https://ticktick.com/.well-known/oauth-authorization-server advertises registration_endpoint https://api.ticktick.com/oauth/register (dynamic registration), authorization_endpoint https://ticktick.com/oauth/authorize, the authorization_code grant and PKCE S256. So the entry uses DCR + PKCE, l0_expectations records issuer https://ticktick.com, dcr: true, pkce: true, verified_on: 2026-10-30, and python -m kiro_crew.connections.l0_probe passes for all 30 providers on this head.

The entry requests both scopes. TickTick offers no read-only MCP scope, so the entry's gotcha_copy (reference text, not rendered on the card) leads with the fact that the grant can write and names the server's delete tools (delete_task, delete_tag, delete_project_group, delete_focus, delete_comment), which run at the user's own permission level. The consent URL ticktick.com/oauth/authorize joins _OAUTH_AUTHORIZATION_ENDPOINTS in security/exfil_oauth.py and the URL corpus.

TickTick ships bare search and fetch, like Atlassian, Neon and Todoist, and its smoke fixture is its own list_projects, the tool Linear and Vercel already rename, so it declares ticktick_search, ticktick_fetch and ticktick_list_projects. A rename fires per colliding tool, only while two servers that ship it are connected together.

Connected together Before After
TickTick + Todoist — 🟩 ticktick_search, ticktick_fetch, todoist_search, todoist_fetch
TickTick + GitLab — 🟩 gitlab_search, ticktick_search; fetch keeps its name
TickTick + Linear — 🟩 linear_list_projects, ticktick_list_projects; search and fetch keep their names
TickTick alone — 🟦 search, fetch and list_projects, unchanged

🟩 added · 🟦 unchanged

The user doc (docs/connections.md, docs/index.md) now counts 36 providers (30 at authoring; six Google Workspace entries landed on main since) and eight rename declarers. The spec roster in docs/system-specs/modules/connections.md gains a TickTick row, and ProviderLogo.tsx maps the new logos/ticktick.svg, the CC0 simple-icons mark (https://simpleicons.org/?q=ticktick, path from icons/ticktick.svg in simple-icons/simple-icons), reduced to the same single-path viewBox="0 0 24 24" shape as the other masked marks.

Backwards compatibility

Compatible: the registry gains one hidden entry and its rename declarations, and nothing main accepts is rejected or removed. The renames run through the existing alias pass and apply only while two servers exposing the same tool are connected together.

Removes nothing: every touched file gains lines; no key, path, function or row is removed or renamed.

Tests

  • test/test_connections_registry.py: TickTick is on the roster and launch-gated. test_ticktick_requests_both_scopes_and_admits_the_grant_can_write pins the endpoint, the two scopes, the write disclosure, the five delete tools named in the copy, and the three-entry alias map.
  • test/test_connections_tool_aliases_decision_table.py: TickTick joins the bare search/fetch group. TickTick + Todoist renames all four tools, TickTick + GitLab renames only search, TickTick + Linear renames only list_projects, and TickTick alone keeps its names. connections_tool_aliases_helpers.py learns the URL.
  • test/test_connections_doc.py: the alias clause's count word now goes up to eight.
  • test/oauth_url_corpus.py: a TickTick consent URL carrying both scopes, which the banner allowlist must accept.
  • test/test_security_gate_liveness.py: _PACKAGE_LINE_BUDGET goes from 33,723 to 33,724 for the one allowlist line in exfil_oauth.py, with the house-style #: note.

Ran locally on this head: the 26 test files that reference the touched modules (1465 passed), isort --check-only and flake8 on src/kiro_crew test conftest.py xdist_budget.py, tsc -p tsconfig.app.json, eslint src/pages/connections, and the vitest files that read the registry or ProviderLogo (ConnectionsPage.owners, ConnectionsPage.coverage, IssueRadarProviderBadge: 89 passed). scripts/local-gate.py's backend lane 1 reports 34 failures on this host that are independent of the diff (test_acp_spawn_offload, test_cli::TestDoctor, test_cli_stt_memory_doctor, test_acp_tool_gate: the host carries a Copilot ~/.mcp.json and a symlinked home); CI is the authority for those.

Manual verification

Done:

  • Both discovery documents fetched live on 2026-10-30 (values above). An unauthenticated initialize against https://mcp.ticktick.com returns 401 with WWW-Authenticate: Bearer ... resource_metadata="https://mcp.ticktick.com/.well-known/oauth-protected-resource", so RFC 9728 discovery starts from the server itself.
  • python -m kiro_crew.connections.l0_probe on this head: 30 of 30 providers ok, TickTick observed authorization_server https://ticktick.com, dcr true, pkce true.
  • The smoke fixture list_projects with {"limit": 1} and the five delete tools named in the copy come from the server's published 58-tool roster as seen by a connected client; no signed-in tools/list was run from this checkout.

Still owed before the card goes visible (the launch-gate check, on a test gateway with a real TickTick account):

  • Connect, consent, Connected, Test, Disconnect, and record the revoke page (the entry points at https://ticktick.com/webapp/#settings with the manual path to the account's authorized apps; refresh revoke_page_url, revoke_manual_path and revoke_verified_note from what the logged-in check finds).
  • Confirm the consent screen grants tasks:read tasks:write as requested, and that a token refresh works across a session held past expiry.
  • tools/list on the live server: confirm bare search, fetch and list_projects are present and that the delete tools listed in the copy are the right names; with Todoist also connected, the agent sees the renamed tools.

Screenshots / video

Why no screenshot: TickTick ships with launch_gate_passed=false, so the Connect grid renders the same cards as main; the new logo renders only once the launch gate flips.

Related Issues

Closes #26388

Prior art: #14177 (Todoist), the entry this one mirrors.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@martchellop
martchellop requested review from a team and KiroCrewCaptain as code owners October 30, 2026 20:51
@martchellop
martchellop requested a review from CrysisDeu October 30, 2026 20:51
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of befd2e276ddd1182c283e50f75d09de7f345fa4f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change adds one hidden catalogue entry that follows the Todoist pattern, and it removes nothing.

Notes

  • The logo and its ProviderLogo mapping don't render while launch_gate_passed is false. Attach a card screenshot to the PR that flips the gate.

[DESIGN-REVIEWED] befd2e2

Description read

[DESCRIPTION-READ] 5d3daf0152829d09b3d6efbfb6402059a0b2dca2ba157e589f03722202ca7845

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of befd2e276ddd1182c283e50f75d09de7f345fa4f via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Every item is catalogue data that stays hidden behind launch_gate_passed: false, which registry.py:742 already enforces. The renames go through the existing alias pass.

Notes

  • Item 4 — undeclared: the list_projects rename depends on "the server's published 58-tool roster… no signed-in tools/list was run". If that bare tool does not exist, the declaration does nothing. Subtraction: delete "list_projects":"ticktick_list_projects" if the launch-gate tools/list does not show a bare list_projects.

What this change ships

Inventory (6 items) — 5 justified

Intent: let TickTick users connect TickTick's hosted MCP server from the Connections catalogue, hidden until the manual launch gate passes. This is an ADDITION.

  1. New TickTick catalogue entry (DCR + PKCE, both scopes), hidden from the Connect grid — justified
  2. TickTick consent page ticktick.com/oauth/authorize is accepted by the OAuth banner allowlist — justified
  3. With TickTick and another server that ships search/fetch connected, both get <provider>_ prefixes — justified
  4. With TickTick and Linear or Vercel connected, list_projects gets renamed — undeclared; rests on a tool list that was never checked live
  5. User docs and the spec roster count 36 providers and eight rename declarers; index's stale "29" is corrected — justified
  6. TickTick logo on the card — justified

[FIRST-PRINCIPLES-REVIEWED] befd2e2

Description read

[DESCRIPTION-READ] 7ad2154af384c74f5466dfd80febdba80e602a5088f32e1de7c077343a56ff10

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of befd2e276ddd1182c283e50f75d09de7f345fa4f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The TickTick card is hidden behind the launch gate (launch_gate_passed: false, no pre-registered auth), so its logo and copy never render, and nothing a user can see changes on this head.

Notes

  • When the gate flips, the screenshots need to show the TickTick card: the logo, its masked rendering in light and dark themes, and the Connect, Connected and Disconnect states.

[UX-REVIEWED] befd2e2

Description read

[DESCRIPTION-READ] 5d109aa0145a62e805a94eed874e89b6d90bd3d271bac9593fd852a2f20414ee

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed befd2e276ddd1182c283e50f75d09de7f345fa4f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] befd2e2

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed befd2e276ddd1182c283e50f75d09de7f345fa4f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] befd2e2

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review (fork) — ✅ PASS

Which legitimate operations does 65c714534ff9219d136b4593bc1a98f9096142a1 newly refuse? Model proposes, scripts/deny_diff.py decides — updated in place on each push. A script-confirmed regression blocks PR readiness.

adjudicated, zero confirmed regressions

Scope-Verdict: PASS

Reason: This patch makes nothing stricter. Its only security change adds one exact (host, path) pair to the code-owned list of OAuth consent endpoints that may skip the entropy checks. That skip applies only when allow_oauth_entropy is set, which happens only on the ACP banner-safety path, so the shell deny composite should behave the same at both refs. The 14 candidates are there to confirm that. The banner gate the pair does change is not a shell guard, so no verdict exists for it; it is named under UNADJUDICATED.

TIGHTENING: none — the one security-relevant hunk loosens the ACP banner OAuth-entropy carve-out (_OAUTH_AUTHORIZATION_ENDPOINTS in src/kiro_crew/security/exfil_oauth.py) by one exact endpoint. The threat that list guards against, a high-entropy credential hidden in OAuth front-channel parameters at a host nobody approved, is still refused for every other host: + ("ticktick.com", "/oauth/authorize"),

ADJUDICATED: 14 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: posix and windows. The diff itself makes no path, separator, interpreter or executable assumption; the new pair is an exact host plus a case-sensitive path, and is the same on every host. The posix rows cover the RFC 9728 and RFC 8414 discovery reads against mcp.ticktick.com and ticktick.com, a HEAD request to the consent endpoint, opening the consent URL with xdg-open, the neighbouring Todoist metadata read, and the maintainers' own pytest, jq, git and grep commands on the touched files. The windows rows cover curl.exe (so PowerShell's curl alias is not used), opening the consent URL with cmd start "", and pytest with \ separators. No platform spelling the diff assumes is left unprobed.

UNADJUDICATED: The guard is the ACP banner-safety URL check. An OAuth consent URL from an MCP server's auth flow takes this path: exfil.py URL heuristics with allow_oauth_entropy=True and is_https and no port → _approved_oauth_authorization_endpoint(host, path) (exfil_oauth.py:492) → exact lookup in _OAUTH_AUTHORIZATION_ENDPOINTS → only the known _OAUTH_QUERY_PARAMS skip the base64 and length heuristics. The patch only widens this guard for ticktick.com/oauth/authorize. A wider guard cannot newly refuse anything, so no regression can come from it. The inputs I would have submitted are the TickTick consent URL from test/oauth_url_corpus.py, with its tasks:read tasks:write scope, S256 PKCE and loopback redirect_uri, plus the same URL with an explicit :443 port and with http://. Those last two must still fail closed because of the HTTPS-only and no-port conditions. None of these is a shell command line, so the classifier gives no verdict on them. The rest of the patch (registry entry, tool aliases, docs, logo, tests) is outside the deny composite.

[SCOPE-REVIEWED] 65c7145

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 10 classified, 0 newly refused, 10 still allowed.
  • ubuntu-latest (platform posix): 10 classified, 0 newly refused, 10 still allowed.
  • windows-latest (platform windows): 4 classified, 0 newly refused, 4 still allowed.

No candidate flipped from allowed to refused.

@martchellop
martchellop force-pushed the feat/connections-ticktick branch from 91e92f3 to 93743a9 Compare October 30, 2026 22:28
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 30, 2026
@martchellop

Copy link
Copy Markdown
Contributor Author
  • Spec row says "the card names the delete tools" but cards do not render gotcha_copy

fixed in 93743a9: the roster row in docs/system-specs/modules/connections.md now says "the entry's gotcha_copy names the delete tools"; the PR body says the same.
The second note (smoke_fixture.args is not sent by l1_smoke.py) is left as is: every registry entry carries args because the loader requires the field, and {"limit": 1} matches the Todoist/Linear shape so a future L1 that does send arguments gets a bounded call. Not a defect in this diff.

The UX note (lead the card text with the write/delete line) is also applied in 93743a9: gotcha_copy now opens with "The grant can write and can delete tasks, tags, project groups, focus records and comments (...)". The rename sentence stays, because gotcha_copy is reference text rather than rendered card prose and the catalogue entry is where an agent reads it.

@martchellop

martchellop commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Note for maintainers: this PR needs an in-repo takeover to pass Sensitive Change Review.

The one-line addition to src/kiro_crew/security/exfil_oauth.py (("ticktick.com", "/oauth/authorize") in _OAUTH_AUTHORIZATION_ENDPOINTS) is required: test_every_registry_mcp_authorization_server_is_banner_allowlisted fails without it. That path is in SENSITIVE_GLOBS, and the gate refuses every fork PR that touches one, so no comment or approval can turn it green from here (I have no push access to this repository).

Per the gate's own remedy: a maintainer recreates the branch in this repository, keeps Co-authored-by: Marcello Pagano <78482880+martchellop@users.noreply.github.com> on the commit, writes Supersedes #26407 in the body, and fills the ## Sensitive change review template for that head. Everything else on 65c714534ff9 (same tree as 93743a9a0fc4) is already green on the fork lanes (Fast Gate, CI, Build, Code Review, Security Scope, Design, UX, First Principles, GPT 6.1 and Opus 5.5 all pass, no findings). The reasoning for the template, so it can be pasted:

  • Rule changed: _OAUTH_AUTHORIZATION_ENDPOINTS gains one exact (host, path) pair. Before: a TickTick consent URL in an ACP banner was scanned as an unknown URL, so its high-entropy state / code_challenge values could trip the bare-secret heuristic and suppress the banner. After: that exact endpoint gets the same PKCE/state entropy carve-out every other registry provider's consent page already has.
  • Worst case: an attacker who controls ticktick.com/oauth/authorize could place a secret-shaped value in a recognised OAuth parameter without the banner gate flagging it. That is the same trust every allowlisted vendor consent page carries, and the host is the RFC 8414 issuer TickTick publishes; test_security_oauth_urls.py still fails the URL closed for any other host, path, userinfo authority, fragment, or unrecognised parameter.
  • Sandbox evidence: test/oauth_url_corpus.py gains the TickTick consent URL with both scopes; test_security_oauth_urls.py, test_mcp_oauth_banner.py, test_exfil_facade.py and test_security_gate_liveness.py pass on this head (1465 related tests locally, CI green on the fork lanes).
  • No regression: no existing tool, provider or allowlist entry changes; the new pair is purely additive and the entry is launch-gated, so no card renders until a human flips the gate.
  • Undo: revert the one line in exfil_oauth.py together with the registry entry (the registry test couples them).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 30, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from 93743a9 to 65c7145 Compare October 30, 2026 23:48
@martchellop

Copy link
Copy Markdown
Contributor Author

Re-pushed: 65c714534ff9 is the same tree as 93743a9a0fc4 (verified git rev-parse <sha>^{tree} equal) under a new SHA, to re-trigger the fork AI lanes. On 93743a9a0fc4 the Fork GPT 6.1 Review (run 41139283259) and Fork Security Scope Review (run 41139283303) failed at their actions/checkout of the trusted base / "Stage the base-owned redactor" steps at 22:36 UTC, before either read the diff, so their checks read "review incomplete" / "no leg reported"; every other lane, including CI, Build and the Opus / Design / UX / First Principles reviews, was green on that head. I have no rights to gh run rerun here. No code changed.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 31, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from 65c7145 to fc8641e Compare October 31, 2026 02:33
@martchellop

Copy link
Copy Markdown
Contributor Author

Rebased onto main (4951c0c0e0) and bumped _PACKAGE_LINE_BUDGET in test/test_security_gate_liveness.py from 33,334 to 33,335 for the one new consent-host line in exfil_oauth.py (the package measures exactly 33,335 on fc8641e3d4); that is the Backend Tests (3.12, 2) red on the previous head. No other change. Maintainers will need to Approve and run once more.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 3, 2026
buluoray
buluoray previously approved these changes Nov 3, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approve at befd2e2.

What it does for users. Adds TickTick to the Connections registry with launch_gate_passed: false, so it is registered but not offered as a one-click card yet. It adds TickTick's consent endpoint to the OAuth banner allowlist, so a TickTick sign-in link (from this card later, or from a hand-configured TickTick MCP server today) is not refused as a high-entropy exfil URL. It also renames TickTick's bare search, fetch and list_projects tools when another server ships the same names.

What I checked

  • The allowlist entry is the exact (host, path) pair TickTick advertises. I fetched https://mcp.ticktick.com/.well-known/oauth-protected-resource (authorization server https://ticktick.com/, scopes tasks:read and tasks:write) and https://ticktick.com/.well-known/oauth-authorization-server (authorization_endpoint is https://ticktick.com/oauth/authorize, dynamic registration, PKCE). The entry matches, and the registry's l0_expectations (DCR true, PKCE true) match the live documents.
  • The change to the security gate is one exact pair in a frozenset of (host, path) tuples, so it exempts only that consent path on that host. It adds no pattern and no new machinery.
  • The scope pair is TickTick's whole published list; it offers no read-only scope. The gotcha copy says the grant can delete tasks, tags, project groups, focus records and comments, which is the right warning to show.
  • Tests on this head: test_security_oauth_urls.py, test_connections_registry.py, test_connections_doc.py, test_connections_tool_aliases_decision_table.py and test_security_gate_liveness.py, 362 passed.
  • Mutation: removing the ("ticktick.com", "/oauth/authorize") row from _OAUTH_AUTHORIZATION_ENDPOINTS turns test_connections_registry.py::test_every_registry_mcp_authorization_server_is_banner_allowlisted red. Restored, tree clean.
  • git merge-tree --write-tree against current main exits 0.

CI. 78 success, 12 skipped. The three red checks are not about this diff: Security Scope Review and Internal Content Scan report that they did not finish (no verdict), and Sensitive Change Review waits for the template below.

Follow-up (non-blocking). revoke_verified_note is "pending manual check". That should be done before the launch gate flips to true.

Sensitive change review

  • Head commit: befd2e2
  • What rule changed: one (host, path) pair, ("ticktick.com", "/oauth/authorize"), is added to _OAUTH_AUTHORIZATION_ENDPOINTS in security/exfil_oauth.py, the allowlist of OAuth consent endpoints whose query entropy the banner exfil gate exempts.
  • Before -> after (what was allowed/blocked, now): before, a TickTick consent URL carrying a PKCE challenge and state was refused as a high-entropy URL. After, a URL at exactly https://ticktick.com/oauth/authorize passes the entropy check; every other path on ticktick.com and every other host is judged as before.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): data encoded in the query of a link to that single consent path is not flagged. The path is TickTick's own authorization page, which a third party cannot read query data from, so the exposure is limited to that one endpoint.
  • Evidence checked (which sandbox result proves it): the live RFC 9728 and RFC 8414 documents name exactly this endpoint. Removing the row reddens test_every_registry_mcp_authorization_server_is_banner_allowlisted.
  • No regression:
    • Tools still work (which tools/commands were run, result): the OAuth URL corpus and gate liveness suites pass (362 passed across the five files above).
    • Backward compatible (old config / old data / old callers still work, how checked): the change only adds a registry entry and an allowlist pair; existing entries are byte-identical apart from a trailing comma, checked in the diff.
    • Existing tests (which suites passed on this head): test_security_oauth_urls.py, test_connections_registry.py, test_connections_doc.py, test_connections_tool_aliases_decision_table.py, test_security_gate_liveness.py.
  • How to undo: revert the commit. The registry entry and the allowlist pair are removed together, and TickTick consent URLs are refused again as before.

@martchellop

Copy link
Copy Markdown
Contributor Author

On befd2e276d every lane that read the diff is green (CI, Build, Code Review, Opus 5.5 ✅ no findings, GPT 6.1, Design, UX, First Principles, Fast Gate, Issue Gate, PR Policy, Dependency License, macOS). PR Readiness reads "2 blocking readiness item(s)": the fork Security Scope Review (run 41685615870) and fork Internal Content Scan (run 41685616261) both stopped at Checkout base (trusted) before reading the diff, so they report "scope never resolved" / "NO VERDICT"; the Denial Differential ubuntu leg was cancelled at the same checkout step (windows and macos legs passed). Same infra flake as on 10/30, which cleared on rerun. I have no rerun rights here; a maintainer Re-run failed jobs on those two lanes should settle readiness. Sensitive Change Review remains the known fork-refused gate (takeover note above). No code change.

@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: @martchellop thanks for the clear takeover note. This change now continues in #29289: your commit cherry-picked unchanged onto current main, with you as Co-authored-by, Supersedes #26407 in the body, and the Sensitive change review template posted for that head. I will close this PR once #29289 merges.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 3, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from befd2e2 to 393eef4 Compare November 4, 2026 14:27
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from 393eef4 to 38cfdbd Compare November 4, 2026 16:52
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 4, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from 38cfdbd to f8cc342 Compare November 4, 2026 20:47
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
Add TickTick's hosted MCP server (https://mcp.ticktick.com) to the
Connections registry as a tier-2 project-management entry with
launch_gate_passed=false, so the Connect grid does not change until the
manual launch-gate check passes. Sign-in is OAuth with dynamic client
registration and PKCE, so no operator app and no per-host install.

The entry requests tasks:read plus tasks:write, the whole scopes_supported
list the resource metadata publishes; TickTick offers no read-only MCP
scope and the card copy says so and names the server's delete tools.
TickTick's consent URL (ticktick.com/oauth/authorize) joins the OAuth
banner allowlist and the URL corpus.

TickTick ships bare search and fetch tools like Atlassian, Neon and
Todoist, and a list_projects like Linear and Vercel, so it declares
ticktick_search, ticktick_fetch and ticktick_list_projects and joins the
bare search/fetch group in the alias decision table. The user doc counts
30 providers and eight rename declarers; the spec roster gains a row and
ProviderLogo.tsx maps logos/ticktick.svg (the CC0 simple-icons mark).

Closes kirodotdev#26388
@martchellop
martchellop force-pushed the feat/connections-ticktick branch from f8cc342 to 5ef3bf4 Compare November 4, 2026 22:10
@martchellop

Copy link
Copy Markdown
Contributor Author

Amended the single commit (f8cc342dc3 → 5ef3bf4a80) with one copy fix to TickTick's gotcha_copy in registry.json, resolving the Opus 5.5 finding on #29289: the rename sentence now says renames happen only when another catalogue provider declaring the same tool names is connected, and that a custom MCP server triggers none. No other change; the same line is offered on #29289 as a one-click suggestion.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
@buluoray

buluoray commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: Superseded by #29289, which merged as 4063b47 with @martchellop as co-author. Thanks for the TickTick connector!

@buluoray buluoray closed this Nov 5, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 5, 2026
@martchellop
martchellop deleted the feat/connections-ticktick branch November 5, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connections: add TickTick (hosted MCP, OAuth DCR + PKCE)

2 participants