Repository navigation
feat(connections): register TickTick, launch-gated - #26407
martchellop wants to merge 1 commit into
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change adds one hidden catalogue entry that follows the Todoist pattern, and it removes nothing. Notes
[DESIGN-REVIEWED] befd2e2 Description read[DESCRIPTION-READ] 5d3daf0152829d09b3d6efbfb6402059a0b2dca2ba157e589f03722202ca7845 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every item is catalogue data that stays hidden behind Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: let TickTick users connect TickTick's hosted MCP server from the Connections catalogue, hidden until the manual launch gate passes. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] befd2e2 Description read[DESCRIPTION-READ] 7ad2154af384c74f5466dfd80febdba80e602a5088f32e1de7c077343a56ff10 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The TickTick card is hidden behind the launch gate ( Notes
[UX-REVIEWED] befd2e2 Description read[DESCRIPTION-READ] 5d109aa0145a62e805a94eed874e89b6d90bd3d271bac9593fd852a2f20414ee That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Security Scope Review (fork) — ✅ PASSWhich legitimate operations does adjudicated, zero confirmed regressions Scope-Verdict: PASS Reason: This patch makes nothing stricter. Its only security change adds one exact TIGHTENING: none — the one security-relevant hunk loosens the ACP banner OAuth-entropy carve-out ( ADJUDICATED: 14 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix and windows. The diff itself makes no path, separator, interpreter or executable assumption; the new pair is an exact host plus a case-sensitive path, and is the same on every host. The posix rows cover the RFC 9728 and RFC 8414 discovery reads against UNADJUDICATED: The guard is the ACP banner-safety URL check. An OAuth consent URL from an MCP server's auth flow takes this path: [SCOPE-REVIEWED] 65c7145Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. |
91e92f3 to
93743a9
Compare
The UX note (lead the card text with the write/delete line) is also applied in 93743a9: |
|
Note for maintainers: this PR needs an in-repo takeover to pass The one-line addition to Per the gate's own remedy: a maintainer recreates the branch in this repository, keeps
|
93743a9 to
65c7145
Compare
|
Re-pushed: |
65c7145 to
fc8641e
Compare
|
Rebased onto main ( |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve at befd2e2.
What it does for users. Adds TickTick to the Connections registry with launch_gate_passed: false, so it is registered but not offered as a one-click card yet. It adds TickTick's consent endpoint to the OAuth banner allowlist, so a TickTick sign-in link (from this card later, or from a hand-configured TickTick MCP server today) is not refused as a high-entropy exfil URL. It also renames TickTick's bare search, fetch and list_projects tools when another server ships the same names.
What I checked
- The allowlist entry is the exact
(host, path)pair TickTick advertises. I fetchedhttps://mcp.ticktick.com/.well-known/oauth-protected-resource(authorization serverhttps://ticktick.com/, scopestasks:readandtasks:write) andhttps://ticktick.com/.well-known/oauth-authorization-server(authorization_endpointishttps://ticktick.com/oauth/authorize, dynamic registration, PKCE). The entry matches, and the registry'sl0_expectations(DCR true, PKCE true) match the live documents. - The change to the security gate is one exact pair in a frozenset of
(host, path)tuples, so it exempts only that consent path on that host. It adds no pattern and no new machinery. - The scope pair is TickTick's whole published list; it offers no read-only scope. The gotcha copy says the grant can delete tasks, tags, project groups, focus records and comments, which is the right warning to show.
- Tests on this head:
test_security_oauth_urls.py,test_connections_registry.py,test_connections_doc.py,test_connections_tool_aliases_decision_table.pyandtest_security_gate_liveness.py, 362 passed. - Mutation: removing the
("ticktick.com", "/oauth/authorize")row from_OAUTH_AUTHORIZATION_ENDPOINTSturnstest_connections_registry.py::test_every_registry_mcp_authorization_server_is_banner_allowlistedred. Restored, tree clean. git merge-tree --write-treeagainst current main exits 0.
CI. 78 success, 12 skipped. The three red checks are not about this diff: Security Scope Review and Internal Content Scan report that they did not finish (no verdict), and Sensitive Change Review waits for the template below.
Follow-up (non-blocking). revoke_verified_note is "pending manual check". That should be done before the launch gate flips to true.
Sensitive change review
- Head commit: befd2e2
- What rule changed: one
(host, path)pair,("ticktick.com", "/oauth/authorize"), is added to_OAUTH_AUTHORIZATION_ENDPOINTSinsecurity/exfil_oauth.py, the allowlist of OAuth consent endpoints whose query entropy the banner exfil gate exempts. - Before -> after (what was allowed/blocked, now): before, a TickTick consent URL carrying a PKCE challenge and state was refused as a high-entropy URL. After, a URL at exactly
https://ticktick.com/oauth/authorizepasses the entropy check; every other path on ticktick.com and every other host is judged as before. - Worst case if wrong (breaks commands / leaks secret / locks user out): data encoded in the query of a link to that single consent path is not flagged. The path is TickTick's own authorization page, which a third party cannot read query data from, so the exposure is limited to that one endpoint.
- Evidence checked (which sandbox result proves it): the live RFC 9728 and RFC 8414 documents name exactly this endpoint. Removing the row reddens
test_every_registry_mcp_authorization_server_is_banner_allowlisted. - No regression:
- Tools still work (which tools/commands were run, result): the OAuth URL corpus and gate liveness suites pass (362 passed across the five files above).
- Backward compatible (old config / old data / old callers still work, how checked): the change only adds a registry entry and an allowlist pair; existing entries are byte-identical apart from a trailing comma, checked in the diff.
- Existing tests (which suites passed on this head):
test_security_oauth_urls.py,test_connections_registry.py,test_connections_doc.py,test_connections_tool_aliases_decision_table.py,test_security_gate_liveness.py.
- How to undo: revert the commit. The registry entry and the allowlist pair are removed together, and TickTick consent URLs are refused again as before.
|
On |
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: @martchellop thanks for the clear takeover note. This change now continues in #29289: your commit cherry-picked unchanged onto current main, with you as |
befd2e2 to
393eef4
Compare
393eef4 to
38cfdbd
Compare
38cfdbd to
f8cc342
Compare
Add TickTick's hosted MCP server (https://mcp.ticktick.com) to the Connections registry as a tier-2 project-management entry with launch_gate_passed=false, so the Connect grid does not change until the manual launch-gate check passes. Sign-in is OAuth with dynamic client registration and PKCE, so no operator app and no per-host install. The entry requests tasks:read plus tasks:write, the whole scopes_supported list the resource metadata publishes; TickTick offers no read-only MCP scope and the card copy says so and names the server's delete tools. TickTick's consent URL (ticktick.com/oauth/authorize) joins the OAuth banner allowlist and the URL corpus. TickTick ships bare search and fetch tools like Atlassian, Neon and Todoist, and a list_projects like Linear and Vercel, so it declares ticktick_search, ticktick_fetch and ticktick_list_projects and joins the bare search/fetch group in the alias decision table. The user doc counts 30 providers and eight rename declarers; the spec roster gains a row and ProviderLogo.tsx maps logos/ticktick.svg (the CC0 simple-icons mark). Closes kirodotdev#26388
f8cc342 to
5ef3bf4
Compare
|
Amended the single commit ( |
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: Superseded by #29289, which merged as 4063b47 with @martchellop as co-author. Thanks for the TickTick connector! |
Problem / Motivation
Goal: TickTick users get a one-click, catalogue-governed Connect for TickTick's hosted MCP server, hidden behind the launch gate until the manual check passes.
The Connections catalogue has no TickTick entry. A user who wants an agent to read and manage their TickTick tasks has to add
https://mcp.ticktick.comby hand on the MCP Servers tab, and gets none of the catalogue's guarantees: no nightly OAuth metadata watch, no consent-banner allowlisting, no card copy saying what the grant can do, and no rename declaration when another connected server also shipssearchandfetch.Why it matters
TickTick runs its own hosted MCP server and documents the connection for Claude, ChatGPT, Cursor, VS Code, Codex and Claude Code, so it is a catalogue-grade provider. A registry entry gives it the same treatment as the other 29: Connect, the L0 metadata probe, the banner allowlist and the card copy. Nothing is installed on the host; kiro-cli runs the sign-in and keeps the token, the same way on macOS, Windows and Linux.
Not a goal
launch_gate_passed: the Connect grid renders the same cards as main until a human walks the flow on a test gateway with a real TickTick account.revoke_verified_notesayspending manual check, like Todoist's did.What changed (motivation → approach → change)
TickTick joins
src/kiro_crew/connections/registry.jsonhidden, mirroring the Todoist entry (#14177). The entry is tier 2,project-management, withlaunch_gate_passed: false.The sign-in shape comes from live discovery on 2026-10-30.
https://mcp.ticktick.com/.well-known/oauth-protected-resourcenameshttps://ticktick.com/as the authorization server andtasks:read/tasks:writeas the wholescopes_supportedlist;https://ticktick.com/.well-known/oauth-authorization-serveradvertisesregistration_endpointhttps://api.ticktick.com/oauth/register(dynamic registration),authorization_endpointhttps://ticktick.com/oauth/authorize, theauthorization_codegrant and PKCES256. So the entry uses DCR + PKCE,l0_expectationsrecords issuerhttps://ticktick.com,dcr: true,pkce: true,verified_on: 2026-10-30, andpython -m kiro_crew.connections.l0_probepasses for all 30 providers on this head.The entry requests both scopes. TickTick offers no read-only MCP scope, so the entry's
gotcha_copy(reference text, not rendered on the card) leads with the fact that the grant can write and names the server's delete tools (delete_task,delete_tag,delete_project_group,delete_focus,delete_comment), which run at the user's own permission level. The consent URLticktick.com/oauth/authorizejoins_OAUTH_AUTHORIZATION_ENDPOINTSinsecurity/exfil_oauth.pyand the URL corpus.TickTick ships bare
searchandfetch, like Atlassian, Neon and Todoist, and its smoke fixture is its ownlist_projects, the tool Linear and Vercel already rename, so it declaresticktick_search,ticktick_fetchandticktick_list_projects. A rename fires per colliding tool, only while two servers that ship it are connected together.ticktick_search,ticktick_fetch,todoist_search,todoist_fetchgitlab_search,ticktick_search;fetchkeeps its namelinear_list_projects,ticktick_list_projects;searchandfetchkeep their namessearch,fetchandlist_projects, unchanged🟩 added · 🟦 unchanged
The user doc (
docs/connections.md,docs/index.md) now counts 36 providers (30 at authoring; six Google Workspace entries landed on main since) and eight rename declarers. The spec roster indocs/system-specs/modules/connections.mdgains a TickTick row, andProviderLogo.tsxmaps the newlogos/ticktick.svg, the CC0 simple-icons mark (https://simpleicons.org/?q=ticktick, path fromicons/ticktick.svgin simple-icons/simple-icons), reduced to the same single-pathviewBox="0 0 24 24"shape as the other masked marks.Backwards compatibility
Compatible: the registry gains one hidden entry and its rename declarations, and nothing main accepts is rejected or removed. The renames run through the existing alias pass and apply only while two servers exposing the same tool are connected together.
Removes nothing: every touched file gains lines; no key, path, function or row is removed or renamed.
Tests
test/test_connections_registry.py: TickTick is on the roster and launch-gated.test_ticktick_requests_both_scopes_and_admits_the_grant_can_writepins the endpoint, the two scopes, the write disclosure, the five delete tools named in the copy, and the three-entry alias map.test/test_connections_tool_aliases_decision_table.py: TickTick joins the baresearch/fetchgroup. TickTick + Todoist renames all four tools, TickTick + GitLab renames onlysearch, TickTick + Linear renames onlylist_projects, and TickTick alone keeps its names.connections_tool_aliases_helpers.pylearns the URL.test/test_connections_doc.py: the alias clause's count word now goes up to eight.test/oauth_url_corpus.py: a TickTick consent URL carrying both scopes, which the banner allowlist must accept.test/test_security_gate_liveness.py:_PACKAGE_LINE_BUDGETgoes from 33,723 to 33,724 for the one allowlist line inexfil_oauth.py, with the house-style#:note.Ran locally on this head: the 26 test files that reference the touched modules (1465 passed),
isort --check-onlyandflake8onsrc/kiro_crew test conftest.py xdist_budget.py,tsc -p tsconfig.app.json,eslint src/pages/connections, and the vitest files that read the registry orProviderLogo(ConnectionsPage.owners,ConnectionsPage.coverage,IssueRadarProviderBadge: 89 passed).scripts/local-gate.py's backend lane 1 reports 34 failures on this host that are independent of the diff (test_acp_spawn_offload,test_cli::TestDoctor,test_cli_stt_memory_doctor,test_acp_tool_gate: the host carries a Copilot~/.mcp.jsonand a symlinked home); CI is the authority for those.Manual verification
Done:
initializeagainsthttps://mcp.ticktick.comreturns401withWWW-Authenticate: Bearer ... resource_metadata="https://mcp.ticktick.com/.well-known/oauth-protected-resource", so RFC 9728 discovery starts from the server itself.python -m kiro_crew.connections.l0_probeon this head: 30 of 30 providers ok, TickTick observedauthorization_server https://ticktick.com, dcr true, pkce true.list_projectswith{"limit": 1}and the five delete tools named in the copy come from the server's published 58-tool roster as seen by a connected client; no signed-intools/listwas run from this checkout.Still owed before the card goes visible (the launch-gate check, on a test gateway with a real TickTick account):
https://ticktick.com/webapp/#settingswith the manual path to the account's authorized apps; refreshrevoke_page_url,revoke_manual_pathandrevoke_verified_notefrom what the logged-in check finds).tasks:read tasks:writeas requested, and that a token refresh works across a session held past expiry.tools/liston the live server: confirm baresearch,fetchandlist_projectsare present and that the delete tools listed in the copy are the right names; with Todoist also connected, the agent sees the renamed tools.Screenshots / video
Why no screenshot: TickTick ships with
launch_gate_passed=false, so the Connect grid renders the same cards as main; the new logo renders only once the launch gate flips.Related Issues
Closes #26388
Prior art: #14177 (Todoist), the entry this one mirrors.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)