Repository navigation
fix(acp): offer a KAS MCP sign-in only when the user names the server - #26481
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: removing the automatic offer fixes the defect in #24614, and the name trigger is the only sign-in path left on KAS. Two items carry more than the Goal needs. Notes
What this change shipsInventory (8 items) — 6 justifiedIntent: KAS users stop seeing Authorize cards for MCP servers they never mentioned. FIX.
[FIRST-PRINCIPLES-REVIEWED] 9b5722c Description read[DESCRIPTION-READ] a536765c5bf4f8790e14b55702d90301c78b0334d6b94a24d22df4521bd61fbd That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the fix removes the unprompted offer policy at its one call site, and the old rotation field has no readers left in the tree. Notes
[DESIGN-REVIEWED] 9b5722c Description read[DESCRIPTION-READ] ba7d4be22fa003ad73135d0fd0d16dab77fcfaeb78b9aaaaf86740f766f144b0 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
edd2af7 to
976cf77
Compare
|
976cf77 to
c7ea7cd
Compare
c7ea7cd to
42e3ead
Compare
42e3ead to
6b1c921
Compare
6b1c921 to
f36534b
Compare
|
On KAS every chat offered a sign-in to every unsigned remote MCP server at turn start and on every status snapshot, rotating to the next server after each timeout. An Authorize card for a server the chat never used showed up after any message, even "test". Being unsigned no longer starts a sign-in. The dashboard runner hands the person's own typed message to the provider; a server is offered only when that message names it, once per ask. Automated, slash and expanded turns hand nothing over. Takes over #24701 without its MCP-menu Sign in route, whose open review findings belong to that second trigger. Co-authored-by: Kyle Seaman <2904635+kyleseaman@users.noreply.github.com>
4642418 to
9b5722c
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen), hotfix watch. Lanes pass on 9b5722c, no conflict, no open change request.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56)
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent.
Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent. - fix(acp): remove a new KAS session's app launch snapshots at shutdown (#28954) (cherry picked from commit 1217a85) adapted: only this PR's launch_snapshots lines (request_identity is another PR's); 0.11.0's hoist_managed_servers name; the two test_runtime_bindings signature digests re-measured.
…28835) Each main PR below was cherry-picked with -x in merge order, oldest first, then squashed (PR Hygiene allows two commits). - fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952) (cherry picked from commit 3a46e60) adapted: 0.11.0's extra-hook branch keeps its from_spec line; the facade shape digest is re-measured. - fix(acp): send a KAS session the kiro-cli spelling of a stored model id (#25671) (cherry picked from commit 7df9837) adapted: three assertions on a pin-refusal field 0.11.0's handle lacks are left out of the test. - fix(kas): start Crew's own MCP servers first so session start does not wait behind slow user servers (#26148) (cherry picked from commit 429b4f7) adapted: 0.11.0 names the hoist hoist_managed_servers. - fix(acp): offer a KAS MCP sign-in only when the user names the server (#26481) (cherry picked from commit 2718088) adapted: the regenerate and chat-runner hunks keep 0.11.0's call shapes and add only this PR's lines. - fix(kas): start env-bearing MCP servers through a local launcher (#26785) (cherry picked from commit d6bb74f) adapted: hoist_managed_servers name; only this PR's handle field and agent_specs helper; the security line budget and the leaf-only population pin are re-measured for the kas-mcp-launch leaf. - fix(kas): refuse a blank kas remove --version instead of deleting every engine (#26623) (cherry picked from commit 2183c96) - fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli (#28437) (cherry picked from commit 3fc4217) adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which does not carry the sentence this PR rewrote; security.md moves. - fix(kas): split an authored rule's long match instead of refusing the block (#28510) (cherry picked from commit 60595c7) adapted: its agent-spec-fields.md sentence lands on 0.11.0's permissions row. - fix(kas): carry session identity to builtin app MCP servers (#28732) (ported by hand from commit 8e9701f) adapted: 0.11.0 has no managed-entry resolution or vault identity on SessionExtras, so the harness returns only the app launches beside the payload; hoist_managed_servers takes app_launches beside resume=; acp-client.md drops the managed-entry sentence 0.11.0 lacks. - fix(kas): relay a remote MCP server's headers through a local bridge (#28615) (cherry picked from commit 755c71b) adapted: its test calls 0.11.0's hoist_managed_servers. - fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852) (cherry picked from commit 83a76fc) - feat(kas): keep remote MCP sign-ins across sessions by default (#28630) (cherry picked from commit 00dc406) adapted: cli_config.py takes only the ack helper and its call sites; configuration.md and the decisions index take only this PR's rows; the decision record names the shared-crew spec, absent on 0.11, without a backticked path so docs-lint passes. - fix(mcp): heal a saved absolute Windows command's PATHEXT extension (#25945) (cherry picked from commit a96eb1f) - fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795) (cherry picked from commit 2af230d) - fix(project-dir): treat an EPERM marker probe as absent so MCP start-up survives a masked mount (#28595) (cherry picked from commit 742ae56) - fix(kas): judge a remote-wrapper web search as its built-in (#28704) (cherry picked from commit 54f4e14) adapted: security.md gets this PR's one inserted clause on 0.11.0's wording of the same bullet. - fix(dashboard): give every MCP handler error a stable code (#26661) (cherry picked from commit 14bd1a5) adapted: error-code-baseline.json regenerated with its generator on 0.11.0's tree (the same mcp.py entry drops as on main). - fix(mcp): refuse to replace an unparseable global mcp.json (#28023) (cherry picked from commit 52184dd) adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main; learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0, stays absent. - fix(acp): remove a new KAS session's app launch snapshots at shutdown (#28954) (cherry picked from commit 1217a85) adapted: only this PR's launch_snapshots lines (request_identity is another PR's); 0.11.0's hoist_managed_servers name; the two test_runtime_bindings signature digests re-measured.
Since #26481 a replacement sign-in is offered only for a server the user named, so the replacement test names it. The mid-turn and dedupe fakes from main gain the two LLMProvider sign-in defaults the banner path now calls.
Since #26481 a replacement sign-in is offered only for a server the user named, so the replacement test names it. The mid-turn and dedupe fakes from main gain the two LLMProvider sign-in defaults the banner path now calls.
Since #26481 a replacement sign-in is offered only for a server the user named, so the replacement test names it. The mid-turn and dedupe fakes from main gain the two LLMProvider sign-in defaults the banner path now calls.
Problem / Motivation
Goal: On the KAS backend, a chat shows an MCP Authorize card only when the user's message names an unsigned server, and never at chat start.
Every new KAS chat offered a sign-in to every remote MCP server that was not signed in, at turn start and on every status snapshot, rotating to the next server about once a minute. A user typed "test" and got a "power-figma-figma requires authentication / Authorize power-figma-figma" card in a chat that never used Figma.
Why it matters
Any KAS user with an unsigned remote OAuth MCP server sees Authorize cards in every chat, unprompted. The cards push real content off screen, teach people to ignore Authorize cards, and make the chat look broken.
Not a goal
What changed (motivation → approach → change)
Cause:
_offer_mcp_sign_inoffered any server whose status saidfailedAuthorization, at every turn start and status snapshot, rotating after each timeout.An unsigned KAS server exposes no tools, so the agent can never call one; the trigger has to be the user's own words. The dashboard runner (
src/kiro_crew/dashboard/chat_runner.py) now hands the person's typed message (before@prompt/$skillexpansion, and only for a human send; never a composed prompt such as the OpenAI-compatible endpoint's flattened conversation (src/kiro_crew/dashboard/openai_compat.py) or a Spec Builder decision answer (src/kiro_crew/apps/builtins/spec_builder/backend/runtime.py,orchestration/decision_outbox.py), and never a turn restored from the on-disk queue) to a new no-op-by-defaultLLMProvider.note_user_message(src/kiro_crew/providers/base.py).AcpProvider(src/kiro_crew/providers/acp.py,src/kiro_crew/providers/acp_turns.py) passes it into that one attempt'sstream(), and the KAS session offers a needed server only when the message names it (its name or an obvious alias, whole word, any case; a multi-word name's last word alone never counts, sopower-aws-docs-searchis not named by "search the web"). One ask starts at most one sign-in, a server with a live card is not asked again, and the ask ends with its turn. Being unsigned alone never starts a sign-in. The spec indocs/system-specs/modules/acp-client.mdsays the same.This takes over Kyle Seaman's #24701 (co-authored), minus its MCP-menu Sign in route, handler, frontend button and link collector.
Backwards compatibility
Compatible: no API, config or stored data changes; a KAS chat only stops offering sign-ins nobody asked for.
Reader: src/kiro_crew/acp/session_handle_mcp.py:_offer_mcp_sign_in -- chat -- the only reader of
_mcp_sign_in_last_offered; now reads_mcp_sign_in_wantedinstead (test_kas_mcp_sign_in.py)Reader: test/test_kas_mcp_reattempt.py:_handle -- chat -- the fixture sets the new fields instead of the removed one
Tests
test/test_kas_mcp_sign_in.py: no card for an unnamed server at start or on a status snapshot; a named server is offered once per ask; a live card is not restarted; the ask does not leak into a later turn; alias matching, includingpower-aws-docs-search,acme:apiandacme:api-servernot matching everyday prose.test/test_chat_runner_mcp_sign_in_ask.py: only a human send hands over its typed text; expanded prompts, sub-agent failure prepends, slash, self-wake, generated, OpenAI-compatible, Spec Builder decision and restored-queue turns hand nothing.Proof: PROVEN test/test_acp_bindings.py::test_the_member_set_is_the_frozen_inventory, test/test_chat_runner_mcp_sign_in_ask.py::test_a_user_turn_hands_over_the_typed_message, test/test_chat_runner_mcp_sign_in_ask.py::test_an_expanded_prompt_server_name_is_not_handed_over, test/test_chat_runner_mcp_sign_in_ask.py::test_a_prepended_sub_agent_failure_is_not_handed_over, test/test_chat_runner_mcp_sign_in_ask.py::test_the_openai_compatible_endpoint_marks_its_prompt_as_composed (head 8ce1ce066836; same tree rebased as 976cf77)
Local gate: 25,701 passed; 2 red are not this PR (
test_context_measuredrewind ordinals is red on clean origin/main 376e0b7;test_beacongated setter passes alone).Manual verification
N/A — the KAS stub test drives a real KAS process through the sign-in path; unit tests cover each trigger and non-trigger.
Related Issues
Closes #24614
Supersedes #24701
Sibling sweep
Swept: git grep -n "begin_mcp_sign_in" -- src/
Sibling: src/kiro_crew/acp/session_handle_mcp.py -- changed here
Sibling: src/kiro_crew/acp/session_handle_turn.py -- changed here
Pattern harvest
Not generalizable: the defect is one offer policy ("offer whatever needs auth"), replaced at its single call site.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)