Skip to content

fix(acp): offer a KAS MCP sign-in only when the user names the server - #26481

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/kas-mcp-signin-on-demand
Oct 31, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/kas-mcp-signin-on-demand

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On the KAS backend, a chat shows an MCP Authorize card only when the user's message names an unsigned server, and never at chat start.

Every new KAS chat offered a sign-in to every remote MCP server that was not signed in, at turn start and on every status snapshot, rotating to the next server about once a minute. A user typed "test" and got a "power-figma-figma requires authentication / Authorize power-figma-figma" card in a chat that never used Figma.

Why it matters

Any KAS user with an unsigned remote OAuth MCP server sees Authorize cards in every chat, unprompted. The cards push real content off screen, teach people to ignore Authorize cards, and make the chat look broken.

Not a goal

What changed (motivation → approach → change)

Cause: _offer_mcp_sign_in offered any server whose status said failedAuthorization, at every turn start and status snapshot, rotating after each timeout.

An unsigned KAS server exposes no tools, so the agent can never call one; the trigger has to be the user's own words. The dashboard runner (src/kiro_crew/dashboard/chat_runner.py) now hands the person's typed message (before @prompt/$skill expansion, and only for a human send; never a composed prompt such as the OpenAI-compatible endpoint's flattened conversation (src/kiro_crew/dashboard/openai_compat.py) or a Spec Builder decision answer (src/kiro_crew/apps/builtins/spec_builder/backend/runtime.py, orchestration/decision_outbox.py), and never a turn restored from the on-disk queue) to a new no-op-by-default LLMProvider.note_user_message (src/kiro_crew/providers/base.py). AcpProvider (src/kiro_crew/providers/acp.py, src/kiro_crew/providers/acp_turns.py) passes it into that one attempt's stream(), and the KAS session offers a needed server only when the message names it (its name or an obvious alias, whole word, any case; a multi-word name's last word alone never counts, so power-aws-docs-search is not named by "search the web"). One ask starts at most one sign-in, a server with a live card is not asked again, and the ask ends with its turn. Being unsigned alone never starts a sign-in. The spec in docs/system-specs/modules/acp-client.md says the same.

This takes over Kyle Seaman's #24701 (co-authored), minus its MCP-menu Sign in route, handler, frontend button and link collector.

Backwards compatibility

Compatible: no API, config or stored data changes; a KAS chat only stops offering sign-ins nobody asked for.

Reader: src/kiro_crew/acp/session_handle_mcp.py:_offer_mcp_sign_in -- chat -- the only reader of _mcp_sign_in_last_offered; now reads _mcp_sign_in_wanted instead (test_kas_mcp_sign_in.py)
Reader: test/test_kas_mcp_reattempt.py:_handle -- chat -- the fixture sets the new fields instead of the removed one

Tests

test/test_kas_mcp_sign_in.py: no card for an unnamed server at start or on a status snapshot; a named server is offered once per ask; a live card is not restarted; the ask does not leak into a later turn; alias matching, including power-aws-docs-search, acme:api and acme:api-server not matching everyday prose. test/test_chat_runner_mcp_sign_in_ask.py: only a human send hands over its typed text; expanded prompts, sub-agent failure prepends, slash, self-wake, generated, OpenAI-compatible, Spec Builder decision and restored-queue turns hand nothing.

Proof: PROVEN test/test_acp_bindings.py::test_the_member_set_is_the_frozen_inventory, test/test_chat_runner_mcp_sign_in_ask.py::test_a_user_turn_hands_over_the_typed_message, test/test_chat_runner_mcp_sign_in_ask.py::test_an_expanded_prompt_server_name_is_not_handed_over, test/test_chat_runner_mcp_sign_in_ask.py::test_a_prepended_sub_agent_failure_is_not_handed_over, test/test_chat_runner_mcp_sign_in_ask.py::test_the_openai_compatible_endpoint_marks_its_prompt_as_composed (head 8ce1ce066836; same tree rebased as 976cf77)

Local gate: 25,701 passed; 2 red are not this PR (test_context_measured rewind ordinals is red on clean origin/main 376e0b7; test_beacon gated setter passes alone).

Manual verification

N/A — the KAS stub test drives a real KAS process through the sign-in path; unit tests cover each trigger and non-trigger.

Related Issues

Closes #24614
Supersedes #24701

Sibling sweep

Swept: git grep -n "begin_mcp_sign_in" -- src/
Sibling: src/kiro_crew/acp/session_handle_mcp.py -- changed here
Sibling: src/kiro_crew/acp/session_handle_turn.py -- changed here

Pattern harvest

Not generalizable: the defect is one offer policy ("offer whatever needs auth"), replaced at its single call site.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 31, 2026 00:08
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 9b5722cecaa572682222ebf53320274cf048c543 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@bolichen97
bolichen97 enabled auto-merge (squash) October 31, 2026 00:09
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 9b5722cecaa572682222ebf53320274cf048c543 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: removing the automatic offer fixes the defect in #24614, and the name trigger is the only sign-in path left on KAS. Two items carry more than the Goal needs.

Notes

  • Item 3 — oversized: mcp_server_aliases adds namespace-tail, mcp/server-suffix and repeated-word rules. The only reported case is power-figma-figma. Subtraction: shrink the aliases to the configured name plus the power- prefix strip, and drop the namespace: form and _GENERIC_NAME_SUFFIXES until someone reports a missed name.
  • Item 8 — zero consumers: test/test_kas_mcp_reattempt.py:114 sets handle._mcp_sign_in_offered, but nothing in src/ reads it (grep _mcp_sign_in_offered: 0 hits). The description says the fixture "sets the new fields", but the new fields are _mcp_sign_in_ask/_asked. Subtraction: delete that line.

What this change ships

Inventory (8 items) — 6 justified

Intent: KAS users stop seeing Authorize cards for MCP servers they never mentioned. FIX.

  1. A KAS chat no longer shows an Authorize card at start or on status snapshots, and no longer rotates through servers — justified
  2. Naming an unsigned server in a typed message shows its Authorize card once per ask — justified
  3. Name matching uses heuristic aliases (namespace, power prefix, generic suffixes) — oversized
  4. OpenAI-compatible requests, Regenerate and Spec Builder decision answers never start a sign-in (_message_is_typed=False) — justified
  5. A second message naming a server whose card is still live starts no new card — justified
  6. New LLMProvider.note_user_message hook, a no-op by default — justified
  7. sign_in_ask argument passed through stream/prompt/_run_turn for that one attempt — justified
  8. Test fixture sets an unread _mcp_sign_in_offered field — zero consumers

[FIRST-PRINCIPLES-REVIEWED] 9b5722c

Description read

[DESCRIPTION-READ] a536765c5bf4f8790e14b55702d90301c78b0334d6b94a24d22df4521bd61fbd

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9b5722cecaa572682222ebf53320274cf048c543 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the fix removes the unprompted offer policy at its one call site, and the old rotation field has no readers left in the tree.

Notes

  • The flag fails open. _message_is_typed defaults to True in _run_chat, so a new caller that composes its prompt offers sign-ins unless someone remembers to opt out. _directive_user_origin bounds this today; a default of False, with human sends opting in, would fail closed.
  • There is now no way to discover a KAS sign-in. Per the spec, a request like "check my design files" "gets no card", and Settings does not reach KAS. A user with an unsigned server sees nothing that says it needs a sign-in, so the follow-up menu route (fix(acp): offer a KAS MCP sign-in only when the user names the server #24701's Sign in action) matters more than the description suggests.

[DESIGN-REVIEWED] 9b5722c

Description read

[DESCRIPTION-READ] ba7d4be22fa003ad73135d0fd0d16dab77fcfaeb78b9aaaaf86740f766f144b0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9b5722cecaa572682222ebf53320274cf048c543 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9b5722c

Verdict parsed from the review's SHA-scoped output markers for commit 9b5722cecaa572682222ebf53320274cf048c543.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9b5722cecaa572682222ebf53320274cf048c543 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9b5722cecaa572682222ebf53320274cf048c543 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9b5722c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9b5722cecaa572682222ebf53320274cf048c543 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from edd2af7 to 976cf77 Compare October 31, 2026 00:27
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=6dd7854a8bdf OpenAI-compatible turns hand the flattened conversation to the sign-in trigger

fixed in 976cf77: _run_chat takes _message_is_typed (default True) and the hand-off requires it; openai_compat passes False, so a flattened system/assistant conversation never starts a sign-in.
Class swept: Spec Builder decision answers (composed from the agent's options) also pass False via _dispatch_turn(message_is_typed=False), and a turn restored from the on-disk queue (_turn_provenance_restored) hands nothing. Slack, regenerate, rewind and chat_send pass the person's own text.
Tests: test_a_composed_prompt_hands_over_nothing, test_the_spec_builder_dispatch_forwards_whether_its_text_was_typed, test_a_restored_queue_turn_hands_over_nothing.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in test/test_interactions_options.py since this head went green (fea0920 -> 798f3a3); CI re-running. Same push fixes the Backend Tests shard-4 red: test_run_chat_keeps_its_entry_signature now lists the new _message_is_typed parameter.

@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from 976cf77 to c7ea7cd Compare October 31, 2026 00:58
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 31, 2026
@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from c7ea7cd to 42e3ead Compare October 31, 2026 02:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 31, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/acp-client.md, src/kiro_crew/acp/session_handle_class.py and nearby acp/ files since this head went green (03f78f1 -> 4951c0c); CI re-running.

@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from 42e3ead to 6b1c921 Compare October 31, 2026 02:54
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 31, 2026
@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from 6b1c921 to f36534b Compare October 31, 2026 03:20
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=db37e66c9e96 Regeneration loses composed-message provenance

fixed in f36534b: api_chat_slot_regenerate passes _message_is_typed=False, so a replayed stored row (which may be an OpenAI-compatible flattened prompt) never reaches note_user_message.
Class swept: edit-and-resend and rewind keep the default because they dispatch the person's freshly edited body["content"]; recovery requeues carry a _turn_actor stamp and restored queue entries carry _turn_provenance_restored, both refused by the hand-off; OpenAI-compatible requests never enqueue (busy slot answers 409).
Test: test_every_regenerate_dispatch_replays_as_composed_text.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 31, 2026
On KAS every chat offered a sign-in to every unsigned remote MCP
server at turn start and on every status snapshot, rotating to the
next server after each timeout. An Authorize card for a server the
chat never used showed up after any message, even "test".

Being unsigned no longer starts a sign-in. The dashboard runner hands
the person's own typed message to the provider; a server is offered
only when that message names it, once per ask. Automated, slash and
expanded turns hand nothing over.

Takes over #24701 without its MCP-menu Sign in route, whose open
review findings belong to that second trigger.

Co-authored-by: Kyle Seaman <2904635+kyleseaman@users.noreply.github.com>
@bolichen97
bolichen97 force-pushed the fix/kas-mcp-signin-on-demand branch from 4642418 to 9b5722c Compare October 31, 2026 08:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 31, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen), hotfix watch. Lanes pass on 9b5722c, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain merged commit 2718088 into main Oct 31, 2026
97 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/kas-mcp-signin-on-demand branch October 31, 2026 12:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 31, 2026
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
- fix(kas): judge a remote-wrapper web search as its built-in (#28704)
  (cherry picked from commit 54f4e14)
  adapted: security.md gets this PR's one inserted clause on 0.11.0's
  wording of the same bullet.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
- fix(kas): judge a remote-wrapper web search as its built-in (#28704)
  (cherry picked from commit 54f4e14)
  adapted: security.md gets this PR's one inserted clause on 0.11.0's
  wording of the same bullet.
- fix(dashboard): give every MCP handler error a stable code (#26661)
  (cherry picked from commit 14bd1a5)
  adapted: error-code-baseline.json regenerated with its generator on
  0.11.0's tree (the same mcp.py entry drops as on main).
- fix(mcp): refuse to replace an unparseable global mcp.json (#28023)
  (cherry picked from commit 52184dd)
  adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main;
  learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's
  wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0,
  stays absent.
buluoray added a commit that referenced this pull request Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
- fix(kas): judge a remote-wrapper web search as its built-in (#28704)
  (cherry picked from commit 54f4e14)
  adapted: security.md gets this PR's one inserted clause on 0.11.0's
  wording of the same bullet.
- fix(dashboard): give every MCP handler error a stable code (#26661)
  (cherry picked from commit 14bd1a5)
  adapted: error-code-baseline.json regenerated with its generator on
  0.11.0's tree (the same mcp.py entry drops as on main).
- fix(mcp): refuse to replace an unparseable global mcp.json (#28023)
  (cherry picked from commit 52184dd)
  adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main;
  learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's
  wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0,
  stays absent.

- fix(acp): remove a new KAS session's app launch snapshots at shutdown
  (#28954)
  (cherry picked from commit 1217a85)
  adapted: only this PR's launch_snapshots lines (request_identity is
  another PR's); 0.11.0's hoist_managed_servers name; the two
  test_runtime_bindings signature digests re-measured.
chenmingwei23 pushed a commit that referenced this pull request Nov 3, 2026
…28835)

Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
- fix(kas): judge a remote-wrapper web search as its built-in (#28704)
  (cherry picked from commit 54f4e14)
  adapted: security.md gets this PR's one inserted clause on 0.11.0's
  wording of the same bullet.
- fix(dashboard): give every MCP handler error a stable code (#26661)
  (cherry picked from commit 14bd1a5)
  adapted: error-code-baseline.json regenerated with its generator on
  0.11.0's tree (the same mcp.py entry drops as on main).
- fix(mcp): refuse to replace an unparseable global mcp.json (#28023)
  (cherry picked from commit 52184dd)
  adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main;
  learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's
  wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0,
  stays absent.

- fix(acp): remove a new KAS session's app launch snapshots at shutdown
  (#28954)
  (cherry picked from commit 1217a85)
  adapted: only this PR's launch_snapshots lines (request_identity is
  another PR's); 0.11.0's hoist_managed_servers name; the two
  test_runtime_bindings signature digests re-measured.
iamwhatever pushed a commit that referenced this pull request Nov 3, 2026
Since #26481 a replacement sign-in is offered only for a server the user
named, so the replacement test names it. The mid-turn and dedupe fakes
from main gain the two LLMProvider sign-in defaults the banner path now
calls.
kyleseaman pushed a commit that referenced this pull request Nov 6, 2026
Since #26481 a replacement sign-in is offered only for a server the user
named, so the replacement test names it. The mid-turn and dedupe fakes
from main gain the two LLMProvider sign-in defaults the banner path now
calls.
kyleseaman pushed a commit that referenced this pull request Nov 6, 2026
Since #26481 a replacement sign-in is offered only for a server the user
named, so the replacement test names it. The mid-turn and dedupe fakes
from main gain the two LLMProvider sign-in defaults the banner path now
calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KAS chats offer MCP sign-in for every unsigned server, unprompted, in every chat

2 participants