Skip to content

chore(release): backport the last 0.11.1 hotfix fixes to release/0.11.0 - #26627

Merged
iamwhatever merged 1 commit into
release/0.11.0from
backport/0.11.1-hotfix-3
Oct 31, 2026
Merged

iamwhatever merged 1 commit into
release/0.11.0from
backport/0.11.1-hotfix-3

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship the last two 0.11.1 hotfix fixes from main to the 0.11.0 release line, after #26487 and #26594.

0.11.0 still refuses a relative file:// prompt with .. on KAS, and its cloud human-action guard recognises only one kind of agent process.

Why it matters

The release line is what users install. #26144 is a P0 fix (#26133); without this PR it reaches users only with 0.12.0. On 0.11.0 today, a process run with KIROCREW_RUNTIME_AGENT=1 and no KIROCREW_SESSION_KEY passes cloud.aws.assert_human_action (checked on this branch's base).

Not a goal

What changed (motivation → approach → change)

One commit; its message lists every pick and its source sha.

Main PR Picked/skipped Why
#26382 picked doc conflicts only; KAS file:// prompt check (acp/kas_prompt_paths.py, acp/kas_agents.py, acp/harness/kas.py)
#26144 picked P0; fix(cloud): treat every agent process as an agent in the human-action guard (cloud/aws.py, dashboard/handlers_cloud.py)
#24709 (part) picked only sandbox_launch_mark.py, its note() call in cli.py and its test reset; #26144 imports it
#26471 skipped a feature on KAS code only main has (ACP_BACKENDS_LOCAL_HARNESS_COMMANDS, switch_slot_model, the KAS bundle route)

#26382 keeps 0.11.0's acp-client.md and takes its path-fence bullets in src/kiro_crew/docs/agent-spec-fields.md. The #24709 piece is adapted only in words: the module docstring and the cli.py comment name the 0.11.0 reader, the cloud guard. test/conftest.py and test/conftest_resets.py gain #24709's reset fixture, so a test that sets the marker cannot leak it to later tests; test/conftest.py also hides the runner's own markers, as #26144 does on main. Two test-only fixes: test/test_cloud_aws.py pins SANDBOX_MARKER to the sandbox's own marker name, and test/test_prompt_override_encoding.py pins the browser CLI probe off, because the host's playwright-cli on PATH added a warning its counts read as a second override warning.

Backwards compatibility

Compatible: each change is its main PR's own. The cloud guard only adds refusals for processes Kiro Crew spawned for an agent; a human terminal and the dashboard's /api/cloud/* carry none of the markers.

Removes nothing: no API, key, row or path is removed.

Tests

The picked tests are the main PRs' own. Run on this head:

  • The changed test files (test_cloud_aws.py, test_kas_prompt_paths.py, test_kas_agents.py, test_kas_project_agents.py, test_prompt_override_encoding.py) with test_spawn_audit.py, every test_cloud* and test_kas_* file and test_cli.py: 4082 passed.
  • The 118 files that touch cloud.aws, assert_human_action or handlers_cloud, plus the CLI and sandbox facade tests: 5953 passed.
  • isort, flake8, mypy src/kiro_crew/, semgrep (repo rules, diff-scoped), black gate, docs-lint, comment history, flake-pattern ratchet: all pass.
  • Local GPT and Opus review: both PASS on this head (afdded4), no findings. An earlier Opus pass left one Low note (a docstring naming a test missing on 0.11.0); it is fixed by the marker pin test in test_cloud_aws.

Determinism: the tests are the main PRs' own, unchanged; their repeat and shuffled-order runs are recorded on each main PR.

Manual verification

N/A - every change was verified on its own main PR; this PR moves them to the release branch.

Screenshots / video

Why no screenshot: backend-only change with no visible output.

Related Issues

Part of #26133

Backport of #26382, #26144 and part of #24709. Follow-up to #26487 and #26594.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

Backports these main fixes to release/0.11.0 after #26487 and #26594:

- fix(kas): let a relative file:// prompt use .. like kiro-cli (#26382) (cherry picked from commit 36c95db)
- part of #24709 (cherry picked from commit d86c94a, partial): the
  sandbox_launch_mark module, its note() call in cli.main before the
  KIROCREW_SANDBOX_ACTIVE pop, and its per-test reset fixture. Nothing
  else of #24709 (its enterprise policy-cache tier) is included; the
  module docstring and the cli.py comment name the 0.11.0 reader.
- fix(cloud): treat every agent process as an agent in the human-action guard (#26144) (cherry picked from commit dd0dd62)

Conflict resolved by hand:
- #26382: keeps 0.11.0's acp-client.md (the paragraph it edits is not on
  0.11.0); agent-spec-fields.md takes its path-fence bullets and keeps
  0.11.0's blank-prompt fallback bullet.

Test-only fixes:
- test_cloud_aws pins sandbox_launch_mark.SANDBOX_MARKER to
  sandbox_tiers._IN_SANDBOX_MARKER (the #24709 test that pinned it on main
  is not on 0.11.0).
- test_prompt_override_encoding pins browser_cli.install.available() off:
  the context build probed the host's PATH for playwright-cli and counted
  its refusal warning as a second override warning.

Left out: #26471 is a feature built on KAS code only main has.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 31, 2026 07:21
@bolichen97
bolichen97 requested review from dodgeblaster and removed request for a team October 31, 2026 07:21
@github-actions

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox_launch_mark.py

  • No reasoning template for afdded4 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: afdded4ad1be2cf2d07929469fa93648f1953e29
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision afdded4ad1be2cf2d07929469fa93648f1953e29 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of afdded4ad1be2cf2d07929469fa93648f1953e29 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this PR copies two main fixes onto the release branch as they shipped, and every code dependency it imports already exists in this tree.

[DESIGN-REVIEWED] afdded4

Description read

[DESCRIPTION-READ] e041322fea0f8e54c3483720de40a5881e07c111772541953be0293b2bdc2d2c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of afdded4ad1be2cf2d07929469fa93648f1953e29 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports fixes already merged on main. Each item has a named harm, and the one deleted pin (the .. refusal) is reversed by a reported user defect quoted in the replacement test.

What this change ships

Inventory (9 items) — 6 justified

Intent: give 0.11.0 users the 0.11.1 hotfix fixes (KAS ../ prompts load, and the cloud guard catches every agent process). FIX.

  1. On KAS, a relative file://../prompts/x.md prompt in a user-level spec now loads, as it does on kiro-cli — justified
  2. A project-checkout spec's relative prompt must still stay inside its .kiro/agents (symlinks followed), and the checked target is what gets read — justified
  3. KAS prompt reads now refuse ~/.config/gh, app_receipt_secret and session_token_*.sig — rides along; not named in the description's table summary
  4. kirocrew cloud mutations are refused when KIROCREW_RUNTIME_AGENT or KIROCREW_HOST_PID is set, not only KIROCREW_SESSION_KEY — justified
  5. The cloud guard also refuses on the remembered sandbox marker or agents-cgroup confinement — justified
  6. New module sandbox_launch_mark, noted in cli.main before the marker is dropped — justified
  7. Test-suite fixtures that hide the runner's agent markers and reset the launch mark — justified
  8. A test pins the browser CLI probe off in test_prompt_override_encoding — rides along; declared test-only fix
  9. The agent-spec-fields.md path-fence bullets are rewritten to match — justified

[FIRST-PRINCIPLES-REVIEWED] afdded4

Description read

[DESCRIPTION-READ] 497e07cb533d69e97b86f6e941a7668009353dced190733b87425670db572769

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed afdded4ad1be2cf2d07929469fa93648f1953e29 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] afdded4

Verdict parsed from the review's SHA-scoped output markers for commit afdded4ad1be2cf2d07929469fa93648f1953e29.

False positive or not applicable? A repository writer can comment:
/ai-review override fable afdded4ad1be2cf2d07929469fa93648f1953e29 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of afdded4ad1be2cf2d07929469fa93648f1953e29 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] afdded4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt afdded4ad1be2cf2d07929469fa93648f1953e29 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 31, 2026
@iamwhatever
iamwhatever merged commit ebe1a37 into release/0.11.0 Oct 31, 2026
24 of 25 checks passed
@iamwhatever
iamwhatever deleted the backport/0.11.1-hotfix-3 branch October 31, 2026 07:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 31, 2026
KiroCrewCaptain pushed a commit that referenced this pull request Oct 31, 2026
…NGELOG) (#26648)

Declare release/0.11.0 as the 0.11.1 hotfix line in the dual-valid RC
spelling the version numbering policy requires: all three version files
move from 0.11.0 to 0.11.1-rc.1. Add the ## [0.11.1] - 2026-10-31
section, written from the three hotfix backports already on the branch
(#26487, #26594, #26627). Every earlier section is unchanged.

Co-authored-by: w <w@k.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants