Repository navigation
refactor: make core independent of the dev-fleet and pptx-maker apps - #27435
Conversation
2fb180e to
8da6429
Compare
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. This is a pure refactor. The Dev Fleet UI files moved without changes apart from import paths, and the user-facing [UX-REVIEWED] 42a910c Description read[DESCRIPTION-READ] e765e91ae53049eae2608a8c44e85405c7e838bb92a6d5467c6a3f4538a651bb That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Behaviour stays the same, and the readers outside the patch ( Notes
[DESIGN-REVIEWED] 42a910c Description read[DESCRIPTION-READ] 61bbd51c81923c7beb8945c58e699f4f9cebe7c3a0bf21d8c0f046d513f43875 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The seam is required by the AGENTS.md "core never hard-codes an app id" rule, but it is a general form with one consumer, and that consumer is due to leave. Notes
What this change shipsInventory (7 items) — 5 justifiedIntent: let the Dev Fleet and PPTX Maker apps leave the repo without breaking the core. This is an ADDITION (a refactor seam).
[FIRST-PRINCIPLES-REVIEWED] 42a910c Description read[DESCRIPTION-READ] 5b1dbfd2aa731145c1c6848ce468450fbbe43df566aac5b1f82ebd02734af81d That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
8da6429 to
7c69171
Compare
|
self-added: yes
|
7c69171 to
773b277
Compare
|
self-added: yes
|
|
self-added: yes
|
773b277 to
1f7c162
Compare
|
self-added: yes
|
86f7f01 to
8c98c31
Compare
|
[operator: bolichen97] Rebased onto main to clear a merge conflict: head 86f7f01 -> 8c98c31, base 1dd2be3 -> 169fa89. The only conflict was the import block of Local checks on the new head: scoped backend tests (901 passed), isort, flake8, mypy, tsc, Dev Fleet and i18n vitest (1265 passed), semgrep on the diff (0 findings). Local GPT and Opus reviews: no findings. AI-assisted, posted on behalf of bolichen97 |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Verdict: APPROVE on 8c98c31.
What it does. The core stops naming Dev Fleet and PPTX Maker. Dev Fleet's host needs (BUILD rlimit, deferred bound-port spawn, forwarded KIROCREW_DEVFLEET_* variables, the dev_fleet config section, the five strict-internal pod routes, the two relay-refused pod credential mints) move into the app's own host_grants.py, read through the new apps/builtin_host_grants.py. PPTX Maker's agent placeholders move into its own agent_placeholders.py. soffice discovery moves into a core soffice_discovery.py that both the file panel and PPTX Maker import. The Dev Fleet UI moves from pages/ and test/ into website/src/apps/dev-fleet/.
Behaviour preservation, checked against source and by import.
- I imported
_STRICT_INTERNAL_API_PATHS,kiro_relay.limits._LOCAL_CREDENTIAL_EXACTandvalidation._APP_OWNED_TOP_KEYSon the base (169fa89) and on this head. The sets are identical: 67, 11 and 1 entries respectively. apps/backend.py:KIROCREW_DEVFLEET_REPOis still forwarded only when non-empty.KIROCREW_DEVFLEET_BIN_*is still forwarded by prefix to every backend, as on main.KIROCREW_BOUND_PORTstill goes only to Dev Fleet, and the BUILD rlimit still applies only to Dev Fleet.backend_runtime/startup.py: the old single-app deferral becomes a loop overbound_port_apps(). For each app it keeps the same enabled-state re-check (is not True) and the same fail-closed activation re-vet. With one grant, the result is the same as before.pod_*MCP tools:mcp_tools/apps.pyanddev_fleet/agent_pod_api.pyare unchanged. The refusal while the app is off still comes from_require_enabled(403app_not_enabled), and the tools are still hidden by theTOOL_APPSrows. The package__init__now imports its route modules insideregister_routes. The gateway'shasattr(package, "register_routes")convention still finds it. No caller reachesdev_fleet.gateway_routesordev_fleet.agent_pod_apias a package attribute, so the lazy import breaks nothing.- UI move: I compared each moved file with its old path, ignoring import lines. Every file is unchanged apart from one relative
resolve(DIR, '..', '..'), one dynamic registry import path and one comment word.devFleetApi.test.tsgains the access-proxy case thatedgeChallengeAtDirectErrorSites.test.tsdrops. The/dev-fleetroute still lazy-loads the same component. - Removed symbols (
DEV_FLEET_APP_NAME,_BUILD_CAPABLE_APPS,_DEV_FLEET_DEFERRED,engine._which_within,engine._soffice_system_install_path,preview_tools.soffice_hint,_linux_soffice_hint, the oldpages/DevFleet*andtest/devFleetApipaths): every reader on current origin/main is a file this PR edits. A grep of the merged tree finds none left. Main has not touched any of the affected core, Dev Fleet or PPTX Maker files since this PR's base.git merge-tree --write-tree origin/mainexits 0.
Tests and mutations.
- I ran the PR's Python test files plus
test_dev_fleet_pod_agent_api.pylocally: 825 passed, 2 skipped, 5 failed. All 5 failures are intest_file_office_slides.py, withModuleNotFoundError: pypdfium2on this host. The same 5 fail the same way on the base commit, so they come from the environment and not from this diff. - Mutation 1: dropping
| _builtin_strict_internal_paths()fromserver_internal_paths.pyreddenstest_builtin_host_grants.py::test_the_core_tables_carry_the_grantsandtest_dev_fleet_pod_agent_api.py::test_every_route_is_named_in_the_strict_internal_table. - Mutation 2: making
_owns_pathreturn True reddens threetest_a_malformed_or_overreaching_row_raises[... own namespace]cases. - The tree was restored and clean after each mutation.
Source-only, not exercised.
- The file panel's
soffice_path()no longer falls through to PPTX Maker's managed preview-tools directory. On main that fallback could never findsoffice, because the managed directory only ever receives apdftoppmlauncher (preview_tools._launcher_paths). PATH and the fixed Windows roots are probed as before, so I see no user-visible change. The Windows lookup path was read, not run. _placeholder_valuesnow also catches an exception raised byplaceholder_values()itself, not only the import, and refuses a malformed result. Both fail closed to{}(no agent registered), the same outcome main had for an unknown app.- I did not run the frontend tests locally (
devFleetBoundary.test.ts, the i18n rename gate). CI covers them.
CI on this head. 59 check names have passed, 11 are skipped and 20 are still queued, including Backend Tests, Frontend Tests, the E2E lanes and Bundle Size Gate. The one red is Publish readiness signal, which failed on API rate limit exceeded for installation. That is infrastructure, not this diff, and PR Readiness is pending a re-check. Security Scope Review passed. The UX, Design, First Principles, GPT 6.1 and Opus 5.5 lanes all report PASS or no blocking findings on this head. No inline threads are open. The only earlier review is a dismissed approval on an older head.
Size. +1487/-672, of which about 600 lines are new tests and the soffice module is mostly moved code. The seam itself is 171 lines with validation that fails at load. For a change that lets two apps leave without a core edit, I think the size is justified.
Follow-ups, not blocking.
- #28355 (Design Tweak) adds a second, parallel loader (
builtin_agent_tools.py) with the same shape, and it also editsserver_internal_paths.py,app-kit-platform.mdandtest_dashboard_server_composition_contract.py. Whichever lands second will need a rebase at the import block and in the docs. One shared on-disk discovery helper for both seams would be worth a later pass. - The couplings listed in the PR body as remaining (the
pod_*mapping inmcp_tools/apps.py, thesecurity_posture.pyrows, the shippedpptx-makerskill) still name the apps. They need an App Kit equivalent before Dev Fleet ships from the registry. - §33 says the strict paths are "folded into
server._STRICT_INTERNAL_API_PATHS". The fold happens inserver_internal_paths.py, whichserverre-exports. It is accurate as written, but naming the owning module would help readers.
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: @bolichen97 #28355 merged first, so this PR now conflicts with main in the files both touch ( |
|
HOLD at 8c98c31. Three things hold this PR:
I found no concrete defect in the security-relevant files I read. To clear: rebase onto main, let CI finish green on the new head, and get a human maintainer's review of the host-grant seam. — crew-pr-reviewer (r142) |
8c98c31 to
8d8d522
Compare
|
[operator: bolichen97] Rebased onto main again because GitHub reported a merge conflict: head 8c98c31 -> 8d8d522, base 169fa89 -> 84ea89d. The conflict came from the design-tweak decoupling that landed on main. Both changes add a reader to Local checks on the new head: scoped backend tests including main's design-tweak seam tests (1037 passed), isort, flake8, mypy, tsc, Dev Fleet, design-tweak and i18n vitest (1505 passed), semgrep on the diff (0 findings). Local GPT and Opus reviews: no findings. This push dismissed the earlier approval, so the PR needs a fresh one. AI-assisted, posted on behalf of bolichen97 |
8d8d522 to
ce06cc7
Compare
|
[operator: bolichen97] Rebased onto main again because GitHub reported a merge conflict: head ce06cc7 -> 42a910c, base 234829d -> fc60e8b (earlier: 8d8d522 -> ce06cc7 on base 84ea89d -> 234829d).
Earlier round (ce06cc7): the conflict came from the Dev Fleet change on main that localizes the UPDATED column age and the prune toast. Local checks on 42a910c: related backend tests (882 passed, including both pptx-maker gates, host grants, soffice, office slides, spawn env, composition, startup and Dev Fleet / PPTX Maker app tests), the built-in adoption tests (213 passed), flake-pattern ratchet (64 passed), mypy (4000 files, clean), flake8, isort, black, subprocess-encoding, comment-history, brand, line-cap and docs-lint gates, Dev Fleet / PPTX Maker / i18n vitest (318 passed), and both i18n scripts. This push dismisses the existing approval, so the PR needs a fresh one. AI-assisted, posted on behalf of bolichen97 |
|
self-added: yes
AI-assisted, posted on behalf of bolichen97 |
|
/ai-review override first-principles ce06cc7 false-positive: The finding repeats a class already rebutted three times on this PR. Manifest config_keys are only known after refresh_app_config_keys runs at gateway boot, so moving dev_fleet there brings back an unknown-key warning on every launch; config_top_keys is the boot-time grant. Rebuttal: #27435 (comment) |
Human judgment recorded@bolichen97 recorded a false-positive release (class
This decision applies only to this commit. A new push requires a new judgment. |
chenmingwei23
left a comment
There was a problem hiding this comment.
Approved for bulk merge: readiness passed, no conflicts, checks green.
Dev Fleet and PPTX Maker are to leave this repository intact, so the core must stop importing them and naming them in its tables. What a built-in asks of the host (the BUILD rlimit, the bound port and its deferred spawn, forwarded KIROCREW_* variables, an app-owned config section, strict-internal routes, relay-refused credential mints) is now data in the app's own host_grants.py, read by the core through apps/builtin_host_grants.py. Only BUILTIN_NAMES packages are read, a row may grant only its own app and only paths under its own namespace, and a malformed row raises at load. PPTX Maker's agent placeholders move into the app's agent_placeholders.py. LibreOffice discovery and its install hint live once, in the core's soffice_discovery.py: the file panel's slide previews and PPTX Maker both import it. The Dev Fleet UI moves under website/src/apps/dev-fleet/. test_core_dev_fleet_pptx_maker_decoupling.py, on the shared core_app_independence scan, fails on any core module or script that imports either app. Part of #26967
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Verdict: APPROVE on 42a910c.
This is a re-review after the rebases. My earlier approval was on 8c98c31 and the push dismissed it.
What it does for users. Nothing changes for users. Dev Fleet and PPTX Maker behave as before, and the core no longer names either app. Dev Fleet's host needs (BUILD rlimit, deferred bound-port spawn, forwarded KIROCREW_DEVFLEET_* variables, the dev_fleet config section, the five strict-internal pod routes, the two relay-refused credential mints) are declared in the app's own host_grants.py and read through apps/builtin_host_grants.py. PPTX Maker's agent placeholders live in the app. soffice discovery is one core module that the file panel and PPTX Maker share. The Dev Fleet UI lives under website/src/apps/dev-fleet/.
What changed since 8c98c31, beyond picking up main. I ran git range-diff from 169fa89..8c98c31 to fc60e8b..42a910c. Everything outside the hunks below is identical.
server_internal_paths.py(conflict with #28355). Both loaders survive: the design-tweakinternal_paths as _builtin_agent_tool_pathsimport and this PR'sstrict_internal_paths as _builtin_strict_internal_pathsimport sit side by side. The fold sites are| _builtin_strict_internal_paths()into the strict set (line 245) and main's| _builtin_agent_tool_paths()into the mixed set (line 419). The module docstring is merged to describe both.test_dashboard_server_composition_contract.py(conflict with #28355)._DATA_MODULE_SOURCESnow lists both names forserver_internal_paths, and the comment is plural. This PR's earlier change to the bindings assertion is gone from the patch because #28355 already landed the same line on main.app-kit-platform.md. #27556 took §33 for Former built-in adoption, so this PR's section is renumbered §34 with its text unchanged. No file refers to either number.test_core_pptx_maker_decoupling.py(from #28337). That gate tolerated this PR's two pptx-maker imports and one literal asPENDING_IMPORTS/PENDING_NAME_REFERENCES, and its docstring said to delete them once this change landed. The PR deletes both sets, their filter and the filter's test, so the gate is now strict.DevFleetPage.tsxkeeps main's newfmtRelativeimport with the moved path. Main's newDevFleetPage.updatedColumnLocale.test.tsxmoves intowebsite/src/apps/dev-fleet/, and only its import lines change.
Behaviour preservation, checked by import. I imported server_internal_paths (every set it exports), kiro_relay.limits._LOCAL_CREDENTIAL_EXACT and validation._APP_OWNED_TOP_KEYS on current main (759a49c) and on this head. Every set is identical: strict 67, mixed 31, CSRF-safe methods 3, pre-audit deny statuses 2, relay local credential paths 11, app-owned config keys 1. The server's strict set is the same object as the data module's. Because the mixed set matches main, the design-tweak fold still takes effect. Because the strict set matches main, this PR's fold reproduces the routes main still lists by hand. A grep of the head finds no reader left for any removed symbol.
Tests and mutations.
- I ran this PR's Python test files plus the Dev Fleet pod API, built-in agent tools, design-tweak and auto-research decoupling and dashboard composition guard/owner/reach tests: 974 passed, 2 skipped, 5 failed. The 5 failures are in
test_file_office_slides.py(pypdfium2is missing on this host). The same 5 fail the same way on main, so they come from the environment. - The Dev Fleet folder plus the i18n rename-sources and edge-challenge vitest files: 12 files, 212 tests passed.
- Main has moved to 642d833 since the rebase.
git merge-tree --write-treeexits 0. On that merged tree, I ran the preview-tools tests (#28972 edited them since), soffice, both decoupling gates, host grants and the composition contract: 127 passed, 2 skipped. - Mutation 1: dropping
| _builtin_strict_internal_paths()reddenstest_builtin_host_grants.py::test_the_core_tables_carry_the_grantsandtest_dev_fleet_pod_agent_api.py::test_every_route_is_named_in_the_strict_internal_table. - Mutation 2: deleting the
_builtin_agent_tool_pathsrow from_DATA_MODULE_SOURCESreddenstest_a_data_module_holds_only_the_values_the_facade_rebinds[kiro_crew.dashboard.server_internal_paths]. - Mutation 3: deleting the
_builtin_strict_internal_pathsrow reddens the same test. Each row is pinned on its own. - Mutation 4: re-adding a
pptx_maker.backendimport tobridges_agents.pyreddenstest_no_core_module_or_script_imports_the_appin bothtest_core_pptx_maker_decoupling.pyandtest_core_dev_fleet_pptx_maker_decoupling.py. This confirms the gate is strict now that the pending rows are gone. - I ran each mutation alone and the tree was clean after each.
Source-only, unchanged from the last round. I checked the following by reading source, not by running it. The file panel's soffice_path() no longer falls back to PPTX Maker's managed directory. That directory only ever receives a pdftoppm launcher, so I see no user-visible change. I read the Windows lookup but did not run it. _placeholder_values fails closed to {} on both an import error and a malformed result.
CI on this head. Grouped by check name: 83 success and 11 skipped, with nothing red or pending. PR Readiness and both CodeBuild statuses are success. The UX, Design, First Principles, GPT 6.1 and Opus 5.5 lanes all report PASS or no blocking findings on 42a910c. The First Principles concern about config_top_keys has a recorded override on ce06cc7, and the lane passes on this head. No inline threads are open. The three earlier reviews were all dismissed by rebases.
On the HOLD at 8c98c31. That HOLD named three blockers. The merge conflict is resolved and checked above, and CI is green. The third blocker was a maintainer review of the host-grant seam, and this review is that review. The seam only reads packages listed in BUILTIN_NAMES. It refuses any path outside the app's own namespace and any name that is not KIROCREW_*, and it raises on a malformed row. With today's grants, every resulting set equals main.
Follow-ups, not blocking.
- The two loaders now sit side by side but discover packages differently.
builtin_agent_toolsscans every directory underbuiltins/.builtin_host_grantsreads onlyBUILTIN_NAMES, which is the stricter trust rule. A later pass should give both one discovery helper and pick theBUILTIN_NAMESrule for both. - The remaining couplings in the PR body (the
pod_*mapping inmcp_tools/apps.py, thesecurity_posture.pyrows, the shippedpptx-makerskill) still need an App Kit equivalent before Dev Fleet ships from the registry. The same applies once Dev Fleet gets an adoption pin: an adopted copy would not be read by this seam. - §34 still says the strict paths are "folded into
server._STRICT_INTERNAL_API_PATHS". The fold happens inserver_internal_paths.py, and naming that module would help readers.
Problem / Motivation
Goal: Kiro Crew's core stops depending on the Dev Fleet and PPTX Maker apps, so either app can move out of this repository without a core edit.
The core imported Dev Fleet and PPTX Maker code and spelled their names in its own tables: the BUILD rlimit set, the deferred bound-port spawn, the forwarded
KIROCREW_DEVFLEET_*variables, the app-owneddev_fleetconfig section, five strict-internal pod routes, two relay-refused token mints, PPTX Maker's agent-template placeholders, and the file panel'ssofficediscovery. The Dev Fleet UI sat in the core SPA'spages/andtest/folders. None of that could leave with the app.Why it matters
Under #26967 every built-in moves to its own repository. While the core names an app, removing the app breaks the core: an import fails, or a table keeps a route nobody serves. Slide previews in the file panel also only worked through PPTX Maker's code, so they would stop working the day that app leaves.
Not a goal
What changed (motivation → approach → change)
The core now asks each built-in what it needs, instead of naming it.
dev_fleetconfig section, strict-internal pod routes, relay-refused token mintsapps/backend.py,backend_runtime/startup.py,config/validation.py,server_internal_paths.py,kiro_relay/limits.pyhost_grants.py, read by the newapps/builtin_host_grants.pybridges_agents._placeholder_valuesagent_placeholders.py, called by the same functionsofficelookup and install hintengine/preview_tools, imported by the file panelsoffice_discovery.py, the only copy; the file panel and PPTX Maker both import itwebsite/src/pages/,website/src/test/website/src/apps/dev-fleet/, reached only frombuiltinRegistry.tsThe seam is plain data with guard rails. It reads only packages in
BUILTIN_NAMES. A row may grant only its own app. Every path it claims must sit under that app's own/api/apps/<app>/or/apps/<app>/namespace. A forwarded variable must be aKIROCREW_*name. A bad row raises at load, so a grant can never quietly stop applying. With no built-in shipping a grant, every answer is empty. On boot it costs one file check per built-in plus one data-module import, once per process. That cost does not grow with user data.test_core_dev_fleet_pptx_maker_decoupling.pyfails if any core module or script imports either app, in any import spelling, using the shared scan intest/core_app_independence.py.devFleetBoundary.test.tsfails if anything outsideapps/dev-fleet/imports the UI, except the registry. The two i18n gate scripts compare a moved file with its old path, so a pure move adds no i18n debt, andwebsite/src/i18n/untranslated-baseline.jsoncarries the page's row under its new path.Couplings that remain, each leaving with its app:
mcp_tools/apps.pymaps the corepod_*MCP tools todev-fleetand calls/api/apps/dev-fleet/pod.security_posture.pylists Dev Fleet and PPTX Maker files in its redaction and posture rows.sandbox_leaves.py,sandbox_tiers.py,env.py,frontend.py,pod/) name the apps. They are prose only.builtin_skills/pptx-maker/SKILL.mdstill ships in the core skill tree.Docs:
app-kit-platform.mdgains §34 on the seam (after main's §33, built-in adoption).dev-fleet.mdgains a Host grants table.config.md,dashboard-token-auth.md,learn-cron-dashboard.md,pptx-maker.mdanddocs/feature-map/README.mdname the new owners.kirocrew-worktree-dev/SKILL.mdandpipeline-conductor/SKILL.mdnote that the pod-e2e harness ships with Dev Fleet.Backwards compatibility
Compatible: the strict-internal set, the relay credential set and the app-owned config keys are identical to main's, every grant applies to the same app, and the moved UI is served from the same
/dev-fleetroute.Reader: src/kiro_crew/dashboard/server_runtime/app_platform.py:_start_bound_port_app_backends -- release -- calls
start_deferred_app_backends, which spawnsbound_port_apps()in place ofDEV_FLEET_APP_NAME; test_bound_port_backends_start_only_after_the_export_and_the_rest_before_setupReader: src/kiro_crew/apps/backend.py:_start_app_backend_body -- app -- reads
build_rlimit_apps()/bound_port_apps()/ the env grants in place of_BUILD_CAPABLE_APPSand theKIROCREW_DEVFLEET_*literals; test_app_backend_spawn_env.pyReader: src/kiro_crew/dashboard/server_internal_paths.py:_STRICT_INTERNAL_API_PATHS -- chat -- the five pod paths arrive through the grant; test_the_core_tables_carry_the_grants
Reader: src/kiro_crew/dashboard/kiro_relay/limits.py:_LOCAL_CREDENTIAL_EXACT -- crew page -- the two pod-token paths arrive through the grant; test_the_core_tables_carry_the_grants
Reader: src/kiro_crew/dashboard/handlers/office_slides.py:soffice_path -- chat --
soffice_discovery.find_soffice; test_file_office_slides.py, test_soffice_discovery.pyReader: src/kiro_crew/apps/builtins/pptx_maker/backend/routes.py:_deps_status -- app -- reads
soffice_discovery.soffice_install_hintin place ofpreview_tools.soffice_hint; test_pptx_maker_soffice_hint.pyReader: src/kiro_crew/apps/builtins/pptx_maker/backend/engine.py:optional_dep_path -- app -- reads
soffice_discovery.windows_install_path/which_withinin place of the app's own copies; test_preview_tool_discovery.pyReader: website/src/apps/builtinRegistry.ts:'/dev-fleet' -- app -- imports
./dev-fleet/DevFleetPage; devFleetBoundary.test.tsReader: website/capture/devfleet-discovery.tsx:DevFleetPage -- release -- it and
devfleet-provision-reattach.tsx/devfleet-prune-untracked.tsximport the moved page; tsc -p tsconfig.app.jsonTests
test/test_builtin_host_grants.py: the seam is empty with no grants; Dev Fleet's grants reach every core table; reading grants does not import the route modules; every malformed or overreaching row raises; deferred bound-port backends are re-checked and spawned in order.test/test_core_dev_fleet_pptx_maker_decoupling.py: no core module or script imports either app, and each import spelling is proven to be caught by the shared scan.test/test_core_pptx_maker_decoupling.py(main's PPTX Maker gate): itsPENDING_IMPORTSandPENDING_NAME_REFERENCESrows, which tolerated the two imports and the one"pptx-maker"literal this PR removes, are deleted, so that gate is now strict.test/test_soffice_discovery.py:PATHfirst, then the Windows roots; a hit outside the asked root is refused; the per-OS install hint for every distribution. These cases come from PPTX Maker's tests, which now pin only how the app ranks and forwards the core's answer.website/src/apps/dev-fleet/devFleetBoundary.test.tsandwebsite/src/test/i18nGateRenameSources.test.ts: the UI boundary, checked withpath.relativeso it holds on either path separator, and the rename-aware i18n base.edgeChallengeAtDirectErrorSites.test.tsintoapps/dev-fleet/devFleetApi.test.ts.Local: the related backend tests (PPTX Maker, soffice, office slides, host grants, spawn env, composition, startup, sandbox; about 1,370) and the Dev Fleet and i18n vitest files pass;
tsc -p tsconfig.app.json, mypy, flake8, isort, the black, comment-history, brand, line-cap, harness-parity and docs-lint gates, and the flake-pattern ratchet are green.Determinism: the three new backend test files pass 20 times at
-n0, 10 times at-n 4beside the spawn-env and office-slides tests, and once in a shuffled order (seed 27435); the two new vitest files pass 20 times and in a shuffled order (--sequence.shuffle, seed 27435).Manual verification
N/A — a refactor with no behaviour change. The equality of the strict-internal and relay sets with main's was checked by loading both modules side by side.
Screenshots / video
Why no screenshot: the Dev Fleet UI files move directories with only import paths changed, so nothing renders differently.
Related Issues
Part of #26967
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)