Repository navigation
fix(file-explorer): announce whether a folder row is open with aria-expanded - #27451
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The PR adds one [UX-REVIEWED] a0ac37e Description read[DESCRIPTION-READ] 133ef80b06e3093ff1b8ffd270571e713f4acf9a6c87f8b0930a8dd2c2161f7a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: it adds one ARIA state attribute to an existing disclosure row, with no visual change and nothing taken away. [DESIGN-REVIEWED] a0ac37e Description read[DESCRIPTION-READ] 5b215e6bd17934f0260076456e5d06aaab1e1ec35f3e570f9c384623b46def06 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: let a screen reader user hear whether a File Explorer folder is open or closed (FIX, #27448).
[FIRST-PRINCIPLES-REVIEWED] a0ac37e Description read[DESCRIPTION-READ] 25aff0c37b2f6c92ce6e5da252fd7601db00f1cc2b7cf4db5370e3ac9db5539a That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds aria-expanded to folder rows in the file explorer tree so screen readers hear open or closed, with a test.
Problem / Motivation
Goal: A screen reader user hears whether a File Explorer folder is open or closed.
A folder row in the File Explorer tree is a
role="button"that opens and closes the folder, but it has noaria-expanded. A screen reader says "src, button" and never says whether it is open.Why it matters
Keyboard and screen reader users cannot tell the tree state without opening and closing folders to find out.
Not a goal
tree/treeitemwidget with arrow-key navigation.What changed (motivation → approach → change)
aria-expandedaria-expanded="false"aria-expandedaria-expanded="true"aria-expandedaria-expandedTreeNode.tsxsetsaria-expandedfrom the same open state that picks the chevron, and only on folder and symlink rows. File rows only select, so they get no expanded state.Backwards compatibility
Compatible: one attribute added to folder rows; nothing that renders or responds today changes.
Removes nothing: the change only adds an attribute.
Tests
website/src/test/fileExplorerComponents.test.tsxadds a TreeNode test: a closed folder row readsaria-expanded="false", an open one"true", and the file row inside it has noaria-expanded. It fails onorigin/mainand passes here. All 21 frontend test files that importfile-explorerpass (754 tests), andtsc -p tsconfig.app.jsonis clean.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is one attribute, asserted in both states.
Screenshots / video
Why no screenshot: the change adds an ARIA attribute and renders no pixel differently.
Related Issues
Fixes #27448
Sibling sweep
Swept: git grep -n "role="button"" -- website/src/apps/file-explorer/
Siblings: none -- TreeNode.tsx is the only file-explorer row that opens and closes
Pattern harvest
Not generalizable: one disclosure row missing its state; the repo has no lint rule that can tell a toggling role=button from a plain one.
Checklist