Skip to content

fix(file-explorer): announce whether a folder row is open with aria-expanded - #27451

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
crew/conductor/x7-tree-aria
Nov 2, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
crew/conductor/x7-tree-aria

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A screen reader user hears whether a File Explorer folder is open or closed.

A folder row in the File Explorer tree is a role="button" that opens and closes the folder, but it has no aria-expanded. A screen reader says "src, button" and never says whether it is open.

Why it matters

Keyboard and screen reader users cannot tell the tree state without opening and closing folders to find out.

Not a goal

What changed (motivation → approach → change)

Row Before After
closed folder no aria-expanded aria-expanded="false"
open folder no aria-expanded aria-expanded="true"
file no aria-expanded no aria-expanded

TreeNode.tsx sets aria-expanded from the same open state that picks the chevron, and only on folder and symlink rows. File rows only select, so they get no expanded state.

Backwards compatibility

Compatible: one attribute added to folder rows; nothing that renders or responds today changes.

Removes nothing: the change only adds an attribute.

Tests

website/src/test/fileExplorerComponents.test.tsx adds a TreeNode test: a closed folder row reads aria-expanded="false", an open one "true", and the file row inside it has no aria-expanded. It fails on origin/main and passes here. All 21 frontend test files that import file-explorer pass (754 tests), and tsc -p tsconfig.app.json is clean.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the change is one attribute, asserted in both states.

Screenshots / video

Why no screenshot: the change adds an ARIA attribute and renders no pixel differently.

Related Issues

Fixes #27448

Sibling sweep

Swept: git grep -n "role="button"" -- website/src/apps/file-explorer/
Siblings: none -- TreeNode.tsx is the only file-explorer row that opens and closes

Pattern harvest

Not generalizable: one disclosure row missing its state; the repo has no lint rule that can tell a toggling role=button from a plain one.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 1, 2026 22:22
@RohanK6
RohanK6 requested a review from iamwhatever November 1, 2026 22:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of a0ac37e79552eabd45e65d638493f0dc59580d7e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR adds one aria-expanded attribute to folder rows and draws nothing new on screen, so there is no visible control to screenshot. The PR says "no-visual-delta" and the diff agrees.

[UX-REVIEWED] a0ac37e

Description read

[DESCRIPTION-READ] 133ef80b06e3093ff1b8ffd270571e713f4acf9a6c87f8b0930a8dd2c2161f7a

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a0ac37e79552eabd45e65d638493f0dc59580d7e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: it adds one ARIA state attribute to an existing disclosure row, with no visual change and nothing taken away.

[DESIGN-REVIEWED] a0ac37e

Description read

[DESCRIPTION-READ] 5b215e6bd17934f0260076456e5d06aaab1e1ec35f3e570f9c384623b46def06

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of a0ac37e79552eabd45e65d638493f0dc59580d7e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: let a screen reader user hear whether a File Explorer folder is open or closed (FIX, #27448).

  1. Screen readers now say whether a folder or symlink row is expanded or collapsed; file rows stay unchanged — justified
  2. New test pins the expanded state on folder rows (both open and closed) and its absence on file rows — justified

[FIRST-PRINCIPLES-REVIEWED] a0ac37e

Description read

[DESCRIPTION-READ] 25aff0c37b2f6c92ce6e5da252fd7601db00f1cc2b7cf4db5370e3ac9db5539a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a0ac37e79552eabd45e65d638493f0dc59580d7e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a0ac37e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a0ac37e79552eabd45e65d638493f0dc59580d7e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a0ac37e79552eabd45e65d638493f0dc59580d7e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a0ac37e

Verdict parsed from the review's SHA-scoped output markers for commit a0ac37e79552eabd45e65d638493f0dc59580d7e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a0ac37e79552eabd45e65d638493f0dc59580d7e false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 2, 2026 00:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds aria-expanded to folder rows in the file explorer tree so screen readers hear open or closed, with a test.

@KiroCrewCaptain
KiroCrewCaptain merged commit c348eb4 into main Nov 2, 2026
94 of 95 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/conductor/x7-tree-aria branch November 2, 2026 00:49
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Explorer folder rows do not tell a screen reader whether they are open (no aria-expanded)

2 participants