Skip to content

docs(rfc): accept the mate sessions RFCs on path B and record the decision - #28858

Merged
iamwhatever merged 1 commit into
mainfrom
docs/rfc-mate-path-b-accepted
Nov 3, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/rfc-mate-path-b-accepted

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the owner's path B pick for where a crewmate's sessions live, and mark both RFCs that design it accepted, so the implementation PRs can proceed.

docs/request-for-change/rfc-crewmate-workers-under-the-crewmate.md (#26643) and docs/request-for-change/rfc-mate-sessions-folder-or-lineage.md (#27837) are merged, and the maintainer picked path B, but both files still say status: draft. The First Principles lane blocks every implementation PR that cites a draft RFC.

Why it matters

Without an accepted RFC and a decision entry, #26952 and the later #26643 steps cannot pass review, and the 2026-10-17 entry ("appears in the sidebar") still reads as the only recorded design.

Not a goal

What changed (motivation → approach → change)

For the maintainer:

Backwards compatibility

Compatible: docs only; no code, config or flag changes.

Removes nothing: the decision entry only names a future supersession; the 2026-10-17 sidebar clause keeps describing the product until the flag defaults on.

Tests

Proof: not provable -- docs or config only

  • ./scripts/docs-lint.sh: pass.
  • DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py: 43 entries intact.
  • Local GPT 6.1 and Opus reviews: both flagged the missing Supersedes: line and a stale README audit sentence; both fixed before push.

Manual verification

N/A — docs only.

Related Issues

Part of #26949

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested a review from buluoray November 3, 2026 05:21
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 3, 2026 05:21
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only record of a maintainer decision, following the supersession path in decisions rule 3; nothing ships behaviour.

Notes

  • Entries are immutable after merge, and the Evidence bullet cites "the maintainer's restatement on the pull request that adds this entry" without a URL. Get the rule-4 restatement comment posted, and put its link into the entry before merge, because the link can't be added afterward.
  • The Supersedes: line is partial and conditional ("sidebar clause only… once the flag is on by default"). Until step 9 ships, both entries read as current for the same surface. The step-9 PR should cite this entry by path so triage can tell when the supersession takes effect.

[DESIGN-REVIEWED] 6949e68

Description read

[DESCRIPTION-READ] 15dfb630a5f79dd00101646ed92e541b9dd4f554054f6414ba9aba4ecb5cf917

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 — this comment is updated in place on each push.

This PR adds a decision entry with a Supersedes: line, which the blocking rule recorded-decisions-are-not-regressions flags by design; it can land only with a maintainer's override.

BLOCKING — docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5
Supersedes: 2026-10-17-crewmate-chat-hands-off-to-worker-sessions.md
Trigger: The PR adds a new file under docs/decisions/** with a Supersedes: line. That path matches the blocking rule, which says "FLAG a PR that carries an entry with a Supersedes: line, with or without the code change it authorizes."
Outcome: Merging without a maintainer's override would replace the recorded sidebar clause of the 2026-10-17 crewmate hand-off entry without the approval the rule requires.
Anchor: recorded-decisions-are-not-regressions
Fix: A maintainer listed in MAINTAINERS.md overrides this flag on the PR. No code change is needed.

[BLOCK-MERGE] 6949e68
[OPUS-REVIEWED] 6949e68

Verdict parsed from the review's SHA-scoped output markers for commit 6949e68d7fa81e1c45ac1a591873e7cdf55cee05.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 6949e68d7fa81e1c45ac1a591873e7cdf55cee05. 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

This comment is updated in place on each push.

BLOCKING -- docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5 -- Superseding a recorded decision requires a maintainer override

Supersedes: 2026-10-17-crewmate-chat-hands-off-to-worker-sessions.md
Trigger: This PR adds a superseding decision entry; the matching base rule explicitly requires blocking it, even without an accompanying code change.
Outcome: The protected sidebar placement receives authorization for future replacement without the rule-required maintainer override.
Anchor: recorded-decisions-are-not-regressions
Fix: Obtain an explicit maintainer override before merging; retain the Supersedes: line.

[BLOCK-MERGE] 6949e68
[GPT-REVIEWED] 6949e68

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 (fenced): this is a security-class finding, governed by the recorded-decision rule, and it stands as written. The entry carries Supersedes: at docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5. The base rule at .review-base-rules/AUTOSDE.yaml:835-840 (blocking: true, line 803) flags every such PR on purpose and names a maintainer override as the only way through. The trigger is not a rare edge case: it fires every time, by design. That is not FLAG territory. The decider, Joe Guo, is listed at MAINTAINERS.md:12, so the clearance is a writer's /ai-review override and no code change is needed.

[ADJUDICATION] 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] 6949e68d7fa81e1c45ac1a591873e7cdf55cee05

[ADJUDICATION-FENCED] 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 fenced=1 flagged=0
UPHOLD-FENCED F1 docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5 -- The base rule (AUTOSDE.yaml:835-840, blocking) flags every superseding entry by design, so the trigger is routine rather than extreme, and only a maintainer override clears it.
[GPT-ADJUDICATED-FENCED] 6949e68d7fa81e1c45ac1a591873e7cdf55cee05

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6949e68d7fa81e1c45ac1a591873e7cdf55cee05 false-positive: <reason, 20 to 500 characters>

@iamwhatever
iamwhatever force-pushed the docs/rfc-mate-path-b-accepted branch from 3446d17 to 6949e68 Compare November 3, 2026 05:39
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Discussed with the team

@iamwhatever
iamwhatever merged commit 6af3032 into main Nov 3, 2026
92 of 95 checks passed
@iamwhatever
iamwhatever deleted the docs/rfc-mate-path-b-accepted branch November 3, 2026 19:11
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant