Repository navigation
docs(rfc): accept the mate sessions RFCs on path B and record the decision - #28858
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only record of a maintainer decision, following the supersession path in decisions rule 3; nothing ships behaviour. Notes
[DESIGN-REVIEWED] 6949e68 Description read[DESCRIPTION-READ] 15dfb630a5f79dd00101646ed92e541b9dd4f554054f6414ba9aba4ecb5cf917 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — 🔴 changes requested (blocking)Reviewed This PR adds a decision entry with a BLOCKING — docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5 [BLOCK-MERGE] 6949e68 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md:5 -- Superseding a recorded decision requires a maintainer override
[BLOCK-MERGE] 6949e68 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 (fenced): this is a security-class finding, governed by the recorded-decision rule, and it stands as written. The entry carries False positive or not applicable? A repository writer can comment: |
3446d17 to
6949e68
Compare
|
Discussed with the team |
Problem / Motivation
Goal: Record the owner's path B pick for where a crewmate's sessions live, and mark both RFCs that design it
accepted, so the implementation PRs can proceed.docs/request-for-change/rfc-crewmate-workers-under-the-crewmate.md(#26643) anddocs/request-for-change/rfc-mate-sessions-folder-or-lineage.md(#27837) are merged, and the maintainer picked path B, but both files still saystatus: draft. The First Principles lane blocks every implementation PR that cites a draft RFC.Why it matters
Without an accepted RFC and a decision entry, #26952 and the later #26643 steps cannot pass review, and the 2026-10-17 entry ("appears in the sidebar") still reads as the only recorded design.
Not a goal
What changed (motivation → approach → change)
status: draft->accepted, status lines updated; index rows and the audit paragraph indocs/request-for-change/README.mdupdated to match.docs/decisions/2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md: path B (lineage stamps; a mate's dispatched sessions leave the person's session lists for the mate's Sessions tab with an in-place crew-log-only recap; folder tools and guidance removed from Crew Mode and mate conductors). Links both RFCs and feat(crew): stamp mate_root and mate_dispatched_by on a mate's sessions (inert) #26952. It carriesSupersedes: 2026-10-17-crewmate-chat-hands-off-to-worker-sessions.mdfor the sidebar clause only, effective once the step 6 flag defaults on (docs(rfc): a crewmate's sessions live under the crewmate #26643 step 9). Every other rule of the 2026-10-17 entry stands.docs/decisions/README.md: one index row.For the maintainer:
docs/decisions/README.mdrule 4, the maintainer restates the path B decision in a comment on this PR.Supersedes:line makesrecorded-decisions-are-not-regressionsflag this PR by design (rule 3). A maintainer override of the GPT and Opus lanes is what lets it land.Backwards compatibility
Compatible: docs only; no code, config or flag changes.
Removes nothing: the decision entry only names a future supersession; the 2026-10-17 sidebar clause keeps describing the product until the flag defaults on.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.sh: pass.DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py: 43 entries intact.Supersedes:line and a stale README audit sentence; both fixed before push.Manual verification
N/A — docs only.
Related Issues
Part of #26949
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.